[dpdk-dev] [PATCH 2/2] crypto/octeontx2: add support for aes-cbc sha256-128-hmac

2020-12-18 Thread Ankur Dwivedi
Support for aes-cbc sha256-128-hmac is added in lookaside protocol mode. The functionality is verified using ipsec-secgw application. Signed-off-by: Ankur Dwivedi --- doc/guides/cryptodevs/octeontx2.rst | 1 + doc/guides/rel_notes/release_21_02.rst| 2 + drivers/crypto/octeon

[dpdk-dev] [PATCH 1/2] crypto/octeontx2: add support for aes-cbc sha1-hmac

2020-12-18 Thread Ankur Dwivedi
Support for aes-cbc sha1-hmac is added in lookaside protocol mode. The functionality is verified using ipsec-secgw application. Signed-off-by: Ankur Dwivedi --- doc/guides/cryptodevs/octeontx2.rst | 1 + doc/guides/rel_notes/release_21_02.rst| 3 + drivers/crypto/octeontx2/ot

[dpdk-dev] [PATCH 0/2] crypto/octeontx2: add support for cipher combinations

2020-12-18 Thread Ankur Dwivedi
This series adds support for aes-cbc sha1-hmac and aes-cbc sha256-128-hmac cipher combinations in lookaside protocol offload mode. The functionality has been verified with ipsec-secgw application running in lookaside protocol offload mode. This series should be applied after the following patch se

[dpdk-dev] [PATCH v2 8/8] doc: update release notes for iavf emudev driver

2020-12-18 Thread Chenbo Xia
Update release notes for emulated iavf driver. Signed-off-by: Chenbo Xia --- doc/guides/rel_notes/release_21_02.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index 3d26b6b580..b310b67b

[dpdk-dev] [PATCH v2 7/8] test/emudev: introduce functional test

2020-12-18 Thread Chenbo Xia
This patch introduces functional test for emudev. The implementation of iavf emudev selftest is also added. Signed-off-by: Miao Li Signed-off-by: Chenbo Xia --- app/test/meson.build | 5 +- app/test/test_emudev.c | 29 + drivers/emu/iavf/iavf_emu.c

[dpdk-dev] [PATCH v2 6/8] emu/iavf: add emudev operations to fit in emudev framework

2020-12-18 Thread Chenbo Xia
This patch implements emudev opertions to make emulated iavf fit into rte_emudev framework. Lifecycle related and device resource related operations are both implemented. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- drivers/emu/iavf/iavf_emu.c | 218 ++

[dpdk-dev] [PATCH v2 5/8] emu/iavf: add resource management and internal logic of iavf

2020-12-18 Thread Chenbo Xia
This patch adds the allocation and release of device resources. Device resources include PCI BARs' memory and interrupt related resources. Device internal logic is also added. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- drivers/emu/iavf/iavf_emu.c | 1 + drivers/emu/iavf/iav

[dpdk-dev] [PATCH v2 4/8] emu/iavf: add vfio-user device register and unregister

2020-12-18 Thread Chenbo Xia
This patch adds vfio-user APIs call in driver probe and remove. rte_vfio_user_register() and rte_vfio_user_unregister() are called to create/destroy a vfio-user device. Notify callbacks that libvfio_user defines are also implemented. Signed-off-by: Chenbo Xia Signed-off-by: Miao Li --- drivers/

[dpdk-dev] [PATCH v2 3/8] emu: introduce emulated iavf driver

2020-12-18 Thread Chenbo Xia
This patch introduces emulated iavf driver. It is a vdev driver emulating all iavf device behavior except data path handling. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- MAINTAINERS | 7 + drivers/emu/iavf/iavf_emu.c | 29 drivers/emu/iavf/i

[dpdk-dev] [PATCH v2 2/8] doc: add emudev library guide

2020-12-18 Thread Chenbo Xia
Add emudev library guide and update release notes. Signed-off-by: Chenbo Xia --- doc/guides/prog_guide/emudev.rst | 122 + doc/guides/prog_guide/index.rst| 1 + doc/guides/rel_notes/release_21_02.rst | 12 +++ 3 files changed, 135 insertions(+) create mo

[dpdk-dev] [PATCH v2 1/8] lib: introduce emudev library

2020-12-18 Thread Chenbo Xia
This patch introduces the emudev library. Emudev library is used to abstract an emulated device, whose type could be general (e.g., network, crypto and etc.). Several device-level APIs are implemented to use or manipulate the device. It can be attached to another data path driver (e.g., ethdev driv

[dpdk-dev] [PATCH v2 0/8] Introduce emudev library and iavf emudev driver

2020-12-18 Thread Chenbo Xia
This series introduces a new device abstraction called emudev for emulated devices. A new library (librte_emudev) is implemented. The first emudev driver is also introduced, which emulates Intel Adaptive Virtual Function (iavf) as a software network device. This series has a dependency on librte_v

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Xia, Chenbo
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Saturday, December 19, 2020 1:18 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; Liang, > Cunming ; Lu, Xiuchun ; Li, > Miao ; Wu, Jingjing > Subject: Re: [PATCH 1/9] lib: introdu

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Xia, Chenbo
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Saturday, December 19, 2020 1:14 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; Liang, > Cunming ; Lu, Xiuchun ; Li, > Miao ; Wu, Jingjing > Subject: Re: [PATCH 1/9] lib: introdu

Re: [dpdk-dev] [PATCH 0/8] Introduce emudev library and iavf emudev driver

2020-12-18 Thread Xia, Chenbo
Hi David, > -Original Message- > From: David Marchand > Sent: Friday, December 18, 2020 5:54 PM > To: Xia, Chenbo > Cc: dev ; Thomas Monjalon ; Stephen > Hemminger ; Liang, Cunming > ; Lu, Xiuchun ; Li, Miao > ; Wu, Jingjing > Subject: Re: [PATCH 0/8] Introduce emudev library and iavf e

[dpdk-dev] Arm roadmap for 21.02

2020-12-18 Thread Honnappa Nagarahalli
(Bcc: Arm internal stake holders) Hello, Following are the work items planned for 21.02: 1) Add Scalable Vector Extensions (SVE) implementation for LPM4 library. 2) Meson build rework to support native compilation for Arm SoCs. 3) Add NEON implementation for VirtIO packed ring RX/TX path.

Re: [dpdk-dev] DPDK ENA PMD spurious ierrors

2020-12-18 Thread Roger Melton (rmelton)
Hi Igor, Thanks for the help. I’ll be happy to test patches when you are ready. Regards, Roger From: "Chauskin, Igor" Date: Friday, December 18, 2020 at 4:29 PM To: "Roger Melton (rmelton)" , "dev@dpdk.org" , "m...@semihalf.com" , "m...@semihalf.com" , "Tzalik, Guy" Subject: RE: DPDK ENA P

Re: [dpdk-dev] [PATCH v2 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set

2020-12-18 Thread Xu, Rosen
Hi, > -Original Message- > From: Steve Yang > Sent: Thursday, December 17, 2020 17:23 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; asoma...@amd.com; > rahul.lakkire...@chelsio.com; hemant.agra...@nxp.com; > sachin.sax...@oss.nxp.com; Guo, Jia ; Wang, Haiy

Re: [dpdk-dev] [PATCH v2] mbuf: fix reset on mbuf free

2020-12-18 Thread Ajit Khaparde
On Fri, Dec 18, 2020 at 5:18 AM Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > > because it can happen that m->nb_seg is != 1. For instance in this > > case: > > > > m1 =

[dpdk-dev] [PATCH 2/2] net/bnxt: fix ol_flags checksum status

2020-12-18 Thread Lance Richardson
From: Lance Richardson The setting of the mbuf ol_flags field for tunneled packets should be different depending upon whether DEV_RX_OFFLOAD_OUTER_* offloads are enabled. Initialize ol_flags mappings based on the receive offload configuration when the receive ring is initialized. Signed-off-by:

[dpdk-dev] [PATCH 1/2] net/bnxt: make offload flags mapping per-ring

2020-12-18 Thread Lance Richardson
From: Lance Richardson Refactor offload flags mapping table to be dynamic and per-ring instead of static and global. Signed-off-by: Lance Richardson Cc: sta...@dpdk.org --- drivers/net/bnxt/bnxt_rxr.c | 34 +-- drivers/net/bnxt/bnxt_rxr.h | 12 +

[dpdk-dev] [PATCH 0/2] net/bnxt: fix outer checksum status

2020-12-18 Thread Lance Richardson
From: Lance Richardson Receive checksum offload status flags in the mbuf ol_flags field should include inner/outer status only when outer checksum offload is enabled, which currently isn't the case for the bnxt PMD. Fix by using a hw-to-ol_flags mapping table that is constructed based on configur

Re: [dpdk-dev] [PATCH v3] eal: add generic thread-local-storage functions

2020-12-18 Thread Tal Shnaiderman
> Subject: Re: [PATCH v3] eal: add generic thread-local-storage functions > > External email: Use caution opening links or attachments > > > On Thu, 17 Dec 2020 19:49:13 +0200, Tal Shnaiderman wrote: > > Add support for tls functionality in EAL. > > > > The following functions are added: > > rte

[dpdk-dev] [PATCH] net/bnxt: remove support for some PCI IDs

2020-12-18 Thread Ajit Khaparde
As announced the deprecation notice during the 20.11 release, remove support for NetXtreme devices belonging to BCM573xx and BCM5740x families. Specifically the support for the following Broadcom PCI device IDs: 0x16c8, 0x16c9, 0x16ca, 0x16ce, 0x16cf, 0x16df, 0x16d0, 0x16d1, 0x16d2, 0x16d4, 0x16d5,

Re: [dpdk-dev] [RFC] mem_debug add more log

2020-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2020 14:21:09 -0500 Peng Zhihong wrote: > 1. The debugging log in current DPDK RTE_MALLOC_DEBUG mode is insufficient, >which makes it difficult to locate the issues, such as: >a) When a memeory overlflow occur in rte_free, there is a little log > information. Even if

Re: [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows

2020-12-18 Thread Kadam, Pallavi
On 12/18/2020 3:29 AM, Thomas Monjalon wrote: 17/12/2020 23:59, Pallavi Kadam: This file is required to compile and build i40e PMD on Windows. Add rte_rand variable to export file. Redefine _m_prefetchw for Clang toolchain due to following error with respect to conflicting types: FAILED: lib

Re: [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows

2020-12-18 Thread Kadam, Pallavi
Hi Thomas, On 12/18/2020 3:27 AM, Thomas Monjalon wrote: 17/12/2020 23:59, Pallavi Kadam: Adds temp folder mlx5/windows as it is required to build this patch without any build error. This folder will be removed once mlx5 PMD patches are merged. Why is it required? The patch [1] already suppo

Re: [dpdk-dev] DPDK ENA PMD spurious ierrors

2020-12-18 Thread Roger Melton (rmelton)
Hi Igor, Thanks for the reply. By work on preparing it do you mean that you plan to: 1. check rxmode.offloads in ena_rx_mbuf_prepare() before setting PKT_RX_[L3,L4]_CKSUM_BAD bits in ol_flags, and 2. increment oerrors instead of ierrors in the TX path? FWIW, Since we do not enable hardw

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add mbuf fast free offload support

2020-12-18 Thread Thomas Monjalon
18/12/2020 18:14, Viacheslav Ovsiienko: > This patch adds support of the mbuf fast free offload to the > transmit datapath. This offload allows to free the mbufs on > transmit completion in the most efficient way. It requires > the all mbufs were allocated from the same pool, have > the reference c

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2020 15:38:43 +0800 Chenbo Xia wrote: > +typedef struct vfio_user_msg { > + uint16_t msg_id; > + uint16_t cmd; > + uint32_t size; > +#define VFIO_USER_TYPE_CMD (0x0) /* Message type is COMMAND */ > +#define VFIO_USER_TYPE_REPLY (0x1 << 0) /* Message typ

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2020 15:38:43 +0800 Chenbo Xia wrote: > +inline void vfio_user_close_msg_fds(VFIO_USER_MSG *msg) > +{ > + int i; > + > + for (i = 0; i < msg->fd_num; i++) > + close(msg->fds[i]); > +} > + Please don't use non-static inlines.

[dpdk-dev] [PATCH 1/2] net/mlx5: optimize inline mbuf freeing

2020-12-18 Thread Viacheslav Ovsiienko
The mlx5 PMD supports packet data inlining by pushing data to the transmit descriptor. If packet is short enough and all data are inline, the mbuf is not needed for data send anymore and can be freed. The mbuf free was performed in the most inner loop building the transmit descriptors. This patch

[dpdk-dev] [PATCH 2/2] net/mlx5: add mbuf fast free offload support

2020-12-18 Thread Viacheslav Ovsiienko
This patch adds support of the mbuf fast free offload to the transmit datapath. This offload allows to free the mbufs on transmit completion in the most efficient way. It requires the all mbufs were allocated from the same pool, have the reference counter value as 1, and have no any externally atta

[dpdk-dev] [PATCH 0/2] net/mlx5: add mbuf fast free Tx offload

2020-12-18 Thread Viacheslav Ovsiienko
This patch adds support of the mbuf fast free offload to the transmit datapath. This offload allows to free the mbufs on transmit completion in the most efficient way. It requires the all mbufs were allocated from the same pool, have the reference counter value as 1, and have no any externally atta

[dpdk-dev] [RFC 3/9] devargs: fix memory leak in legacy parser

2020-12-18 Thread Xueming Li
Data field was designed as parser buffer, will be released once in releasing struct memory. The duplicated device arguments was not saved to data and this caused memory leak. This patch fixes this leak by saving to new allocated memory to data field. Fixes: 4969f5914c9e ("devargs: introduce new p

[dpdk-dev] [RFC 1/9] devargs: fix data buffer storage type

2020-12-18 Thread Xueming Li
The data field fo struct devargs is used as data scratch buffer, not a const, remove. Also fixes references to data field of struct devargs. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization") Cc: gaetan.ri...

[dpdk-dev] [RFC 5/9] kvargs: add get by key function

2020-12-18 Thread Xueming Li
Adds a new function to get value of a specific key from kvargs list. Signed-off-by: Xueming Li --- lib/librte_kvargs/rte_kvargs.c | 20 lib/librte_kvargs/rte_kvargs.h | 14 ++ lib/librte_kvargs/version.map | 1 + 3 files changed, 35 insertions(+) diff --git a/

[dpdk-dev] [RFC 6/9] devargs: support new global device syntax

2020-12-18 Thread Xueming Li
When parsing a device syntax, try to parse new global syntax firstly, then try to parse as legacy syntax if failed. Example of new global syntax: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 17 +++

[dpdk-dev] [RFC 8/9] common/mlx5: support device global syntax

2020-12-18 Thread Xueming Li
This patch support new device global syntax: bus=,k=v,,,/class=,k=v,,,/driver=,k=v To reuse class name of global syntax, this patch also changes internal class name introduced by commit [1] to algin with RTE class name. [1] 8a41f4deccc3: common/mlx5: introduce layer for multiple class drivers

[dpdk-dev] [RFC 9/9] net/mlx5: support new device global syntax

2020-12-18 Thread Xueming Li
This patch support new device global syntax like: bus=pci,addr=BB:DD.F/class=eth/driver=mlx5,devargs,.. Ignore "driver" key as part of new global device syntax in devargs. The representor devarg is supposed to come from either class section or driver section. Signed-off-by: Xueming Li -

[dpdk-dev] [RFC 2/9] devargs: fix memory leak on parsing error

2020-12-18 Thread Xueming Li
This patch fixes memory leak in parsing error handling. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_devargs.c | 5 + 1 file changed, 5 insertions(+) diff -

[dpdk-dev] [RFC 4/9] devargs: fix buffer data memory leak

2020-12-18 Thread Xueming Li
Struct rte_devargs data buffer was changed from args to data field, not all references were changed accordingly, memory leak happened when releasing devargs. Free data field of devargs struct. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta.

[dpdk-dev] [RFC 0/9] support global syntax

2020-12-18 Thread Xueming Li
New Global device syntax [1] is used to identify a device with full bus, class and driver description, example: -a bus=pci,id=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 This patch try to enable global syntax with backward compatibility by trying to new global syntax firstle and fallback to legacy

[dpdk-dev] [RFC 7/9] bus/pci: add new global device syntax support

2020-12-18 Thread Xueming Li
With new global device syntax, this patch tries to get PCI BDF firstly from bus "addr" argument, fallback to name if not found. Example: -w bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li --- drivers/bus/pci/pci_common.c | 18 +++--- 1 file changed

[dpdk-dev] [PATCH] crypto/octeontx2: add CN98xx support

2020-12-18 Thread Tejasree Kondoj
CN98xx SoC comes up with two CPT blocks wrt CN96xx, CN93xx, to achieve higher performance. Adding support to allocate all LFs of VF with even BDF from CPT0 and all LFs of VF with odd BDF from CPT1. If LFs are not available in one block then they will be allocated from alternate block. Signed-off-

[dpdk-dev] [RFC 5/7] kvargs: update parser for new representor syntax

2020-12-18 Thread Xueming Li
This patch updates kvargs parser to allow comma in list value: k1=a[1,2]b[3-5] Signed-off-by: Xueming Li --- lib/librte_kvargs/rte_kvargs.c | 82 +++--- 1 file changed, 56 insertions(+), 26 deletions(-) diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvarg

[dpdk-dev] [RFC 6/7] common/mlx5: update representor name parsing

2020-12-18 Thread Xueming Li
This patch updates representor name parsing for SF. In sysfs, representor name stored in from 'phys_port_name file', similar to VF representor, switch port name of SF representor is "pfsf". For netlink message, net SF type is supported. Examples: pf0sf1 pf0sf[0-3] Signed-off-by: Xueming Li ---

[dpdk-dev] [RFC 7/7] net/mlx5: support representor of sub function

2020-12-18 Thread Xueming Li
This patch supports of SF representor. Similar to VF representor, switch port name of SF representor in sysfs phys_port_name is "pfsf". Device representor argumnt is "representors=sf[list]", list member could be mix of instance and range. Example: representors=sf[0,2,4,8-12,-1] To probe VF repr

[dpdk-dev] [RFC 1/7] ethdev: support sub function representor

2020-12-18 Thread Xueming Li
To support SF representor, this patch enhances devargs syntax: [pf#]vf#: new VF port representor/s, example: vf[0-3], pf0vf3 [pf#]sf#: new SF port representor/s, example: sf[0-3], pf1sf2 pf# is optional for SF and VF representor. If not present, representor is detected from PCI BDF of device argu

[dpdk-dev] [RFC 2/7] ethdev: support multi-host representor

2020-12-18 Thread Xueming Li
This patch introduce multi-host controller for ethdev representor syntax, examples: [[c#]pf#]vf#: VF port representor/s, example: pf0vf1 [[c#]pf#]sf#: SF port representor/s, example: c1pf1sf[0-3] c# is controller ID/range in case of multi-host, optional. It is mostly for SmartNIC attached to mult

[dpdk-dev] [RFC 3/7] devarg: change reprsentor ID to bitmap

2020-12-18 Thread Xueming Li
In eth representor comparer callback, ethdev was compared with devarg. Since ethdev representor port didn't contain controller(host) and owner port information, callback only compared representor port and returned representor port on other PF port. This patch changes representor port to bitmap enc

[dpdk-dev] [RFC 4/7] ethdev: capability for new representor syntax

2020-12-18 Thread Xueming Li
This patch introduces new eth device capability to support SubFunction representor device. Signed-off-by: Xueming Li --- lib/librte_ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index f5f8919186..3c087bec

[dpdk-dev] [RFC 0/7] support SubFunction representor

2020-12-18 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports eswitch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. >From SmartNIC per

Re: [dpdk-dev] [PATCH 5/7] net/hns3: fix location of saving ethdev

2020-12-18 Thread Ferruh Yigit
On 12/13/2020 8:03 AM, Lijun Ou wrote: From: "Min Hu (Connor)" In current version, procedure of saving eth_dev in hns3 PMD init will be called more than twice, one for primary, the other for secondary. That will cause segmentation fault in Multi-process as eth_dev will be changed in secondary p

[dpdk-dev] DPDK 21.02 NVIDIA Mellanox Roadmap

2020-12-18 Thread Asaf Penso
Below is NVIDIA Mellanox's roadmap for DPDK21.02, which we are currently working on: rte_flow new APIs: === [1]Support a new and generic copy action - Providing an ability to copy from an arbitrary source field to an arbitrary destination field. Motivation: Copy tunnel in

[dpdk-dev] Potential regression introduced by commit b10231aed1edb9

2020-12-18 Thread Balazs Nemeth
Hi, Commit b10231aed1edb9 introduces a regression on my systems. I have a "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" which relies on the qede driver. Calling rte_eth_promiscuous_enable(portid) followed by rte_eth_allmulticast_enable(port_id) causes no packets to arrive from m

Re: [dpdk-dev] [PATCH 2/7] net/hns3: fix xstats statistics with id

2020-12-18 Thread Ferruh Yigit
On 12/18/2020 7:06 AM, oulijun wrote: 在 2020/12/17 23:20, Ferruh Yigit 写道: On 12/13/2020 8:03 AM, Lijun Ou wrote: From: Huisong Li Number of xstats item in rte_eth_xstats_get_by_id is obtained by the eth_dev_get_xstats_count API, and the xstats_get_by_id ops of the driver only needs to repo

[dpdk-dev] [PATCH v2] net/virtio-user: fix advertising of protocol features

2020-12-18 Thread Olivier Matz
When connected to a vhost-user backend, the flag VHOST_USER_F_PROTOCOL_FEATURES is not advertised, preventing to do multiqueue (the VHOST_USER_PROTOCOL_F_MQ protocol feature is ignored by some backends if the VHOST_USER_F_PROTOCOL_FEATURES feature is not set). When setting vhost-user features, adv

Re: [dpdk-dev] [PATCH v2] mbuf: fix reset on mbuf free

2020-12-18 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > because it can happen that m->nb_seg is != 1. For instance in this > case: > > m1 = rte_pktmbuf_alloc(mp); > rte_pktmbuf_append(m1, 500); > m2 = rte_

[dpdk-dev] [PATCH 2/2] crypto/octeontx2: add lookaside IPsec ESN and anti-replay support

2020-12-18 Thread Tejasree Kondoj
Adding ESN and anti-replay support for lookaside IPsec. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/octeontx2.rst | 2 + doc/guides/rel_notes/release_21_02.rst| 5 ++ drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 47 ++- drivers/crypto/octeontx2

[dpdk-dev] [PATCH 1/2] crypto/octeontx2: make anti-replay routine generic

2020-12-18 Thread Tejasree Kondoj
Adding changes to make anti-replay routine common to both inline and lookaside IPsec. Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_ipsec_anti_replay.h | 11 +-- drivers/net/octeontx2/otx2_rx.h | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-)

[dpdk-dev] [PATCH 0/2] add lookaside IPsec ESN and anti-replay support

2020-12-18 Thread Tejasree Kondoj
This series adds lookaside IPsec ESN and anti-replay support to OCTEON TX2 crypto PMD. The functionality has been tested with ipsec-secgw application running in lookaside protocol offload mode. Tejasree Kondoj (2): crypto/octeontx2: make anti-replay routine generic crypto/octeontx2: add lookas

[dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations

2020-12-18 Thread Tejasree Kondoj
Adding support for SSL/TLS way of cipher-auth operations order - auth generation followed by encryption - decryption followed by auth verify Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev_aes_test_vectors.h | 576 + app/test/test_cryptodev_blockcipher.c

[dpdk-dev] [PATCH v3] build: fix plugin load on static builds

2020-12-18 Thread Olivier Matz
When dpdk is compiled as static libraries, it is not possible to load a plugin from an application. We get the following error: EAL: librte_pmd_.so: undefined symbol: per_lcore__rte_errno This happens because the dpdk symbols are not exported. Add them to the dynamic symbol table by using '

[dpdk-dev] [PATCH 1/2] common/cpt: support SSL/TLS way of cipher-auth operations

2020-12-18 Thread Tejasree Kondoj
Adding support for SSL/TLS way of cipher-auth operations order - auth generation followed by encryption - decryption followed by auth verify Signed-off-by: Tejasree Kondoj --- doc/guides/rel_notes/release_21_02.rst| 6 +++ drivers/common/cpt/cpt_mcode_defines.h| 7 +++-

[dpdk-dev] [PATCH 0/2] support SSL/TLS way of cipher-auth operations

2020-12-18 Thread Tejasree Kondoj
This series adds SSL/TLS way of cipher-auth operations support i.e. auth generation followed by encryption and decryption followed by auth verify in OCTEON TX, OCTEON TX2 PMDs and sample unit test application. Tejasree Kondoj (2): common/cpt: support SSL/TLS way of cipher-auth operations test/

[dpdk-dev] [PATCH v2] mbuf: fix reset on mbuf free

2020-12-18 Thread Olivier Matz
m->nb_seg must be reset on mbuf free whatever the value of m->next, because it can happen that m->nb_seg is != 1. For instance in this case: m1 = rte_pktmbuf_alloc(mp); rte_pktmbuf_append(m1, 500); m2 = rte_pktmbuf_alloc(mp); rte_pktmbuf_append(m2, 500); rte_pktmbuf_chain(m1, m2); m0 =

[dpdk-dev] [PATCH v2] app: fix plugin load on static builds

2020-12-18 Thread Olivier Matz
When dpdk is compiled as static libraries, it is not possible to load a plugin from an application. We get the following error: EAL: librte_pmd_.so: undefined symbol: per_lcore__rte_errno This happens because the dpdk symbols are not exported. Add them to the dynamic symbol table by using '

[dpdk-dev] [PATCH] net/virtio-user: fix advertising of protocol features

2020-12-18 Thread Olivier Matz
When connected to a vhost-user backend, the flag VHOST_USER_F_PROTOCOL_FEATURES is not advertised, preventing to do multiqueue (the VHOST_USER_PROTOCOL_F_MQ protocol feature is ignored by some backends if the VHOST_USER_F_PROTOCOL_FEATURES feature is not set). When setting vhost-user features, adv

[dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying

2020-12-18 Thread Kamil Vojanec
This patch fixes a bug where firmware version was not copied from ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability to read firmware version. Signed-off-by: Kamil Vojanec --- drivers/net/mlx5/linux/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[dpdk-dev] [PATCH v1 3/3] examples/vhost: refactor vhost async data path

2020-12-18 Thread Cheng Jiang
Support latest async vhost api, refactor vhost async data path, and clean some codes. Signed-off-by: Cheng Jiang --- examples/vhost/main.c | 88 --- examples/vhost/main.h | 2 +- 2 files changed, 42 insertions(+), 48 deletions(-) diff --git a/examples/vh

[dpdk-dev] [PATCH v1 2/3] examples/vhost: optimize vhost data path for batch

2020-12-18 Thread Cheng Jiang
Change the vm2vm data path to batch enqueue for better performance. Signed-off-by: Cheng Jiang --- examples/vhost/main.c | 84 ++- 1 file changed, 75 insertions(+), 9 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 8d8c3038bf

[dpdk-dev] [PATCH v1 1/3] examples/vhost: add ioat ring space count and check

2020-12-18 Thread Cheng Jiang
Add ioat ring space count and check, if ioat ring space is not enough for the next async vhost packet enqueue, then just return to prevent enqueue failure. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/exa

[dpdk-dev] [PATCH v1 0/3] examples/vhost: sample code refactor

2020-12-18 Thread Cheng Jiang
Refactor the vhost sample code. Add ioat ring space count and check in ioat callback, optimize vhost data path for batch enqueue, and refactor vhost async data path. Cheng Jiang (3): examples/vhost: add ioat ring space count and check examples/vhost: optimize vhost data path for batch exampl

Re: [dpdk-dev] [PATCH v6] ip_frag: remove padding length of fragment

2020-12-18 Thread Ananyev, Konstantin
> > In some situations, we would get several ip fragments, which total > data length is less than min_ip_len(64) and padding with zeros. > We simulated intermediate fragments by modifying the MTU. > To illustrate the problem, we simplify the packet format and > ignore the impact of the packet h

Re: [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows

2020-12-18 Thread Thomas Monjalon
17/12/2020 23:59, Pallavi Kadam: > This file is required to compile and build i40e PMD on Windows. > Add rte_rand variable to export file. > > Redefine _m_prefetchw for Clang toolchain due to following error > with respect to conflicting types: > > FAILED: lib/76b5a35@@rte_eal@sta/librte_eal_comm

Re: [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows

2020-12-18 Thread Thomas Monjalon
17/12/2020 23:59, Pallavi Kadam: > Adds temp folder mlx5/windows as it is required to build this patch > without any build error. This folder will be removed once mlx5 PMD > patches are merged. Why is it required? > +if is_windows > + build = false > + reason = 'Not supported on Windows'

[dpdk-dev] [dpdk-announce] DPDK 19.11.6 released

2020-12-18 Thread luca . boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.11.6.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.11 Luca Boccassi --- MAINTAINERS| 20 +- VERSION

[dpdk-dev] dpdk nic driver VS linux kernel driver

2020-12-18 Thread 전수진
hi, I'm in South Korea. I recently study your project DPDK. and I have an question. how can I measure speed for dpdk nic driver VS linux kernel driver? I'm setting dpdk driver at 2 vf(virtual function) nics and running the pktgen. however, I want to get the speed of the dpdk-nic. how can I do

[dpdk-dev] [RFC] mem_debug add more log

2020-12-18 Thread Peng Zhihong
1. The debugging log in current DPDK RTE_MALLOC_DEBUG mode is insufficient, which makes it difficult to locate the issues, such as: a) When a memeory overlflow occur in rte_free, there is a little log information. Even if abort here, we can find which API is core dumped but we sti

Re: [dpdk-dev] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu

2020-12-18 Thread Nithin Dabilpuram
On Thu, Dec 17, 2020 at 09:23:02AM +, Steve Yang wrote: > The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but > the Ether overhead is larger than 18 when it supports dual VLAN tags. > That will cause the jumbo flag rx offload is wrong when MTU size is > 'RTE_ETHER_MTU'. > >

[dpdk-dev] [RFC PATCH] lpm: add sve support for lookup on Arm platform

2020-12-18 Thread Ruifeng Wang
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set. Signed-off-by: Ruifeng Wang --- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build| 2 +- lib/librte_lpm/rte_lpm.h | 4

Re: [dpdk-dev] 19.11.6 patches review and test

2020-12-18 Thread Luca Boccassi
Thank you! Will proceed with the release, then. On Fri, 2020-12-18 at 02:45 +, Yu, DapengX wrote: > Hi Luca, > > The patch "net/iavf: enable port reset" has been validated by the QA team, > and confirmed the test case passes. > > Best regards, > Yu Dapeng > > -Original Message- > F

Re: [dpdk-dev] [PATCH 0/8] Introduce emudev library and iavf emudev driver

2020-12-18 Thread David Marchand
On Fri, Dec 18, 2020 at 9:02 AM Chenbo Xia wrote: > > This series introduces a new device abstraction called emudev for emulated > devices. A new library (librte_emudev) is implemented. The first emudev > driver is also introduced, which emulates Intel Adaptive Virtual Function > (iavf) as a softw

Re: [dpdk-dev] [PATCH 0/9] Introduce vfio-user library

2020-12-18 Thread David Marchand
Hello, On Fri, Dec 18, 2020 at 8:54 AM Chenbo Xia wrote: > *librte_vfio_user* library is an implementation of VFIO-over-socket[1] (also > known as vfio-user) which is a protocol that allows a device to be virtualized > in a separate process outside of QEMU. What is the status of the specificatio

[dpdk-dev] [PATCH v3 32/33] net/txgbe: add security offload in Rx and Tx process

2020-12-18 Thread Jiawen Wu
Add security offload in Rx and Tx process. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ipsec.c | 106 drivers/net/txgbe/txgbe_ipsec.h | 2 + drivers/net/txgbe/txgbe_rxtx.c | 93 +++- drivers/net/txgbe/txgbe_rxtx.h | 13

[dpdk-dev] [PATCH v3 33/33] net/txgbe: add security type in flow action

2020-12-18 Thread Jiawen Wu
Add security type in flow action. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 52 + drivers/net/txgbe/txgbe_ipsec.c | 30 +++ drivers/net/txgbe/txgbe_ipsec.h | 3 ++ 3 files changed, 85 insertions(+) diff --git a/drivers/net/tx

[dpdk-dev] [PATCH v3 31/33] net/txgbe: destroy security session

2020-12-18 Thread Jiawen Wu
Add support to clear a security session's private data, get the size of a security session, add update the mbuf with provided metadata. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ipsec.c | 167 drivers/net/txgbe/txgbe_ipsec.h | 15 +++ 2 files changed,

[dpdk-dev] [PATCH v3 30/33] net/txgbe: add security session create operation

2020-12-18 Thread Jiawen Wu
Add support to configure a security session. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 9 ++ drivers/net/txgbe/txgbe_ipsec.c | 251 +++ drivers/net/txgbe/txgbe_ipsec.h | 77 ++ 3 files changed, 337 insertions(+) create mode 100644 d

[dpdk-dev] [PATCH v3 29/33] net/txgbe: add IPsec context creation

2020-12-18 Thread Jiawen Wu
Initialize securiry context, and add support to get security capabilities. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/meson.build | 3 +- drivers/net/txgbe/txgbe_ethdev.c | 10 ++ drivers/net/txgbe/txgbe_ethdev.h | 4 + drivers/net/tx

[dpdk-dev] [PATCH v3 26/33] net/txgbe: support TM node add and delete

2020-12-18 Thread Jiawen Wu
Support traffic manager node add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe_tm.c | 488 +++ 2 files changed, 489 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/t

[dpdk-dev] [PATCH v3 28/33] net/txgbe: support to add traffic mirror rules

2020-12-18 Thread Jiawen Wu
Add and reset traffic mirroring rules. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 186 + drivers/net/txgbe/txgbe_ethdev.h | 1 + 3 files changed, 188 insertions(+) diff --git a/doc/guides/nics/fea

[dpdk-dev] [PATCH v3 27/33] net/txgbe: add TM hierarchy commit

2020-12-18 Thread Jiawen Wu
Add traffic manager hierarchy commit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_tm.c | 70 1 file changed, 70 insertions(+) diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 6dd593e54..b8edd78bf 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v3 25/33] net/txgbe: support TM shaper profile add and delete

2020-12-18 Thread Jiawen Wu
Support traffic manager profile add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_tm.c | 129 +++ 1 file changed, 129 insertions(+) diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 545590ba2..8adb03825 1

[dpdk-dev] [PATCH v3 24/33] net/txgbe: add TM capabilities get operation

2020-12-18 Thread Jiawen Wu
Add support to get traffic manager capabilities. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 9 + drivers/net/txgbe/txgbe_tm.c | 278 +++ 3 files changed, 288 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v3 23/33] net/txgbe: add TM configuration init and uninit

2020-12-18 Thread Jiawen Wu
Add traffic manager configuration init and uninit operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/meson.build| 1 + drivers/net/txgbe/txgbe_ethdev.c | 16 + drivers/net/txgbe/txgbe_ethdev.h | 60 drivers/net/txgbe/txgbe_tm.c | 57 +

[dpdk-dev] [PATCH v3 22/33] net/txgbe: support UDP tunnel port add and delete

2020-12-18 Thread Jiawen Wu
Support UDP tunnel port add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 105 +++ 1 file changed, 105 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index dfab653a5..73498935c 1

[dpdk-dev] [PATCH v3 20/33] net/txgbe: support to destroy consistent filter

2020-12-18 Thread Jiawen Wu
Add a function to destroy the flow filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 116 + 1 file changed, 116 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index dd865dbf3..7d508616e 100644 --- a/

[dpdk-dev] [PATCH v3 21/33] net/txgbe: flush all the filters

2020-12-18 Thread Jiawen Wu
Add support to flush all the filters. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 87 drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 70 ++ drivers/net/txgbe/txgbe_ethdev.h | 7 +++ drivers/net

[dpdk-dev] [PATCH v3 19/33] net/txgbe: support to create consistent filter

2020-12-18 Thread Jiawen Wu
Create a flow rule, to use the matched filter which the rule hit first. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 + drivers/net/txgbe/txgbe_ethdev.h | 7 + drivers/net/txgbe/txgbe_flow.c | 308 ++- 3 files changed, 316 insertions(+), 2 d

  1   2   >