Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Saturday, December 19, 2020 1:14 AM
> To: Xia, Chenbo <chenbo....@intel.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; Liang,
> Cunming <cunming.li...@intel.com>; Lu, Xiuchun <xiuchun...@intel.com>; Li,
> Miao <miao...@intel.com>; Wu, Jingjing <jingjing...@intel.com>
> Subject: Re: [PATCH 1/9] lib: introduce vfio-user library
> 
> On Fri, 18 Dec 2020 15:38:43 +0800
> Chenbo Xia <chenbo....@intel.com> wrote:
> 
> > +inline void vfio_user_close_msg_fds(VFIO_USER_MSG *msg)
> > +{
> > +   int i;
> > +
> > +   for (i = 0; i < msg->fd_num; i++)
> > +           close(msg->fds[i]);
> > +}
> > +
> 
> Please don't use non-static inlines.

Got it. Will fix in v2.

Thanks!
Chenbo

Reply via email to