[dpdk-dev] [PATCH RESEND 2/2] raw/octeontx2_dma: Add support in case of multiple DPI blocks

2020-10-05 Thread Radha Mohan Chintakuntla
This patch adds support for multiple DPI blocks by removing the fixed macro that was writing to same sysfs entry for different DPI blocks. Signed-off-by: Radha Mohan Chintakuntla Reviewed-by: Satananda Burla --- drivers/raw/octeontx2_dma/otx2_dpi_msg.c| 18 +- drivers/raw/oc

[dpdk-dev] [PATCH RESEND 1/2] raw/octeontx2_dma: Assign pem_id as lport for non-internal DMA

2020-10-05 Thread Radha Mohan Chintakuntla
DPI needs to know the PEM number for all external transfers. Signed-off-by: Radha Mohan Chintakuntla Reviewed-by: Satha Koteswara Rao Kottidi Reviewed-by: Satananda Burla --- drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 2 ++ drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h | 1 + 2 files changed,

Re: [dpdk-dev] [PATCH v6 1/1] net/mlx5: support match ICMP identifier fields

2020-10-05 Thread Li Zhang
Hi Ori, What's your comment? I can not find it in last mail. Can you help give more detail about it? Thanks, Regards, Li Zhang > -Original Message- > From: Ori Kam > Sent: Monday, October 5, 2020 6:33 PM > To: Li Zhang ; Dekel Peled ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org;

Re: [dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options

2020-10-05 Thread Stephen Hemminger
On Tue, 06 Oct 2020 00:55:19 +0200 Thomas Monjalon wrote: > > - cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr)); > > + cksum = rte_raw_cksum(ipv4_hdr, (ipv4_hdr->version_ihl & 0xf) * 4); > > > > Truly naive questions: > - doesn't it deserve a static inline function rt

Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

2020-10-05 Thread Chautru, Nicolas
Hi Tom, I will let Thomas and Bruce chime in on this Reviewer-list concept, there is arguably merit to this given this is used in some linux foundation projects but probably needs generic discussion on the DPDK tech board. Specifically for bbdev for now, I can make sure to include you in. > --

Re: [dpdk-dev] [PATCH v11 03/10] baseband/acc100: add info get function

2020-10-05 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Chautru, Nicolas > Sent: Monday, October 5, 2020 9:39 AM > To: 'Tom Rix' ; dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce ; Xu, Rosen > ; maxime.coque...@redhat.com; Yigit, Ferruh > ; Liu, Tianjiao > Subject: RE: [PATCH v11 03/10] baseband/

[dpdk-dev] [PATCH v12 08/10] baseband/acc100: add interrupt support to PMD

2020-10-05 Thread Nicolas Chautru
Adding capability and functions to support MSI interrupts, call backs and inforing. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 307 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 16 ++ 2 files changed, 320 i

[dpdk-dev] [PATCH v12 07/10] baseband/acc100: add support for 4G processing

2020-10-05 Thread Nicolas Chautru
Adding capability for 4G encode and decoder processing Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- doc/guides/bbdevs/features/acc100.ini|4 +- drivers/baseband/acc100/rte_acc100_pmd.c | 1007 +++--- 2 files changed, 936 insertions(+), 75 deletions(-

[dpdk-dev] [PATCH v12 10/10] baseband/acc100: add configure function

2020-10-05 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/test_bbdev_perf.c | 71 +++ doc/guides/rel_notes/release_20_11.rst

Re: [dpdk-dev] [PATCH v11 03/10] baseband/acc100: add info get function

2020-10-05 Thread Chautru, Nicolas
Hi Tom > From: Tom Rix > > > On 10/1/20 6:01 PM, Nicolas Chautru wrote: > > Add in the "info_get" function to the driver, to allow us to query the > > device. > > No processing capability are available yet. > > Linking bbdev-test to support the PMD with null capability. > > > > Signed-off-by: Ni

[dpdk-dev] [PATCH v12 06/10] baseband/acc100: add HARQ loopback support

2020-10-05 Thread Nicolas Chautru
Additional support for HARQ memory loopback Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao Reviewed-by: Tom Rix --- drivers/baseband/acc100/rte_acc100_pmd.c | 159 ++- 1 file changed, 155 insertions(+), 4 deletions(-) diff --git a/drivers/baseband/acc100/rte

[dpdk-dev] [PATCH v12 09/10] baseband/acc100: add debug function to validate input

2020-10-05 Thread Nicolas Chautru
Debug functions to validate the input API from user Only enabled in DEBUG mode at build time Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao Reviewed-by: Tom Rix --- drivers/baseband/acc100/rte_acc100_pmd.c | 436 +++ 1 file changed, 436 insertions(+) diff --

[dpdk-dev] [PATCH v12 04/10] baseband/acc100: add queue configuration

2020-10-05 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 445 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 45 +++

[dpdk-dev] [PATCH v12 05/10] baseband/acc100: add LDPC processing functions

2020-10-05 Thread Nicolas Chautru
Adding LDPC decode and encode processing operations Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao Acked-by: Dave Burley --- doc/guides/bbdevs/features/acc100.ini|8 +- drivers/baseband/acc100/rte_acc100_pmd.c | 1621 +- drivers/baseband/acc100/rte_ac

[dpdk-dev] [PATCH v12 03/10] baseband/acc100: add info get function

2020-10-05 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No processing capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/meson.build | 3 + driv

[dpdk-dev] [PATCH v12 01/10] drivers/baseband: add PMD for ACC100

2020-10-05 Thread Nicolas Chautru
Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru Reviewed-by: Tom Rix Acked-by: Liu Tianjiao --- doc/guides/bbdevs/acc100.rst | 228 + doc/guides/bbdevs/features/acc100.ini | 14 ++ doc/guides/bbdevs/index.rst

[dpdk-dev] [PATCH v12 02/10] baseband/acc100: add register definition file

2020-10-05 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Reviewed-by: Tom Rix Acked-by: Liu Tianjiao --- drivers/baseband/acc100/acc100_pf_enum.h | 1068 ++ drivers/baseband/acc100/acc100_vf_

[dpdk-dev] [PATCH v12 00/10] bbdev PMD ACC100

2020-10-05 Thread Nicolas Chautru
v12: Correcting 1 spelling error and 1 code clean up. v11: Further updates based on Tom + Maxime review comments on v9 and v10. Variable renaming v10: Updates based on Tom Rix valuable review comments. Notably doc clarifiction, #define names updates, few magic numbers left, stricter error handl

Re: [dpdk-dev] [PATCH v4] raw/ntb: add Ice Lake support for Intel NTB

2020-10-05 Thread Thomas Monjalon
> > Add NTB device support (4th generation) for Intel Ice Lake platform. > > > > Signed-off-by: Xiaoyun Li > Acked-by: Jingjing Wu Applied, thanks

Re: [dpdk-dev] [PATCH v2] drivers/common: mark all symbols as internal

2020-10-05 Thread Thomas Monjalon
01/10/2020 10:00, Kinsella, Ray: > On 01/10/2020 08:55, David Marchand wrote: > > Now that we have the internal tag, let's avoid confusion with exported > > symbols in common drivers that were using the experimental tag as a > > workaround. > > There is also no need to put internal API symbols in t

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-10-05 Thread Thomas Monjalon
02/10/2020 14:12, Burakov, Anatoly: > On 02-Oct-20 10:36 AM, David Marchand wrote: > > On Thu, Sep 17, 2020 at 4:47 PM David Marchand > > wrote: > >> > >> On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly > >> wrote: > >>> Anonymous hugepages shouldn't matter, yes, but single-file segments mode >

Re: [dpdk-dev] [PATCH v3] regex/mlx5: add dynamic memory registration to datapath

2020-10-05 Thread Thomas Monjalon
> From: Yuval Avnery > > Currently job data is being copied to pre-registered buffer. > To avoid memcpy on the datapath, use dynamic memory registration. > > This change will reduce latency when sending regex jobs. The first few > jobs may have high latency due to registration, but assuming all

Re: [dpdk-dev] [PATCH v1] mempool: dump socket id attribute

2020-10-05 Thread Thomas Monjalon
11/09/2020 10:31, Andrew Rybchenko: > On 9/11/20 11:13 AM, Sachin Saxena (OSS) wrote: > > From: Sachin Saxena > > > > Enhance the dump function to also print socket_id attribute > > passed at creation time. > > > > Signed-off-by: Sachin Saxena > > Acked-by: Andrew Rybchenko Applied, thanks

Re: [dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options

2020-10-05 Thread Thomas Monjalon
> - cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr)); > + cksum = rte_raw_cksum(ipv4_hdr, (ipv4_hdr->version_ihl & 0xf) * 4); Truly naive questions: - doesn't it deserve a static inline function rte_ipv4_hdr_len()? - how generated code for "* 4" compares with "<< 2"?

Re: [dpdk-dev] [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode

2020-10-05 Thread Thomas Monjalon
> > Sequences like "value = %"PRIu64 (no space before PRIu64) are parsed as a > > single preprocessor token, user-defined-string-literal, in C++11 onwards. > > While modern compilers are smart enough to parse this properly, GCC 9.3.0 > > generates warnings like: > > > > rte_rcu_qsbr.h:555:26:

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

2020-10-05 Thread Thomas Monjalon
15/09/2020 16:47, Stephen Hemminger: > Ferruh Yigit wrote: > > On 9/15/2020 3:03 AM, Stephen Hemminger wrote: > > > Vdev_netvsc has been around for several years. It no longer needs > > > to be marked experimental. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > -Microsoft vdev_netv

Re: [dpdk-dev] [PATCH] doc: remove trailing white space

2020-10-05 Thread Thomas Monjalon
> Run a simple script to remove trailing white space and blank > lines at end of file across all documents. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: update email address

2020-10-05 Thread Thomas Monjalon
24/09/2020 15:40, Andrew Rybchenko: > Signed-off-by: Andrew Rybchenko Applied

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-10-05 Thread Thomas Monjalon
05/10/2020 19:16, Georgios Katsikas: > Hi, > > What is the conclusion? > I haven't seen this patch being committed yet. You missed updating the file doc/guides/tools/flow-perf.rst > On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther wrote: > >From: Georgios Katsikas > > > > > >* One can now configu

Re: [dpdk-dev] [PATCH] doc: add index file to doxygen dependencies

2020-10-05 Thread Thomas Monjalon
> The doxygen index file is not printed as a processed file by doxygen so it > does not appear in the output .d (dependency file) list automatically > generated. Therefore, for correct rebuild tracking, we need to explicitly > include it as a dependency of the doxygen job. > > Signed-off-by: Bruce

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/prog_guide: fix formatting of notes in meson chapter

2020-10-05 Thread Thomas Monjalon
> > The "note" callouts in the chapter describing the meson build were > > incorrectly formatted, so adjust to use the correct markdown syntax. > > > > Fixes: 9c3adc289c5e ("doc: add instructions on build using meson") > > Cc: sta...@dpdk.org > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: make sphinx comply with meson werror option

2020-10-05 Thread Thomas Monjalon
> When the --werror meson build option is set, we can pass the "-W", > warning-as-errors, flag to sphinx to get the same behaviour for doc > building as for building the rest of DPDK. This can help catch > documentation errors sooner in the development process. > > Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: make guest channel headers public

2020-10-05 Thread Thomas Monjalon
> The channel commands header file contains definitions that are used by the > example application for power management, and so need to be made public. > Similarly the guest_channel.h header is used by the guest_cli example > utility, so needs to be public also. Without this change, the example >

Re: [dpdk-dev] [PATCH v2 0/8] Add Crypto PMD for Broadcom`s FlexSparc devices

2020-10-05 Thread Vikas Gupta
Hi Akhil, On Mon, Oct 5, 2020 at 10:17 PM Ajit Khaparde wrote: > > On Mon, Oct 5, 2020 at 8:39 AM Akhil Goyal wrote: > > > > Hi Vikas > > > > > > > > > > > > > Hi, > > > > This patchset contains support for Crypto offload on Broadcom’s > > > > Stingray/Stingray2 SoCs having FlexSparc unit. > > >

Re: [dpdk-dev] [PATCH v2 0/8] Add Crypto PMD for Broadcom`s FlexSparc devices

2020-10-05 Thread Ajit Khaparde
On Mon, Oct 5, 2020 at 8:39 AM Akhil Goyal wrote: > > Hi Vikas > > > > > > > > > Hi, > > > This patchset contains support for Crypto offload on Broadcom’s > > > Stingray/Stingray2 SoCs having FlexSparc unit. > > > BCMFS is an acronym for Broadcom FlexSparc device used in the patchest. > > > > > >

[dpdk-dev] [PATCH v3 7/8] crypto/bcmfs: add crypto h/w module

2020-10-05 Thread Vikas Gupta
Add crypto h/w module to process crypto op. Crypto op is processed via sym_engine module before submitting the crypto request to h/w queues. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- drivers/crypto/bcmfs/bcmfs_sym.c| 289 ++ driv

[dpdk-dev] [PATCH v3 8/8] crypto/bcmfs: add crypto pmd into cryptodev test

2020-10-05 Thread Vikas Gupta
Add global test suite for bcmfs crypto pmd Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- app/test/test_cryptodev.c | 17 + app/test/test_cryptodev.h | 1 + doc/guides/cryptodevs/bcmfs.rst | 11 +++ 3 files cha

[dpdk-dev] [PATCH v3 5/8] crypto/bcmfs: create a symmetric cryptodev

2020-10-05 Thread Vikas Gupta
Create a symmetric crypto device and add supported cryptodev ops. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- drivers/crypto/bcmfs/bcmfs_device.c | 15 ++ drivers/crypto/bcmfs/bcmfs_device.h | 9 + drivers/crypto/bcmfs/bcmfs_qp.c | 3

[dpdk-dev] [PATCH v3 6/8] crypto/bcmfs: add session handling and capabilities

2020-10-05 Thread Vikas Gupta
Add session handling and capabilities supported by crypto h/w accelerator Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- doc/guides/cryptodevs/bcmfs.rst | 47 ++ doc/guides/cryptodevs/features/bcmfs.ini | 56 ++ drivers/crypto

[dpdk-dev] [PATCH v3 4/8] crypto/bcmfs: add hw queue pair operations

2020-10-05 Thread Vikas Gupta
Add queue pair operations exported by supported devices. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- drivers/crypto/bcmfs/bcmfs_dev_msg.h | 29 + drivers/crypto/bcmfs/bcmfs_device.c | 51 ++ drivers/crypto/bcmfs/bcmfs_device.h

[dpdk-dev] [PATCH v3 1/8] crypto/bcmfs: add BCMFS driver

2020-10-05 Thread Vikas Gupta
Add Broadcom FlexSparc(FS) device creation driver which registers to a vdev and create a device. Add APIs for logs, supportive documention and maintainers file. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- MAINTAINERS

[dpdk-dev] [PATCH v3 3/8] crypto/bcmfs: add apis for queue pair management

2020-10-05 Thread Vikas Gupta
Add queue pair management APIs which will be used by Crypto device to manage h/w queues. A bcmfs device structure owns multiple queue-pairs based on the mapped address allocated to it. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- drivers/crypto/

[dpdk-dev] [PATCH v3 2/8] crypto/bcmfs: add vfio support

2020-10-05 Thread Vikas Gupta
Add VFIO support for BCMFS PMD. The BCMFS PMD functionality is dependent on the VFIO_PRESENT flag, which gets enabled in the rte_vfio.h. If this flag is not enabled in the compiling platform driver will silently return with error, when executed. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra

[dpdk-dev] [PATCH v3 0/8] Add Crypto PMD for Broadcom`s FlexSparc devices

2020-10-05 Thread Vikas Gupta
Hi, This patchset contains support for Crypto offload on Broadcom’s Stingray/Stingray2 SoCs having FlexSparc unit. BCMFS is an acronym for Broadcom FlexSparc device used in the patchest. The patchset progressively adds major modules as below. a) Detection of platform-device based on the known reg

[dpdk-dev] [PATCH v2 2/2] eventdev: update app and examples for new eventdev ABI

2020-10-05 Thread Timothy McDaniel
Several data structures and constants changed, or were added, in the previous patch. This commit updates the dependent apps and examples to use the new ABI. Signed-off-by: Timothy McDaniel --- app/test-eventdev/evt_common.h | 11 app/test-eventdev/test_order_atq.c

[dpdk-dev] [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints

2020-10-05 Thread Timothy McDaniel
This commit implements the eventdev ABI changes required by the DLB PMD. Signed-off-by: Timothy McDaniel --- drivers/event/dpaa/dpaa_eventdev.c | 3 +- drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- drivers/event/dsw/dsw_evdev.c | 3 +- drivers/event/octeo

[dpdk-dev] [PATCH v2 0/2] Eventdev ABI changes for DLB/DLB2

2020-10-05 Thread Timothy McDaniel
This series implements the eventdev ABI changes required by the DLB and DLB2 PMDs. This ABI change was announced in the 20.08 release notes [1]. This patch was initially part of the V1 DLB PMD patchset. The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the n

[dpdk-dev] [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size

2020-10-05 Thread Timothy McDaniel
Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size. Fixes "CTF field is too long" error when running with trace enabled. Signed-off-by: Timothy McDaniel --- lib/librte_eal/common/eal_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_tra

[dpdk-dev] [PATCH v2 1/1] eventdev: add PCI probe named convenience function

2020-10-05 Thread Timothy McDaniel
Add new internal wrapper function for use by pci drivers as a .probe function to attach to an event interface. Same as rte_event_pmd_pci_probe, except the caller can specify the name. Updated rte_event_pmd_pci_probe so as to not duplicate code. Signed-off-by: Timothy McDaniel --- lib/librte_ev

Re: [dpdk-dev] [PATCH v3 3/4] ppc: change cpuflag macros to compiler macros

2020-10-05 Thread David Christensen
On 9/24/20 1:18 AM, Radu Nicolau wrote: Replace use of RTE_MACHINE_CPUFLAG macros with regular compiler macros, which are more complete than those provided by DPDK, and as such it allows new instruction sets to be leveraged without having to do extra work to set them up in DPDK. Signed-off-by

[dpdk-dev] [PATCH v3 08/14] acl: introduce 256-bit width AVX512 classify implementation

2020-10-05 Thread Konstantin Ananyev
Introduce classify implementation that uses AVX512 specific ISA. rte_acl_classify_avx512x16() is able to process up to 16 flows in parallel. It uses 256-bit width registers/instructions only (to avoid frequency level change). Note that for now only 64-bit version is supported. Signed-off-by: Konst

[dpdk-dev] [PATCH v3 07/14] acl: add infrastructure to support AVX512 classify

2020-10-05 Thread Konstantin Ananyev
Add necessary changes to support new AVX512 specific ACL classify algorithm: - changes in meson.build to check that build tools (compiler, assembler, etc.) do properly support AVX512. - run-time checks to make sure target platform does support AVX512. - dummy rte_acl_classify_avx512() for tar

[dpdk-dev] [PATCH v3 05/14] app/acl: few small improvements

2020-10-05 Thread Konstantin Ananyev
- enhance output to print extra stats - use rte_rdtsc_precise() for cycle measurements Signed-off-by: Konstantin Ananyev --- app/test-acl/main.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/app/test-acl/main.c b/app/test-acl/main.c index 0a5dfb621d..d9b655

[dpdk-dev] [PATCH v3 06/14] test/acl: expand classify test coverage

2020-10-05 Thread Konstantin Ananyev
Make classify test to run for all supported methods. Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 103 ++-- 1 file changed, 51 insertions(+), 52 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 316bf4d065..333b34757

[dpdk-dev] [PATCH v3 01/14] acl: fix x86 build when compiler doesn't support AVX2

2020-10-05 Thread Konstantin Ananyev
Right now we define dummy version of rte_acl_classify_avx2() when both X86 and AVX2 are not detected, though it should be for non-AVX2 case only. Fixes: e53ce4e41379 ("acl: remove use of weak functions") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/librte_acl/rte_acl.c | 2 +-

[dpdk-dev] [PATCH v3 04/14] acl: remove library constructor

2020-10-05 Thread Konstantin Ananyev
Right now ACL library determines best possible (default) classify method on a given platform with specilal constructor function rte_acl_init(). This patch makes the following changes: - Move selection of default classify method into a separate private function and call it for each ACL context c

[dpdk-dev] [PATCH v3 03/14] acl: remove of unused enum value

2020-10-05 Thread Konstantin Ananyev
Removal of unused enum value (RTE_ACL_CLASSIFY_NUM). This enum value is not used inside DPDK, while it prevents to add new classify algorithms without causing an ABI breakage. Note that this change introduce a formal ABI incompatibility with previous versions of ACL library. Signed-off-by: Konsta

[dpdk-dev] [PATCH v3 00/14] acl: introduce AVX512 classify methods

2020-10-05 Thread Konstantin Ananyev
These patch series introduce support of AVX512 specific classify implementation for ACL library. It adds two new algorithms: - RTE_ACL_CLASSIFY_AVX512X16 - can process up to 16 flows in parallel. It uses 256-bit width instructions/registers only (to avoid frequency level change). On my SK

[dpdk-dev] [PATCH v3 11/14] acl: for AVX512 classify use 4B load whenever possible

2020-10-05 Thread Konstantin Ananyev
With current ACL implementation first field in the rule definition has always to be one byte long. Though for optimising classify implementation it might be useful to do 4B reads (as we do for rest of the fields). So at build phase, check user provided field definitions to determine is it safe to d

[dpdk-dev] [PATCH v3 02/14] doc: fix missing classify methods in ACL guide

2020-10-05 Thread Konstantin Ananyev
Add brief description for missing ACL classify algorithms: RTE_ACL_CLASSIFY_NEON and RTE_ACL_CLASSIFY_ALTIVEC. Fixes: 34fa6c27c156 ("acl: add NEON optimization for ARMv8") Fixes: 1d73135f9f1c ("acl: add AltiVec for ppc64") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- doc/guides/pro

Re: [dpdk-dev] [PATCH 0/4] remove experimental tags from APIs

2020-10-05 Thread David Christensen
On 9/25/20 7:14 AM, Ananyev, Konstantin wrote: On Wed, Sep 16, 2020 at 7:09 PM David Marchand wrote: On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong wrote: Experimental tags can be removed from APIs in module: ticket lock, MCS lock, pause (wait until equal APIs), and RCU (except for defer q

Re: [dpdk-dev] [PATCH v3 02/18] eal: add default SIMD bitwidth values

2020-10-05 Thread David Christensen
On 9/30/20 6:03 AM, Ciara Power wrote: Each arch has a define for the default SIMD bitwidth value, this is used on EAL init to set the config max SIMD bitwidth. Cc: Ruifeng Wang Cc: Jerin Jacob Cc: Honnappa Nagarahalli Cc: David Christensen Signed-off-by: Ciara Power --- v3: - Remov

Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver

2020-10-05 Thread Narcisa Ana Maria Vasile
On Fri, Oct 02, 2020 at 11:21:54AM -0700, Ranjit Menon wrote: > > On 10/1/2020 3:55 PM, Narcisa Ana Maria Vasile wrote: > >From: Narcisa Vasile > > > >The Windows netuio kernel driver provides the DPDK userspace application > >with direct access to hardware, by mapping the HW registers in userspa

[dpdk-dev] [PATCH v3 14/14] app/acl: add AVX512 classify support

2020-10-05 Thread Konstantin Ananyev
Add ability to use AVX512 classify method. Signed-off-by: Konstantin Ananyev --- app/test-acl/main.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test-acl/main.c b/app/test-acl/main.c index d9b65517cb..2a3a35a054 100644 --- a/app/test-acl/main.c +++ b/app/test-acl/main.c @@ -8

[dpdk-dev] [PATCH v3 13/14] test/acl: add AVX512 classify support

2020-10-05 Thread Konstantin Ananyev
Add AVX512 classify to the test coverage. Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 333b347579..5b32347954 100644 --- a/app/test/test_acl.c +++ b/app/test/tes

[dpdk-dev] [PATCH v3 12/14] acl: deduplicate AVX512 code paths

2020-10-05 Thread Konstantin Ananyev
Current rte_acl_classify_avx512x32() and rte_acl_classify_avx512x16() code paths are very similar. The only differences are due to 256/512 register/instrincts naming conventions. So to deduplicate the code: - Move common code into “acl_run_avx512_common.h” - Use macros to hide difference in nam

[dpdk-dev] [PATCH v3 10/14] acl: introduce 512-bit width AVX512 classify implementation

2020-10-05 Thread Konstantin Ananyev
Introduce classify implementation that uses AVX512 specific ISA. rte_acl_classify_avx512x32() is able to process up to 32 flows in parallel. It uses 512-bit width registers/instructions and provides higher performance then rte_acl_classify_avx512x16(), but can cause frequency level change. Note tha

[dpdk-dev] [PATCH v3 09/14] acl: update default classify algorithm selection

2020-10-05 Thread Konstantin Ananyev
On supported platforms, set RTE_ACL_CLASSIFY_AVX512X16 as default ACL classify algorithm. Note that AVX512X16 implementation uses 256-bit registers/instincts only to avoid possibility of frequency drop. Signed-off-by: Konstantin Ananyev --- lib/librte_acl/rte_acl.c | 1 + 1 file changed, 1 inser

[dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Hariprasad Govindharajan
With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this patch provides a Makefile which can be used to build this m

Re: [dpdk-dev] [PATCH 2/7] security: modify PDCP xform to support SDAP

2020-10-05 Thread Coyle, David
Hi Akhil > -Original Message- > From: akhil.go...@nxp.com > diff --git a/doc/guides/prog_guide/rte_security.rst > b/doc/guides/prog_guide/rte_security.rst > index 127da2e4f..ab535d1cd 100644 > --- a/doc/guides/prog_guide/rte_security.rst > +++ b/doc/guides/prog_guide/rte_security.rst >

[dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Hariprasad Govindharajan
With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this patch provides a Makefile which can be used to build this m

Re: [dpdk-dev] [PATCH v2 0/2] ethdev: RSS expand code fix and relocate

2020-10-05 Thread Ferruh Yigit
On 9/24/2020 3:52 PM, Dekel Peled wrote: Patch [1] added support for RSS flow expansion. It was added in ethdev for public use, but until now it is used only by MLX5 PMD. This patch series fixes an issue in this code, removes it from ethdev and moves it to MLX5 PMD file (following maintainer comm

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: move RSS expand code from ethdev to MLX5 PMD

2020-10-05 Thread Ferruh Yigit
On 9/24/2020 3:52 PM, Dekel Peled wrote: Patch [1] added support for RSS flow expansion. It was added in ethdev for public use, but until now it is used only by MLX5 PMD. To allow local changes in this code, this patch removes it from ethdev and moves it to MLX5 PMD file. [1] commit 4ed05fcd441b

Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute

2020-10-05 Thread Van Haaren, Harry
> -Original Message- > From: dev On Behalf Of Van Haaren, Harry > Sent: Wednesday, September 23, 2020 3:17 PM > To: Mattias Rönnblom ; dev@dpdk.org > Cc: david.march...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work > attribute > > > -Original Mes

[dpdk-dev] [PATCH] examples/vm_power: fix 32-bit build

2020-10-05 Thread Ferruh Yigit
Compiler version: gcc 10.2.1 "cc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1)" Build error: ../examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:346:23: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘uint64_t’ {aka ‘long long unsigned int’}

Re: [dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Ferruh Yigit
On 10/5/2020 5:18 PM, Hariprasad Govindharajan wrote: With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this pat

Re: [dpdk-dev] [PATCH v11 04/10] baseband/acc100: add queue configuration

2020-10-05 Thread Chautru, Nicolas
Hi Tom, > From: Tom Rix > On 10/1/20 6:01 PM, Nicolas Chautru wrote: > > Adding function to create and configure queues for the device. Still > > no capability. > > > > Signed-off-by: Nicolas Chautru > > Reviewed-by: Rosen Xu > > Acked-by: Liu Tianjiao > > --- > > drivers/baseband/acc100/rte

Re: [dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Stephen Hemminger
On Mon, 5 Oct 2020 17:18:28 +0100 Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module insi

Re: [dpdk-dev] [PATCH] net/memif: use abstract socket address

2020-10-05 Thread Stephen Hemminger
On Mon, 5 Oct 2020 14:09:20 +0100 Ferruh Yigit wrote: > On 10/5/2020 1:39 PM, Jakub Grajciar wrote: > > Abstract socket address has no connection with > > filesystem pathnames and the socket dissapears > > once all open references are closed. > > > > Memif pmd will use abstract socket address by

[dpdk-dev] net/bnx2x: Qlogic nic card support (1077:16a1)

2020-10-05 Thread Dey, Souvik
Hi All, I see that the linux bnx2x driver supports the following vendor id : device id * vendor: 1077 ("QLogic Corp."), device: 16a1 * vendor: 1077 ("QLogic Corp."), device: 16a4 * vendor: 1077 ("QLogic Corp."), device: 16ad but this are not supported by the bnx2x_pmd. This co

Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats

2020-10-05 Thread David Christensen
On 9/23/20 1:07 AM, Maxime Coquelin wrote: Hi David, Could you please post a v2 with Chenbo's comments taken into account? Sorry, been out of the office for a bit but now working through my backlog. I did make the change but discovered there were additional dependencies between stats and

Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

2020-10-05 Thread Tom Rix
On 10/5/20 9:26 AM, Chautru, Nicolas wrote: > Hey Tom, > Thanks for your recent reviews. > My only concern with this is how in reality you would be able to serve the > role of maintainer for these drivers/lib/test and engage in meaningful > discussions? > Do you understand 3GPP and the relate

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-10-05 Thread Georgios Katsikas
Hi, What is the conclusion? I haven't seen this patch being committed yet. Thanks, Georigos On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther wrote: > Hi, > > >-Original Message- > >From: george@gmail.com On Behalf Of Georgios > >Katsikas > >Sent: Thursday, September 24, 2020 12:11 PM

[dpdk-dev] [PATCH v4 2/3] ethdev: reset all when releasing a port

2020-10-05 Thread Thomas Monjalon
The function rte_eth_dev_release_port() is partially resetting the struct rte_eth_dev. The drivers were completing this reset with more pointers set to NULL in the close or remove operations. More pointers are reset at ethdev level, and some redundant assignments are removed from PMDs. Signed-off

[dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-05 Thread Thomas Monjalon
The API function rte_eth_dev_close() was returning void. The return type is changed to int for notifying of errors. If an error happens during a close operation, the status of the port is undefined, a maximum of resources having been freed. Signed-off-by: Thomas Monjalon Reviewed-by: Liron Himi

[dpdk-dev] [PATCH v4 0/3] cleanup ethdev close operation

2020-10-05 Thread Thomas Monjalon
Most of the patches from the v3 have been merged already. The remaining 3 patches are reworked in this v4: - reset dev_started in some PMDs - selectively reset pointers in rte_eth_dev_release_port() - fix error handling Thomas Monjalon (3): ethdev: remove forcing stopped state upon close

[dpdk-dev] [PATCH v4 1/3] ethdev: remove forcing stopped state upon close

2020-10-05 Thread Thomas Monjalon
When closing a port, it is supposed to be already stopped, and marked as such with "dev_started" state zeroed by the stop API. Resetting "dev_started" before calling the driver close operation was hiding the case of not properly stopped port being closed. The flag "dev_started" is not changed anym

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-10-05 Thread Jerin Jacob
On Tue, Sep 29, 2020 at 2:32 PM Nicolau, Radu wrote: > > > On 9/28/2020 5:02 PM, Honnappa Nagarahalli wrote: > > > >>> Add minimum burst throughout the scheduler pipeline and a flush counter. > >>> Replace ring API calls with local single threaded implementation where > >>> possible. > >>> > >>>

Re: [dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

2020-10-05 Thread Chautru, Nicolas
Hey Tom, Thanks for your recent reviews. My only concern with this is how in reality you would be able to serve the role of maintainer for these drivers/lib/test and engage in meaningful discussions? Do you understand 3GPP and the related processing and what these devices are actually doing? Su

[dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Hariprasad Govindharajan
With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this patch provides a Makefile which can be used to build this m

Re: [dpdk-dev] [PATCH] eventdev: fix adapter leak in error path

2020-10-05 Thread Jerin Jacob
On Tue, Sep 29, 2020 at 7:17 PM wangyunjian wrote: > > From: Yunjian Wang > > In rte_event_crypto_adapter_create_ext() allocated memory for > adapter, we should free it when error happens, otherwise it > will lead to memory leak. > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementati

Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets

2020-10-05 Thread Jerin Jacob
On Mon, Oct 5, 2020 at 9:05 PM Stephen Hemminger wrote: > > On Mon, 5 Oct 2020 12:45:04 +0530 > nipun.gu...@nxp.com wrote: > > > From: Nipun Gupta > > > > This change adds a RX offload capability, which once enabled, > > hardware will drop the packets in case there of any error in > > the packet

Re: [dpdk-dev] [PATCH v2 0/8] Add Crypto PMD for Broadcom`s FlexSparc devices

2020-10-05 Thread Akhil Goyal
Hi Vikas > > > > > Hi, > > This patchset contains support for Crypto offload on Broadcom’s > > Stingray/Stingray2 SoCs having FlexSparc unit. > > BCMFS is an acronym for Broadcom FlexSparc device used in the patchest. > > > > The patchset progressively adds major modules as below. > > a) Detectio

Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets

2020-10-05 Thread Stephen Hemminger
On Mon, 5 Oct 2020 12:45:04 +0530 nipun.gu...@nxp.com wrote: > From: Nipun Gupta > > This change adds a RX offload capability, which once enabled, > hardware will drop the packets in case there of any error in > the packet such as L3 checksum error or L4 checksum. > > Signed-off-by: Nipun Gupt

Re: [dpdk-dev] [PATCH v3 0/7] cmdline: support Windows

2020-10-05 Thread Olivier Matz
Hi Dmitry, On Tue, Sep 29, 2020 at 12:50:45AM +0300, Dmitry Kozlyuk wrote: > This patchset enables librte_cmdline on Windows. To do that, it creates > a number of wrappers for OS-dependent terminal handling and I/O. > Considered alternative was to revive [1] and use libedit (Unix-only) > for termi

Re: [dpdk-dev] [PATCH] net/memif: use abstract socket address

2020-10-05 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> -Original Message- > From: Ferruh Yigit > Sent: Monday, October 5, 2020 3:09 PM > To: Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/memif: use abstract socket address > > On 10/5/2020 1:39 PM, Jakub Grajciar wrote: > >

Re: [dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Ferruh Yigit
On 10/5/2020 3:47 PM, Hariprasad Govindharajan wrote: With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this pat

Re: [dpdk-dev] [PATCH] ethdev: check if queues are allocated before getting info

2020-10-05 Thread Ferruh Yigit
On 10/1/2020 8:40 PM, Ajit Khaparde wrote: On Thu, Oct 1, 2020 at 11:14 AM Ferruh Yigit wrote: A crash is detected when '--txpkts=#' parameter provided to the testpmd, this is because queue information is requested before queues have been allocated. Adding check to queue info APIs ('rte_eth_r

[dpdk-dev] [PATCH] maintainers: add self to baseband maintainers

2020-10-05 Thread trix
From: Tom Rix I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well. Signed-off-by: Tom Rix --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINER

[dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module

2020-10-05 Thread Hariprasad Govindharajan
With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this patch provides a Makefile which can be used to build this m

  1   2   3   >