On Mon, Oct 5, 2020 at 9:05 PM Stephen Hemminger <step...@networkplumber.org> wrote: > > On Mon, 5 Oct 2020 12:45:04 +0530 > nipun.gu...@nxp.com wrote: > > > From: Nipun Gupta <nipun.gu...@nxp.com> > > > > This change adds a RX offload capability, which once enabled, > > hardware will drop the packets in case there of any error in > > the packet such as L3 checksum error or L4 checksum.
IMO, Providing additional support up to the level to choose the errors to drops give more control to the application. Meaning, L1 errors such as FCS error L2 errors .. L3 errors such checksum i.e ethdev spec need to have error level supported by PMD and the application can set the layers interested to drop. > > > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com> > > Signed-off-by: Rohit Raj <rohit....@nxp.com> > > --- > > These patches are based over series: > > https://patchwork.dpdk.org/patch/78630/ > > > > Changes in v2: > > - Add support in DPAA1 driver (patch 2/3) > > - Add support and config parameter in testpmd (patch 3/3) > > > > lib/librte_ethdev/rte_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > Maybe this should be an rte_flow match/action which would then make it > more flexible? I think, it is not based on any Patten matching. So IMO, it should be best if it is part of RX offload. > > There is not much of a performance gain for this in real life and > if only one driver supports it then I am not convinced this is needed. Marvell HW has this feature.