[dpdk-dev] [PATCH v4] windows/netuio: add Windows NetUIO kernel driver

2020-09-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile The Windows netuio kernel driver provides the DPDK userspace application with direct access to hardware, by mapping the HW registers in userspace and allowing read/write operations from/to the device configuration space. Two IOCTLs are defined by the netuio interface: * IO

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-18 Thread Long Li
Thanks for confirming the fix! I'm investigating the issue you are seeing with KNI in 18.11.10. Is there an easy way to reproduce it? It would be great if you can provide steps on how you setup your system. Long From: Dey, Souvik Sent: Friday, September 18, 202

Re: [dpdk-dev] [PATCH] net/memif: relax barrier for zero copy path

2020-09-18 Thread Honnappa Nagarahalli
Hi Jakub, I am trying to review this patch. I am having difficulty in understanding the implementation for the queue/ring, appreciate if you could help me understand the logic. 1) The S2M queues - are used to send packets from slave to master. My understanding is that, the slave thread

Re: [dpdk-dev] [PATCH v2 4/4] mbuf: remove physical address alias

2020-09-18 Thread Thomas Monjalon
18/09/2020 16:43, Kinsella, Ray: > On 17/09/2020 11:41, Thomas Monjalon wrote: > > Remove the deprecated buf_physaddr union field from rte_mbuf. > > It is replaced with buf_iova which is at the same offset. > > > > The single field buf_physaddr in rte_kni_mbuf is also renamed. > > > > This conclu

Re: [dpdk-dev] [PATCH v5 0/8] app/proc-info enhancements

2020-09-18 Thread Stephen Hemminger
On Tue, 28 Jul 2020 12:13:22 -0700 Stephen Hemminger wrote: > The current proc-info command is useful for diagnosing issues > with external DPDK applications, but the display is limited > and somewhat ugly. This patchset adds some enhancements which > show more info and suppress unnecessary stuff

Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-18 Thread Stephen Hemminger
On Mon, 7 Sep 2020 17:14:48 +0800 Chengchang Tang wrote: > On 2020/9/6 0:59, Stephen Hemminger wrote: > > On Sat, 5 Sep 2020 17:07:32 +0800 > > Chengchang Tang wrote: > > > >>printf("\t -- queue %d rx scatter %d" > >>" d

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-18 Thread Akhil Goyal
Hi Fan, > Subject: [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs > > This patch adds data-path service APIs for enqueue and dequeue > operations to cryptodev. The APIs support flexible user-define > enqueue and dequeue behaviors and operation mode. > > Signed-off-by: Fan Zhang

Re: [dpdk-dev] [dpdk-dev v9 4/4] doc: add cryptodev service APIs guide

2020-09-18 Thread Akhil Goyal
Hi Fan, > Subject: [dpdk-dev v9 4/4] doc: add cryptodev service APIs guide > > This patch updates programmer's guide to demonstrate the usage > and limitations of cryptodev symmetric crypto data-path service > APIs. > > Signed-off-by: Fan Zhang > --- > doc/guides/prog_guide/cryptodev_lib.rst |

Re: [dpdk-dev] [PATCH V7 3/3] app/testpmd: add FEC command

2020-09-18 Thread Ajit Khaparde
On Fri, Sep 18, 2020 at 4:51 AM Min Hu (Connor) wrote: > > This commit adds testpmd capability to query and config FEC > function of device. This includes: > - show FEC capabilities, example: > testpmd> show port 0 fec capabilities > - show FEC mode, example: > testpmd> show port 0

Re: [dpdk-dev] [dpdk-dev v9 3/4] test/crypto: add unit-test for cryptodev direct APIs

2020-09-18 Thread Akhil Goyal
Hi Fan, > Subject: [dpdk-dev v9 3/4] test/crypto: add unit-test for cryptodev direct > APIs > > This patch adds the QAT test to use cryptodev symmetric crypto > direct APIs. > > Signed-off-by: Fan Zhang > --- > app/test/test_cryptodev.c | 461 +++--- > app/test

[dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses

2020-09-18 Thread Long Li
From: Long Li The address should be calculated before type cast, not after. Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors") Cc: sta...@dpdk.org Reported-by: Souvik Dey Signed-off-by: Long Li --- drivers/net/netvsc/hn_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [dpdk-dev] [PATCH v11 00/24] ethdev: allow unknown link speed

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 6:23 PM, Ferruh Yigit wrote: On 9/15/2020 8:06 PM, Ivan Dyukov wrote: <...> v11 changes: * 0 Mbps =>  None * Invalid speed => Invalid * Change code style of rte_eth_link_speed_to_str v10 changes: * remove format string arg from rte_eth_link_to_str function * add rte_eth_link_spee

Re: [dpdk-dev] [PATCH 02/12] net/bnxt: fix rxq/txq get information

2020-09-18 Thread Lance Richardson
On Fri, Sep 11, 2020 at 10:41 AM Ferruh Yigit wrote: > > > - qinfo->conf.rx_drop_en = 0; > > + qinfo->conf.rx_drop_en = 1; > > Why 0 is wrong but 1 is correct? > > Technically 'rx_drop_en' is a user configuration, which is set via > 'rte_eth_rx_queue_setup()' API. > > bnxt seems not honori

Re: [dpdk-dev] [PATCH v11 07/24] examples: new link status print format

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:07 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov <...> @@ -457,13 +458,9 @@ lsi_e

Re: [dpdk-dev] [PATCH v11 07/24] examples: new link status print format

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:07 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov <...> --- a/examples/link_status

Re: [dpdk-dev] [PATCH v11 19/24] examples/multi_proc*: new link status print format

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:07 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 15 ++- examples/multi_process/symmetric_mp/main.c| 13 + 2 files cha

Re: [dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API

2020-09-18 Thread Ajit Khaparde
On Fri, Sep 18, 2020 at 5:13 AM Ananyev, Konstantin wrote: > > > > This patch adds Forward error correction(FEC) support for ethdev. > > Introduce APIs which support query and config FEC information in > > hardware. > > > > Signed-off-by: Min Hu (Connor) > > Reviewed-by: Wei Hu (Xavier) > > Revi

Re: [dpdk-dev] [PATCH v11 13/24] examples/kni: new link status print format

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:07 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/m

Re: [dpdk-dev] [PATCH v11 11/24] examples/ip_pipeline: new link status print format

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:07 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_speed_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline

Re: [dpdk-dev] [PATCH v11 08/24] examples/bbdev_app: new link status print format

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:07 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-18 Thread Vimal Chungath
On 9/17/20 9:02 PM, Jerin Jacob wrote: > > On Thu, Sep 17, 2020 at 10:41 PM Honnappa Nagarahalli > wrote: >> >> >> > > On 9/11/20 8:23 PM, Honnappa Nagarahalli wrote: >> >> +Jerin, Hemant, Dharmik >> >> >> Hi Vimal, >> Few comments inline. >> >>> >

[dpdk-dev] [PATCH v3] eventdev: support telemetry with xstats info

2020-09-18 Thread Mike Ximing Chen
The telemetry library is connected with eventdev xstats and port link info. The following new telemetry commands are added: /eventdev/dev_list /eventdev/port_list,DevID /eventdev/queue_list,DevID /eventdev/dev_xstats,DevID /eventdev/port_xstats,DevID,PortID /eventdev/queue_xstats,DevID,PortID /eve

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_xdp: fix umem size

2020-09-18 Thread Ferruh Yigit
On 9/10/2020 10:06 AM, Ciara Loftus wrote: The kernel expects the start address of the UMEM to be page size aligned. Since the mempool is not guaranteed to have such alignment, we have been aligning the address to the start of the page the mempool is on. However when passing the 'size' of the UME

Re: [dpdk-dev] [PATCH v11 03/24] app: update apps&docs with new UNKNOWN link speed

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:06 PM, Ivan Dyukov wrote: Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov > Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v11 02/24] ethdev: format a link status text

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 9:44 PM, Morten Brørup wrote: From: Ivan Dyukov [mailto:i.dyu...@samsung.com] Sent: Tuesday, September 15, 2020 9:07 PM There is new link_speed value introduced. It's INT_MAX value which means that speed is unknown. To simplify processing of the value in application, new function is

Re: [dpdk-dev] [PATCH v11 00/24] ethdev: allow unknown link speed

2020-09-18 Thread Ferruh Yigit
On 9/15/2020 8:06 PM, Ivan Dyukov wrote: <...> v11 changes: * 0 Mbps => None * Invalid speed => Invalid * Change code style of rte_eth_link_speed_to_str v10 changes: * remove format string arg from rte_eth_link_to_str function * add rte_eth_link_speed_to_str function * add usage of rte_eth_li

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-18 Thread Ajit Khaparde
::snip:: > > > > This patch rang a bell. > There is the exact same patch proposed by Xia with a comment, so I > guess Xia is still working on it? > https://patchwork.dpdk.org/patch/75177/#117201 Xia, Will you submit the changes that Thomas asked for? Otherwise I will apply the bnxt patch and you ca

[dpdk-dev] [PATCH v2] eventdev: support telemetry with xstats info

2020-09-18 Thread Mike Ximing Chen
The telemetry library is connected with eventdev xstats and port link info. The following new telemetry commands are added: /eventdev/dev_list /eventdev/port_list,DevID /eventdev/queue_list,DevID /eventdev/dev_xstats,DevID /eventdev/port_xstats,DevID,PortID /eventdev/queue_xstats,DevID,PortID /eve

Re: [dpdk-dev] [PATCH 0/3] net/cxgbe: rework queue allocation and add RSS reta update

2020-09-18 Thread Ferruh Yigit
On 9/12/2020 12:52 AM, Rahul Lakkireddy wrote: Patch 1 removes the equal distribution queue allocation across all ports under the same PF. Instead, the queues are allocated based on whichever port requests for the queues first. This will allow unused queue resources on other ports to be redistrib

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-18 Thread David Marchand
On Wed, Sep 16, 2020 at 6:44 PM Bruce Richardson wrote: > > As flagged previously on-list, there are a number of macros used to specify > what libs and drivers are enabled in the build which differ from the > equivalents used with make. This patchset is one possible approach to > fixing these, but

Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-09-18 Thread Ankur Dwivedi
Hi Abhinandan, Please see my comments inline. Thanks Ankur >-Original Message- >From: Gujjar, Abhinandan S >Sent: Friday, September 18, 2020 8:13 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapte

Re: [dpdk-dev] [PATCH 0/2] net/cxgbe: release port resources during port close

2020-09-18 Thread Ferruh Yigit
On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote: Patch 1 fixes queue DMA ring leaks seen during port close. Patch 2 enables RTE_ETH_DEV_CLOSE_REMOVE and reworks resources release logic for port close. Thanks, Rahul Rahul Lakkireddy (2): net/cxgbe: fix queue DMA ring leaks during port close

Re: [dpdk-dev] [PATCH v2 5/6] eal: hide internal device event structure

2020-09-18 Thread Kinsella, Ray
On 14/09/2020 09:23, David Marchand wrote: > This structure is not used in the public API. > > Fixes: a753e53d517b ("eal: add device event monitor framework") > > Signed-off-by: David Marchand > --- > doc/guides/rel_notes/deprecation.rst | 3 --- > doc/guides/rel_notes/release_20_11.rst |

Re: [dpdk-dev] [PATCH v2 4/4] mbuf: remove physical address alias

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 11:41, Thomas Monjalon wrote: > Remove the deprecated buf_physaddr union field from rte_mbuf. > It is replaced with buf_iova which is at the same offset. > > The single field buf_physaddr in rte_kni_mbuf is also renamed. > > This concludes a 3-year process of semantic change. >

Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-09-18 Thread Gujjar, Abhinandan S
Hi Ankur, Please see comments inline. Regards Abhinandan > -Original Message- > From: Ankur Dwivedi > Sent: Friday, September 18, 2020 8:05 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > > Subject: RE: [PATCH 1/3] test/event_crypto_adapter

Re: [dpdk-dev] [PATCH v2 3/4] mbuf: remove deprecated function and macro aliases

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 11:41, Thomas Monjalon wrote: > Remove the deprecated functions > - rte_mbuf_data_dma_addr > - rte_mbuf_data_dma_addr_default > which aliased the more recent functions > - rte_mbuf_data_iova > - rte_mbuf_data_iova_default > > Remove the deprecated macros >

Re: [dpdk-dev] [PATCH v2 2/4] mempool: remove physical address aliases

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 11:41, Thomas Monjalon wrote: > Remove the deprecated unioned fields physaddr and phys_addr > from the structures rte_mempool_objhdr and rte_mempool_memhdr. > They are replaced with the fields iova which are at the same offsets. > > Remove the deprecated macro MEMPOOL_F_NO_PHYS_CO

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources during port close

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 2:18 PM, Rahul Lakkireddy wrote: On Thursday, September 09/17/20, 2020 at 13:46:24 +0100, Ferruh Yigit wrote: On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote: Enable RTE_ETH_DEV_CLOSE_REMOVE during PCI probe for all ports enumerated under the PF. Free up the underlying port Virtual Ide

Re: [dpdk-dev] [PATCH v2 1/4] mem: remove physical address aliases

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 11:41, Thomas Monjalon wrote: > Remove the deprecated unioned fields phys_addr > from the structures rte_memseg and rte_memzone. > They are replaced with the fields iova which are at the same offsets. > > Signed-off-by: Thomas Monjalon > Acked-by: Andrew Rybchenko > Acked-by: An

Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-09-18 Thread Ankur Dwivedi
Hi Abhinandan, Please see my comments inline. Thanks Ankur >-Original Message- >From: Gujjar, Abhinandan S >Sent: Friday, September 18, 2020 12:41 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapt

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-18 Thread Asaf Penso
Hello Jan, You can have a look in series [1] where we propose to add APIs to DPDK20.11 for both mirroring and sampling for packets, with additional actions of the different traffic. [1] http://patches.dpdk.org/project/dpdk/list/?series=12045 Regards, Asaf Penso >-Original Message- >Fr

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add GENEVE parsing

2020-09-18 Thread Ophir Munk
Hi Olivier, Please find comments inline. I sent v5 based on your review. http://patches.dpdk.org/project/dpdk/list/?series=12354 > -Original Message- > From: Olivier Matz > Sent: Thursday, September 17, 2020 3:23 PM > To: Ophir Munk > Cc: dev@dpdk.org; Wenzhuo Lu ; Beilei Xing > ; Bernar

[dpdk-dev] [PATCH v5 2/3] app/testpmd: enable configuring GENEVE port

2020-09-18 Thread Ophir Munk
From: Ophir Munk IANA has assigned port 6081 as the fixed well-known destination port for GENEVE. Nevertheless draft-ietf-nvo3-geneve-09 recommends that implementations make this configurable. This commit enables specifying any positive UDP destination port number for GENEVE. Signed-off-by: Oph

[dpdk-dev] [PATCH v5 3/3] app/testpmd: reduce tunnel parsing code duplication

2020-09-18 Thread Ophir Munk
From: Ophir Munk This is a cleanup commit. It assembles all tunnel outer updates into one function call to avoid code duplications. It defines RTE_VXLAN_GPE_DEFAULT_PORT (4790) in accordance with all other tunnel protocol definitions. Signed-off-by: Ophir Munk --- app/test-pmd/csumonly.c|

[dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd

2020-09-18 Thread Ophir Munk
v1: Initial version v2: Rebased + Minor update in protocol options field: char opts[0] ===> uint8_t opts[] v3: Rebase document "geneve-port=N" parameter v4: Mispelling corrections v5: Rebase + Updates following review http://patches.dpdk.org/patch/77734/ Ophir Munk (3): app/testpmd: add GENEVE p

[dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-09-18 Thread Ophir Munk
From: Ophir Munk GENEVE is a widely used tunneling protocol in modern Virtualized Networks. testpmd already supports parsing of several tunneling protocols including VXLAN, VXLAN-GPE, GRE. This commit adds GENEVE parsing of inner protocols (IPv4-0x0800, IPv6-0x86dd, Ethernet-0x6558) based on IETF

Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs

2020-09-18 Thread Bruce Richardson
On Fri, Sep 18, 2020 at 02:54:21PM +0200, Mohammed Hawari wrote: > Hello Bruce, > > Thanks for the quick response, see inline > > Best regards, > > Mohammed > > > On 18 Sep 2020, at 13:43, Bruce Richardson > > wrote: > > > > On Fri, Sep 18, 2020 at 10:49:23AM +0200, Mohammed Hawari wrote: >

[dpdk-dev] [PATCH v2] crypto/octeontx2: fix sessionless code

2020-09-18 Thread Ankur Dwivedi
A temporary session is created for sessionless crypto operations. rte_cryptodev_sym_session_create() should be used for creating the temporary session as it initializes the session structure in the correct way. Also the session should be set to 0 before freeing it. Fixes: 17ac2a72191b ("crypto/oct

Re: [dpdk-dev] [PATCH v1 4/5] vhost: add packed ring vectorized dequeue

2020-09-18 Thread Maxime Coquelin
On 8/19/20 5:24 AM, Marvin Liu wrote: > Optimize vhost packed ring dequeue path with SIMD instructions. Four > descriptors status check and writeback are batched handled with AVX512 > instructions. Address translation operations are also accelerated by > AVX512 instructions. > > If platform or

Re: [dpdk-dev] [PATCH v3 3/6] pci: move resource mapping to the PCI bus

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 12:28, David Marchand wrote: > As reported during 20.08 work for Windows, the pci_map_resource API was > built with the assumption that its flags would be passed to mmap(). > > This introduced a regression when adding the rte_mem_map API as reported > in the workaround commit 9d2b

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 10:23 AM, Igor Ryzhov wrote: Hi, Your code will work only if stats are updated at least once between two overflows. > In this case it will have problems in 'i40e_stat_update_48()' too. It seems there is no way to detect if the increase in stats is N or MAX_48+N by the software.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 4:44 AM, Jiang, JunyuX wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 8:31 PM To: Jiang, JunyuX ; dev@dpdk.org Cc: Guo, Jia ; Xing, Beilei ; sta...@dpdk.org Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte coun

Re: [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure

2020-09-18 Thread Kinsella, Ray
On 18/09/2020 04:40, Guo, Jia wrote: > Hi, David > >> -Original Message- >> From: David Marchand >> Sent: Thursday, September 17, 2020 7:28 PM >> To: dev@dpdk.org >> Cc: arybche...@solarflare.com; Ray Kinsella ; Neil >> Horman ; Mcnamara, John >> ; Kovacevic, Marko >> ; Jianfeng Tan ;

Re: [dpdk-dev] [RFC 3/3] sft: introduce API

2020-09-18 Thread Kinsella, Ray
On 09/09/2020 21:30, Andrey Vesnovaty wrote: > Defines RTE SFT APIs for Statefull Flow Table library. > > SFT General description: > SFT library provides a framework for applications that need to maintain > context across different packets of the connection. > Examples for such applications: >

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources during port close

2020-09-18 Thread Rahul Lakkireddy
On Thursday, September 09/17/20, 2020 at 13:46:24 +0100, Ferruh Yigit wrote: > On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote: > >Enable RTE_ETH_DEV_CLOSE_REMOVE during PCI probe for all ports > >enumerated under the PF. Free up the underlying port Virtual > >Identifier (VI) and associated resources d

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 14:34, Olivier Matz wrote: > Hi Dmitry, > > On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: >> struct cmdline exposes platform-specific members it contains, most >> notably struct termios that is only available on Unix. Make the >> structure opaque. >> >> Remove te

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-18 Thread Kinsella, Ray
On 17/09/2020 18:05, Stephen Hemminger wrote: > On Thu, 17 Sep 2020 15:34:43 +0200 > Olivier Matz wrote: > >> Hi Dmitry, >> >> On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: >>> struct cmdline exposes platform-specific members it contains, most >>> notably struct termios that

[dpdk-dev] Duplicating traffic with RTE Flow

2020-09-18 Thread Jan Viktorin
Hello all, we are looking for a way to duplicate ingress traffic in hardware. There is an example in [1] suggesting to insert two fate actions into the RTE Flow actions array like: flow create 0 ingress pattern end \ actions queue index 0 / void / queue index 1 / end But our experience

Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs

2020-09-18 Thread Mohammed Hawari
Hello Bruce, Thanks for the quick response, see inline Best regards, Mohammed > On 18 Sep 2020, at 13:43, Bruce Richardson wrote: > > On Fri, Sep 18, 2020 at 10:49:23AM +0200, Mohammed Hawari wrote: >> Similarly to the disable_drivers option, the disable_libs option is >> introduced. This all

[dpdk-dev] [PATCH] app/test-sad: fix uninitialized variable

2020-09-18 Thread Vladimir Medvedkin
Coverity issue: 362055 Fixes: 908be0651a5a ("app/test-sad: add test application for IPsec SAD") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test-sad/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-sad/main.c b/app/test-sad/main.c index b01e8

Re: [dpdk-dev] [PATCH v5] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Maxime Coquelin
On 9/18/20 11:55 AM, Vipul Ashri wrote: > Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always > failing as assignment done using var_ having local scope only. > This leads to TX packets not going out and found broken due to cleanup > malfunctioning. This patch fixes the wrong

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue assertion

2020-09-18 Thread Maxime Coquelin
On 9/2/20 10:34 AM, Matan Azrad wrote: > The CQ configuration enables the collapse feature in HW what cause HW to > write all the completions in the first CQE. > When this feature is enabled the HW doesn't switch the owner bit when it > starts a new cycle of the CQ, not like working without the

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue polling

2020-09-18 Thread Maxime Coquelin
On 9/10/20 9:20 AM, Matan Azrad wrote: > The CQ polling is done in order to notify the guest about new traffic > bursts and to release FW resources for the next bursts management. > > When HW is faster than SW, it may be that all the FW resources are busy > in SW due to late polling. > In this

Re: [dpdk-dev] [v1] vdpa/mlx5: fix event channel setup

2020-09-18 Thread Maxime Coquelin
On 8/25/20 11:17 AM, Xueming Li wrote: > During vdap device setup, if some error happens, event channel release > stuck at polling event channel. > > Event channel fd is set to nonblocking in cqe setup, so if any error > happens before this function and after event channel created, the > poolin

Re: [dpdk-dev] [PATCH v2 1/1] vhost: fix iotlb mempool single-consumer flag

2020-09-18 Thread Maxime Coquelin
On 8/31/20 9:59 AM, Eugenio Pérez wrote: > Bugzilla bug: 523 > > Control thread (which handles iotlb msg) and forwarding > thread both use iotlb to translate address. The former may modify the > same entry of mempool and may cause a loop in iotlb_pending_entries > list. > > Fixes: d012d1f293f4

Re: [dpdk-dev] [PATCH v3] vhost: add device reset status

2020-09-18 Thread Maxime Coquelin
On 8/10/20 3:18 PM, Chenbo Xia wrote: > vhost lib now does not have definition of reset status. This patch > adds the reset status definition and changes related log. > > Signed-off-by: Chenbo Xia > --- > lib/librte_vhost/vhost.h | 1 + > lib/librte_vhost/vhost_user.c | 2 ++ > 2 files c

Re: [dpdk-dev] [PATCH v3 0/4] Add support for GET/SET_STATUS on virtio-user pmd

2020-09-18 Thread Maxime Coquelin
On 8/5/20 4:45 PM, Adrian Moreno wrote: > Recently, two new messages have been added to the vhost-user protocol that > make the device initialization more robust. > > VHOST_VIRTIO_SET_STATUS allows the driver to set the device status > VHOST_VIRTIO_GET_STATUS allows the driver to read the statu

[dpdk-dev] [Bug 538] Incorrect packets sent by mlx5 with multiseg configuration in testpmd

2020-09-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=538 Bug ID: 538 Summary: Incorrect packets sent by mlx5 with multiseg configuration in testpmd Product: DPDK Version: 18.11 Hardware: All OS: All Status: UNC

Re: [dpdk-dev] [PATCH v5] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Maxime Coquelin
On 9/18/20 11:55 AM, Vipul Ashri wrote: > Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always > failing as assignment done using var_ having local scope only. > This leads to TX packets not going out and found broken due to cleanup > malfunctioning. This patch fixes the wrong

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-18 Thread Dey, Souvik
Hi Long, Yes the below patch helped in getting the tx path issue resolved in 18.11.9. Thank you very much for the help. I think it will be really good to have this patch include in 18.11.10 too. Current status: 18.11.9 – 1. Required 2 patches on top of 18.11.9 to make it work. a. htt

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 9:59 AM, Andrew Rybchenko wrote: On 9/18/20 11:41 AM, Bruce Richardson wrote: On Thu, Sep 17, 2020 at 08:59:26PM +0300, Andrew Rybchenko wrote: On 9/16/20 7:44 PM, Bruce Richardson wrote: As flagged previously on-list, there are a number of macros used to specify what libs and dri

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-18 Thread Ferruh Yigit
On 9/18/2020 9:33 AM, Bruce Richardson wrote: On Thu, Sep 17, 2020 at 10:05:48AM -0700, Stephen Hemminger wrote: On Thu, 17 Sep 2020 15:34:43 +0200 Olivier Matz wrote: Hi Dmitry, On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: struct cmdline exposes platform-specific members

Re: [dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API

2020-09-18 Thread Ananyev, Konstantin
> This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > --- > v6->v7: > d

[dpdk-dev] [PATCH v4 4/4] build: add abi breakage checks to meson

2020-09-18 Thread Conor Walsh
This patch adds the ability to run ABI breakage checks to meson. To do this the developer needs to set the meson build type to debug and set the version of DPDK that they want to check the ABI against. The option "abi_checks" has been added to meson for this, the option accepts DPDK tags e.g. "late

[dpdk-dev] [PATCH v4 3/4] buildtools: add script to setup abi checks for meson

2020-09-18 Thread Conor Walsh
This patch adds a script that is intended to be invoked by meson to do the required setup for performing ABI breakage checks at build time. The required ABI dump archives can come from several sources including being generated at build time or prebuilt archives can be pulled from a remote http loca

[dpdk-dev] [PATCH v4 0/4] abi breakage checks for meson

2020-09-18 Thread Conor Walsh
This patchset allows developers to check ABI breakages during build time. Currently checking that the DPDK ABI has not changed before up-streaming code is not intuitive. The current method, requires the contributor to use either the test-build.sh and test-meson-build.sh tools, along side some envir

[dpdk-dev] [PATCH v4 2/4] devtools: add generation of compressed abi dump archives

2020-09-18 Thread Conor Walsh
This patch adds a script that generates a compressed archive containing .dump files which can be used to perform ABI breakage checking for the build specified in the parameters. Invoke using "./gen-abi-tarball.py [-t ] [-a ] [-cf ]" - : dpdk tag e.g. "v20.11", default: latest - : re

[dpdk-dev] [PATCH v4 1/4] devtools: bug fix for gen-abi.sh

2020-09-18 Thread Conor Walsh
This patch fixes a bug with the gen-abi.sh script in devtools. When ran on an install directory the script would try to generate .dump files from directories as well as the .so files which is not correct. Example error: abidw: gcc/lib/librte_net.so.21.0.p is not a regular file To rectify this the r

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/sfc/base: fix tunnel configuration failure

2020-09-18 Thread Ferruh Yigit
On 9/8/2020 10:20 AM, Andrew Rybchenko wrote: From: Igor Romanov Tunnel configuration may fail because of insufficient access rights on a virtual function. Ignore the failure if a tunnel configuration with empty UDP ports is requested. Fixes: 17551f6dffcc ("net/sfc/base: add API to control UDP

Re: [dpdk-dev] [PATCH] net/memif: relax barrier for zero copy path

2020-09-18 Thread Ferruh Yigit
On 9/11/2020 6:38 AM, Phil Yang wrote: Using 'rte_mb' to synchronize the shared ring head/tail between producer and consumer will stall the pipeline and damage performance on the weak memory model platforms, such like aarch64. Relax the expensive barrier with c11 atomic with explicit memory orde

[dpdk-dev] [PATCH v2 1/1] net/af_xdp: shared UMEM support

2020-09-18 Thread Ciara Loftus
Kernel v5.10 will introduce the ability to efficiently share a UMEM between AF_XDP sockets bound to different queue ids on the same or different devices. This patch integrates that functionality into the AF_XDP PMD. A PMD will attempt to share a UMEM with others if the shared_umem=1 vdev arg is se

[dpdk-dev] [PATCH v2 0/1] net/af_xdp: shared UMEM support

2020-09-18 Thread Ciara Loftus
This patch integrates support for shared UMEMs into the AF_XDP PMD. The feature is currently available in the linux-next tree [1] and should be available in the v5.10 kernel. Detailed information on the shared UMEM feature can be found in the kernel documentation. Support for the kernel feature i

[dpdk-dev] [PATCH V7 3/3] app/testpmd: add FEC command

2020-09-18 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

[dpdk-dev] [PATCH V7 2/3] net/hns3: support FEC

2020-09-18 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

[dpdk-dev] [PATCH V7 0/3] add FEC support

2020-09-18 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 219 +++ app/test-pmd/config.c| 54 app/test-pmd/te

[dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API

2020-09-18 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang --- v6->v7: deleted RTE_ETH_FEC_NUM t

Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs

2020-09-18 Thread Bruce Richardson
On Fri, Sep 18, 2020 at 10:49:23AM +0200, Mohammed Hawari wrote: > Similarly to the disable_drivers option, the disable_libs option is > introduced. This allows to selectively disable the build of elements > in libs to speed-up the build process. > > Signed-off-by: Mohammed Hawari > --- While I

Re: [dpdk-dev] [PATCH v8 1/3] ethdev: add level support for RSS offload types

2020-09-18 Thread Ferruh Yigit
On 9/17/2020 7:56 PM, Ajit Khaparde wrote: On Thu, Sep 17, 2020 at 2:36 AM Andrew Rybchenko wrote: On 9/17/20 5:07 AM, kirankum...@marvell.com wrote: From: Kiran Kumar K This patch reserves 2 bits as input selection to select Inner and outer encapsulation level for RSS computation. It is co

[dpdk-dev] [PATCH][V2] net/af_xdp: avoid deadlock due to empty fill queue

2020-09-18 Thread Li RongQing
when receive packets, it is possible to fail to reserve fill queue, since buffer ring is shared between tx and rx, and maybe not available temporary. at last, both fill queue and rx queue are empty. then kernel side will be unable to receive packets due to empty fill queue, and dpdk will be unable

Re: [dpdk-dev] [PATCH] af_xdp: avoid deadlock due to empty fill queue

2020-09-18 Thread Li,Rongqing
> -Original Message- > From: Loftus, Ciara [mailto:ciara.lof...@intel.com] > Sent: Friday, September 18, 2020 5:27 PM > To: Li,Rongqing ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] af_xdp: avoid deadlock due to empty fill queue > > > when receive packets, it is

Re: [dpdk-dev] [PATCH 2/2] af_xdp: avoid to unnecessary allocation and free mbuf

2020-09-18 Thread Li,Rongqing
> -Original Message- > From: Loftus, Ciara [mailto:ciara.lof...@intel.com] > Sent: Friday, September 18, 2020 5:39 PM > To: Li,Rongqing > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] af_xdp: avoid to unnecessary allocation > and > free mbuf > > > > > optimize rx performance,

Re: [dpdk-dev] [v1] vdpa/mlx5: fix event channel setup

2020-09-18 Thread Xueming(Steven) Li
> -Original Message- > From: Maxime Coquelin > Sent: Friday, September 18, 2020 5:42 PM > To: Xueming(Steven) Li ; Matan Azrad > ; Slava Ovsiienko > Cc: dev@dpdk.org; Asaf Penso > Subject: Re: [dpdk-dev] [v1] vdpa/mlx5: fix event channel setup > > > > On 8/25/20 11:17 AM, Xueming Li

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-18 Thread Somnath Kotur
On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot wrote: > > .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function > ‘bnxt_ulp_destroy_df_rules’: > .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error: > comparison is always true due to limited range of data type > [-Werror=

[dpdk-dev] [PATCH v2 2/2] net/octeontx2: add replay check for inline inbound packets

2020-09-18 Thread Ankur Dwivedi
The function handling anti replay is added. If replay window is enabled the rx packets will be validated against the window. The rx offload fails in case of error. Signed-off-by: Ankur Dwivedi --- .../crypto/octeontx2/otx2_ipsec_anti_replay.h | 208 ++ drivers/net/octeontx2/otx2_

[dpdk-dev] [PATCH v2 0/2] add anti replay support in OCTEON TX2 security

2020-09-18 Thread Ankur Dwivedi
Support for anti replay is added in OCTEON TX2 security PMD. The functionality has been tested with ipsec-secgw application running in inline protocol offload mode. v2: * In the "net/octeontx2: add replay check for inline inbound packets" patch, few local variables are explicitly initialized to

[dpdk-dev] [PATCH v2 1/2] net/octeontx2: add anti replay support in security session

2020-09-18 Thread Ankur Dwivedi
Initialize the inbound session for anti replay. The replay window is allocated during session create and freed in session destroy. Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx2/otx2_ipsec_fp.h | 29 ++-- drivers/crypto/octeontx2/otx2_security.h | 3 ++ drivers/net/octeon

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-18 Thread Long Li
Can you apply the following patch to see if it helps? diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 813f8c3cc..8359cc121 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Maxime Coquelin
On 9/18/20 12:46 PM, Vipul Ashri wrote: > Hi Edward / Andrew > > I like your suggestions and applied with [v5] net/virtio: fix wrong variable > assignment in helper macro > V4 had a extra line typos., V5 is tested compiled and pushed carefully Thanks! Thanks Vipul, I plan to pick your patch l

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Vipul Ashri
Hi Edward / Andrew I like your suggestions and applied with [v5] net/virtio: fix wrong variable assignment in helper macro V4 had a extra line typos., V5 is tested compiled and pushed carefully Thanks! Regards Vipul -Original Message- From: Edward Makarov [mailto:maka...@kraftway.ru] S

Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-18 Thread Ananyev, Konstantin
> >> > >> +/** > >> + * This enum indicates the possible (forward error correction)FEC modes > >> + * of an ethdev port. > >> + */ > >> +enum rte_fec_mode { > >> + RTE_ETH_FEC_NOFEC = 0, /**< FEC is off */ > >> + RTE_ETH_FEC_BASER, /**< FEC using common algorithm */ > >> + RTE_ETH_

  1   2   >