Re: [dpdk-dev] [PATCH v1] net: expand the data size of L3 length to 16 bits

2020-09-04 Thread Wang, Haiyue
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, September 5, 2020 02:56 > To: Wang, Haiyue > Cc: dev@dpdk.org; Olivier Matz > Subject: Re: [dpdk-dev] [PATCH v1] net: expand the data size of L3 length to > 16 bits > > On Fri, 4 Sep 2020 13:40:20 +0800 > Haiyue Wang wr

[dpdk-dev] [PATCH v2] net: adjust the header length parse size

2020-09-04 Thread Haiyue Wang
Align to the rte_mbuf's design about Tx header length data size for the header length parse result. struct { uint64_t l2_len:7; /*88: 0 8 */ uint64_t l3_len:9; /*88: 7 8 */ uint64_t l4_len:8;

Re: [dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 15:31:19 -0700 Stephen Hemminger wrote: > If using lots of queues and ports, and having per port or per queue > metrics it is easy to exceed the upper bound of the metric library. > Move the limit into rte_config where user can change it. > > Ideally, there would be no upper

[dpdk-dev] [PATCH v4] usertools: add huge page setup script

2020-09-04 Thread Stephen Hemminger
This is an improved version of the setup of huge pages bases on earlier DPDK setup. Differences are: * it autodetects NUMA vs non NUMA * it allows setting different page sizes recent kernels support multiple sizes. * it accepts a parameter in bytes (not pages). If necessary the steps

[dpdk-dev] [PATCH 9/9] net/i40e/base: update version

2020-09-04 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 58174d472..6af299311 100644 --- a/drivers/net/i40e/base/README +++

[dpdk-dev] [PATCH 5/9] net/i40e/base: add support for minimum rollback revision

2020-09-04 Thread Guinan Sun
Add support for minimum rollback revision. Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq_cmd.h | 18 +++ drivers/net/i40e/base/i40e_common.c | 29 + drivers/net/i40e/base/i40e_prototype.h | 4

[dpdk-dev] [PATCH 8/9] net/i40e/base: fix PHY config param when enabling EEE

2020-09-04 Thread Guinan Sun
The i40e_enable_eee function did not copy phy_type_ext field from current PHY configuration retrieved with Get PHY Abilities AQ. It caused a misconfiguration of the PHY on devices supporting 2.5 and 5G speeds and prevented establishing link when only those speeds were selected for advertisement. F

[dpdk-dev] [PATCH 6/9] net/i40e/base: fix Rx only for unicast promisc on VLAN

2020-09-04 Thread Guinan Sun
Set promiscuous mode to rx traffic only if VSI has VLANs configured. Rename misleading PROMISC_TX bit to proper name. Added I40E_AQC_SET_VSI_PROMISC_RX_ONLY during VSI unicast promiscuous mode configuration with port VLAN. Aligned unicast promiscuous with VLAN to the one without VLAN. Previously ot

[dpdk-dev] [PATCH 7/9] net/i40e/base: add EEE LPI status check for X722 adapters

2020-09-04 Thread Guinan Sun
Add reading LPI (low power idle) status for supported X722 devices. If adapter's PHY supports EEE in current mode (device ID + link speed), LPI status is read from PHY Clause 45 PCS status register. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH 3/9] net/i40e/base: enable pipe monitor thresholds

2020-09-04 Thread Guinan Sun
Enable several registers and defines for software controlled DCB, particularly around the receive pipe monitor configuration which is necessary to help ports achieve the right throughput under load in several different configurations. Signed-off-by: Jesse Brandeburg Signed-off-by: Guinan Sun ---

[dpdk-dev] [PATCH 2/9] net/i40e/base: update FW API version

2020-09-04 Thread Guinan Sun
Update FW increment API version. Signed-off-by: Jacek Naczyk Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index 076

[dpdk-dev] [PATCH 1/9] net/i40e/base: add VLAN field for input set

2020-09-04 Thread Guinan Sun
Add VLAN bit used during flow director programming, as a part of input set for HW. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/bas

[dpdk-dev] [PATCH 4/9] net/i40e/base: fix missing function header arguments

2020-09-04 Thread Guinan Sun
Fix them by adding the argument descriptions. Fixes: 0d9d27bb8684 ("i40e/base: prepare local LLDP MIB in TLV") Cc: sta...@dpdk.org Signed-off-by: Jesse Brandeburg Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_dcb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 0/9] update i40e base code

2020-09-04 Thread Guinan Sun
update i40e base code. source code of i40e driver: cid-i40e.2020.08.27.tar.gz dropped by the team which develop basic drivers for any i40e NIC. changelog in ND share repo: >From c0bfc1c07bb3 ("i40e-shared: Add VLAN field for input set") To 1a82d59f0797 ("i40e-shared: Fix PHY configuration paramet

Re: [dpdk-dev] [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode

2020-09-04 Thread Honnappa Nagarahalli
> > Sequences like "value = %"PRIu64 (no space before PRIu64) are parsed as a > single preprocessor token, user-defined-string-literal, in C++11 onwards. > While modern compilers are smart enough to parse this properly, GCC 9.3.0 > generates warnings like: > > rte_rcu_qsbr.h:555:26: warning

Re: [dpdk-dev] [PATCH] usertools: add huge page setup script

2020-09-04 Thread Stephen Hemminger
On Sat, 5 Sep 2020 00:13:06 +0100 Ferruh Yigit wrote: > What do you thing checking if mount point exist before 'cmd'? > > +if not exists(HUGEDIR): > +os.system('mkdir -p ' + HUGEDIR) Not necessary with standard systemd

Re: [dpdk-dev] [PATCH] usertools: add huge page setup script

2020-09-04 Thread Ferruh Yigit
On 9/4/2020 7:35 PM, Stephen Hemminger wrote: > This is an improved version of the setup of huge pages > bases on earlier DPDK setup. Differences are: >* it autodetects NUMA vs non NUMA >* it allows setting different page sizes > recent kernels support multiple sizes. >* it accepts

[dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config

2020-09-04 Thread Stephen Hemminger
If using lots of queues and ports, and having per port or per queue metrics it is easy to exceed the upper bound of the metric library. Move the limit into rte_config where user can change it. Ideally, there would be no upper bound and a dynamic structure such as red-black tree or hash table would

[dpdk-dev] [PATCH] eal/rte_malloc: add alloc_size() attribute to allocation functions

2020-09-04 Thread Stephen Hemminger
By using the alloc_size() attribute the compiler can optimize better and detect errors at compile time. For example, Gcc will fail one of the invalid allocation examples in app/test/test_malloc.c because the allocation is outside the limits of memory. Signed-off-by: Stephen Hemminger --- app/te

[dpdk-dev] [RFC] net/mlx5: Flow mark ID and L3/L4 header CQE compression

2020-09-04 Thread Alexander Kozyrev
CQE compression reduces PCI bandwidth usage by coalescing and compressing multiple CQEs into a single zipped CQE. This improves Rx message rate, especially for small packet traffic. CQEs must be almost identical to be successfully merged and compressed together. All the shared data is contained in

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add simple power management API

2020-09-04 Thread Ananyev, Konstantin
> Add a simple API allow ethdev get the last > available queue descriptor address from PMD. > Also include internal structure update. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > --- > lib/librte_ethdev/rte_ethdev.h | 22 ++ > lib/librte_ethdev/rte_ethdev_core

[dpdk-dev] [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode

2020-09-04 Thread Dmitry Kozlyuk
Sequences like "value = %"PRIu64 (no space before PRIu64) are parsed as a single preprocessor token, user-defined-string-literal, in C++11 onwards. While modern compilers are smart enough to parse this properly, GCC 9.3.0 generates warnings like: rte_rcu_qsbr.h:555:26: warning: invalid suffix

Re: [dpdk-dev] [PATCH v1] net: expand the data size of L3 length to 16 bits

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 13:40:20 +0800 Haiyue Wang wrote: > diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h > index 94b06d9ee..992fb088a 100644 > --- a/lib/librte_net/rte_net.h > +++ b/lib/librte_net/rte_net.h > @@ -20,11 +20,11 @@ extern "C" { > */ > struct rte_net_hdr_lens { >

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these i

[dpdk-dev] [PATCH] usertools: add huge page setup script

2020-09-04 Thread Stephen Hemminger
This is an improved version of the setup of huge pages bases on earlier DPDK setup. Differences are: * it autodetects NUMA vs non NUMA * it allows setting different page sizes recent kernels support multiple sizes. * it accepts a parameter in bytes (not pages). If necessary the steps

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-04 Thread Ananyev, Konstantin
> > Add a simple on/off switch that will enable saving power when no > packets are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering an > architecture-defined optimized power state that will either wait > until a TSC timestamp

Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-04 Thread Ferruh Yigit
On 9/4/2020 12:32 PM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, only statistics of rx/tx queues with queue_id less than > RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain > application scenario that it needs to use 256 or more than 256 queues > and display all st

Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-04 Thread Ferruh Yigit
On 9/4/2020 12:32 PM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, only statistics of rx/tx queues with queue_id less than > RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain > application scenario that it needs to use 256 or more than 256 queues > and display all st

[dpdk-dev] [PATCH v4 09/11] baseband/acc100: add debug function to validate input

2020-09-04 Thread Nicolas Chautru
Debug functions to validate the input API from user Only enabled in DEBUG mode at build time Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 424 +++ 1 file changed, 424 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c

[dpdk-dev] [PATCH v4 01/11] drivers/baseband: add PMD for ACC100

2020-09-04 Thread Nicolas Chautru
Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru --- config/common_base | 4 + doc/guides/bbdevs/acc100.rst | 233 + doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_20_

[dpdk-dev] [PATCH v4 11/11] doc: update bbdev feature table

2020-09-04 Thread Nicolas Chautru
Correcting overview matrix to use acc100 name Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/features/acc100.ini | 14 ++ doc/guides/bbdevs/features/mbc.ini| 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) create mode 100644 doc/guides/bbdevs/features

[dpdk-dev] [PATCH v4 10/11] baseband/acc100: add configure function

2020-09-04 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 72 +++ drivers/baseband/acc100/Makefile | 3 + drivers

[dpdk-dev] [PATCH v4 08/11] baseband/acc100: add interrupt support to PMD

2020-09-04 Thread Nicolas Chautru
Adding capability and functions to support MSI interrupts, call backs and inforing. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 288 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 15 ++ 2 files changed, 300 insertions(+), 3 deletion

[dpdk-dev] [PATCH v4 06/11] baseband/acc100: add HARQ loopback support

2020-09-04 Thread Nicolas Chautru
Additional support for HARQ memory loopback Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 158 +++ 1 file changed, 158 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c inde

[dpdk-dev] [PATCH v4 07/11] baseband/acc100: add support for 4G processing

2020-09-04 Thread Nicolas Chautru
Adding capability for 4G encode and decoder processing Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 1010 -- 1 file changed, 943 insertions(+), 67 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/

[dpdk-dev] [PATCH v4 02/11] baseband/acc100: add register definition file

2020-09-04 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/acc100_pf_enum.h | 1068 ++ drivers/baseband/acc100/acc100_vf_enum.h | 73 ++ drivers/baseband/acc100/rte_acc100_pmd.h | 490 +++

[dpdk-dev] [PATCH v4 05/11] baseband/acc100: add LDPC processing functions

2020-09-04 Thread Nicolas Chautru
Adding LDPC decode and encode processing operations Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 1625 +- drivers/baseband/acc100/rte_acc100_pmd.h |3 + 2 files changed, 1626 insertions(+), 2 deletions(-) diff --git a/drivers/base

[dpdk-dev] [PATCH v4 03/11] baseband/acc100: add info get function

2020-09-04 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No processing capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru --- app/test-bbdev/Makefile | 3 + app/test-bbdev/meson.build

[dpdk-dev] [PATCH v4 04/11] baseband/acc100: add queue configuration

2020-09-04 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 420 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 45 2 files changed, 464 insertions(+), 1 deleti

[dpdk-dev] [PATCH v4 00/11] bbdev PMD ACC100

2020-09-04 Thread Nicolas Chautru
v4: an odd compilation error is reported for one CI variant using "gcc latest" which looks to me like a false positive of maybe-undeclared. http://mails.dpdk.org/archives/test-report/2020-August/148936.html Still forcing a dummy declare to remove this CI warning I will check with c...@dpdk.org in

Re: [dpdk-dev] [PATCH v2] usertools: add huge page setup script

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 10:22:28 +0100 Bruce Richardson wrote: > > +def set_pages(pages, hugepgsz): > > +'''Sets the numberof huge pages to be reserved''' > > +if is_numa(): > > +set_numa_pages(pages, hugepgsz) > > +else: > > +set_non_numa_pages(pages, hugepgsz) > > + >

Re: [dpdk-dev] [PATCH v3 01/11] drivers/baseband: add PMD for ACC100

2020-09-04 Thread Chautru, Nicolas
Hi, > -Original Message- > From: Xu, Rosen > > Hi, > > > -Original Message- > > From: dev On Behalf Of Nicolas Chautru > > Sent: Wednesday, August 19, 2020 8:25 > > To: dev@dpdk.org; akhil.go...@nxp.com > > Cc: Richardson, Bruce ; Chautru, Nicolas > > > > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these i

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add simple power management API

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:56 +0100 Liang Ma wrote: > +#define ETH_EMPTYPOLL_MAX 512 /**< Empty poll number threshlold */ Spelling here. Also, shouldn't this be a per-device (or per-queue) configuration value.

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:57 +0100 Liang Ma wrote: > Add a simple on/off switch that will enable saving power when no > packets are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering an > architecture-defined optimized power st

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > + * > + * @return > + * Architecture-dependent return value. > + */ > +static inline int rte_power_monitor(const volatile void *p, > + const uint64_t expected_value, const uint64_t value_mask, > + const uint32_t state,

[dpdk-dev] [dpdk-dev v2 2/2] fips_validation: update GCM test

2020-09-04 Thread Fan Zhang
This patch updates fips validation GCM test capabilities: - In NIST GCMVS spec GMAC test vectors are the GCM ones with plaintext length as 0 and uses AAD as input data. Originally fips_validation tests treats them both as GCM test vectors. This patch introduce automatic test type recognition betwe

[dpdk-dev] [dpdk-dev v2 1/2] fips_validation: add SGL support

2020-09-04 Thread Fan Zhang
This patch adds SGL support to FIPS sample application. Originally the application allocates single mbuf of 64KB - 1 bytes data room. With the change the user may reduce the mbuf dataroom size by using the add cmdline option. If the input test data is longer than the user provided data room size th

[dpdk-dev] [dpdk-dev v2 0/2] fips_validation: add SGL and GMAC support

2020-09-04 Thread Fan Zhang
This patchset adds SGL and GMAC support to fips_validation sample application. The added cmdline option allows user to split the input data into multiple mbuf segments to test SGL feature of the target cryptodev PMD; The NIST GCMVS compliant GMAC test method support is also added in this patchset.

Re: [dpdk-dev] [PATCH] security: update session create API

2020-09-04 Thread Lukasz Wojciechowski
W dniu 03.09.2020 o 22:09, akhil.go...@nxp.com pisze: > From: Akhil Goyal > > The API ``rte_security_session_create`` takes only single > mempool for session and session private data. So the > application need to create mempool for twice the number of > sessions needed and will also lead to wast

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-04 Thread Bruce Richardson
On Fri, Sep 04, 2020 at 03:25:26PM +0100, Ferruh Yigit wrote: > On 9/3/2020 4:35 PM, Bruce Richardson wrote: > > On Sat, Aug 29, 2020 at 03:13:16PM +0800, Chengchang Tang wrote: > >> Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer > >> size used in receiving packets for HW.

[dpdk-dev] [dpdk-dev v8 4/4] doc: add cryptodev service APIs guide

2020-09-04 Thread Fan Zhang
This patch updates programmer's guide to demonstrate the usage and limitations of cryptodev symmetric crypto data-path service APIs. Signed-off-by: Fan Zhang --- doc/guides/prog_guide/cryptodev_lib.rst | 90 + 1 file changed, 90 insertions(+) diff --git a/doc/guides/prog

[dpdk-dev] [dpdk-dev v8 3/4] test/crypto: add unit-test for cryptodev direct APIs

2020-09-04 Thread Fan Zhang
This patch adds the QAT test to use cryptodev symmetric crypto direct APIs. Signed-off-by: Fan Zhang --- app/test/test_cryptodev.c | 452 +++--- app/test/test_cryptodev.h | 7 + app/test/test_cryptodev_blockcipher.c | 51 ++- 3 files changed, 447 in

[dpdk-dev] [dpdk-dev v8 2/4] crypto/qat: add crypto data-path service API support

2020-09-04 Thread Fan Zhang
This patch updates QAT PMD to add crypto service API support. Signed-off-by: Fan Zhang --- drivers/common/qat/Makefile| 1 + drivers/crypto/qat/meson.build | 1 + drivers/crypto/qat/qat_sym.h | 13 + drivers/crypto/qat/qat_sym_hw_dp.c | 941 + d

[dpdk-dev] [dpdk-dev v8 1/4] cryptodev: add crypto data-path service APIs

2020-09-04 Thread Fan Zhang
This patch adds data-path service APIs for enqueue and dequeue operations to cryptodev. The APIs support flexible user-define enqueue and dequeue behaviors and operation mode. Signed-off-by: Fan Zhang Signed-off-by: Piotr Bronowski --- lib/librte_cryptodev/rte_crypto.h | 9 + lib/

[dpdk-dev] [dpdk-dev v8 0/4] cryptodev: add data-path service APIs

2020-09-04 Thread Fan Zhang
Direct crypto data-path service are a set of APIs that especially provided for the external libraries/applications who want to take advantage of the rich features provided by cryptodev, but not necessarily depend on cryptodev operations, mempools, or mbufs in the their data-path implementations. T

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-04 Thread Bruce Richardson
On Fri, Sep 04, 2020 at 03:25:26PM +0100, Ferruh Yigit wrote: > On 9/3/2020 4:35 PM, Bruce Richardson wrote: > > On Sat, Aug 29, 2020 at 03:13:16PM +0800, Chengchang Tang wrote: > >> Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer > >> size used in receiving packets for HW.

Re: [dpdk-dev] [PATCH v2] usertools: add huge page setup script

2020-09-04 Thread Bruce Richardson
On Fri, Sep 04, 2020 at 03:58:03PM +0100, Burakov, Anatoly wrote: > On 03-Sep-20 11:48 PM, Stephen Hemminger wrote: > > This is an improved version of the setup of huge pages > > bases on earlier DPDK setup. Differences are: > > * it autodetects NUMA vs non NUMA > > * it allows setting diff

Re: [dpdk-dev] [PATCH v2] usertools: add huge page setup script

2020-09-04 Thread Burakov, Anatoly
On 03-Sep-20 11:48 PM, Stephen Hemminger wrote: This is an improved version of the setup of huge pages bases on earlier DPDK setup. Differences are: * it autodetects NUMA vs non NUMA * it allows setting different page sizes recent kernels support multiple sizes. * it accepts a p

Re: [dpdk-dev] [PATCH V2 0/4] ethdev: change the queue ID type

2020-09-04 Thread Ferruh Yigit
On 9/4/2020 12:32 PM, Min Hu (Connor) wrote: > This series are minor change the queue ID type from > uint8_t to uint16_t. Hi Min Hu, For the next time, a change log to summarize what has been updated in new version can help to the reviewers, please add it either to commit log or cover letter. >

[dpdk-dev] [PATCH] crypto/octeontx2: add lookaside IPsec IPv6 support

2020-09-04 Thread Tejasree Kondoj
Adding IPv6 tunnel mode support in lookaside IPsec PMD. Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 13 +++-- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 28 ++- drivers/crypto/o

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure

2020-09-04 Thread Ferruh Yigit
On 9/3/2020 4:35 PM, Bruce Richardson wrote: > On Sat, Aug 29, 2020 at 03:13:16PM +0800, Chengchang Tang wrote: >> Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer >> size used in receiving packets for HW. >> >> In this way, upper-layer users can get this information by call

Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-04 Thread Pattan, Reshma
> -Original Message- > From: Bruce Richardson > > > > The ``dpdk-pdump`` tool depends on DPDK pcap PMD, so the system > > should have libpcap development files installed and the pcap PMD > > enabled in the build. > > > Sounds good, though I'd suggest changing "enabled" to "not disabl

Re: [dpdk-dev] [PATCH v2 3/7] rawdev: add private data length parameter to config fn

2020-09-04 Thread Bruce Richardson
On Thu, Aug 13, 2020 at 12:28:01PM +0100, Bruce Richardson wrote: > Currently with the rawdev API there is no way to check that the structure > passed in via the dev_private pointer in the structure passed to configure > API is of the correct type - it's just checked that it is non-NULL. Adding > i

Re: [dpdk-dev] Issue with VFIO/IOMMU

2020-09-04 Thread Burakov, Anatoly
On 03-Sep-20 12:09 PM, Vikas Gupta wrote: Hi, I observe an issue with IOVA address returned by api rte_memzone_reserve_aligned (flags= RTE_MEMZONE_IOVA_CONTIG) used for queue memory allocation. With high level debugging, I notice that IOVA address returned in mz->iova is not mapped by VFIO_IO

Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-04 Thread Bruce Richardson
On Fri, Sep 04, 2020 at 09:04:48AM +, Pattan, Reshma wrote: > > > > -Original Message- From: Power, Ciara > > > > diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst > > index + * The ``dpdk-pdump`` tool depends on libpcap based PMD > > which must be +

Re: [dpdk-dev] [PATCH v3 35/37] doc: remove reference to make in tools guides

2020-09-04 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara > diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst index > + * The ``dpdk-pdump`` tool depends on libpcap based PMD which must be > +installed on the board. > +Once the libpcap development files are ins

Re: [dpdk-dev] [PATCH v8 1/8] net/dpaa: add support for fmlib in dpdk

2020-09-04 Thread Ferruh Yigit
On 9/4/2020 9:39 AM, Hemant Agrawal wrote: > DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. > There are two ways to control it. > 1. Statically configure the queues and classification rules before the > start of the application using FMC tool. > 2. Dynamically configure it within a

[dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-04 Thread Min Hu (Connor)
From: Huisong Li Currently, only statistics of rx/tx queues with queue_id less than RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain application scenario that it needs to use 256 or more than 256 queues and display all statistics of rx/tx queue. At this moment, we have to chang

[dpdk-dev] [PATCH V2 4/4] doc: announce modified field in ethdev API

2020-09-04 Thread Min Hu (Connor)
Field type of stat_idx will be modified, from uint8_t to uint16_t in "set_queue_stats_mapping", "rte_eth_dev_set_tx_queue_stats_mapping", "rte_eth_dev_set_rx_queue_stats_mapping" for meeting the needs use 256 or more than 256 queues and display all statistics of rx/tx queue. Signed-off-by: Min Hu

[dpdk-dev] [PATCH V2 2/4] ethdev: change data type in TC rxq and TC txq

2020-09-04 Thread Min Hu (Connor)
From: Huisong Li Currently, base and nb_queue in the tc_rxq and tc_txq information of queue and TC mapping on both TX and RX paths are uint8_t. However, these datas will be truncated when queue number under a TC is greater than 256. So it is necessay for base and nb_queue to change from uint8_t t

[dpdk-dev] [PATCH V2 3/4] doc: announce modified field in DCB TC queue mapping

2020-09-04 Thread Min Hu (Connor)
Field type of base and nb_queue will be modified, from uint8_t to uint16_t in struct ``rte_eth_dcb_tc_queue_mapping``.As the data of uint8_t will be truncated when queue number under a TC is greater than 256. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) --- doc/guides/rel_notes/

[dpdk-dev] [PATCH V2 0/4] ethdev: change the queue ID type

2020-09-04 Thread Min Hu (Connor)
This series are minor change the queue ID type from uint8_t to uint16_t. Huisong Li (2): ethdev: fix compiling errors for per-queue statistics ethdev: change data type in TC rxq and TC txq Min Hu (Connor) (2): doc: announce modified field in DCB TC queue mapping doc: announce modified fie

Re: [dpdk-dev] [PATCH 05/11] net/hns3: add more hardware error types

2020-09-04 Thread Ferruh Yigit
On 8/25/2020 12:52 PM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > The new firmware adds the hardware error types reported by MSI-x mode. > These errors are defined as RAS errors in hardware and belong to a > different type from the MSI-x errors processed by the driver. > > When hardwar

Re: [dpdk-dev] [PATCH 10/11] net/hns3: fix Rx/Tx queue offload capability

2020-09-04 Thread Ferruh Yigit
On 8/25/2020 12:53 PM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > According to rte_eth_rx_queue_setup and rte_eth_tx_queue_setup API > function, rx_queue_offload_capa and rx_offload_capa, tx_queue_offload_capa > and tx_offload_capa must be mutually exclusive in the '.dev_infos_get' ops

Re: [dpdk-dev] [PATCH 08/11] net/hns3: change the log level to INFO

2020-09-04 Thread Ferruh Yigit
On 8/25/2020 12:53 PM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > This patch changes the log level from NOTICE to INFO. > > Signed-off-by: Wei Hu (Xavier) > --- > drivers/net/hns3/hns3_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH 00/11] updates for hns3 PMD driver

2020-09-04 Thread Ferruh Yigit
On 9/3/2020 2:04 AM, Wei Hu (Xavier) wrote: > Hi, all > >    Are there any comments? > > Thanks > > Xavier > > On 2020/8/25 19:52, Wei Hu (Xavier) wrote: >> This series are features and fixes for hns3 PMD driver. >> >> Huisong Li (3): >>net/hns3: replace private macro with RTE MAX >>ne

[dpdk-dev] [PATCH v3 5/6] net/i40e: implement power management API

2020-09-04 Thread Liang Ma
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_rxtx.c | 23

[dpdk-dev] [PATCH v3 6/6] net/ice: implement power management API

2020-09-04 Thread Liang Ma
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 23

[dpdk-dev] [PATCH v3 2/6] ethdev: add simple power management API

2020-09-04 Thread Liang Ma
Add a simple API allow ethdev get the last available queue descriptor address from PMD. Also include internal structure update. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- lib/librte_ethdev/rte_ethdev.h | 22 ++ lib/librte_ethdev/rte_ethdev_core.h | 46 ++

[dpdk-dev] [PATCH v3 4/6] net/ixgbe: implement power management API

2020-09-04 Thread Liang Ma
Implement support for the power management API by implementing a `next_rx_desc` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_rxtx.c | 22

[dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-04 Thread Liang Ma
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w

[dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Liang Ma
Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructions. The power management instructions provide an ar

Re: [dpdk-dev] [PATCH v1] baseband/turbo_sw: update meson for more dynamic compilation

2020-09-04 Thread Bruce Richardson
On Thu, Sep 03, 2020 at 06:05:35PM -0700, Nicolas Chautru wrote: > The meson for the turbo_sw PMD is updated to prevent the > requirement for any device specific toplevel flags to be > passed down (unlike what used to be the case with make). > The linking to the optional libraries is purely auto >

Re: [dpdk-dev] [PATCH v2] usertools: add huge page setup script

2020-09-04 Thread Bruce Richardson
On Thu, Sep 03, 2020 at 03:48:31PM -0700, Stephen Hemminger wrote: > This is an improved version of the setup of huge pages > bases on earlier DPDK setup. Differences are: >* it autodetects NUMA vs non NUMA >* it allows setting different page sizes > recent kernels support multiple siz

[dpdk-dev] [PATCH v8 8/8] net/dpaa: add RSS update func with FMCless

2020-09-04 Thread Hemant Agrawal
From: Sachin Saxena With fmlib (FMCLESS) mode now RSS can be modified on runtime. This patch add support for RSS update functions Signed-off-by: Hemant Agrawal Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++ 1 file changed, 37 insertion

[dpdk-dev] [PATCH v8 4/8] bus/dpaa: add shared MAC support

2020-09-04 Thread Hemant Agrawal
From: Radu Bulie A shared MAC interface is an interface which can be used by both kernel and userspace based on classification configuration It is defined in dts with the compatible string "fsl,dpa-ethernet-shared" which bpool will be seeded by the dpdk partition and configured as a netdev by the

[dpdk-dev] [PATCH v8 6/8] net/dpaa: add support for Virtual Storage Profile

2020-09-04 Thread Hemant Agrawal
From: Jun Yang This patch adds support for Virtual Storage profile (VSP) feature. With VSP support when memory pool is created, the hw buffer pool id i.e. bpid is not allocated; thhe bpid is identified by dpaa flow create API. The memory pool of RX queue is attached to specific BMan pool accordin

[dpdk-dev] [PATCH v8 7/8] net/dpaa: add fmc parser support for VSP

2020-09-04 Thread Hemant Agrawal
From: Jun Yang FMC tool genertes and saves the setup in a file. This patch help Parse the /tmp/fmc.bin generated by fmc to setup RXQs for each port on fmc mode. The parser gets the fqids and vspids from fmc.bin Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.

[dpdk-dev] [PATCH v8 5/8] bus/dpaa: add Virtual Storage Profile port init

2020-09-04 Thread Hemant Agrawal
This patch add support to initialize the VSP ports in the FMAN library. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 57 +++ drivers/bus/dpaa/include/fman.h | 3 ++ 2 files changed, 60 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/

[dpdk-dev] [PATCH v8 2/8] net/dpaa: add VSP support in FMLIB

2020-09-04 Thread Hemant Agrawal
From: Jun Yang This patch adds support for VSP (Virtual Storage Profile) in fmlib routines. VSP allow a network interface to be divided into physical and virtual instance(s). The concept is very similar to SRIOV. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst

Re: [dpdk-dev] [PATCH v2 01/17] eal: add max SIMD bitwidth

2020-09-04 Thread Bruce Richardson
On Fri, Sep 04, 2020 at 05:30:28AM +, Honnappa Nagarahalli wrote: > > > diff --git a/lib/librte_eal/include/rte_eal.h > b/lib/librte_eal/include/rte_eal.h > > index ddcf6a2e7a..8148f650f2 100644 > > --- a/lib/librte_eal/include/rte_eal.h > > +++ b/lib/librte_eal/include/rte_eal.h > > @@ -4

[dpdk-dev] [PATCH v8 3/8] net/dpaa: add support for fmcless mode

2020-09-04 Thread Hemant Agrawal
From: Sachin Saxena This patch uses fmlib to configure the FMAN HW for flow and distribution configuration, thus avoiding the need for static FMC tool execution optionally. Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 1 + driver

[dpdk-dev] [PATCH v4 1/2] gro: add UDP GRO support

2020-09-04 Thread yang_y_yi
From: Yi Yang UDP GRO can help improve VM-to-VM UDP performance when VM is enabled UFO or GSO, GRO must be supported if GSO or UFO is enabled, otherwise, performance gain will be hurt. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, this will make sure IP

[dpdk-dev] [PATCH v4 0/2] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-04 Thread yang_y_yi
From: Yi Yang In case that UFO or GSO is enabled, GRO is very necessary, especially for UDP, it is more so. Many NICs can't support VXLAN UDP UFO/USO and VLAN UFO/USO, so UDP performance improvement depends on GSO and GRO to a great extent. This patch series added VLAN UDP GRO and VXLAN UDP GRO

[dpdk-dev] [PATCH v4 2/2] gro: add VXLAN UDP GRO support

2020-09-04 Thread yang_y_yi
From: Yi Yang VXLAN UDP GRO can help improve VM-to-VM UDP performance when VM is enabled UFO or GSO, GRO must be supported if GSO or UFO is enabled, otherwise, performance gain will be hurt. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, this will make s

[dpdk-dev] [PATCH v7 7/7] net/dpaa: add RSS update func with FMCless

2020-09-04 Thread Hemant Agrawal
From: Sachin Saxena With fmlib (FMCLESS) mode now RSS can be modified on runtime. This patch add support for RSS update functions Signed-off-by: Hemant Agrawal Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++ 1 file changed, 37 insertion

[dpdk-dev] [PATCH v7 6/7] net/dpaa: add fmc parser support for VSP

2020-09-04 Thread Hemant Agrawal
From: Jun Yang FMC tool genertes and saves the setup in a file. This patch help Parse the /tmp/fmc.bin generated by fmc to setup RXQs for each port on fmc mode. The parser gets the fqids and vspids from fmc.bin Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.

[dpdk-dev] [PATCH v7 5/7] net/dpaa: add support for Virtual Storage Profile

2020-09-04 Thread Hemant Agrawal
From: Jun Yang This patch adds support for Virtual Storage profile (VSP) feature. With VSP support when memory pool is created, the hw buffer pool id i.e. bpid is not allocated; thhe bpid is identified by dpaa flow create API. The memory pool of RX queue is attached to specific BMan pool accordin

[dpdk-dev] [PATCH v7 2/7] net/dpaa: add support for fmcless mode

2020-09-04 Thread Hemant Agrawal
From: Sachin Saxena This patch uses fmlib to configure the FMAN HW for flow and distribution configuration, thus avoiding the need for static FMC tool execution optionally. Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 1 + driver

  1   2   >