Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Eli Britstein > Sent: Tuesday, August 4, 2020 6:47 PM > To: Dekel Peled ; ferruh.yi...@intel.com; > arybche...@solarflare.com; Ori Kam ; Thomas > Monjalon > Cc: Asaf Penso ; Matan Azrad > ; dev@dpdk.org > Subject: Re: [RFC] ethdev: add VLAN attri

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, August 4, 2020 7:22 PM > To: Dekel Peled > Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; Ori Kam > ; Thomas Monjalon ; Asaf > Penso ; Matan Azrad ; Eli > Britstein ; dev@dpdk.org > Subject: Re: [dpdk-de

Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure

2020-08-04 Thread Slava Ovsiienko
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, August 4, 2020 16:33 > To: Slava Ovsiienko > Cc: dpdk-dev ; Matan Azrad ; > Raslan Darawsheh ; Thomas Monjalon > ; Ferruh Yigit ; Stephen > Hemminger ; Andrew Rybchenko > ; Ajit Khaparde > ; Maxime Coquelin > ; Olivier Matz ; > Dav

[dpdk-dev] [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elements

2020-08-04 Thread Feifei Wang
The actual capacity of ring should be the (RING_SIZE - 1), thus only (RING_SIZE - 1) elements can be enqueued into the ring. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ru

[dpdk-dev] [PATCH v2 4/4] test/ring: add check to validate the dequeued objects

2020-08-04 Thread Feifei Wang
For the single element enqueue and dequeue in test_ring_basic_ex and test_ring_with_exact_size, add check to validate the dequeued objects. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_ring.c | 145

[dpdk-dev] [PATCH v2 2/4] test/ring: fix wrong size used in memcmp

2020-08-04 Thread Feifei Wang
When using memcmp function to check data, the third param should be the size of all elements, rather than the number of the elements. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Review

[dpdk-dev] [PATCH v2 0/4] wrong pointer passed and add check

2020-08-04 Thread Feifei Wang
Fix wrong pointer passed problems when using test_ring_enqueue APIs to enqueue one element into the ring. Furthermore, add check to validate the dequeued objects in test_ring.c when calling test_ring_enqueue APIs. v2: 1. add check to validate the dequeued objects in test_ring.c and fix some bugs

[dpdk-dev] [PATCH v2 1/4] test/ring: fix wrong parameter passed to the enqueue APIs

2020-08-04 Thread Feifei Wang
When enqueue one element to ring in the performance test, a pointer should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of void *pointers. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Sign

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-08-04 Thread Kusztal, ArkadiuszX
Hi Akhil, @Akhil: Is there a chance getting this change into 20.11? Any more comments or anyone see any potential issues with this approach? Regards, Arek -Original Message- From: Doherty, Declan Sent: piątek, 31 lipca 2020 16:34 To: Kusztal, ArkadiuszX ; dev@dpdk.org Cc: akhil.go...@

[dpdk-dev] [PATCH V1] doc: update firmware/dricer mapping table for i40e

2020-08-04 Thread Chen, Zhaoyan
From: ChenBo Update i40e PMD firmware/driver mapping table. Signed-off-by: ChenBo --- doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index cf1ae2d0b..b7430f6c4 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/

[dpdk-dev] [PATCH V1] doc: Add tested Intel platforms for DPDK 20.08 release

2020-08-04 Thread Chen, Zhaoyan
From: ChenBo doc: add tested Intel platforms with Intel NICs. Signed-off-by: ChenBo --- doc/guides/rel_notes/release_20_08.rst | 107 + 1 file changed, 107 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index

Re: [dpdk-dev] [PATCH v4 1/5] eal: added interrupts empty stubs

2020-08-04 Thread Dmitry Kozlyuk
On Tue, 4 Aug 2020 09:29:43 +0300, Fady Bader wrote: [snip] > diff --git a/lib/librte_eal/windows/eal_interrupts.c > b/lib/librte_eal/windows/eal_interrupts.c > new file mode 100644 > index 00..1e3c6d20d2 > --- /dev/null > +++ b/lib/librte_eal/windows/eal_interrupts.c > @@ -0,0 +1,17 @@ >

Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows

2020-08-04 Thread Dmitry Kozlyuk
On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_telemetry/rte_telemetry.h| 4 +++ > lib/librte_telemetry/telemetry.c| 51 > ++

Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation

2020-08-04 Thread Ajit Khaparde
On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal wrote: > > On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon > > wrote: > > > > > > Since DPDK 18.11, some drivers are migrating to a new behaviour, > > > releasing port resources on close. > > > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this

Re: [dpdk-dev] [PATCH] doc: announce API change in timer

2020-08-04 Thread Honnappa Nagarahalli
[ > > Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in timer > > > > Thank you Eric, I will fix the mistakes in v2 > > > > On Tue, Aug 4, 2020 at 4:16 AM Honnappa Nagarahalli > > wrote: > > > > > > > > > > > > > > > > > If the user tries to reset/stop some other timer in it's callback

Re: [dpdk-dev] [PATCH v4 5/5] ethdev: compiling ethdev under Windows

2020-08-04 Thread Narcisa Ana Maria Vasile
On Tue, Aug 04, 2020 at 09:29:47AM +0300, Fady Bader wrote: > Compiling needed libraries for ethdev under Windows. > > Signed-off-by: Fady Bader > --- > lib/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Narcisa Vasile

Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows

2020-08-04 Thread Narcisa Ana Maria Vasile
On Tue, Aug 04, 2020 at 09:29:46AM +0300, Fady Bader wrote: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_telemetry/rte_telemetry.h| 4 +++ > lib/librte_telemetry/telemetry.c| 51 >

Re: [dpdk-dev] [PATCH v4 3/5] ethdev: remove structs from export list

2020-08-04 Thread Narcisa Ana Maria Vasile
On Tue, Aug 04, 2020 at 09:29:45AM +0300, Fady Bader wrote: > Some ethdev structs were present in ethdev export list. > There structs were removed from the export list. > > Signed-off-by: Fady Bader > --- > lib/librte_ethdev/rte_ethdev_version.map | 2 -- > 1 file changed, 2 deletions(-) > Acke

Re: [dpdk-dev] [PATCH v4 2/5] eal: updated export list for Windows

2020-08-04 Thread Narcisa Ana Maria Vasile
On Tue, Aug 04, 2020 at 09:29:44AM +0300, Fady Bader wrote: > Added eal functions used by ethdev lib to the export list under Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_eal/rte_eal_exports.def | 11 +++ > 1 file changed, 11 insertions(+) > Acked-by: Narcisa Vasile

Re: [dpdk-dev] [PATCH v4 1/5] eal: added interrupts empty stubs

2020-08-04 Thread Narcisa Ana Maria Vasile
On Tue, Aug 04, 2020 at 09:29:43AM +0300, Fady Bader wrote: > The ethdev lib uses interrupts. Interrupts are not implemented for Windows. > To solve this, empty interrupt stubs were added under Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_eal/windows/eal_interrupts.c | 17 ++

[dpdk-dev] [PATCH] tracepoint: fix compilation with C++

2020-08-04 Thread Pawel Wodkowski
trace_mem is declared as 'void *' which triggers following error: '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’ [-fpermissive]...' Fix this by changing void to struct __rte_trace_header --- lib/librte_eal/common/eal_common_trace.c | 2 +- lib/librte_eal/include/rte_trace_point.h |

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 9:54 PM Bruce Richardson wrote: > > On Tue, Aug 04, 2020 at 09:33:14PM +0530, Jerin Jacob wrote: > > On Tue, Aug 4, 2020 at 7:55 PM Bruce Richardson > > wrote: > > > > > > On Tue, Aug 04, 2020 at 05:07:12PM +0530, Jerin Jacob wrote: > > > > On Tue, Aug 4, 2020 at 4:12 PM Br

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Bruce Richardson
On Tue, Aug 04, 2020 at 09:33:14PM +0530, Jerin Jacob wrote: > On Tue, Aug 4, 2020 at 7:55 PM Bruce Richardson > wrote: > > > > On Tue, Aug 04, 2020 at 05:07:12PM +0530, Jerin Jacob wrote: > > > On Tue, Aug 4, 2020 at 4:12 PM Bruce Richardson > > > wrote: > > > > > > > > On Mon, Aug 03, 2020 at 1

Re: [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id

2020-08-04 Thread Stephen Hemminger
On Tue, 4 Aug 2020 17:41:47 + Chenbo Xia wrote: > Currenly the variable size of ethdev port id is 8 bits. This > patch standarizes it to 16 bits. > > Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy") > Cc: sta...@dpdk.org > > Reported-by: Yinan Wang > Signed-off-by: C

Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Stephen Hemminger
On Tue, 4 Aug 2020 18:36:20 +0300 Dekel Peled wrote: > In existing code the match on tagged/untagged packets is not explicit. > Recent documentation update [1] describes the different patterns and > clarifies the intended use of different patterns. > > This patch proposes an update to ETH item

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Stephen Hemminger
On Tue, 4 Aug 2020 11:41:53 +0100 Bruce Richardson wrote: > On Mon, Aug 03, 2020 at 12:59:03PM +0530, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add 64 byte padding at the end of event device public structure to allow > > future extensions. > > > > Signed-off-by: Pavan N

[dpdk-dev] [PATCH] doc: announce change in ETH item struct

2020-08-04 Thread Dekel Peled
Struct rte_flow_item_eth will be modified to include additional values, indicating existence or absence of VLAN headers following the ETH header, as proposed in RFC https://mails.dpdk.org/archives/dev/2020-August/177349.html. Because of ABI break this change is proposed for 20.11. Signed-off-by: D

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 7:55 PM Bruce Richardson wrote: > > On Tue, Aug 04, 2020 at 05:07:12PM +0530, Jerin Jacob wrote: > > On Tue, Aug 4, 2020 at 4:12 PM Bruce Richardson > > wrote: > > > > > > On Mon, Aug 03, 2020 at 12:59:03PM +0530, pbhagavat...@marvell.com wrote: > > > > From: Pavan Nikhiles

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

2020-08-04 Thread Hemant Agrawal
> -Original Message- > From: dev On Behalf Of Jerin Jacob > Sent: Tuesday, August 4, 2020 1:09 PM > To: McDaniel, Timothy > Cc: Jerin Jacob ; Mattias Rönnblom > ; dpdk-dev ; Gage Eads > ; Van Haaren, Harry > Subject: Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB > PMD

[dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item

2020-08-04 Thread Dekel Peled
In existing code the match on tagged/untagged packets is not explicit. Recent documentation update [1] describes the different patterns and clarifies the intended use of different patterns. This patch proposes an update to ETH item struct, to clearly define the required characteristic of a packet,

Re: [dpdk-dev] [PATCH] doc: announce kernel driver enum removal

2020-08-04 Thread Gaëtan Rivet
On 04/08/20 15:29 +0100, Bruce Richardson wrote: > On Tue, Aug 04, 2020 at 04:07:52PM +0200, David Marchand wrote: > > rte_kernel_driver is only used by the PCI subsystem and has polluted > > ethdev for no reason. > > Hide it in the PCI bus driver. > > > > Signed-off-by: David Marchand > > --- >

Re: [dpdk-dev] [PATCH] doc: announce kernel driver enum removal

2020-08-04 Thread Bruce Richardson
On Tue, Aug 04, 2020 at 04:07:52PM +0200, David Marchand wrote: > rte_kernel_driver is only used by the PCI subsystem and has polluted > ethdev for no reason. > Hide it in the PCI bus driver. > > Signed-off-by: David Marchand > --- > doc/guides/rel_notes/deprecation.rst | 7 +++ > 1 file cha

Re: [dpdk-dev] [PATCH] doc: announce internal hotplug structure removal

2020-08-04 Thread Bruce Richardson
On Tue, Aug 04, 2020 at 04:07:17PM +0200, David Marchand wrote: > rte_dev_event has never been used outside of the EAL. > No point in exposing it. > > Signed-off-by: David Marchand > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guide

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Bruce Richardson
On Tue, Aug 04, 2020 at 05:07:12PM +0530, Jerin Jacob wrote: > On Tue, Aug 4, 2020 at 4:12 PM Bruce Richardson > wrote: > > > > On Mon, Aug 03, 2020 at 12:59:03PM +0530, pbhagavat...@marvell.com wrote: > > > From: Pavan Nikhilesh > > > > > > Add 64 byte padding at the end of event device public s

Re: [dpdk-dev] [PATCH] doc: announce API change in timer

2020-08-04 Thread Carrillo, Erik G
> -Original Message- > From: Sarosh Arif > Sent: Monday, August 3, 2020 10:29 PM > To: Honnappa Nagarahalli ; Carrillo, Erik G > > Cc: rsanf...@akamai.com; dev@dpdk.org; nd > Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in timer > > Thank you Eric, I will fix the mistakes

Re: [dpdk-dev] [PATCH v4] doc: add deprecation notice for sched changes

2020-08-04 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of Savinay Dharmappa > Sent: Wednesday, July 29, 2020 4:38 PM > To: Dharmappa, Savinay ; Singh, Jasvinder > ; Shetty, Praveen ; > Tummala, Sivaprasad ; dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH v4] doc: add deprecation

[dpdk-dev] [PATCH v4 8/9] config/arm: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2. Cc: Thomas Monjalon Signed-off-by: Louise Kilheeney --- config/arm/armv8_machine.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/arm/armv8_machine.py b/config/arm/armv8_machine.py index 4

[dpdk-dev] [PATCH v4 9/9] app/test-bbdev: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Cc: Nicolas Chautru Signed-off-by: Louise Kilheeney --- app/test-bbdev/test-bbdev.py | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/test-bbdev/test-bbdev.p

[dpdk-dev] [PATCH v4 5/9] app/test-cmdline: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Cc: Olivier Matz Signed-off-by: Louise Kilheeney --- app/test-cmdline/cmdline_test.py | 7 +-- app/test-cmdline/cmdline_test_data.py | 1 + mk/rte.sdktest.mk

[dpdk-dev] [PATCH v4 4/9] usertools/cpu_layout: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Signed-off-by: Louise Kilheeney --- usertools/cpu_layout.py | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layou

[dpdk-dev] [PATCH v4 7/9] devtools: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Cc: Neil Horman Cc: Ray Kinsella Signed-off-by: Louise Kilheeney --- devtools/update_version_map_abi.py | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/devtool

[dpdk-dev] [PATCH v4 6/9] app/test: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Signed-off-by: Louise Kilheeney --- app/test/autotest.py| 7 +-- app/test/autotest_data.py | 1 + app/test/autotest_runner.py | 21 - app/te

[dpdk-dev] [PATCH v4 3/9] usertools/dpdk-pmdinfo: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Cc: Neil Horman Signed-off-by: Louise Kilheeney --- usertools/dpdk-pmdinfo.py | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/usertools/dpdk-pmdinfo.py b/userto

[dpdk-dev] [PATCH v4 1/9] usertools/dpdk-telemetry-client: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Cc: Kevin Laatz Signed-off-by: Louise Kilheeney --- usertools/dpdk-telemetry-client.py | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/usertools

[dpdk-dev] [PATCH v4 0/9] adding support for python 3 only.

2020-08-04 Thread Louise Kilheeney
This patch set converts all python scripts in the project to use python3 only and removes all deprecation notices associated with these changes. This is due to python2 being EOL in January 2020. Louise Kilheeney (9): usertools/dpdk-telemetry-client: support python3 only usertools/dpdk-devbind

[dpdk-dev] [PATCH v4 2/9] usertools/dpdk-devbind: support python3 only

2020-08-04 Thread Louise Kilheeney
Changed script to explicitly use python3 only to avoid maintaining python 2 and removed deprecation notice. Signed-off-by: Louise Kilheeney --- usertools/dpdk-devbind.py | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/usertools/dpdk-devbind.py b/userto

[dpdk-dev] [PATCH] doc: announce kernel driver enum removal

2020-08-04 Thread David Marchand
rte_kernel_driver is only used by the PCI subsystem and has polluted ethdev for no reason. Hide it in the PCI bus driver. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/

[dpdk-dev] [PATCH] doc: announce internal hotplug structure removal

2020-08-04 Thread David Marchand
rte_dev_event has never been used outside of the EAL. No point in exposing it. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 24808c00

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

2020-08-04 Thread Van Haaren, Harry
> -Original Message- > From: McDaniel, Timothy > Sent: Monday, August 3, 2020 6:56 PM > To: jer...@marvell.com > Cc: mattias.ronnb...@ericsson.com; dev@dpdk.org; Eads, Gage > ; Van Haaren, Harry ; > McDaniel, Timothy > Subject: [PATCH] doc: eventdev ABI change to support DLB PMD > > From

Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure

2020-08-04 Thread Jerin Jacob
On Mon, Aug 3, 2020 at 6:36 PM Slava Ovsiienko wrote: > > Hi, Jerin, > > Thanks for the comment, please, see below. > > > -Original Message- > > From: Jerin Jacob > > Sent: Monday, August 3, 2020 14:57 > > To: Slava Ovsiienko > > Cc: dpdk-dev ; Matan Azrad ; > > Raslan Darawsheh ; Thoma

Re: [dpdk-dev] [PATCH] doc: announce change in IPv6 item struct

2020-08-04 Thread Dekel Peled
Kind reminder to all maintainers, please review and ack/comment. > -Original Message- > From: Dekel Peled > Sent: Monday, August 3, 2020 10:51 PM > To: dev@dpdk.org > Cc: jerinjac...@gmail.com; step...@networkplumber.org; > arybche...@solarflare.com; ajit.khapa...@broadcom.com; > maxime.c

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 4:12 PM Bruce Richardson wrote: > > On Mon, Aug 03, 2020 at 12:59:03PM +0530, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add 64 byte padding at the end of event device public structure to allow > > future extensions. > > > > Signed-off-by: Pavan Nikhi

Re: [dpdk-dev] [PATCH] doc: announce PCI resources map API removal

2020-08-04 Thread Gaëtan Rivet
On 04/08/20 14:22 +0530, Jerin Jacob wrote: > On Tue, Aug 4, 2020 at 2:18 PM David Marchand > wrote: > > > > The PCI resources map API (pci_map_resource/pci_unmap_resource) was > > imposing use of Unix mmap flags while it does not make sense on Windows. > > This API was only used to internally se

Re: [dpdk-dev] [PATCH] net/rte_pmd_i40e: remove duplicate check

2020-08-04 Thread Ferruh Yigit
On 8/1/2020 2:57 AM, Gaurav Singh wrote: > remove duplicate check > > Signed-off-by: Gaurav Singh Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] doc: add reserve fields to eventdev public structures

2020-08-04 Thread Bruce Richardson
On Mon, Aug 03, 2020 at 12:59:03PM +0530, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add 64 byte padding at the end of event device public structure to allow > future extensions. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Jerin Jacob > --- > v2 Changes: > - Modify commit

Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 4:00 PM Maxime Coquelin wrote: > > > > On 8/4/20 12:26 PM, Thomas Monjalon wrote: > > Environment configuration is the responsibility of distributions > > or upper-level frameworks. > > DPDK focus on documenting the requirements and some recommendations. > > > > Maintaining

Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script

2020-08-04 Thread Maxime Coquelin
On 8/4/20 12:26 PM, Thomas Monjalon wrote: > Environment configuration is the responsibility of distributions > or upper-level frameworks. > DPDK focus on documenting the requirements and some recommendations. > > Maintaining a good adaptative deployment setup is a project by itself. > Anyway t

[dpdk-dev] [PATCH] doc: announce removal of interactive setup script

2020-08-04 Thread Thomas Monjalon
Environment configuration is the responsibility of distributions or upper-level frameworks. DPDK focus on documenting the requirements and some recommendations. Maintaining a good adaptative deployment setup is a project by itself. Anyway this script was interactive, useful only for experimenters.

[dpdk-dev] discussion about VLAN API

2020-08-04 Thread Thomas Monjalon
Hi, We have a quite complex API for VLAN filter/push/pop, per port, per queue or per flow. These are the old per-port functions: rte_eth_dev_vlan_filter rte_eth_dev_set_vlan_strip_on_queue rte_eth_dev_set_vlan_ether_type rte_eth_dev_set_vlan_offload rte_eth

[dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API

2020-08-04 Thread Thomas Monjalon
Some confusing comments were still present from old days, when most drivers were from Intel. Signed-off-by: Thomas Monjalon --- v2: remove i40e comment for pvid field --- lib/librte_ethdev/rte_ethdev.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/librte_e

[dpdk-dev] [PATCH] ethdev: remove device-specific comments from VLAN API

2020-08-04 Thread Thomas Monjalon
Some confusing comments were still present from old days, when most drivers were from Intel. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.h | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_et

Re: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration

2020-08-04 Thread Phil Yang
> -Original Message- > From: oulijun > Sent: Tuesday, August 4, 2020 9:29 AM > To: Phil Yang ; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com; > adrien.mazarg...@6wind.com; ferruh.yi...@intel.com > Cc: dev@dpdk.org; linux...@huawei.com; nd > Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation

2020-08-04 Thread Hemant Agrawal
> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon > wrote: > > > > Since DPDK 18.11, some drivers are migrating to a new behaviour, > > releasing port resources on close. > > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode > in > > the migrated drivers. > > After 2 years, the fla

Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon wrote: > > Since DPDK 18.11, some drivers are migrating to a new behaviour, > releasing port resources on close. > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode > in the migrated drivers. > After 2 years, the flag and the old beha

[dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation

2020-08-04 Thread Thomas Monjalon
Since DPDK 18.11, some drivers are migrating to a new behaviour, releasing port resources on close. The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode in the migrated drivers. After 2 years, the flag and the old behaviour will be removed. Last drivers not migrated will have to compl

Re: [dpdk-dev] [PATCH] doc: announce removal of L2 tunnel filtering API

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 1:21 PM David Marchand wrote: > > On Mon, Aug 3, 2020 at 8:06 PM Thomas Monjalon wrote: > > > > The functions for L2 tunnel were missed when marking the legacy > > filtering API as deprecated. That's why a separate notice is done > > to make clear that it will be removed as

Re: [dpdk-dev] [PATCH v2 1/2] doc: announce rte_dev_probe() API change

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 1:42 PM David Marchand wrote: > > On Thu, Jun 25, 2020 at 10:04 AM Maxime Coquelin > wrote: > > > > In order to simplify the use of rte_dev_probe() and > > rte_dev_remove() by applications, rte_dev_probe() will > > return a reference on the rte_device stating DPDK v20.11. >

[dpdk-dev] [PATCH] net/bnxt: fix variable size of port id

2020-08-04 Thread Chenbo Xia
Currenly the variable size of ethdev port id is 8 bits. This patch standarizes it to 16 bits. Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy") Cc: sta...@dpdk.org Reported-by: Yinan Wang Signed-off-by: Chenbo Xia --- drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +- 1 file

Re: [dpdk-dev] [PATCH] doc: announce PCI resources map API removal

2020-08-04 Thread Jerin Jacob
On Tue, Aug 4, 2020 at 2:18 PM David Marchand wrote: > > The PCI resources map API (pci_map_resource/pci_unmap_resource) was > imposing use of Unix mmap flags while it does not make sense on Windows. > This API was only used to internally setup PCI devices in the PCI bus > driver and has no known

Re: [dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App

2020-08-04 Thread Maxime Coquelin
Hi Nicolas, On 8/3/20 6:18 PM, Chautru, Nicolas wrote: > Hi Maxime, Thomas, > >> From: Maxime Coquelin >> Hi Nicolas, >> >> On 7/31/20 5:17 PM, Chautru, Nicolas wrote: >>> Hi Maxime, >>> Hi Nicolas, On 7/16/20 10:20 PM, Nicolas Chautru wrote: > Adding companion applicati

[dpdk-dev] [PATCH] doc: announce PCI resources map API removal

2020-08-04 Thread David Marchand
The PCI resources map API (pci_map_resource/pci_unmap_resource) was imposing use of Unix mmap flags while it does not make sense on Windows. This API was only used to internally setup PCI devices in the PCI bus driver and has no known external users. Announce its removal in 20.11 with its associat

[dpdk-dev] [PATCH v2] doc: update RSS action with best effort

2020-08-04 Thread Ori Kam
Using the rte_flow action RSS types field, may result in undefined outcome. For example selecting both UDP and TCP, selecting TCP RSS type but the pattern is targeting UDP traffic. another option is that the PMD doesn't support all requested types. Until now, it wasn't clear what will happen in s

Re: [dpdk-dev] [PATCH v2 1/2] doc: announce rte_dev_probe() API change

2020-08-04 Thread David Marchand
On Thu, Jun 25, 2020 at 10:04 AM Maxime Coquelin wrote: > > In order to simplify the use of rte_dev_probe() and > rte_dev_remove() by applications, rte_dev_probe() will > return a reference on the rte_device stating DPDK v20.11. > > Signed-off-by: Maxime Coquelin Acked-by: David Marchand --

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-04 Thread Xia, Chenbo
> -Original Message- > From: Adrian Moreno > Sent: Tuesday, August 4, 2020 3:39 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Xia, Chenbo ; > david.march...@redhat.com; Adrian Moreno > Subject: [PATCH] devtools: ignore PREFER_FALLTHROUGH > > The PREFER_FALLTHROUGH check warns if a p

Re: [dpdk-dev] [PATCH] doc: announce removal of L2 tunnel filtering API

2020-08-04 Thread Ajit Khaparde
On Mon, Aug 3, 2020 at 11:06 AM Thomas Monjalon wrote: > The functions for L2 tunnel were missed when marking the legacy > filtering API as deprecated. That's why a separate notice is done > to make clear that it will be removed as well in DPDK 20.11. > > Signed-off-by: Thomas Monjalon > Acked-b

Re: [dpdk-dev] [PATCH] doc: announce removal of legacy ethdev filtering API

2020-08-04 Thread David Marchand
On Mon, Aug 3, 2020 at 1:49 PM Thomas Monjalon wrote: > > Deprecation of rte_eth_dev_filter_ctrl() was announced in 2016, > and confirmed last year by avoiding include of rte_eth_ctrl.h. > After 4 years, it is time to complete the removal of the API > which is replaced with rte_flow. > > Signed-of

Re: [dpdk-dev] [PATCH] doc: announce removal of L2 tunnel filtering API

2020-08-04 Thread David Marchand
On Mon, Aug 3, 2020 at 8:06 PM Thomas Monjalon wrote: > > The functions for L2 tunnel were missed when marking the legacy > filtering API as deprecated. That's why a separate notice is done > to make clear that it will be removed as well in DPDK 20.11. > > Signed-off-by: Thomas Monjalon Acked-by

Re: [dpdk-dev] [PATCH] doc: announce removal of ethdev flow director API

2020-08-04 Thread Hemant Agrawal
> On Mon, Aug 3, 2020 at 7:49 PM Thomas Monjalon > wrote: > > > > The flow director config, part of the legacy filtering API, was marked > > as deprecated last year. > > A separate notice is added to make clear that these specific structs > > will be removed as well in DPDK 20.11, as the rest of t

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-04 Thread Ferruh Yigit
On 8/4/2020 8:38 AM, Adrian Moreno wrote: > The PREFER_FALLTHROUGH check warns if a passthrough comment is found > because, in the kernel, the special macro "fallthrough" is prefered. > > Since that keyword is not defined in DPDK, ignore the warning. > > Ignoring this check does not affect the MI

Re: [dpdk-dev] [PATCH] doc: eventdev ABI change to support DLB PMD

2020-08-04 Thread Jerin Jacob
On Mon, Aug 3, 2020 at 11:28 PM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" There is still "," in the name. > > The ABI changes associated with this notification will better support > devices that: > 1. Have limits on the number or queues that may be linked to a port > 2. Have ports

[dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-04 Thread Adrian Moreno
The PREFER_FALLTHROUGH check warns if a passthrough comment is found because, in the kernel, the special macro "fallthrough" is prefered. Since that keyword is not defined in DPDK, ignore the warning. Ignoring this check does not affect the MISSING_BREAK check that will warn if a switch case/defa

Re: [dpdk-dev] [PATCH] doc: announce removal of ethdev flow director API

2020-08-04 Thread David Marchand
On Mon, Aug 3, 2020 at 7:49 PM Thomas Monjalon wrote: > > The flow director config, part of the legacy filtering API, > was marked as deprecated last year. > A separate notice is added to make clear that these specific structs > will be removed as well in DPDK 20.11, as the rest of the legacy > fi

Re: [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API

2020-08-04 Thread David Marchand
On Mon, Aug 3, 2020 at 5:33 PM Thomas Monjalon wrote: > > A new API is planned to be introduced for sampling and mirroring > with rte_flow. It should be more generic and allow more use cases. > > This deprecation is to show the direction, avoiding overlapping APIs. > > Signed-off-by: Thomas Monjal

[dpdk-dev] [PATCH v2 2/4] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user

2020-08-04 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support for VHOST_USER_SET_STATUS request. It is used to make the backend aware of Virtio devices status update. It is useful for the backend to know when the Virtio driver is done with the Virtio device configuration. Signed-off-by: Maxime Coquelin Signed

[dpdk-dev] [PATCH v2 4/4] net/virtio: enable feature checking on virtio-user

2020-08-04 Thread Adrian Moreno
virtio 1.0 introduced a mechanism for the driver to verify that the feature bits it sets are accepted by the device. This mechanism consists in setting the VIRTIO_STATUS_FEATURE_OK status bit and re-reading it, whitch gives a chance for the device to clear it if the the features were not accepted.

[dpdk-dev] [PATCH v2 0/4] Add support for GET/SET_STATUS on virtio-user pmd

2020-08-04 Thread Adrian Moreno
Recently, two new messages have been added to the vhost-user protocol that make the device initialization more robust. VHOST_VIRTIO_SET_STATUS allows the driver to set the device status VHOST_VIRTIO_GET_STATUS allows the driver to read the status back from the device This series implements these

[dpdk-dev] [PATCH v2 3/4] net/virtio: add GET_STATUS support to virtio-user

2020-08-04 Thread Adrian Moreno
This patch adds support for VHOST_USER_GET_STATUS request. Only vhost-user backed is supported for now Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_user/vhost_user.c | 2 + .../net/virtio/virtio_user/virtio_user_dev.c | 42 +++ .../net/virtio/virtio_user/virtio

[dpdk-dev] [PATCH v2 1/4] net/virtio: add DEVICE_NEEDS_RESET status bit

2020-08-04 Thread Adrian Moreno
For the sake of completeness, add the definition of the missing status bit in accordance with the virtio spec Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_pci.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.h b/drive

Re: [dpdk-dev] [PATCH v1] net/iavf: fix hash default set

2020-08-04 Thread Xie, WeiX
Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo Sent: Tuesday, August 4, 2020 10:59 AM To: Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Guo, Junfeng ; Su, Simei ; Guo, Jia Subje