On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader <f...@mellanox.com> > --- > lib/librte_telemetry/rte_telemetry.h | 4 +++ > lib/librte_telemetry/telemetry.c | 51 > ++++++++++++++++++++++++++++++++- > lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- > 3 files changed, 79 insertions(+), 2 deletions(-)
You could #ifdef code in librte_ethdev that uses librte_telemetry and not build librte_telemetry at all. This approach is already taken in eal_common_options.c and it avoids spreading #ifdef throughout telemetry code.