On Tue, 4 Aug 2020 09:29:43 +0300, Fady Bader wrote: [snip] > diff --git a/lib/librte_eal/windows/eal_interrupts.c > b/lib/librte_eal/windows/eal_interrupts.c > new file mode 100644 > index 0000000000..1e3c6d20d2 > --- /dev/null > +++ b/lib/librte_eal/windows/eal_interrupts.c > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2020 Mellanox Technologies, Ltd > + */
Blank line is needed here, like in other files. > +#include <rte_interrupts.h> [snip] > diff --git a/lib/librte_eal/windows/meson.build > b/lib/librte_eal/windows/meson.build > index 08c888e018..c5a19648d6 100644 > --- a/lib/librte_eal/windows/meson.build > +++ b/lib/librte_eal/windows/meson.build > @@ -17,6 +17,7 @@ sources += files( > 'eal_timer.c', > 'fnmatch.c', > 'getopt.c', > + 'eal_interrupts.c', > ) Please keep the list sorted.
