[dpdk-dev] 回复: [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-30 Thread Feifei Wang
> -邮件原件- > 发件人: Feifei Wang > 发送时间: 2020年7月30日 18:29 > 收件人: Honnappa Nagarahalli ; David > Marchand > 抄送: Konstantin Ananyev ; Gavin Hu > ; Olivier Matz ; dev > ; nd ; dpdk stable ; nd > ; nd > 主题: 回复: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to > the enqueue APIs >

[dpdk-dev] [PATCH v1] net/ice: revert the TSO fake fix

2020-07-30 Thread Haiyue Wang
The two fixes are not the real root cause for MDD event, it mitigates the failure rate when different test mode, so revert them. Fixes: 2a0c9ae4f646 ("net/ice: fix TCP checksum offload") Fixes: 7365a3cee51f ("net/ice: calculate TCP header size for offload") Cc: sta...@dpdk.org Signed-off-by: Haiy

Re: [dpdk-dev] [PATCH v1] net/ice: fix burst Tx descriptor set issue

2020-07-30 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Friday, July 31, 2020 12:27 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Xu, Ting ; Sun, Chenmin ; > Wang, Yinan ; Wang, Haiyue > ; sta...@dpdk.org > Subject: [PATCH v1] net/ice: fix burst Tx descriptor set issue > > The v

Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param

2020-07-30 Thread Honnappa Nagarahalli
> > 主题: Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the > > param > > > > On Wed, Jul 29, 2020 at 8:31 AM Feifei Wang > > wrote: > > > > > > When enqueue one element to the ring, the param "obj" should be the > > > object to be added into the ring. The object is of type void*.

Re: [dpdk-dev] [PATCH] librte_metrics: fix memory leak

2020-07-30 Thread Honnappa Nagarahalli
Hi Gaurav, One comment inline. > > Fix memory leak for sequential allocations. > > Signed-off-by: Gaurav Singh > --- > lib/librte_metrics/rte_metrics_telemetry.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_metrics/rte_metrics_telemetry.

[dpdk-dev] [PATCH v1] net/ice: fix burst Tx descriptor set issue

2020-07-30 Thread Haiyue Wang
The variables 'td_offset' and 'td_tag' should be reset to 0 for every burst packet, otherwise the fields of Tx Descriptor will be set wrong, this will cause the MDD event error, and Tx will hang. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Sun, GuinanX
Hi Beilei > -Original Message- > From: Xing, Beilei > Sent: Friday, July 31, 2020 11:50 AM > To: Wang, ShougangX ; Sun, GuinanX > ; Guo, Jia ; dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > -Original Message

[dpdk-dev] [Bug 519] DPDK 20.08-rc3 meson build fails with MLNX_OFED_LINUX-5.1-0.6.6.0

2020-07-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=519 Bug ID: 519 Summary: DPDK 20.08-rc3 meson build fails with MLNX_OFED_LINUX-5.1-0.6.6.0 Product: DPDK Version: 20.08 Hardware: x86 OS: Linux Status: UNCON

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Xing, Beilei
> -Original Message- > From: Wang, ShougangX > Sent: Friday, July 31, 2020 10:38 AM > To: Xing, Beilei ; Sun, GuinanX > ; Guo, Jia ; dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > Hi Beilei > > > -Original Messa

[dpdk-dev] [PATCH] librte_metrics: fix memory leak

2020-07-30 Thread Gaurav Singh
Fix memory leak for sequential allocations. Signed-off-by: Gaurav Singh --- lib/librte_metrics/rte_metrics_telemetry.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c index 289ebae

[dpdk-dev] [PATCH 1/2] net/mlx5: add hash list extended lookup and insert

2020-07-30 Thread Suanming Mou
The mlx5 PMD hashed list was designed in approach to contain the items with unique keys only. Now there is the need to store the objects with possible key collisions. It is not expected to have many collisions (very likely to have a few ones), but keys become not unique. This commit adds the hash

[dpdk-dev] [PATCH 2/2] net/mlx5: manage modify actions with hashed list

2020-07-30 Thread Suanming Mou
To manage header modify actions mlx5 PMD used the single linked list and lookup and insertion operations took too long times if there were millions of objects and this impacted the flow insertion/deletion rate. In order to optimize the performance the hashed list is engaged. The list implementatio

[dpdk-dev] [PATCH 0/2] net/mlx5: manage modify actions with hashed list

2020-07-30 Thread Suanming Mou
To manage header modify actions mlx5 PMD used the single linked list and lookup and insertion operations took too long times if there were millions of objects and this impacted the flow insertion/deletion rate. In order to optimize the performance the hashed list is engaged. The list implementatio

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Wang, ShougangX
Hi Beilei > -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Friday, July 31, 2020 10:30 AM > To: Sun, GuinanX ; Guo, Jia ; > dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > -Original Message

[dpdk-dev] [PATCH] net/bxnt: remove redundant null check

2020-07-30 Thread Gaurav Singh
vxlan_mask cannot be NULL since its already being accessed before. Remove the redundant NULL check. Signed-off-by: Gaurav Singh --- drivers/net/bnxt/bnxt_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 3

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-30 Thread Fu, Patrick
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 30, 2020 2:33 PM > To: Fu, Patrick > Cc: dev@dpdk.org; Yigit, Ferruh ; > maxime.coque...@redhat.com; Richardson, Bruce > ; Wang, Zhihong ; > Wang, Liang-min ; Ananyev, Konstantin > ; Miskell, Timothy > ; Liang

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status

2020-07-30 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Thursday, July 30, 2020 6:25 PM > To: Xing, Beilei ; Guo, Jia ; > dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > If the PF driver supports the new speed re

Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR GTPU rule create fail

2020-07-30 Thread Huang, ZhiminX
Tested-by: Huang, ZhiminX Regards, HuangZhiMin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao Sent: Thursday, July 30, 2020 5:28 PM To: dev@dpdk.org Cc: Zhang, Qi Z ; Zhao1, Wei Subject: [dpdk-dev] [PATCH v2] net/ice: fix FDIR GTPU rule create fail F

[dpdk-dev] [dpdk-announce] release candidate 20.08-rc3

2020-07-30 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.08-rc3 There are 138 new patches in this snapshot. Release notes: http://doc.dpdk.org/guides/rel_notes/release_20_08.html A lot of deprecation notices are expected. The -rc4 will include only

Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

2020-07-30 Thread Stephen Hemminger
On Fri, 31 Jul 2020 00:06:23 +0200 Thomas Monjalon wrote: > 15/07/2020 01:21, Stephen Hemminger: > > Simple script to look for drivers and scripts that > > are missing requires SPDX header. > > > > Signed-off-by: Stephen Hemminger > [...] > > +#! /bin/sh > > +# SPDX-License-Identifier: BSD-3-

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix references to /dev/huge

2020-07-30 Thread Thomas Monjalon
06/07/2020 10:01, Sarosh Arif: > On Mon, Jul 6, 2020 at 1:44 AM Thomas Monjalon wrote: > > > 23/06/2020 07:55, Sarosh Arif: > > > change /dev/huge to /dev/hugepages > > > > > > Bugzilla ID: 492 > > > Signed-off-by: Sarosh Arif > > > > Please could you explain why /dev/hugepages must be used, > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/guides/sample_app_ug: fix ethtool app path

2020-07-30 Thread Thomas Monjalon
04/06/2020 11:59, Sarosh Arif: > The path to the ethtool application was slightly incorrect in the > documentation. This patch corrects that path. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample > application") > Cc: remy.hor...@intel.com > > Signed-off-by: Sarosh Arif

Re: [dpdk-dev] [PATCH] doc: clarify adding author to commit message

2020-07-30 Thread Thomas Monjalon
30/06/2020 21:01, Honnappa Nagarahalli: > Clarify to add the author in CC while contributing patches to stable. Not only for stable. We should explain in this commit log that this Cc is for automatic handling by git-send-email. It is manually removed when pushing in the git repository to avoid na

Re: [dpdk-dev] [PATCH v2] doc: add dependency syntax to contributing guide

2020-07-30 Thread Thomas Monjalon
03/07/2020 11:53, Ferruh Yigit: > To help managing patch dependencies, both for maintainers or automation > tasks, document a syntax for commit logs or cover letters to express > their dependencies. > > Using the syntax proposed in Bugzilla ID 210: > [https://bugs.dpdk.org/show_bug.cgi?id=210] >

Re: [dpdk-dev] [PATCH v2] doc: fix doc build when sphinx reports version to stderr

2020-07-30 Thread Thomas Monjalon
22/06/2020 16:20, David Marchand: > On Mon, Jun 22, 2020 at 4:00 PM Bruce Richardson > wrote: > > > > When sphinx-build reports its version information to stderr rather > > than stdout, the wrapper script misses it, and then fails to run. > > We can fix this by redirecting stderr to stdout for the

Re: [dpdk-dev] [PATCH] devtools: return error on failure

2020-07-30 Thread Thomas Monjalon
25/06/2019 19:01, Ferruh Yigit: > Currently script is always returning success, returning failure on error > helps on using script on automation tools. > > Signed-off-by: Ferruh Yigit > --- > devtools/check-git-log.sh | 56 ++- > 1 file changed, 43 insertions(

Re: [dpdk-dev] [PATCH v4 0/2] standardize devtools check scripts

2020-07-30 Thread Thomas Monjalon
23/06/2020 11:29, Ciara Power: > v4: > - Merge doc patch into patch with code changes. > - Simplified and reduced documentation and comments. > > v3: > - Fix comments on v2. > - Add patch to update contributor's guide. > > v2: Fix comments on v1. > > This patchset standardizes the checkp

Re: [dpdk-dev] [PATCH v4 2/2] devtools: added stats print

2020-07-30 Thread Thomas Monjalon
23/06/2020 11:29, Ciara Power: > When all checks are completed on the specified commit logs, the script > indicates if all are valid, or if there were some failures. > > Signed-off-by: Ciara Power > Acked-by: Ferruh Yigit > > --- > v2: Added appropriate exit codes based on failure status. > ---

Re: [dpdk-dev] [PATCH 1/3] eal/windows: add missing SPDX license tag

2020-07-30 Thread Dmitry Kozlyuk
On Wed, Jul 15, 2020 at 2:50 AM Stephen Hemminger wrote: > > This file was added without license information. > Add BSD SPDX license with copyright assigned to the original > author (as was done for other files in Windows EAL). > > Signed-off-by: Stephen Hemminger > --- [snip] Acked-by: Dmitry K

Re: [dpdk-dev] [PATCH 1/3] eal/windows: add missing SPDX license tag

2020-07-30 Thread Thomas Monjalon
+Cc Dmitry 15/07/2020 01:50, Stephen Hemminger: > This file was added without license information. > Add BSD SPDX license with copyright assigned to the original > author (as was done for other files in Windows EAL). > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/windows/eal_hugepa

Re: [dpdk-dev] [PATCH 2/3] net/qede/base: add missing license information

2020-07-30 Thread Thomas Monjalon
+Cc maintainers 15/07/2020 01:50, Stephen Hemminger: > Add SPDX header that is the same as other files in the > same qede/base directory. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/qede/base/ecore_hsi_func_common.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/dr

Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

2020-07-30 Thread Thomas Monjalon
15/07/2020 01:21, Stephen Hemminger: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger [...] > +#! /bin/sh > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2020 Microsoft Corporation > +# > +# Produce a list of f

Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

2020-07-30 Thread Thomas Monjalon
15/07/2020 01:25, Stephen Hemminger: > On Tue, 14 Jul 2020 16:21:01 -0700 > Stephen Hemminger wrote: > > > Simple script to look for drivers and scripts that > > are missing requires SPDX header. > > > > Signed-off-by: Stephen Hemminger > Preprocessor Directives > > Because of the long delay

Re: [dpdk-dev] [PATCH] devtools: add checkpatch spelling dictionary builder

2020-07-30 Thread Thomas Monjalon
07/07/2020 10:54, Thomas Monjalon: > The script checkpatch.pl (used in checkpatches.sh) can use a dictionary > from the codespell project to check spelling. > There are multiple dictionaries to be used. > > The script build-dict.sh concatenate multiple dictionaries and remove > some annoying false

Re: [dpdk-dev] [PATCH] devtools: forbid experimental build flag for non-examples

2020-07-30 Thread Thomas Monjalon
16/07/2020 09:26, David Marchand: > -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since > https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5 > > Warn people not to copy/paste this flag that was needed before. > > Signed-off-by: David Marchand Applied with small rewording, thanks

Re: [dpdk-dev] [PATCH 1/2] examples/l3fwd: increase number of routes

2020-07-30 Thread Thomas Monjalon
11/11/2019 08:46, Pavan Nikhilesh Bhagavatula: > >On Wed, Oct 30, 2019 at 6:23 AM wrote: > >> > >> From: Pavan Nikhilesh > >> > >> Increase the number of routes from 8 to 16 that are statically added > >for > >> lpm and em mode as most of the SoCs support more than 8 > >interfaces. > >> > >> Sign

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-07-30 Thread Thomas Monjalon
13/07/2020 15:28, Sarosh Arif: > Did you get the time to review it? > > On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma > wrote: > > *From:* Sarosh Arif > > > > > Hello, > > > > > > This patch has been sitting around for more than 3 weeks. Is there > > > something that needs to be done further f

Re: [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask

2020-07-30 Thread Thomas Monjalon
05/06/2020 15:41, Sarosh Arif: > Giving invalid or zero portmask as command line option to > packet_ordering application will have an unexpected response. > The reason behind this is that parse_portmask's return value is > stored in a variable called portmask.The data type of portmask > is unsign

Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on exit

2020-07-30 Thread Thomas Monjalon
Declan is not reviewing patches anymore. Adding more maintainers in Cc. PS: Maybe we should update the file MAINTAINERS to avoid patches being stuck. 22/07/2020 14:50, Ibtisam Tariq: > When exiting the application, resources should be cleared. > > Signed-off-by: Ibtisam Tariq > --- > examples

Re: [dpdk-dev] [PATCH] examples: fix return value of function that parses portmask

2020-07-30 Thread Thomas Monjalon
21/07/2020 18:07, Bruce Richardson: > On Thu, Jun 11, 2020 at 05:36:24PM +0500, Sarosh Arif wrote: > > Giving invalid or zero portmask as command line option to > > these applications will have an unexpected response. > > The reason behind this is that the return value of function > > that parses

[dpdk-dev] [PATCH v2 6/7] cmdline: support Windows

2020-07-30 Thread Dmitry Kozlyuk
Implement terminal handling, input polling, and vdprintf() for Windows. Because Windows I/O model differs fundamentally from Unix and there is no concept of character device, polling is simulated depending on the underlying inpue device. Supporting non-terminal input is useful for automated testin

[dpdk-dev] [PATCH v2 2/7] cmdline: add internal wrappers for terminal handling

2020-07-30 Thread Dmitry Kozlyuk
Extract struct terminal and associated functions that set up, save, and restore terminal parameters. Use existing code as Unix implementation. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/Makefile | 4 lib/librte_cmdline/cmdline_os_unix.c | 27 +++

[dpdk-dev] [PATCH v2 7/7] examples/cmdline: build on Windows

2020-07-30 Thread Dmitry Kozlyuk
Enable cmdline sample application as all dependencies are met. Signed-off-by: Dmitry Kozlyuk --- examples/cmdline/commands.c | 1 - examples/cmdline/main.c | 1 - examples/meson.build| 6 +++--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/cmdline/commands.

[dpdk-dev] [PATCH v2 4/7] cmdline: add internal wrapper for vdprintf

2020-07-30 Thread Dmitry Kozlyuk
Add internal wrapper for vdprintf(3) that is only available on Unix. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 2 +- lib/librte_cmdline/cmdline_os_unix.c | 6 ++ lib/librte_cmdline/cmdline_private.h | 8 3 files changed, 15 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 5/7] eal/windows: improve compatibility networking headers

2020-07-30 Thread Dmitry Kozlyuk
Extend compatibility header system to support librte_cmdline. pthread.h has to include windows.h, which exposes struct in_addr, etc. conflicting with compatibility headers. WIN32_LEAN_AND_MEAN macro is required to disable this behavior. Use rte_windows.h to define WIN32_LEAN_AND_MEAN for pthread l

[dpdk-dev] [PATCH v2 0/7] cmdline: support Windows

2020-07-30 Thread Dmitry Kozlyuk
This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, testing revealed that WinEditLine [2] is not a drop-in replac

[dpdk-dev] [PATCH v2 3/7] cmdline: add internal wrappers for character input

2020-07-30 Thread Dmitry Kozlyuk
poll(3) is a purely Unix facility, so it cannot be directly used by common code. read(2) is limited in device support outside of Unix. Create wrapper functions and implement them for Unix. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 12 +++- lib/librte_cmdlin

[dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-07-30 Thread Dmitry Kozlyuk
struct cmdline exposes platform-specific members it contains, most notably struct termios that is only available on Unix. Make the structure opaque. Remove tests checking struct cmdline content as meaningless. Add cmdline_get_rdline() to access history buffer. The new function is currently used o

[dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 809 +++ 1 file changed, 809 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index d5df855..5adc95e 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: Iff64ba83ead496b3dedeaf323ee09bce1f631a6f Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 263 +++ 1 file changed, 263 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I58cb02dc040aa6dcf30992ea57ff3f332b4946f2 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 3ece86a..d5df855 100644

[dpdk-dev] [PATCH 24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I763bff70a4da35b898c1f5abfdcc45a7c1dfac08 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 7a78d59..3ece86a 100644

[dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I06d4006786440a0454ce883dba0ce14640dfff92 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 166 +++ 1 file changed, 166 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I9dcf8cf95c1001e09ab3e44e3fbd2ccbf0ddec72 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: I7dc1b4c03a222b40d629705946d00f3800dbe63d Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index e601a0e..0eb0cf5 1

[dpdk-dev] [PATCH 20/27] event/dlb: add port_link

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: Id86dbdd1070e8102bf602765654fe5afde0e0d6c Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 303 +++ 1 file changed, 303 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c i

[dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Change-Id: Ifa154a041fa117776612efc027b128c1603b6396 Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 2da5cd1..b10

[dpdk-dev] [PATCH 18/27] event/dlb: add queue setup

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 295 +++ 1 file changed, 295 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index b1070c9..ae1d19b 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 19/27] event/dlb: add port_setup

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 1241 +++ 1 file changed, 1241 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index ae1d19b..8bbcd03 100644 --- a/drivers/event/dlb

[dpdk-dev] [PATCH 15/27] event/dlb: add probe

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile|1 + drivers/event/dlb/dlb.c | 508 + drivers/event/dlb/meson.build |3 +- 3 files changed, 511 insertions(+), 1 deletion(-) create mode 100644 d

[dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" The PMD uses function pointers so that it can be executed as a bifurcated PMD accessing hardware via a linux kernel mode driver, or as a PF PMD where it has complete control of the hardware device. Note that this interface is not used in the data path. Signed-off-by: M

[dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb.c | 401 +++ 1 file changed, 401 insertions(+) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index c1054d7..2da5cd1 100644 --- a/drivers/event/dlb/

[dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |2 + drivers/event/dlb/meson.build |4 +- drivers/event/dlb/rte_pmd_dlb.c | 38 + drivers/event/dlb/rte_pmd_dlb.h

[dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- app/test/test_eventdev.c |8 + drivers/event/dlb/Makefile |1 + drivers/event/dlb/dlb_selftest.c | 1563 ++ drivers/event/dlb/meson.build|3 +- 4 files changed, 1574

[dpdk-dev] [PATCH 09/27] event/dlb: add inline functions used in multiple files

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_inline_fns.h | 80 1 file changed, 80 insertions(+) create mode 100644 drivers/event/dlb/dlb_inline_fns.h diff --git a/drivers/event/dlb/dlb_inline_fns.h b/drivers/even

[dpdk-dev] [PATCH 13/27] event/dlb: add xstats support

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |1 + drivers/event/dlb/dlb_xstats.c | 1249 drivers/event/dlb/meson.build |3 +- 3 files changed, 1252 insertions(+), 1 deletion(-) create mode 10064

[dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- doc/guides/eventdevs/dlb.rst | 343 ++ 1 file changed, 343 insertions(+) create mode 100644 doc/guides/eventdevs/dlb.rst diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb

[dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/Makefile |2 + drivers/event/dlb/meson.build |4 +- drivers/event/dlb/pf/dlb_main.c | 614 ++ drivers/event/dlb/pf/dlb_main.h | 54 +++ drivers/event/dlb/pf/dlb_pf.c

[dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_priv.h | 565 ++ 1 file changed, 565 insertions(+) create mode 100644 drivers/event/dlb/dlb_priv.h diff --git a/drivers/event/dlb/dlb_priv.h b/drivers/event/dlb/dlb_pr

[dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_user.h | 1083 ++ 1 file changed, 1083 insertions(+) create mode 100644 drivers/event/dlb/dlb_user.h diff --git a/drivers/event/dlb/dlb_user.h b/drivers/event/dlb/dlb_u

[dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- drivers/event/dlb/dlb_log.h | 25 + 1 file changed, 25 insertions(+) create mode 100644 drivers/event/dlb/dlb_log.h diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h new file mode 100

[dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Signed-off-by: McDaniel, Timothy --- config/common_base| 19 ++- config/rte_config.h |8 +++- drivers/event/Makefile|7 +++ drivers/event/dlb/Makefile| 27 +++ drivers/event/d

[dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the number of queues that may be linked to a port. 2) Some ports a further restricted to a maximum of 1 linked queue. 3) It does not (currently) have the ability to carry the flow_i

[dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" Previous implementation traced u8 disable_impl_release, which is now a bit field contained in the new u32 event_port_cfg field. Signed-off-by: McDaniel, Timothy --- lib/librte_eventdev/rte_event_crypto_adapter.c |2 +- lib/librte_eventdev/rte_event_eth_tx_adapter.

[dpdk-dev] [PATCH 00/27] Add Intel DLM PMD to 20.11

2020-07-30 Thread McDaniel, Timothy
From: "McDaniel, Timothy" This patchset is targetted at DPDK 20.11 Changes since V2 - Fixed a memory corruption issue due to not allocating enough CQ memory for depths < 8. Hardware requires minimum allocation to be at least 8 entries. - Address review comments from Gage and Mat

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-30 Thread Jerin Jacob
On Thu, Jul 30, 2020 at 10:03 PM McDaniel, Timothy wrote: > > > >-Original Message- > >From: McDaniel, Timothy > >Sent: Thursday, July 2, 2020 5:14 PM > >To: dev@dpdk.org > >Cc: jer...@marvell.com; Eads, Gage ; Van Haaren, Harry > >; m...@ashroe.eu; nhor...@tuxdriver.com; Rao, > >Nikhil ;

Re: [dpdk-dev] [PATCH v3] doc: add more detail to telemetry guides

2020-07-30 Thread Thomas Monjalon
24/07/2020 13:20, Ciara Power: > +**Example Callback** > + > +This callback is an example of handling multiple commands in one callback, > +and also shows the use of params which holds a port ID. The params input > needs > +to be validated and converted to the required integer type for port ID. Th

Re: [dpdk-dev] [PATCH 0/7] cmdline: support Windows

2020-07-30 Thread Kadam, Pallavi
Hi Dmitry, On 6/20/2020 2:05 PM, Dmitry Kozlyuk wrote: This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, t

Re: [dpdk-dev] [PATCH] net/netvsc: fix seg fault during transmit

2020-07-30 Thread Ferruh Yigit
On 7/30/2020 4:13 PM, Stephen Hemminger wrote: > On Wed, 29 Jul 2020 09:58:44 -0400 > Chas Williams <3ch...@gmail.com> wrote: > >> Commit cc0251813277 ("net/netvsc: split send buffers from Tx >> descriptors") changed the way that transmit descriptors are >> allocated. They come from a single pool

Re: [dpdk-dev] [EXT] [PATCH] doc: add deprecation notice for security session create API

2020-07-30 Thread Anoob Joseph
> The API ``rte_security_session_create`` takes only single mempool for session > and session private data. So the application need to create mempool for twice > the number of sessions needed and will also lead to wastage of memory as > session private data need more memory compared to session. >

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

2020-07-30 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2020-07-30 Thread Thomas Monjalon
29/07/2020 14:22, Raslan Darawsheh: [...] > +* Mellanox\ |reg| ConnectX\ |reg|-6 Dx EN 100G MCX623106AN-CDAT (2x100G) > + > + * Host interface: PCI Express 4.0 x16 > + * Device ID: 15b3:101d > + * Firmware version: 22.28.1002 and above > + > +* Mellanox(R) BlueField SmartNIC > +

[dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

2020-07-30 Thread Akhil Goyal
The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to wastage of memory as session private data need more memory compared to session. Hence the A

[dpdk-dev] [RFC] eal: mark rte_malloc with malloc attribute

2020-07-30 Thread Stephen Hemminger
Gcc (and recent versions of Clang) have a function attribute that hints to the optimizer that it doesn't need to worry about aliasing on a pointer returned from malloc. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_common.h | 11 +++ lib/librte_eal/include/rte_malloc.h

Re: [dpdk-dev] Userspace testing

2020-07-30 Thread Owen Hilyard
Thanks for the advice. I was wondering about the state of the "Setup VFIO permissions" option in the setup script. It seems to just modify the character device's permissions and then check their memory limit. Should this option also handle the hugepages setup? Thanks On Wed, Jul 29, 2020 at 11:3

Re: [dpdk-dev] [PATCH] doc: announce changes to eventdev public data structures

2020-07-30 Thread McDaniel, Timothy
>-Original Message- >From: McDaniel, Timothy >Sent: Thursday, July 2, 2020 5:14 PM >To: dev@dpdk.org >Cc: jer...@marvell.com; Eads, Gage ; Van Haaren, Harry >; m...@ashroe.eu; nhor...@tuxdriver.com; Rao, >Nikhil ; Carrillo, Erik G ; >Gujjar, >Abhinandan S ; pbhagavat...@marvell.com; >he

[dpdk-dev] [PATCH v1] net/ice: optimize TCP header size calculation

2020-07-30 Thread Haiyue Wang
The rte_pktmbuf_read function can handle the contiguous data buffer reading, so remove the redundant contiguous memory handling. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Fixes: 2a0c9ae4f646 ("net/ice: fix TCP checksum offload") Fixes: 7365a3cee51f ("net/ice: calculate TCP header size f

Re: [dpdk-dev] [EXT] Re: [PATCH v1 1/3] eal: add API for bus close

2020-07-30 Thread Rohit Raj
Yes, I agree. I will rework and send this patch series again. Regards, Rohit Raj Software Engineer | NXP India Private Limited Email: rohit@nxp.com -Original Message- From: Stephen Hemminger Sent: Tuesday, July 28, 2020 10:54 PM To: Rohit Raj Cc: Ray Kinsella ; Neil Horman ; dev@

Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: support malloc and free tracking log

2020-07-30 Thread Somnath Kotur
On Thu, Jul 30, 2020 at 8:43 PM Xueming(Steven) Li wrote: > > Hi Som, > > > -Original Message- > > From: Somnath Kotur > > Sent: Thursday, July 30, 2020 11:10 PM > > To: Iremonger, Bernard > > Cc: Xueming(Steven) Li ; Burakov, Anatoly > > ; Yigit, Ferruh ; Stephen > > Hemminger ; dev@dpd

Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: support malloc and free tracking log

2020-07-30 Thread Xueming(Steven) Li
Hi Som, > -Original Message- > From: Somnath Kotur > Sent: Thursday, July 30, 2020 11:10 PM > To: Iremonger, Bernard > Cc: Xueming(Steven) Li ; Burakov, Anatoly > ; Yigit, Ferruh ; Stephen > Hemminger ; dev@dpdk.org; Asaf Penso > > Subject: Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: suppo

Re: [dpdk-dev] [PATCH] net/netvsc: fix seg fault during transmit

2020-07-30 Thread Stephen Hemminger
On Wed, 29 Jul 2020 09:58:44 -0400 Chas Williams <3ch...@gmail.com> wrote: > Commit cc0251813277 ("net/netvsc: split send buffers from Tx > descriptors") changed the way that transmit descriptors are > allocated. They come from a single pool instead of being > individually attached to each mbuf. T

Re: [dpdk-dev] [RFC v2 2/2] app/testpmd: support malloc and free tracking log

2020-07-30 Thread Somnath Kotur
On Tue, Apr 21, 2020 at 7:11 PM Iremonger, Bernard wrote: > > > -Original Message- > > From: dev On Behalf Of Xueming Li > > Sent: Friday, April 17, 2020 9:04 AM > > To: Burakov, Anatoly ; Yigit, Ferruh > > ; Stephen Hemminger > > > > Cc: dev@dpdk.org; Asaf Penso > > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH v2 20.08 4/6] doc: announce deprecation blacklist/whitelist

2020-07-30 Thread Stephen Hemminger
On Thu, 30 Jul 2020 09:45:19 +0100 Bruce Richardson wrote: > On Wed, Jul 29, 2020 at 05:58:02PM -0700, Stephen Hemminger wrote: > > Announce upcoming changes for 20.11. > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/rel_notes/deprecation.rst | 21 + > > 1 f

[dpdk-dev] [PATCH v5 6/6] net/qede: add VF FLR support

2020-07-30 Thread Manish Chopra
This patch adds required bit to handle VF FLR indication from Management FW (MFW) of the device With that VFs were able to load in VM (VF attached as PCI passthrough to the guest VM) followed by FLR successfully Updated the docs/guides with the feature support Signed-off-by: Manish Chopra Signe

[dpdk-dev] [PATCH v5 4/6] net/qede: add infrastructure support for VF load

2020-07-30 Thread Manish Chopra
This patch adds necessary infrastructure support (required to handle messages from VF and sending ramrod on behalf of VF's configuration request from alarm handler context) to start/load the VF-PMD driver instance on top of PF-PMD driver instance. Signed-off-by: Manish Chopra Signed-off-by: Igor

[dpdk-dev] [PATCH v5 5/6] net/qede: initialize VF MAC and link

2020-07-30 Thread Manish Chopra
This patch configures VFs with random mac if no MAC is provided by the PF/bulletin. This also adds required bulletin APIs by PF-PMD driver to communicate LINK properties/changes to the VFs through bulletin update mechanism. With these changes, VF-PMD instance is able to run fastpath over PF-PMD dr

[dpdk-dev] [PATCH v5 3/6] net/qede: configure VFs on hardware

2020-07-30 Thread Manish Chopra
Based on number of VFs enabled at PCI, PF-PMD driver instance enables/configures those VFs from hardware perspective, such that in later patches they could get required HW access to communicate with PFs for slowpath configuration and run the fastpath themsleves. This patch also add two new qede IO

[dpdk-dev] [PATCH v5 2/6] net/qede: define PCI config space specific osals

2020-07-30 Thread Manish Chopra
This patch defines various PCI config space access APIs in order to read and find IOV specific PCI capabilities. With these definitions implemented, it enables the base driver to do SR-IOV specific initialization and HW specific configuration required from PF-PMD driver instance. Signed-off-by: M

[dpdk-dev] [PATCH v5 1/6] drivers: add generic API to find PCI extended cap

2020-07-30 Thread Manish Chopra
By adding generic API, this patch removes individual functions/defines implemented by drivers to find extended PCI capabilities. Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- drivers/bus/pci/pci_common.c | 43 ++ drivers/bus/pci/rte_bus_pci.h

[dpdk-dev] [PATCH v5 0/6] qede: SR-IOV PF driver support

2020-07-30 Thread Manish Chopra
Hi, This series adds SR-IOV PF pmd driver support to have VF pmd driver work over PF pmd driver instances in order to run the adapter completely under DPDK environment for one of the use cases like ovs-dpdk. This is very initial bring-up with following testing covered - * Enable/Disable SR-IOV V

  1   2   >