21/07/2020 18:07, Bruce Richardson: > On Thu, Jun 11, 2020 at 05:36:24PM +0500, Sarosh Arif wrote: > > Giving invalid or zero portmask as command line option to > > these applications will have an unexpected response. > > The reason behind this is that the return value of function > > that parses portmask is stored in a variable whose datatype is > > unsigned int, hence returning -1 in case of zero or > > invalid portmask causes an unexpected behaviour. > > If we return 0 instead of -1 this issue can be resolved. > > The program already contains the functionality to print > > "invalid portmask" and program usage if zero is returned. > > > > Signed-off-by: Sarosh Arif <sarosh.a...@emumba.com> > > --- > > Checked a number of the examples and all seem to behave similarly to > described. This looks a good fix. > > Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Applied, thanks
