Hi Dmitry, On 6/20/2020 2:05 PM, Dmitry Kozlyuk wrote:
This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, testing revealed that WinEditLine [2] is not a drop-in replacement for libedit, so this solution wouldn't be universal. Note: not all dependency series are up-to-date at the time of submission, so this version may require hacking to test. [1]: http://patchwork.dpdk.org/patch/38561 [2]: http://mingweditline.sourceforge.net --- Depends-on: series-10512 ("Windows bus/pci support ") Depends-on: series-10244 ("[v4] eal/windows: ring build on Windows") Depends-on: series-10282 ("build mempool on Windows ") Depends-on: series-10382 ("compile librte_net for windows") Dmitry Kozlyuk (7): cmdline: make implementation opaque cmdline: add internal wrappers for terminal handling cmdline: add internal wrappers for character input cmdline: add internal wrapper for vdprintf eal/windows: improve compatibility networking headers cmdline: support Windows examples/cmdline: build on Windows app/test-cmdline/commands.c | 8 +- app/test/test_cmdline_lib.c | 42 ++-- config/meson.build | 2 + examples/cmdline/commands.c | 1 - examples/cmdline/main.c | 1 - examples/meson.build | 6 +- lib/librte_cmdline/Makefile | 4 + lib/librte_cmdline/cmdline.c | 29 +-- lib/librte_cmdline/cmdline.h | 15 +- lib/librte_cmdline/cmdline_os_unix.c | 53 +++++ lib/librte_cmdline/cmdline_os_windows.c | 207 ++++++++++++++++++++ lib/librte_cmdline/cmdline_parse.c | 4 +- lib/librte_cmdline/cmdline_private.h | 61 ++++++ lib/librte_cmdline/cmdline_socket.c | 25 +-- lib/librte_cmdline/cmdline_vt100.c | 1 - lib/librte_cmdline/cmdline_vt100.h | 4 + lib/librte_cmdline/meson.build | 6 + lib/librte_cmdline/rte_cmdline_version.map | 8 + lib/librte_eal/windows/include/arpa/inet.h | 30 +++ lib/librte_eal/windows/include/netinet/in.h | 11 ++ lib/librte_eal/windows/include/pthread.h | 2 +- lib/librte_eal/windows/include/sys/socket.h | 24 +++ lib/meson.build | 1 + 23 files changed, 470 insertions(+), 75 deletions(-) create mode 100644 lib/librte_cmdline/cmdline_os_unix.c create mode 100644 lib/librte_cmdline/cmdline_os_windows.c create mode 100644 lib/librte_cmdline/cmdline_private.h create mode 100644 lib/librte_eal/windows/include/arpa/inet.h create mode 100644 lib/librte_eal/windows/include/sys/socket.h
Will this series be rebased with the latest in order to apply it cleanly? Thanks,
