Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
Ho Maxime Good morning From: Maxime Coquelin: > On 6/23/20 4:52 PM, Matan Azrad wrote: > > > > > >> -Original Message- > >> From: Maxime Coquelin > >> Sent: Tuesday, June 23, 2020 4:56 PM > >> To: Matan Azrad ; Xiao Wang > >> > >> Cc: dev@dpdk.org > >> Subject: Re: [PATCH v1 3/4] vhost:

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: restrict pointer aliasing for NEON vpmd

2020-06-23 Thread Stephen Hemminger
On Wed, 24 Jun 2020 02:58:28 + Joyce Kong wrote: > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other p

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Chengchang Tang
On 2020/6/23 17:30, Andrew Rybchenko wrote: > On 6/23/20 9:48 AM, Chengchang Tang wrote: >> In common practice, PMD configure the rx_buf_size according to the data >> room size of the object in mempool. But in fact the final value is related >> to the specifications of hw, and its values will aff

Re: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch filter

2020-06-23 Thread Sun, GuinanX
Hi Guojia > -Original Message- > From: Guo, Jia > Sent: Sunday, June 21, 2020 8:29 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei > Subject: Re: [PATCH] net/i40e: enable port filter by switch filter > > hi, guinan > > On 6/11/2020 1:24 PM, Guinan Sun wrote: > > This patch enabl

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: restrict pointer aliasing for NEON vpmd

2020-06-23 Thread Joyce Kong
> -Original Message- > From: Phil Yang > Sent: Tuesday, June 23, 2020 5:06 PM > To: Maxime Coquelin ; Joyce Kong > ; jer...@marvell.com; zhihong.w...@intel.com; > xiaolong...@intel.com; Honnappa Nagarahalli > ; Ruifeng Wang > > Cc: dev@dpdk.org > Subject: RE: [PATCH v1 1/2] net/virtio: re

[dpdk-dev] [PATCH v4] net/ice: initialize and update RSS based on user request

2020-06-23 Thread Junyu Jiang
Initialize and update RSS configure based on user request (rte_eth_rss_conf) from dev_configure and .rss_hash_update ops. All previous default configure has been removed. Signed-off-by: Junyu Jiang --- v3->v4: change the return value to success when rss_hf value update to 0. v2->v3: change the

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-23 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Friday, May 8, 2020 12:59 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce > Subject: [PATCH v4 1/4] hash: add kv hash library > > KV hash is a special optimized key-value sto

[dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path

2020-06-23 Thread longli
From: Long Li When rte_pktmbuf_attach_extbuf() is used, the driver should not decrease the reference count in its callback function hn_rx_buf_free_cb, because the reference count is already decreased by rte_pktmbuf. Doing it twice may result in underflow and driver may never send an ack packet ov

[dpdk-dev] [PATCH 2/2] net/netvsc: detach external buffer on failure

2020-06-23 Thread longli
From: Long Li When external buffer is used, driver should detach it if it doesn't make it successfully to the queue. Signed-off-by: Long Li --- drivers/net/netvsc/hn_rxtx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c ind

Re: [dpdk-dev] [PATCH v8 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-23 Thread Dmitry Kozlyuk
[snip] > + /* kernel driver type is unsupported */ > + RTE_LOG(DEBUG, EAL, > + "kernel driver type for PCI device " PCI_PRI_FMT "," > + " is unsupported", Nit: log messages usually start with a capital. > + dev->a

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-23 Thread Ananyev, Konstantin
> Hi Vladimir, > > > --- /dev/null > > +++ b/lib/librte_hash/k32v64_hash.c > > @@ -0,0 +1,277 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2020 Intel Corporation > > + */ > > + > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#include "k32v64_

Re: [dpdk-dev] [PATCH v3 0/2] Support EAL debug functions on Windows

2020-06-23 Thread Dmitry Kozlyuk
On Tue, 23 Jun 2020 23:57:19 +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > This patchset adds support for the EAL debug function on Windows by > implementing backtracing in rte_dump_stack and cleanup calls in > rte_eal_cleanup. > > Additionally, the functions rte_exit, __rte_p

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, June 23, 2020 4:20 PM > To: Phil Yang > Cc: dev@dpdk.org; Carrillo, Erik G ; > d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v3] maintainers: update for interrupt subsystem

2020-06-23 Thread Thomas Monjalon
17/06/2020 14:28, Harman Kalra: > updating MAINTAINERS file for interrupt subsytem. > > Signed-off-by: Harman Kalra > --- > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Interrupt Subsystem > +M: Harman Kalra > +F: lib/librte_eal/*/*interrupts.* > +F: app/test/test_interrupts.c Applied, thanks for v

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Stephen Hemminger
On Fri, 12 Jun 2020 19:19:57 +0800 Phil Yang wrote: > /* Track which cores have actually armed a timer */ > struct { > - rte_atomic16_t v; > + int16_t v; > } __rte_cache_aligned in_use[RTE_MAX_LCORE]; Do you really need this to be cache aligned (ie one p

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com > Subject: [PATCH 2/3] e

[dpdk-dev] [PATCH v3 0/2] Support EAL debug functions on Windows

2020-06-23 Thread talshn
From: Tal Shnaiderman This patchset adds support for the EAL debug function on Windows by implementing backtracing in rte_dump_stack and cleanup calls in rte_eal_cleanup. Additionally, the functions rte_exit, __rte_panic and rte_dump_registers were moved to a common file to avoid code duplicat

[dpdk-dev] [PATCH v3 1/2] eal: move OS common debug functions to single file

2020-06-23 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_debug.c. Those functions are rte_exit, __rte_panic and rte_dump_registers which has the same implementation on Unix and Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/eal_common_debug.c | 59

[dpdk-dev] [PATCH v3 2/2] eal/windows: support debug calls

2020-06-23 Thread talshn
From: Tal Shnaiderman Support the debug functions in eal_common_debug.c for Windows. Implementation of rte_dump_stack to get a backtrace similarly to Unix and of rte_eal_cleanup in eal.c. Signed-off-by: Tal Shnaiderman --- config/meson.build | 1 + lib/librte_eal/common/meson

Re: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Monday, June 22, 2020 5:12 AM > To: Phil Yang ; dev@dpdk.org; Carrillo, Erik G > > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar > ; nd > Subject: RE: [dpdk-dev] [PATCH 3/3

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-23 Thread Akhil Goyal
Hi Konstantin/David, > > Hi David, > > > > > > > > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > > > rte_crypto_op { > > > > > > struct rte_crypto_asym_op asym[0]; > > > > > > /**< Asymmetric operation parameters */ > > > > > >

Re: [dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-23 Thread Akhil Goyal
Hi David, > +/** DOCSIS direction */ > +enum rte_security_docsis_direction { > + RTE_SECURITY_DOCSIS_UPLINK, > + /**< Uplink > + * - Decryption, followed by CRC Verification > + */ > + RTE_SECURITY_DOCSIS_DOWNLINK, > + /**< Downlink > + * - CRC Generation, followed b

Re: [dpdk-dev] [PATCH v2 5/6] test/crypto: add DOCSIS security test cases

2020-06-23 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Tuesday, June 23, 2020 11:14 AM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Bren

Re: [dpdk-dev] [PATCH v2 3/6] crypto/aesni_mb: add support for DOCSIS protocol

2020-06-23 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Tuesday, June 23, 2020 11:14 AM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Bren

Re: [dpdk-dev] [PATCH v2 1/2] eal: move OS common debug functions to single file

2020-06-23 Thread Thomas Monjalon
08/06/2020 10:32, tal...@mellanox.com: > From: Tal Shnaiderman > > Move common functions between Unix and Windows to eal_common_debug.c. [...] > --- /dev/null > +++ b/lib/librte_eal/common/eal_common_debug.c > @@ -0,0 +1,58 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Me

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] meter: remove inline functions from export list

2020-06-23 Thread Thomas Monjalon
17/06/2020 10:24, Fady Bader: > The code didn't compile when using exported meter functions under windows. > > error LNK2001: unresolved external symbol > rte_meter_srtcm_color_aware_check > error LNK2001: unresolved external symbol > rte_meter_srtcm_color_blind_check > error LNK2001: unresolved e

Re: [dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Tuesday, June 23, 2020 11:14 AM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; >

Re: [dpdk-dev] [PATCH v3 9/9] mempool/bucket: handle non-EAL lcores

2020-06-23 Thread Andrew Rybchenko
On 6/22/20 4:25 PM, David Marchand wrote: > Convert to new lcore API to support non-EAL lcores. > > Signed-off-by: David Marchand > --- > drivers/mempool/bucket/rte_mempool_bucket.c | 131 > 1 file changed, 82 insertions(+), 49 deletions(-) > > diff --git a/drivers/mempool/

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread Andrew Rybchenko
On 6/22/20 4:25 PM, David Marchand wrote: > DPDK allows calling some part of its API from a non-EAL thread but this > has some limitations. > OVS (and other applications) has its own thread management but still > want to avoid such limitations by hacking RTE_PER_LCORE(_lcore_id) and > faking EAL th

Re: [dpdk-dev] [PATCH] ethdev: verify reserved HW ring

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 7:41 PM, Ferruh Yigit wrote: > Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based > on name match, but other requested attributes are discarded. > This may cause driver using a memzone with wrong size or alignment. > > Verify size, alignment and socket_id for matche

[dpdk-dev] [PATCH] ethdev: verify reserved HW ring

2020-06-23 Thread Ferruh Yigit
Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based on name match, but other requested attributes are discarded. This may cause driver using a memzone with wrong size or alignment. Verify size, alignment and socket_id for matched memzone, and do not use memzone if any one of th

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread Coyle, David
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 5:22 PM > To: Coyle, David > > > > > I guess > > > > > https://patchwork.dpdk.org/project/dpdk/list/?series=9304 > > > > > can be marked Superseded then. > > > > > Thanks. > > > > > > > > [DC] Yes it can - I have t

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 5:56 PM Coyle, David wrote: > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, June 23, 2020 4:39 PM > > > > I guess https://patchwork.dpdk.org/project/dpdk/list/?series=9304 > > > > can be marked Superseded then. > > > > Thanks. > > > > > > [DC]

Re: [dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows

2020-06-23 Thread Thomas Monjalon
18/06/2020 21:32, Ranjit Menon: > On 6/17/2020 11:55 PM, Fady Bader wrote: > > This patchset splits OS dependent EAL timer functions and implements them > > for windows. > > > > v2: > > * fixing styles and correctness errors. > > v3: > > * fixing correctness, get_tsc_freq was reimplement

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread Coyle, David
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 4:39 PM > > > I guess https://patchwork.dpdk.org/project/dpdk/list/?series=9304 > > > can be marked Superseded then. > > > Thanks. > > > > [DC] Yes it can - I have tried to set it to Superseded but don't have > > pe

Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings

2020-06-23 Thread Andrew Rybchenko
Hi Renata, Looks good to me except to minor notes below. It is better to use: --to-cmd ./devtools/get-maintainer.sh --cc dev@dpdk.org to have required list of maintainers directly specified. On 6/23/20 4:42 PM, Renata Saiakhova wrote: > Free previously allocated memzone for HW rings > > Signed

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-23 Thread Ananyev, Konstantin
Hi Vladimir, > --- /dev/null > +++ b/lib/librte_hash/k32v64_hash.c > @@ -0,0 +1,277 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Intel Corporation > + */ > + > +#include > + > +#include > +#include > +#include > + > +#include "k32v64_hash.h" > + > +static inline int >

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 5:18 PM Coyle, David wrote: > > I guess https://patchwork.dpdk.org/project/dpdk/list/?series=9304 can be > > marked Superseded then. > > Thanks. > > [DC] Yes it can - I have tried to set it to Superseded but don't have > permissions to > do that - guess one of the Maintain

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 5:48 PM, Stephen Hemminger wrote: > On Tue, 23 Jun 2020 14:48:54 +0800 > Chengchang Tang wrote: > >> In common practice, PMD configure the rx_buf_size according to the data >> room size of the object in mempool. But in fact the final value is related >> to the specifications of hw, and

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 4:52 PM, Matan Azrad wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, June 23, 2020 4:56 PM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> Hi Matan, >> >> On 6/23/

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread Coyle, David
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 3:52 PM > > > A number of approaches to combine DOCSIS Crypto and CRC functions > have > > been discussed in the DPDK community to date, namely: > > 1) adding a new rte_accelerator API, to provide a generic inter

Re: [dpdk-dev] [PATCH v3] bus/pci: fix VF bus error for memory access

2020-06-23 Thread Harman Kalra
On Mon, Jun 22, 2020 at 07:13:51PM +0800, Haiyue Wang wrote: > To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps > and block MMIO access on disabled memory, it will send a SIGBUS to the > application: > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm

Re: [dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5

2020-06-23 Thread Slava Ovsiienko
Hi, Patrick. Not all rdma-core versions provide the - mlx5dv_get_clock_info(context, clock_info); - mlx5dv_ts_to_ns(clock_info, device_timestamp); With these versions we would get compilation/linkage error. There should be conditional compilation like it is done with other mlx5dv routines. Wit

Re: [dpdk-dev] [RFC][PATCH v2 2/3] ethdev: add API to convert raw timestamps to nsec

2020-06-23 Thread Slava Ovsiienko
Hi, Patrick > /**< @internal Function used to get the current value of the device clock. */ > @@ -730,6 +734,7 @@ struct eth_dev_ops { > eth_timesync_read_time timesync_read_time; /** Get the device > clock time. */ > eth_timesync_write_timetimesync_write_time; /** Set the dev

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 23, 2020 4:56 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > Hi Matan, > > On 6/23/20 1:53 PM, Matan Azrad wrote: > > > > > > From: Maxime

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 12:36 PM David Coyle wrote: > A number of approaches to combine DOCSIS Crypto and CRC functions have > been discussed in the DPDK community to date, namely: > 1) adding a new rte_accelerator API, to provide a generic interface for >combining operations of different type

[dpdk-dev] [PATCH v2] net/af_xdp: optimisations to improve packet loss

2020-06-23 Thread Ciara Loftus
This commit makes some changes to the AF_XDP PMD in an effort to improve its packet loss characteristics. 1. In the case of failed transmission due to inability to reserve a tx descriptor, the PMD now pulls from the completion ring, issues a syscall in which the kernel attempts to complete outstan

Re: [dpdk-dev] [PATCH] net/af_xdp: optimisations to improve packet loss

2020-06-23 Thread Loftus, Ciara
> > On Fri, 12 Jun 2020 14:17:46 + > Ciara Loftus wrote: > > > This commit makes some changes to the AF_XDP PMD in an effort to > improve > > its packet loss characteristics. > > > > 1. In the case of failed transmission due to inability to reserve a tx > > descriptor, the PMD now pulls from

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Stephen Hemminger
On Tue, 23 Jun 2020 14:48:54 +0800 Chengchang Tang wrote: > In common practice, PMD configure the rx_buf_size according to the data > room size of the object in mempool. But in fact the final value is related > to the specifications of hw, and its values will affect the number of > fragments in r

Re: [dpdk-dev] [PATCH 0/3] improve MinGW-w64 support

2020-06-23 Thread Thomas Monjalon
22/06/2020 22:51, Kadam, Pallavi: > On 6/20/2020 3:35 PM, Dmitry Kozlyuk wrote: > > Following the discussion on the mailing list [1], clarify MinGW-w64 > > installation process and stop linking with pthread on Windows. > > Make Meson cross-file more general along the way. > > > > [1]: https://mail

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 3:55 PM, Maxime Coquelin wrote: > Hi Matan, > > On 6/23/20 1:53 PM, Matan Azrad wrote: >> >> >> From: Maxime Coquelin: >>> On 6/23/20 11:02 AM, Matan Azrad wrote: From: Maxime Coquelin: > On 6/22/20 5:51 PM, Matan Azrad wrote: >> >> >> From: Maxime Coqu

Re: [dpdk-dev] [PATCH] doc: mark internal symbols in ethdev

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 4:49 PM, Ferruh Yigit wrote: > The APIs are marked in the doxygen comment but better to mark the > symbols too. This is planned for v20.11 release. > > Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH] net/mlx5: fix host physical function representor naming

2020-06-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, June 23, 2020 10:49 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix host physical function representor naming > > The new kernel adds the names like "pf0

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
Hi Matan, On 6/23/20 1:53 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/23/20 11:02 AM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: On 6/22/20 5:51 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 3:43 PM, Matan Azrad wrote: >>> >

Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings

2020-06-23 Thread Ferruh Yigit
On 6/23/2020 2:42 PM, Renata Saiakhova wrote: > Free previously allocated memzone for HW rings > > Signed-off-by: Renata Saiakhova Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation

2020-06-23 Thread Ferruh Yigit
On 6/23/2020 2:42 PM, Renata Saiakhova wrote: > igb and ixgbe and some other drivers allocate HW rings using > rte_eth_dma_zone_reserve(), > which checks first if the memzone exists for a given name, consisting of port > id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id.

[dpdk-dev] [PATCH] doc: mark internal symbols in ethdev

2020-06-23 Thread Ferruh Yigit
The APIs are marked in the doxygen comment but better to mark the symbols too. This is planned for v20.11 release. Signed-off-by: Ferruh Yigit --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel

[dpdk-dev] [PATCH] net/iavf: fix uninitialized variable

2020-06-23 Thread Ferruh Yigit
This is observed with experimental gcc 11, although the older gcc versions don't complain about it, issue seems a valid one. gcc version 11.0.0 20200621 (experimental) (GCC) Build error .../drivers/net/iavf/iavf_ethdev.c: In function ‘iavf_dev_link_update’: .../drivers/net/iavf/iavf_ethdev.c:641:6

[dpdk-dev] [PATCH v5 4/4] drivers/net: fix in em and ice HW rings memory overlap

2020-06-23 Thread Renata Saiakhova
Delete memzones for HW rings in em and ice while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/em_rxtx.c | 2 ++ drivers/net/ice/ice_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 49c53712a..67

[dpdk-dev] [PATCH v5 3/4] drivers/net: fix in i40e HW rings memory overlap

2020-06-23 Thread Renata Saiakhova
Delete memzones for HW rings in i40e while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/i40e/i40e_fdir.c | 3 +++ drivers/net/i40e/i40e_rxtx.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index d59399afe..3a8

[dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings

2020-06-23 Thread Renata Saiakhova
Free previously allocated memzone for HW rings Signed-off-by: Renata Saiakhova --- lib/librte_ethdev/rte_ethdev.c | 30 ++-- lib/librte_ethdev/rte_ethdev_driver.h| 17 ++ lib/librte_ethdev/rte_ethdev_version.map | 7 ++ 3 files changed, 52 inser

[dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation

2020-06-23 Thread Renata Saiakhova
igb and ixgbe and some other drivers allocate HW rings using rte_eth_dma_zone_reserve(), which checks first if the memzone exists for a given name, consisting of port id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id. If the memzone with a given name exists it is returne

[dpdk-dev] [PATCH v5 2/4] drivers/net: fix in igb and ixgbe HW rings memory

2020-06-23 Thread Renata Saiakhova
Delete memzones for HW rings in igb and ixgbe while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/igb_rxtx.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 68

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: enable empty polls in burst stats

2020-06-23 Thread Ali Alnubani
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 5:43 PM > To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Ali Alnubani > ; orgerl...@mellanox.com; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com; jer

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation

2020-06-23 Thread Ali Alnubani
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 5:43 PM > To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Ali Alnubani > ; orgerl...@mellanox.com; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com; jer

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-23 Thread Ali Alnubani
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 5:43 PM > To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Ali Alnubani > ; orgerl...@mellanox.com; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com; jer

[dpdk-dev] [PATCH] drivers/bus/vdev: corrected a typing error in header file

2020-06-23 Thread Muhammad Bilal
Here I have corrected a potential typing mistake in header file. while Uninitalizing the driver the comment was mentioning initializing instead of Uninitalizing in despription of parameter Fixes: d4a586d29e65 ("bus/vdev: move code from EAL into a new driver") Cc: jianfeng@intel.com Signed-of

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread Ananyev, Konstantin
Hi David, > > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > > b/lib/librte_eal/common/eal_common_lcore.c > > > index 86d32a3dd7..7db05428e7 100644 > > > --- a/lib/librte_eal/common/eal_common_lcore.c > > > +++ b/lib/librte_eal/common/eal_common_lcore.c > > > @@ -220,3 +221,38 @@ rte

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 11:14 AM Bruce Richardson wrote: > > On Tue, Jun 23, 2020 at 09:49:18AM +0200, David Marchand wrote: > > Hello Konstantin, > > > > On Mon, Jun 22, 2020 at 5:49 PM Ananyev, Konstantin > > wrote: > > > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > > > b/lib/li

Re: [dpdk-dev] [PATCH v4 1/4] librte_ethdev: Introduce a function to release HW rings

2020-06-23 Thread Ferruh Yigit
On 6/23/2020 10:11 AM, Renata Saiakhova wrote: > Hi Ferruh, > > I added an INTERNAL block in .map file, that gives me an error: > > Build targets in project: 806 > Found ninja-1.8.2 at /usr/bin/ninja > [7/627] Linking target lib/librte_ethdev.so.20.0.3. > FAILED: lib/librte_ethdev.so.20.0.3 > cca

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-23 Thread Bruce Richardson
On Tue, Jun 23, 2020 at 07:28:06AM -0400, Neil Horman wrote: > On Mon, Jun 22, 2020 at 10:39:46PM +0300, Dmitry Kozlyuk wrote: > > On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote: > > > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: > > [snip] > > > > > > 2. How much error-

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
From: Maxime Coquelin: > On 6/23/20 11:02 AM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> On 6/22/20 5:51 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin: > On 6/22/20 3:43 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> Sent: Mond

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-23 Thread Neil Horman
On Mon, Jun 22, 2020 at 10:39:46PM +0300, Dmitry Kozlyuk wrote: > On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote: > > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: > [snip] > > > 1. No standard ELF or COFF module for Python > > > (amount of Python code without libelf on

[dpdk-dev] [PATCH 8/8] crypto/octeontx2: add cryptodev sec dequeue routine

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 37 +++ drivers/crypto/octeontx2/otx2_ipsec_po.h | 30 +++ 2 files changed, 67 insertions(+) diff --git a/drivers/crypto/octeo

[dpdk-dev] [PATCH 7/8] crypto/octeontx2: add cryptodev sec enqueue routine

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.h | 8 + drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 36 +++- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 + drivers/crypto/octeontx2/otx2_ipsec_po_o

[dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- .../octeontx2/otx2_cryptodev_capabilities.c | 108 ++ .../octeontx2/otx2_cryptodev_capabilities.h | 3 + drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 4 +- 3 files changed, 114 insertions(+), 1 deletion(-

[dpdk-dev] [PATCH 6/8] crypto/octeontx2: add cryptodev sec session create

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 466 +- drivers/crypto/octeontx2/otx2_ipsec_po.h | 295 +++ drivers/crypto/octeontx2/otx2_security.h | 9 + drivers/net/octe

[dpdk-dev] [PATCH 3/8] crypto/octeontx2: add cryptodev sec registration

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/Makefile | 1 + drivers/crypto/octeontx2/meson.build | 3 +- drivers/crypto/octeontx2/otx2_cryptodev.c | 12 - drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 46 +

[dpdk-dev] [PATCH 5/8] crypto/octeontx2: add cryptodev sec misc callbacks

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 34 +-- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2

[dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 52 drivers/crypto/octeontx2/otx2_ipsec_po.h | 119 ++ drivers/crypto/octeontx2/otx2_security.h | 2 + drivers/net/octeontx2/otx2_ethdev_sec.h

[dpdk-dev] [PATCH 0/8] add OCTEON TX2 lookaside IPsec support

2020-06-23 Thread Tejasree Kondoj
This series adds lookaside IPsec support in OCTEON TX2 PMD. Features supported: * IPv4 * ESP * Tunnel mode * AES-128/192/256-GCM This series is on top of http://patches.dpdk.org/patch/71638/ Tejasree Kondoj (4): net/octeontx2: move otx2_sec_session struct to otx2_security.h crypto/octeontx2:

[dpdk-dev] [PATCH 1/8] net/octeontx2: move otx2_sec_session struct to otx2_security.h

2020-06-23 Thread Tejasree Kondoj
This patch moves otx2_sec_session structure to otx2_security.h to make it common for inline and lookaside protocol Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_security.h | 21 + drivers/net/octeontx2/otx2_ethdev_sec.c| 1 + drivers/net/octeontx2/ot

Re: [dpdk-dev] [PATCH v2 1/3] examples/packet_ordering: free resources on exit

2020-06-23 Thread Pattan, Reshma
> -Original Message- > From: Sarosh Arif > Sent: Wednesday, June 17, 2020 5:01 AM > To: dev@dpdk.org; Richardson, Bruce ; > Mcnamara, John ; Pattan, Reshma > ; Varghese, Vipin > Cc: Sarosh Arif > Subject: [PATCH v2 1/3] examples/packet_ordering: free resources on exit > > Resources s

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-23 Thread Wang, Xiao W
Hi, The original issue is with legacy QEMU (e.g.QEMUv2.6, with centos7.2 as guest kernel, without set_vring_status as an indicator). For a normal boot, the last 2 messages are set_vring_kick and set_vring_call, inside the set_vring_kick handling, virtio_is_ready() will reture true (because of th

[dpdk-dev] [PATCH v2 6/6] test/security: add DOCSIS capability check tests

2020-06-23 Thread David Coyle
Add unit tests for DOCSIS capabilitity checks. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- app/test/test_security.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 3076

[dpdk-dev] [PATCH v2 5/6] test/crypto: add DOCSIS security test cases

2020-06-23 Thread David Coyle
Add uplink and downlink DOCSIS unit test cases and vectors, to test the combined DOCSIS Crypto-CRC support that has been added to the rte_security and rte_cryptodev libraries. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- app/test/test_cryptodev.c | 552

[dpdk-dev] [PATCH v2 3/6] crypto/aesni_mb: add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Add support to the AESNI-MB PMD for the DOCSIS protocol, through the rte_security API. This, therefore, includes adding support for the rte_security API to this PMD. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- .../crypto/aesni_mb/aesni_mb_pmd_private.h| 19 +- drivers

[dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Introduction This patchset adds support for the DOCSIS protocol to the DPDK Security API (rte_security), to be used by the AESNI-MB and QAT crypto devices to combine and accelerate Crypto and CRC functions of the DOCSIS protocol into a single operation. Performing these functions in

[dpdk-dev] [PATCH v2 4/6] crypto/qat: add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Add support to the QAT SYM PMD for the DOCSIS protocol, through the rte_security API. This, therefore, includes adding support for the rte_security API to this PMD. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- drivers/common/qat/Makefile | 3 + drivers/crypt

[dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Add support for DOCSIS protocol to rte_security library. This support currently comprises the combination of Crypto and CRC operations. A security operation definition is also added. This allow security protocol related parameters be specified at the operation level. For DOCSIS, these parameters i

[dpdk-dev] [PATCH v2 1/6] cryptodev: add security operation to crypto operation

2020-06-23 Thread David Coyle
Add a new security operation field to the crypto operation to allow protocol specific parameters be defined for a crypto operation. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- lib/librte_cryptodev/rte_crypto.h| 19 +-- lib/librte_cryptodev/rte_cryptodev

Re: [dpdk-dev] [PATCH 00/10] net/ice: base code update for 20.08 batch 2

2020-06-23 Thread Yang, Qiming
Reviewed-by: Qiming Yang > -Original Message- > From: Zhang, Qi Z > Sent: Friday, June 19, 2020 12:25 > To: Yang, Qiming > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: RE: [PATCH 00/10] net/ice: base code update for 20.08 batch 2 > > > > > -Original Message- > > From: Yang, Qim

Re: [dpdk-dev] [PATCH v3] net/ice: initialize and update RSS based on user request

2020-06-23 Thread Zhang, Qi Z
> -Original Message- > From: Jiang, JunyuX > Sent: Tuesday, June 23, 2020 4:33 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Su, Simei ; Jiang, JunyuX > > Subject: [PATCH v3] net/ice: initialize and update RSS based on user request > > Initialize and update RSS configure

Re: [dpdk-dev] [PATCH] doc: update softnic documentation

2020-06-23 Thread Singh, Jasvinder
> -Original Message- > From: dev On Behalf Of Jasvinder Singh > Sent: Monday, June 22, 2020 4:47 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] doc: update softnic documentation > > Update traffic management function parameters description and command >

[dpdk-dev] [PATCH v2] app/testpmd: remove softnic forward mode

2020-06-23 Thread Jasvinder Singh
Softnic can be used like other virtual devices without needing any special mode. Therefore, remove softnic mode from testpmd app. Documentation is updated as well. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v2 - merge softnic document update patch app/test-pmd/Makefile

[dpdk-dev] [PATCH v4 1/2] devtools: standardize script arguments

2020-06-23 Thread Ciara Power
This patch modifies the arguments expected by the check-git-log script, to match the format of arguments for the checkpatches script. Both scripts now take certain argument options in the same format, making them easier to use. e.g. Both now take a commit ID range by "-r " The checkpatches help pr

[dpdk-dev] [PATCH v4 0/2] standardize devtools check scripts

2020-06-23 Thread Ciara Power
v4: - Merge doc patch into patch with code changes. - Simplified and reduced documentation and comments. v3: - Fix comments on v2. - Add patch to update contributor's guide. v2: Fix comments on v1. This patchset standardizes the checkpatches and check-git-log scripts to accept the same s

[dpdk-dev] [PATCH v4 2/2] devtools: added stats print

2020-06-23 Thread Ciara Power
When all checks are completed on the specified commit logs, the script indicates if all are valid, or if there were some failures. Signed-off-by: Ciara Power Acked-by: Ferruh Yigit --- v2: Added appropriate exit codes based on failure status. --- devtools/check-git-log.sh | 45

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 9:48 AM, Chengchang Tang wrote: > In common practice, PMD configure the rx_buf_size according to the data > room size of the object in mempool. But in fact the final value is related > to the specifications of hw, and its values will affect the number of > fragments in recieving pkts. >

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-06-23 Thread Pattan, Reshma
From: Sarosh Arif Sent: Tuesday, June 23, 2020 10:19 AM To: dev@dpdk.org; Pattan, Reshma Subject: Re: [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments Hello, This patch has been sitting around for more than 3 weeks. Is there something that needs

  1   2   >