Hi David,
> -----Original Message-----
> From: Coyle, David <david.co...@intel.com>
> Sent: Tuesday, June 23, 2020 11:14 AM
> To: akhil.go...@nxp.com; Doherty, Declan <declan.dohe...@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Trahe, Fiona
> <fiona.tr...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>;
> Ananyev, Konstantin <konstantin.anan...@intel.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh
> <ferruh.yi...@intel.com>; Ryan, Brendan <brendan.r...@intel.com>;
> hemant.agra...@nxp.com; ano...@marvell.com; ruifeng.w...@arm.com;
> lir...@marvell.com; rnagadhee...@marvell.com; jsrika...@marvell.com;
> g.si...@nxp.com; jianjay.z...@huawei.com; ravi1.ku...@amd.com;
> Richardson, Bruce <bruce.richard...@intel.com>; olivier.m...@6wind.com;
> honnappa.nagaraha...@arm.com; step...@networkplumber.org;
> al...@mellanox.com; jer...@marvell.com; Coyle, David
> <david.co...@intel.com>; O'loingsigh, Mairtin <mairtin.oloings...@intel.com>
> Subject: [PATCH v2 5/6] test/crypto: add DOCSIS security test cases
>
> Add uplink and downlink DOCSIS unit test cases and vectors, to test
> the combined DOCSIS Crypto-CRC support that has been added to the
> rte_security and rte_cryptodev libraries.
>
> Signed-off-by: David Coyle <david.co...@intel.com>
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloings...@intel.com>
...
> +static int
> +test_docsis_proto_uplink(int i, struct docsis_test_data *d_td)
> +{
> + struct rte_security_op *sec_op;
> + struct rte_security_docsis_op *doc_op;
> + struct crypto_testsuite_params *ts_params = &testsuite_params;
> + struct crypto_unittest_params *ut_params = &unittest_params;
> + uint8_t *plaintext, *ciphertext;
> + uint8_t *iv_ptr;
> + int cipher_len = 0;
> + int crc_len = 0, crc_data_len;
Minor comment. These "int" should be "unsigned int", as they are not going to
hold a negative value.
> + int ret = TEST_SUCCESS;
