[dpdk-dev] [PATCH v16 1/2] eal: add uuid dependent header files explicitly

2020-06-16 Thread Haiyue Wang
Add the dependent header files explicitly, so that the user just needs to include the 'rte_uuid.h' header file directly to avoid compile error: (1). rte_uuid.h:97:55: error: unknown type name ‘size_t’ (2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’ Fixes: 6bc67c497a51 ("ea

[dpdk-dev] [PATCH v16 2/2] eal: support for VFIO-PCI VF token

2020-06-16 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. Signed-off-by: Haiyue Wang Acked-by: Anatoly Burakov Acked-by: An

[dpdk-dev] [PATCH v16 0/2] support for VFIO-PCI VF token interface

2020-06-16 Thread Haiyue Wang
v16: Rebase the patch for 20.08 release note. v15: Add the missed EXPERIMENTAL warning for API doxgen. v14: Rebase the patch for 20.08 release note. v13: Rename the EAL get VF token function, and leave the freebsd type as empty. v12: support to vfio devices with VF token and no token. v11: Use

Re: [dpdk-dev] rte_log simplification using constructor scheme

2020-06-16 Thread Jerin Jacob
On Tue, Jun 9, 2020 at 1:55 AM Thomas Monjalon wrote: > > 27/05/2020 18:05, Jerin Kollanukkaran: > > +#define RTE_LOG_REGISTER(type, name, level)\ > > +int type; \ > > +RTE_INIT(__##type)

[dpdk-dev] [PATCH v2 1/4] net/ice: add support more PPPoE packet type for switch

2020-06-16 Thread Wei Zhao
This patch add more support for switch parser of pppoe packet, it enable parse tcp/udp L4 layer and ipv4/ipv6 L3 layer parser for pppoe payload, so we can use L4 dst/src port and L3 ip address as input set for switch filter pppoe related rule. Signed-off-by: Wei Zhao --- doc/guides/rel_notes/rel

[dpdk-dev] [PATCH v2 2/4] net/ice: add redirect support for VSI list rule

2020-06-16 Thread Wei Zhao
This patch enable redirect switch rule of vsi list type. Fixes: 397b4b3c5095 ("net/ice: enable flow redirect on switch") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v2 0/4] enable more PPPoE packet type for switch

2020-06-16 Thread Wei Zhao
1. add more support for switch parser of pppoe packet. 2. add redirect support for VSI list rule 3. add check for NVGRE protocol 4. support flow for specific L4 type This patchset is based on: [1] https://patches.dpdk.org/cover/70762/ : net/ice: base code update Depends-on: series-10300 v2: fix

[dpdk-dev] [PATCH v2 4/4] net/ice: support switch flow for specific L4 type

2020-06-16 Thread Wei Zhao
This patch add more specific tunnel type for ipv4/ipv6 packet, it enable tcp/udp layer of ipv4/ipv6 as L4 payload but without L4 dst/src port number as input set for the switch filter rule. Fixes: 47d460d63233 ("net/ice: rework switch filter") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- dri

[dpdk-dev] [PATCH v2 3/4] net/ice: add check for NVGRE protocol

2020-06-16 Thread Wei Zhao
This patch add check for protocol type of IPv4 packet, it need to update tunnel type when NVGRE is in payload. Fixes: 6bc7628c5e0b ("net/ice: change default tunnel type") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 7 ++- 1 file changed, 6 insertion

[dpdk-dev] [PATCH 12/13] drivers/baseband: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- .../baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 17 + drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 18 +- drivers/baseband

[dpdk-dev] [PATCH 13/13] app/test: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- app/test/test_efd.c| 6 +- app/test/test_hash.c | 7 +-- app/test/test_timer_racecond.c | 7 +-- 3 files changed, 3 insertion

[dpdk-dev] [PATCH 08/13] drivers/crypto: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 8 +--- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c| 8 +--- drivers/crypto/caam_jr/caam_jr.c

[dpdk-dev] [PATCH 07/13] drivers/event: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/event/dpaa/dpaa_eventdev.c | 8 +--- drivers/event/dpaa2/dpaa2_eventdev.c | 10 +- drivers/event/octeontx/ssovf_evdev.c | 8 +--- d

[dpdk-dev] [PATCH 11/13] drivers/bus: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/bus/dpaa/dpaa_bus.c | 10 +- drivers/bus/fslmc/fslmc_bus.c| 11 +-- drivers/bus/ifpga/ifpga_bus.c| 9 + drivers/b

[dpdk-dev] [PATCH 09/13] drivers/compress: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/compress/isal/isal_compress_pmd.c | 10 +- drivers/compress/octeontx/otx_zip_pmd.c | 10 +- drivers/compress/zlib/zlib_pmd.c

[dpdk-dev] [PATCH 10/13] drivers/common: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/common/dpaax/dpaax_iova_table.c | 10 +-- drivers/common/iavf/iavf_impl.c | 9 +-- drivers/common/octeontx/octeontx_mbox.c | 9 +-- drivers/c

[dpdk-dev] [PATCH 05/13] drivers/net: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/net/af_packet/rte_eth_af_packet.c | 8 +--- drivers/net/af_xdp/rte_eth_af_xdp.c | 8 +--- drivers/net/ark/ark_ethdev.c | 10 +

[dpdk-dev] [PATCH 06/13] drivers/mempool: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/mempool/dpaa/dpaa_mempool.c | 10 ++ drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 10 +- drivers/mempool/octeontx/octeontx_fpavf.c

[dpdk-dev] [PATCH 02/13] lib: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- lib/librte_bbdev/rte_bbdev.c | 8 +-- lib/librte_bpf/bpf.c | 9 +--- lib/librte_cfgfile/rte_cfgfile.c

[dpdk-dev] [PATCH 04/13] drivers/raw: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 11 +-- drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 11 +-- drivers/raw/ifpga/ifpga_rawdev.c | 10 +

[dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off-by: Jerin Jacob --- lib/librte_eal/include/rte_l

[dpdk-dev] [PATCH 00/13] rte_log registration usage improvement

2020-06-16 Thread jerinj
From: Jerin Jacob This patch series improves the rte_log registration code snippet by avoiding duplication of the code around registration by introducing RTE_LOG_REGISTER macro. Pending stuff ~ I have converted all existing rte_log_register() to new macro, except the following (as it

[dpdk-dev] [PATCH 03/13] drivers/vdpa: use log register macro

2020-06-16 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/vdpa/ifc/ifcvf_vdpa.c | 10 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 7 +++ 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/driv

Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix fdir allocating msix resource error

2020-06-16 Thread Huang, ZhiminX
Tested-by: zhiminx.hu...@intel.com Regards, HuangZhiMin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiang Mao Sent: Tuesday, June 9, 2020 10:26 AM To: Ye, Xiaolong Cc: dev@dpdk.org; sta...@dpdk.org; Jiang, MaoX Subject: [dpdk-dev] [PATCH 2/2] net/i40e: fix f

[dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue

2020-06-16 Thread Ting Xu
When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align. Fixes: 8aa327214c ("table: hash") Cc: sta...@dpdk.org Signed-off-by: Ting Xu --- v1->v2: Correct patch tim

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-06-16 Thread Huang, ZhiminX
Tested-by: zhiminx.hu...@intel.com Regards, HuangZhiMin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiang Mao Sent: Tuesday, June 9, 2020 10:26 AM To: Ye, Xiaolong Cc: dev@dpdk.org; sta...@dpdk.org; Jiang, MaoX Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix bi

[dpdk-dev] [PATCH v2 3/3] examples/skeleton: free resources on exit

2020-06-16 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- v2: initialize portid --- examples/skeleton/basicfwd.c | 41 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/examples/skeleton/basicfwd.c

[dpdk-dev] [PATCH v2 2/3] examples/rxtx_callbacks: free resources on exit

2020-06-16 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- v2: initialize portid --- examples/rxtx_callbacks/main.c | 47 -- 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/examples/rxtx_callbacks/main

[dpdk-dev] [PATCH v2 1/3] examples/packet_ordering: free resources on exit

2020-06-16 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- v2: initialize portid --- examples/packet_ordering/main.c | 57 ++--- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/examples/packet_ordering/ma

Re: [dpdk-dev] [PATCH] net/af_xdp: optimisations to improve packet loss

2020-06-16 Thread Stephen Hemminger
On Fri, 12 Jun 2020 14:17:46 + Ciara Loftus wrote: > This commit makes some changes to the AF_XDP PMD in an effort to improve > its packet loss characteristics. > > 1. In the case of failed transmission due to inability to reserve a tx > descriptor, the PMD now pulls from the completion ring

Re: [dpdk-dev] [PATCH 2/3] net/virtio: add reply-ack support to Virtio-user

2020-06-16 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Thursday, May 28, 2020 3:46 PM > To: dev@dpdk.org; amore...@redhat.com; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 2/3] net/virtio: add reply

Re: [dpdk-dev] [PATCH v8 3/3] timer: support EAL functions on Windows

2020-06-16 Thread Ranjit Menon
On 6/14/2020 1:43 AM, Fady Bader wrote: Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 90

[dpdk-dev] [PATCH v3 0/2] add FD support for GTPU with outer IP on VF and PF

2020-06-16 Thread Junfeng Guo
Add FDir support for MAC_IPV6_GTPU type with outer IP address, teid and qfi fields matching for both VF and PF. Note that outer IP matching fields here includes both SRC & DST of both IPv4 & IPv6. [PATCH v3 1/2] add FD support for GTPU with outer IP on PF [PATCH v3 2/2] add FD support for GTPU wit

[dpdk-dev] [PATCH v3 1/2] net/ice: add FD support for GTPU with outer IP

2020-06-16 Thread Junfeng Guo
Add FDir support for MAC_IPV6_GTPU type with outer IP address, teid and qfi fields matching. Note that outer IP matching fields here includes both SRC & DST of both IPv4 & IPv6. Signed-off-by: Junfeng Guo --- drivers/net/ice/ice_fdir_filter.c | 53 ++ drivers/net/ice

[dpdk-dev] [PATCH v3 2/2] net/iavf: add FD support for GTPU with outer IP

2020-06-16 Thread Junfeng Guo
Add FDir support for MAC_IPV6_GTPU type with outer IP address, teid and qfi fields matching. Note that outer IP matching fields here includes both SRC & DST of both IPv4 & IPv6. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_fdir.c | 18 ++ drivers/net/iavf/iavf_gen

Re: [dpdk-dev] [PATCH] net/af_xdp: optimisations to improve packet loss

2020-06-16 Thread Ye Xiaolong
Hi, Ciara Thanks for the work, really good improvement. On 06/12, Ciara Loftus wrote: >This commit makes some changes to the AF_XDP PMD in an effort to improve >its packet loss characteristics. > >1. In the case of failed transmission due to inability to reserve a tx >descriptor, the PMD now pull

Re: [dpdk-dev] [PATCH] maintainers: update for interrupt subsystem

2020-06-16 Thread Thomas Monjalon
03/06/2020 17:22, Harman Kalra: > updating MAINTAINERS file for interrupt subsytem. > > Signed-off-by: Harman Kalra > --- > +Interrupt Subsystem > +M: Harman Kalra > +F: lib/librte_eal/include/rte_interrupts.h > +F: lib/librte_eal/include/rte_eal_interrupts.h > +F: lib/librte_eal/linux/eal_inter

Re: [dpdk-dev] [PATCH] bus/pci: optimize bus scan

2020-06-16 Thread Thomas Monjalon
10/06/2020 13:50, jer...@marvell.com: > From: Jerin Jacob > > In order to optimize the PCI management, RTE_KDRV_NONE based > device driver probing removed by not adding them to list in > the scan phase. > > The legacy virtio is the only consumer of RTE_KDRV_NONE based device > driver probe schem

Re: [dpdk-dev] MinGW guide

2020-06-16 Thread Dmitry Kozlyuk
On Mon, 15 Jun 2020 09:25:07 + Tal Shnaiderman wrote: > > Subject: Re: MinGW guide > > > > On Sat, 13 Jun 2020 10:55:14 +0200 > > Thomas Monjalon wrote: > > [snip] > > > > Then when installing mingw-w64-install.exe, a choice must be done > > > between threads POSIX or Win32. > > > If I

Re: [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test

2020-06-16 Thread Thomas Monjalon
16/06/2020 22:35, David Christensen: > Thomas Monjalon wrote: > > This script supports only builds from x86 Linux so far. > > This patch is adding cross-compilation of ppc from x86, > > and it works fine. > > Which distro and packages are used for testing? I tried it with Ubuntu > 20.04 but the

Re: [dpdk-dev] [PATCH v8 0/3] eal timer split and implementation for Windows

2020-06-16 Thread Dmitry Kozlyuk
On Sun, 14 Jun 2020 11:43:45 +0300 Fady Bader wrote: > v8: > * fixing error handling issue. > * removed unneded headers. The patchset now needs a trivial rebase to apply. Feel free to propagate my previous Tested-by. -- Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test

2020-06-16 Thread David Christensen
+# ppc configurations +for f in $srcdir/config/ppc/ppc* ; do + build build-$(basename $f | cut -d'-' -f-2) $f $use_shared +done + The entire script file is poorly structured for multi-architecture builds. The script fails on PPC64LE even before your changes: This script supports only bu

Re: [dpdk-dev] Aligning DPDK Link bonding with current standards terminology

2020-06-16 Thread Chas Williams
On 6/16/20 11:45 AM, Stephen Hemminger wrote: > On Tue, 16 Jun 2020 09:52:01 -0400 > Chas Williams <3ch...@gmail.com> wrote: > >> On 6/16/20 7:48 AM, Jay Rolette wrote: >> > On Mon, Jun 15, 2020 at 5:52 PM Stephen Hemminger < >> > step...@networkplumber.org> wrote: >> > >> >> I am distu

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: re-implement commands by using private API

2020-06-16 Thread Kevin Traynor
On 11/06/2020 07:01, Chenxu Di wrote: > The legacy filter API will be superseded. This patch use > private api to change the implementation of commands > global_config gre-key-len and > show port fdir > > Signed-off-by: Chenxu Di > --- > app/test-pmd/cmdline.c | 23 - > app/test-p

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Tasnim Bashar
> From: Thomas Monjalon > Sent: Tuesday, June 16, 2020 12:17 PM > To: dmitry.kozl...@gmail.com; Tasnim Bashar > Cc: dev@dpdk.org; harini.ramakrish...@microsoft.com; > pallavi.ka...@intel.com; ranjit.me...@intel.com; ocard...@microsoft.com; > navas...@linux.microsoft.com; Tal Shnaiderman ; Fady >

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Thomas Monjalon
16/06/2020 20:53, Tasnim Bashar: > > From: Thomas Monjalon > > 02/06/2020 04:00, Tasnim Bashar: > > > Casting thread ID to handle is not accurate way to get thread handle. > > > Need to use OpenThread function to get thread handle from thread ID. > > > > > > pthread_setaffinity_np and pthread_geta

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Tasnim Bashar
> From: Thomas Monjalon > 02/06/2020 04:00, Tasnim Bashar: > > #define pthread_setaffinity_np(thread, size, cpuset) \ > > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > > + eal_set_thread_affinity_mask(thread, cpuset) > > #define pthread_getaffinity_np(thread, size, cpuse

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Tasnim Bashar
> From: Thomas Monjalon > 02/06/2020 04:00, Tasnim Bashar: > > Casting thread ID to handle is not accurate way to get thread handle. > > Need to use OpenThread function to get thread handle from thread ID. > > > > pthread_setaffinity_np and pthread_getaffinity_np functions for > > Windows are affe

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-16 Thread Jerin Jacob
On Tue, Jun 16, 2020 at 3:01 PM Burakov, Anatoly wrote: > > On 15-Jun-20 5:29 PM, Jerin Jacob wrote: > > On Mon, Jun 15, 2020 at 9:15 PM Burakov, Anatoly > > wrote: > >> > >> On 15-Jun-20 4:21 PM, Jerin Jacob wrote: > >>> On Mon, Jun 15, 2020 at 8:35 PM Burakov, Anatoly > >>> wrote: > > >>>

[dpdk-dev] [PATCH] examples/eventdev_pipeline: fix 32-bit coremask logic

2020-06-16 Thread Harry van Haaren
This commit fixes a bug in 32-bit environments when a core mask greater than 32-bits is requested. The fix is to convert the bitmask logic to 64 bits, aligning 64 and 32 bit implementations. Fixes: adb5d548 ("examples/eventdev_pipeline_sw_pmd: add sample app") Cc: sta...@dpdk.org Reported-by: Jun

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-16 Thread Ferruh Yigit
On 6/16/2020 5:23 PM, Matan Azrad wrote: > > > From: Ferruh Yigit >> On 6/16/2020 5:06 PM, Matan Azrad wrote: >>> Hi >>> >>> Ferruh, Raslan >>> >>> This patch is not a fix, we don't need to backport it. >> >> Why not backport it? > > There is no a bug fix. > The behavior will not be changed. >

Re: [dpdk-dev] [PATCH v4 0/4] add new kv hash table

2020-06-16 Thread Thomas Monjalon
Waiting for reviews please. 08/05/2020 21:58, Vladimir Medvedkin: > Currently DPDK has a special implementation of a hash table for > 4 byte keys which is called FBK hash. Unfortunately its main drawback > is that it only supports 2 byte values. > The new implementation called KV hash > supports 4

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-16 Thread Matan Azrad
From: Ferruh Yigit > On 6/16/2020 5:06 PM, Matan Azrad wrote: > > Hi > > > > Ferruh, Raslan > > > > This patch is not a fix, we don't need to backport it. > > Why not backport it? There is no a bug fix. The behavior will not be changed. It is just for comfort. > > I don't think we need fix

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-16 Thread Ferruh Yigit
On 6/16/2020 5:06 PM, Matan Azrad wrote: > Hi > > Ferruh, Raslan > > This patch is not a fix, we don't need to backport it. Why not backport it? > I don't think we need fixes and cc stable here. > > Matan > > From: Raslan Darawsheh >> Hi, >> >>> -Original Message- >>> From: Ferruh Yig

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-16 Thread Thomas Monjalon
05/06/2020 20:35, Stephen Hemminger: > On Thu, 4 Jun 2020 10:17:31 -0700 > Stephen Hemminger wrote: > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > operations are called from a non-EAL thread. > > > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-16 Thread Matan Azrad
Hi Ferruh, Raslan This patch is not a fix, we don't need to backport it. I don't think we need fixes and cc stable here. Matan From: Raslan Darawsheh > Hi, > > > -Original Message- > > From: Ferruh Yigit > > Sent: Tuesday, June 16, 2020 1:28 PM > > To: Dekel Peled ; Matan Azrad > > ;

Re: [dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's

2020-06-16 Thread Thomas Monjalon
28/04/2020 12:28, Bruce Richardson: > On Mon, Apr 27, 2020 at 04:16:21PM -0700, Stephen Hemminger wrote: > > The DPDK API's are lax about checking for undefined flag values. > > This makes it impossible to add new bits to existing API's > > without causing ABI breakage. This means we end up doing u

Re: [dpdk-dev] Aligning DPDK Link bonding with current standards terminology

2020-06-16 Thread Stephen Hemminger
On Tue, 16 Jun 2020 09:52:01 -0400 Chas Williams <3ch...@gmail.com> wrote: > On 6/16/20 7:48 AM, Jay Rolette wrote: > > On Mon, Jun 15, 2020 at 5:52 PM Stephen Hemminger < > > step...@networkplumber.org> wrote: > > > >> I am disturbed by the wide spread use of master/slave in Ethernet

[dpdk-dev] [PATCH] net/bnxt: fix xstats by id

2020-06-16 Thread Ferruh Yigit
The xstat by id device operation seems wrong, it fills 'xstats' struct via 'bnxt_dev_xstats_get_op()' call, but the retrieved values are not transferred to user input 'values' array. ethdev layer 'rte_eth_xstats_get_by_id()' & 'rte_eth_xstats_get_names_by_id' already provides "by id" support when

Re: [dpdk-dev] [PATCH] Fix various typos found by Lintian

2020-06-16 Thread Luca Boccassi
On Tue, 2020-06-16 at 14:44 +0200, Thomas Monjalon wrote: > 26/04/2020 11:49, Luca Boccassi: > > On Sat, 2020-04-25 at 19:47 +0200, Thomas Monjalon wrote: > > > 04/03/2020 16:28, Luca Boccassi: > > > > On Wed, 2020-03-04 at 14:34 +, Kevin Traynor wrote: > > > > > On 29/02/2020 16:37, luca.bocca

Re: [dpdk-dev] 19.11.3 patches review and test

2020-06-16 Thread Govindharajan, Hariprasad
> Hi all, > > Here is a list of patches targeted for stable release 19.11.3. > > The planned date for the final release is the 17th of June. > > Please help with testing and validation of your use cases and report any > issues/results with reply-all to this mail. For the final release the fi

Re: [dpdk-dev] Aligning DPDK Link bonding with current standards terminology

2020-06-16 Thread Chas Williams
On 6/16/20 7:48 AM, Jay Rolette wrote: > On Mon, Jun 15, 2020 at 5:52 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > >> I am disturbed by the wide spread use of master/slave in Ethernet bonding. >> Asked the current IEEE chairs and it looks like it is already fixed >> "upstream

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 16, 2020 1:28 PM > To: Dekel Peled ; Matan Azrad > ; Slava Ovsiienko ; > Raslan Darawsheh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct > location > > On 6/10/2020 2:25 P

[dpdk-dev] [PATCH 1/2] crypto/octeontx2: discover capabilities

2020-06-16 Thread Anoob Joseph
From: Tejasree Kondoj Populate capabilities based on device features. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/octeontx2/otx2_mbox.h | 33 + drivers/crypto/octeontx2/otx2_cryptodev.c | 7 + drivers/crypto/octeontx2/otx2_cryptodev.h |

[dpdk-dev] [PATCH 2/2] crypto/octeontx2: add ChaCha20-Poly1305 support

2020-06-16 Thread Anoob Joseph
From: Tejasree Kondoj Add ChaCha20-Poly1305 AEAD algorithm support in crypto_octeontx2 PMD Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/features/octeontx2.ini | 7 ++-- doc/guides/cryptodevs/octeontx2.rst | 1 + doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time

2020-06-16 Thread Thomas Monjalon
Konstantin, Honnappa, Any update about a fix for compilation time please? 30/04/2020 12:23, Thomas Monjalon: > 30/04/2020 03:56, Honnappa Nagarahalli: > > test_ring.c takes lot of time to compile with clang. It is > > reproducable with compiler version 8.0 on Ubuntu 18.04. > > Amount of testing i

Re: [dpdk-dev] [PATCH] Fix various typos found by Lintian

2020-06-16 Thread Thomas Monjalon
26/04/2020 11:49, Luca Boccassi: > On Sat, 2020-04-25 at 19:47 +0200, Thomas Monjalon wrote: > > 04/03/2020 16:28, Luca Boccassi: > > > On Wed, 2020-03-04 at 14:34 +, Kevin Traynor wrote: > > > > On 29/02/2020 16:37, luca.bocca...@gmail.com wrote: > > > > > Debian's linter is getting more and

Re: [dpdk-dev] [PATCH v10 0/6] implement common bit operation APIs

2020-06-16 Thread Thomas Monjalon
27/04/2020 09:58, Joyce Kong: > Joyce Kong (6): > lib/eal: implement the family of common bit operation APIs > test/bitops: add bit operation test case > net/axgbe: use common rte bit operation APIs instead > net/bnx2x: use common rte bit operation APIs instead > net/qede: use common rte

Re: [dpdk-dev] [PATCH v10 6/6] net/hinic: use common rte bit operation APIs instead

2020-06-16 Thread Thomas Monjalon
27/04/2020 09:58, Joyce Kong: > Remove its own bit operation APIs and use the common one, > this can reduce the code duplication largely. > > Signed-off-by: Joyce Kong > Reviewed-by: Gavin Hu > --- > --- a/drivers/net/hinic/Makefile > +++ b/drivers/net/hinic/Makefile > +CFLAGS += -DALLOW_EXPERIM

Re: [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions

2020-06-16 Thread Singh, Jasvinder
> -Original Message- > From: Hrvoje Habjanic > Sent: Monday, June 15, 2020 6:19 PM > To: Dumitrescu, Cristian ; Singh, Jasvinder > > Cc: dev@dpdk.org > Subject: [PATCH] rte_sched: fix 64-bit support in rate functions > > Functions rte_sched_subport_config_pipe_profile_table and > pipe

Re: [dpdk-dev] Aligning DPDK Link bonding with current standards terminology

2020-06-16 Thread Jay Rolette
On Mon, Jun 15, 2020 at 5:52 PM Stephen Hemminger < step...@networkplumber.org> wrote: > I am disturbed by the wide spread use of master/slave in Ethernet bonding. > Asked the current IEEE chairs and it looks like it is already fixed > "upstream". > > The proper terminology is for Ethernet link ag

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-16 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> -Original Message- > From: Sunil Kumar Kori > Sent: Wednesday, June 10, 2020 12:01 PM > To: Muhammad Bilal > Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > Bhagavatula ; dev@dpdk.org; Jakub Grajciar -X > (jgrajcia - PANTHEON TECH SRO at Cisco) ; > vipin.var

Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf

2020-06-16 Thread Thomas Monjalon
16/06/2020 11:26, Dmitry Kozlyuk: > Thomas Monjalon wrote: > > 16/06/2020 10:33, Tal Shnaiderman: > > > > 01/06/2020 11:38, tal...@mellanox.com: > > > > > From: Tal Shnaiderman > > > > > > > > > > Export needed eal functions used by the lib. > > > > > > > > > > Signed-off-by: Tal Shnaiderman >

[dpdk-dev] [Bug 357] ppc64: i40e not compiling on RHEL7/CentOS7

2020-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=357 Kevin Traynor (kevu...@gmail.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UNCON

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-16 Thread Sunil Kumar Kori
>-Original Message- >From: Muhammad Bilal >Sent: Tuesday, June 16, 2020 3:44 PM >To: Sunil Kumar Kori >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh >Bhagavatula ; dev@dpdk.org; >jgraj...@cisco.com; vipin.vargh...@intel.com >Subject: Re: [EXT] [PATCH 1/5] exampl

Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-16 Thread Ferruh Yigit
On 6/10/2020 2:25 PM, Dekel Peled wrote: > Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just > above function flow_dv_validate_item_gtp(), where it is used. > > Patch was applied together with other patches which modified the same > file, so the mask was located further away from

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-16 Thread Muhammad Bilal
On Tue, Jun 16, 2020 at 10:53 AM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Muhammad Bilal > >Sent: Monday, June 15, 2020 5:30 PM > >To: Sunil Kumar Kori > >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > >Bhagavatula ; dev@dpdk.org; > >jgraj...@c

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2020-06-16 Thread Chas Williams
Acked-by: Chas Williams On 6/16/20 5:46 AM, David Marchand wrote: Caught by code review, rte_eth_dev_socket_id() returns -1 on error. The code should behave the same, but still, do not use LCORE_ID_ANY for something that is not a lcore id. Fixes: c15c5897340d ("net/bonding: avoid allocating me

Re: [dpdk-dev] Aligning DPDK Link bonding with current standards terminology

2020-06-16 Thread Chas Williams
On 6/15/20 6:52 PM, Stephen Hemminger wrote: > I am disturbed by the wide spread use of master/slave in Ethernet bonding. > Asked the current IEEE chairs and it looks like it is already fixed "upstream". > > The proper terminology is for Ethernet link aggregation in the > the current standard

Re: [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix non-EAL thread support

2020-06-16 Thread Liron Himi
Acked-by: Liron Himi -Original Message- From: David Marchand Sent: Tuesday, 16 June 2020 12:47 To: dev@dpdk.org Cc: sta...@dpdk.org; Liron Himi ; Natalie Samsonov Subject: [EXT] [PATCH] net/mvpp2: fix non-EAL thread support External Email --

[dpdk-dev] [PATCH] net/mvpp2: fix non-EAL thread support

2020-06-16 Thread David Marchand
Caught by code inspection, for a non-EAL thread identified with rte_lcore_id() == LCORE_ID_ANY, the code currently arbitrarily uses lcore 0 while there is no guarantee this lcore is used. Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation") Cc: sta...@dpdk.org Signed-off-by: David Marchan

[dpdk-dev] [PATCH] net/bonding: fix socket id check

2020-06-16 Thread David Marchand
Caught by code review, rte_eth_dev_socket_id() returns -1 on error. The code should behave the same, but still, do not use LCORE_ID_ANY for something that is not a lcore id. Fixes: c15c5897340d ("net/bonding: avoid allocating mempool on unknown socket") Cc: sta...@dpdk.org Signed-off-by: David Ma

[dpdk-dev] [PATCH v1 3/4] net/mlx5: add MR callbacks in per-device cache

2020-06-16 Thread Ophir Munk
Prior to this commit MR operations were verbs based and hard coded under common/mlx5/linux directory. This commit enables upper layers (e.g. net/mlx5) to determine which MR operations to use. For example the net layer could set devx based MR operations in non-Linux environments. The reg_mr and dere

[dpdk-dev] [PATCH v1 4/4] mlx5/linux: add MR callbacks to verbs operations struct

2020-06-16 Thread Ophir Munk
Create a set of verbs callbacks in 'struct mlx5_verbs_ops' and add MR operations to it (file net/mlx5/linux/mlx5_verbs.c). Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/Makefile | 1 + drivers/net/mlx5/linux/meson.build | 1 + drivers/net/mlx5/linux/mlx5_os.c

[dpdk-dev] [PATCH v1 2/4] common/mlx5: export MR verbs operations

2020-06-16 Thread Ophir Munk
The glue verbs operations reg_mr and dereg_mr are wrapped and exported in functions mlx5_common_verbs_reg_mr and mlx5_common_verbs_dereg_mr respectively. The exported functions are added to a new file linux/mlx5_common_verbs.c. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common

[dpdk-dev] [PATCH v1 1/4] common/mlx5: remove MR struct dependency on ibv

2020-06-16 Thread Ophir Munk
Replace 'struct ibv_mr *' (in 'struct mlx5_mr') with a new 'struct mlx5_pmd_mr'. The new struct contains the required MR field: lkey, addr, len and is independent of ibv. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c | 60 -

[dpdk-dev] [PATCH v1 0/4] mlx5 MR refactor

2020-06-16 Thread Ophir Munk
This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. This series handles memory region refactoring. Ophir Munk (4): common/mlx5: remove MR struct dependency on ibv common/mlx5: export MR verbs operations net/mlx5: add MR callbacks in per-device cache mlx5/

[dpdk-dev] [PATCH v2 1/2] net/ice: add FD support for GTPU with outer IP

2020-06-16 Thread Junfeng Guo
Add FDir support for MAC_IPV6_GTPU type with outer IP address, teid and qfi fields matching. Note that outer IP matching fields here includes both SRC & DST of both IPv4 & IPv6. Signed-off-by: Junfeng Guo --- drivers/net/ice/ice_fdir_filter.c | 54 ++ drivers/net/ice

[dpdk-dev] [PATCH v2 0/2] add FD support for GTPU with outer IP on PF and VF

2020-06-16 Thread Junfeng Guo
This series contains adding FD support for GTPU with outer IP and IPv6 on both PF and VF. [PATCH v2 1/2] add FD support for GTPU with outer IP on PF. [PATCH v2 2/2] add FD support for GTPU with outer IP on VF. v2: * Fix minor cover letter commit log issue. Junfeng Guo (2): net/ice: add FD supp

[dpdk-dev] [PATCH v2 2/2] net/iavf: add FD support for GTPU with outer IP

2020-06-16 Thread Junfeng Guo
Add FDir support for MAC_IPV6_GTPU type with outer IP address, teid and qfi fields matching. Note that outer IP matching fields here includes both SRC & DST of both IPv4 & IPv6. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_fdir.c | 22 ++ drivers/net/iavf/iavf

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-16 Thread Burakov, Anatoly
On 15-Jun-20 5:29 PM, Jerin Jacob wrote: On Mon, Jun 15, 2020 at 9:15 PM Burakov, Anatoly wrote: On 15-Jun-20 4:21 PM, Jerin Jacob wrote: On Mon, Jun 15, 2020 at 8:35 PM Burakov, Anatoly wrote: On 15-Jun-20 12:43 PM, Jerin Jacob wrote: On Mon, Jun 15, 2020 at 5:02 PM Burakov, Anatoly wro

Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf

2020-06-16 Thread Dmitry Kozlyuk
On Tue, 16 Jun 2020 10:45:49 +0200 Thomas Monjalon wrote: > 16/06/2020 10:33, Tal Shnaiderman: > > > 01/06/2020 11:38, tal...@mellanox.com: > > > > From: Tal Shnaiderman > > > > > > > > Export needed eal functions used by the lib. > > > > > > > > Signed-off-by: Tal Shnaiderman > > > > --- > >

Re: [dpdk-dev] [PATCH v5 6/8] drivers: fix incorrect meson import folder for Windows

2020-06-16 Thread Bruce Richardson
On Tue, Jun 09, 2020 at 01:31:37PM +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > import library (/IMPLIB) in meson.build should use > the 'drivers' and not 'libs' folder. > > The error is: fatal error LNK1149: output filename matches input filename. > The fix uses the correct fol

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-06-16 Thread Thomas Monjalon
10/06/2020 14:00, Fady Bader: > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2020 Mellanox Technologies, Ltd > + */ Isn't it a different copyright? Where does it come from? > + > +#ifndef _IN_H_ > +#define _IN_H_ > + > +#define IPPROTO_IP 0 > +#define IPPROTO_HOPOPTS 0 > +#define

Re: [dpdk-dev] [PATCH v8 3/3] timer: support EAL functions on Windows

2020-06-16 Thread Thomas Monjalon
14/06/2020 10:43, Fady Bader: > Implemented the needed Windows eal timer functions. > > Signed-off-by: Fady Bader I think there were some acks and tested flags from previous versions but they are not reported here. It is blocking the merge.

Re: [dpdk-dev] [PATCH v8 0/3] eal timer split and implementation for Windows

2020-06-16 Thread Thomas Monjalon
14/06/2020 10:43, Fady Bader: > This patchset splits OS dependent EAL timer functions and implements them for > windows. > > v2: > * fixing styles and correctness errors. > v3: > * fixing correctness, get_tsc_freq was reimplemented. > v4: > * rebasing to the new version of "Windows ba

Re: [dpdk-dev] [PATCH v5 1/8] eal: move OS common functions to single file

2020-06-16 Thread David Marchand
On Tue, Jun 9, 2020 at 12:32 PM wrote: > > From: Tal Shnaiderman > > Move common functions between Unix and Windows to eal_common_config.c. > > Those simple functions are getter functions for IOVA, > configuration, Multi-process. > > Move rte_config and runtime_dir to be defined in a common file.

Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf

2020-06-16 Thread Thomas Monjalon
16/06/2020 10:33, Tal Shnaiderman: > > 01/06/2020 11:38, tal...@mellanox.com: > > > From: Tal Shnaiderman > > > > > > Export needed eal functions used by the lib. > > > > > > Signed-off-by: Tal Shnaiderman > > > --- > > > --- a/lib/librte_eal/rte_eal_exports.def > > > +++ b/lib/librte_eal/rte_eal

Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf

2020-06-16 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf > > 01/06/2020 11:38, tal...@mellanox.com: > > From: Tal Shnaiderman > > > > Export needed eal functions used by the lib. > > > > Signed-off-by: Tal Shnaiderman > > --- > > --- a/lib/librte_eal/rte_eal_exports.def > > ++

Re: [dpdk-dev] [PATCH v5 6/8] drivers: fix incorrect meson import folder for Windows

2020-06-16 Thread Thomas Monjalon
Bruce, please could you review this patch? 09/06/2020 12:31, tal...@mellanox.com: > From: Tal Shnaiderman > > import library (/IMPLIB) in meson.build should use > the 'drivers' and not 'libs' folder. > > The error is: fatal error LNK1149: output filename matches input filename. > The fix uses

  1   2   >