Acked-by: Liron Himi <lir...@marvell.com>
-----Original Message-----
From: David Marchand <david.march...@redhat.com>
Sent: Tuesday, 16 June 2020 12:47
To: dev@dpdk.org
Cc: sta...@dpdk.org; Liron Himi <lir...@marvell.com>; Natalie Samsonov
<nsams...@marvell.com>
Subject: [EXT] [PATCH] net/mvpp2: fix non-EAL thread support
External Email
----------------------------------------------------------------------
Caught by code inspection, for a non-EAL thread identified with
rte_lcore_id() == LCORE_ID_ANY, the code currently arbitrarily uses lcore 0
while there is no guarantee this lcore is used.
Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand <david.march...@redhat.com>
---
drivers/net/mvpp2/mrvl_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index b98b1fd667..9037274327 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -816,7 +816,7 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)
unsigned int core_id = rte_lcore_id();
if (core_id == LCORE_ID_ANY)
- core_id = 0;
+ core_id = rte_get_master_lcore();
hif = mrvl_get_hif(priv, core_id);
@@ -1620,7 +1620,7 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)
core_id = rte_lcore_id();
if (core_id == LCORE_ID_ANY)
- core_id = 0;
+ core_id = rte_get_master_lcore();
hif = mrvl_get_hif(rxq->priv, core_id);
if (!hif)
@@ -1770,7 +1770,7 @@ mrvl_rx_queue_release(void *rxq)
unsigned int core_id = rte_lcore_id();
if (core_id == LCORE_ID_ANY)
- core_id = 0;
+ core_id = rte_get_master_lcore();
if (!q)
return;
--
2.23.0
