+# ppc configurations
+for f in $srcdir/config/ppc/ppc* ; do
+       build build-$(basename $f | cut -d'-' -f-2) $f $use_shared
+done
+

The entire script file is poorly structured for multi-architecture
builds.  The script fails on PPC64LE even before your changes:

This script supports only builds from x86 Linux so far.
This patch is adding cross-compilation of ppc from x86,
and it works fine.

Which distro and packages are used for testing? I tried it with Ubuntu 20.04 but the cross-compiler is named differently (powerpc64le-linux-gnu-gcc instead of powerpc64le-linux-gcc).

I think the logic of looping through supported configs for test builds
is the right one, but more changes are required for multi-architecture
support in this script.  For now I'd abandon the PPC/ARM support
entirely in this script.

I am adding PPC compilation check to avoid having PPC broken,
because after asking for many years to IBM execs,
there is still no PPC CI integrated in DPDK patchwork.
If you don't think this small step is going in the right direction,
then I will stop bothering about PPC support,
and we should probably completely drop PPC support I guess.

Sorry, I didn't understand the context behind the change request nor how the script is used. I appreciate the effort behind the change and would like to help where I can.

Dave

Reply via email to