[dpdk-dev] [PATCH 1/2] net/qede: add flush support to rte flow ops

2020-04-24 Thread Rasesh Mody
This patch adds suppot to flush the RTE FLOWs. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_filter.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c index b7ad59ad6..

[dpdk-dev] [PATCH 2/2] net/qede: add support for get FW version

2020-04-24 Thread Rasesh Mody
Add support for get firmware version operation. Get and dump multi boot image (MBI) version as part of get firmware version string along with Management fimrware (MFW) version. Use qede_fw_version_get() for PMD info logs. Signed-off-by: Yash Sharma Signed-off-by: Rasesh Mody Signed-off-by: Igor

[dpdk-dev] [PATCH v6 4/6] devtools: ignore internal ABI check

2020-04-24 Thread Haiyue Wang
Ignore the internal version ABI check, this kind of ABI is used only by drivers and libraries. Signed-off-by: Haiyue Wang --- devtools/libabigail.abignore | 5 + 1 file changed, 5 insertions(+) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 1911890a7..986a527

[dpdk-dev] [PATCH v6 1/6] eal: add internal ABI tag definition

2020-04-24 Thread Haiyue Wang
Introduce the __rte_internal tag to mark internal ABI function which is used only by the drivers or other libraries. Signed-off-by: Haiyue Wang --- lib/librte_eal/include/rte_compat.h | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/include/rte_compat.h b/lib/li

[dpdk-dev] [PATCH v6 2/6] build: enable internal API tag

2020-04-24 Thread Haiyue Wang
Allow the drivers and libraries to use the internal tag for marking internal ABI symbols. Signed-off-by: Haiyue Wang --- drivers/meson.build | 5 - lib/meson.build | 5 - mk/target/generic/rte.vars.mk | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v6 0/6] dpdk: introduce __rte_internal tag

2020-04-24 Thread Haiyue Wang
Move the internal function into INTERNAL session to avoid the ABI checking, and it is only used for DPDK drivers or related library. __rte_internal funA INTERNAL { global: funA }; v6: split into small patches, and add the missed handling. v5: add the checkpatch for __rt

[dpdk-dev] [PATCH v6 3/6] mk: add internal tag check

2020-04-24 Thread Haiyue Wang
Add checks during build to ensure that all symbols in the INTERNAL version map section have __internal tags on their definitions, and enable the warnings needed to announce their use. Signed-off-by: Haiyue Wang --- ...-experimental-syms.sh => check-symbols.sh} | 31 +++ mk/intern

[dpdk-dev] [PATCH v6 5/6] devtools: exempt internal ABI checking

2020-04-24 Thread Haiyue Wang
No need to restrict the ABI on symbols that are only used by core libraries. Signed-off-by: Haiyue Wang --- devtools/check-symbol-change.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index ed2178e36..7b6d5f40f 100

[dpdk-dev] [PATCH v6 6/6] devtools: enforce internal tag at the beginning

2020-04-24 Thread Haiyue Wang
Move the internal tag on a separate line and make it the first thing of function prototypes. Signed-off-by: Haiyue Wang --- devtools/checkpatches.sh | 39 +++ 1 file changed, 39 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh in

Re: [dpdk-dev] [PATCH v5 1/1] eal: add internal ABI marking support

2020-04-24 Thread Wang, Haiyue
Hi David, Try to fix the issues you mentioned, except below, plan to another patch set, I need more time to test these adding. We are missing updates on devtools/check-abi-version.sh and devtools/update_version_map_abi.py. More importantly on this file: - drivers/meson.build is not update

[dpdk-dev] [PATCH 2/5] net/bnxt: action record external pool updates

2020-04-24 Thread Venkat Duvvuru
From: Farah Smith - Added support variable sized action records - Additional error checking on table scope params - Single external pool supported per direction - Changed to return action record pointer - Allows action pool to fully utilize the number of flows Signed-off-by: Farah Smith Signed-

[dpdk-dev] [PATCH 5/5] net/bnxt: ulp must set hw flow cache timer when allocating table scope

2020-04-24 Thread Venkat Duvvuru
From: Mike Baucom The tf_alloc_tbl_scope API now accepts a timer interval for flushing the hw flow cache. The flush timer is necessary in order to refresh the flow table. Signed-off-by: Mike Baucom Reviewed-by: Venkat Duvvuru --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 6 ++ 1 file changed,

[dpdk-dev] [PATCH 4/5] net/bnxt: add truflow flush-timer to alloc table scope API

2020-04-24 Thread Venkat Duvvuru
From: Shahaji Bhosle Updated the params list to include flush timer, this will allow users to set the HW flush timer value in 10th of second. Setting 0 will disable the pending cache flush feature. Signed-off-by: Shahaji Bhosle Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Revie

[dpdk-dev] [PATCH 1/5] net/bnxt: reserve a flowdb resource function as invalid

2020-04-24 Thread Venkat Duvvuru
From: Mike Baucom The resource function did not have a method of invalidating or indicating that a resource is uninitialized. Added an invalid enum so that processing works correctly for partially added flows. Signed-off-by: Mike Baucom Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Kumar

[dpdk-dev] [PATCH 3/5] net/bnxt: ulp modifications for handling actions/index tables

2020-04-24 Thread Venkat Duvvuru
From: Mike Baucom The ulp required changes to properly call the index table management routines and use the index for external memory indices. The ulp no longer has to account for stride as the tf_core returns the actual offset, not a 0 based index. Signed-off-by: Mike Baucom Reviewed-by: Kish

[dpdk-dev] [PATCH 0/5] introduce changes to support flow scaling

2020-04-24 Thread Venkat Duvvuru
This patchset introduces changes to the action record allocation, flow database entry deletion, and hw flow cache updates. Action record allocation now allows the actions to scale with the flows. Additionally, resources attached to a flow database entry are now correctly released when the critical

[dpdk-dev] [PATCH 1/2] net/tap: simplify netlink send/receive functions

2020-04-24 Thread Stephen Hemminger
The tap_nl_recv() function does not need to use the full complex recvmsg() system call, basic recv() will work here. Ditto for tap_nl_send() full sendmsg is not needed. Add logic to retry in case EINTR rather than forcing error handling back in driver or worse to ethdev API. Signed-off-by: Steph

[dpdk-dev] [PATCH 0/2] net/tap: simplfication and servicabilty improvements

2020-04-24 Thread Stephen Hemminger
These are a couple of small fixes to the TAP driver. The first makes it more robust to random signals, and the second one adds better error reporting. Stephen Hemminger (2): net/tap: simplify netlink send/receive functions net/tap: use netlink extended ack support drivers/net/tap/tap_netlink

[dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support

2020-04-24 Thread Stephen Hemminger
In recent Linux kernels, there is support for extended acknowledgement to netlink messages. This is quite useful for diagnosing errors in configuration in the kernel with TAP. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_netlink.c | 78 +++ 1 file chan

Re: [dpdk-dev] [PATCH 2/2] timer: support EAL functions on Windows

2020-04-24 Thread Dmitry Kozlyuk
On 2020-04-23 17:43 GMT+0300 Fady Bader wrote: > +uint64_t > +get_tsc_freq(void) > +{ > + uint64_t tsc_freq; > + LARGE_INTEGER Frequency; > + > + QueryPerformanceFrequency(&Frequency); > + /* > + QueryPerformanceFrequency output is in khz. > + Mulitply by 1K to obtain the tr

Re: [dpdk-dev] [PATCH v4 00/18] update and simplify telemetry library.

2020-04-24 Thread Wiles, Keith
> On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: > > v4: > - Internal representation now uses generic data format instead of JSON. > - Help command added to provide help text for a command. > > v3: > - Removed rte_option as it is no longer used. > - General cleanup. > > v2: > - Added

Re: [dpdk-dev] [PATCH v4 13/18] telemetry: introduce telemetry backward compatibility

2020-04-24 Thread Wiles, Keith
> On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: > > The new telemetry will now open a socket using the old telemetry path, > to ensure backward compatibility. This is not yet initialised, as it > would clash with the existing telemetry, to be removed in a later patch. > This means that both

Re: [dpdk-dev] [PATCH v4 06/18] telemetry: introduce new telemetry functionality

2020-04-24 Thread Wiles, Keith
> On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: > > From: Bruce Richardson > > This patch introduces a new telemetry connection socket and handling > functionality. Like the existing telemetry implementation (which is > unaffected by this change) it uses a unix socket, but unlike the > ex

Re: [dpdk-dev] [PATCH v1] examples/l2fwd: add check for promiscuous no support

2020-04-24 Thread David Marchand
On Wed, Feb 26, 2020 at 2:46 PM Ye Xiaolong wrote: > On 02/26, David Marchand wrote: > >On Wed, Feb 26, 2020 at 10:15 AM Sivaprasad Tummala > > wrote: > >> > >> l2fwd application exits, if return for rte_eth_promiscuous_enable > >> is not success. But for vHost PMD, promiscuous enable returns "Not

Re: [dpdk-dev] [PATCH v2 1/4] ring: future proof flag settings

2020-04-24 Thread Stephen Hemminger
On Fri, 24 Apr 2020 18:07:15 + Honnappa Nagarahalli wrote: > > > > > > All API's should check that they support the flag values passed. > > These checks ensure that the extra bits can safely be used without risk of > > ABI > > breakage. > > > > Signed-off-by: Stephen Hemminger > > --- >

Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation

2020-04-24 Thread Thomas Monjalon
Please Somnath, it is waiting for a v2. 26/02/2020 01:55, Stephen Hemminger: > On Fri, 7 Feb 2020 15:29:59 +0100 > Olivier Matz wrote: > > > The meaning of each flag should be as simple as possible, I think we can > > summarize them like this: > > > > - PKT_RX_VLAN: the vlan is saved in vlan t

Re: [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation

2020-04-24 Thread Ajit Khaparde
On Fri, Apr 24, 2020 at 4:04 AM Somnath Kotur wrote: > Max Rx Ring count could be < Max stat contexts. While accounting > for stat contexts, this should be also considered and > the max ring count adjusted accordingly. > > Fixes: f03e66cb64ce ("net/bnxt: limit queue count for NS3/Stingray > devic

Re: [dpdk-dev] [PATCH v2 1/4] ring: future proof flag settings

2020-04-24 Thread Honnappa Nagarahalli
> > All API's should check that they support the flag values passed. > These checks ensure that the extra bits can safely be used without risk of ABI > breakage. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_ring/rte_ring.c | 10 ++ > 1 file changed, 10 insertions(+) > > di

Re: [dpdk-dev] [PATCH] eal: fix build on armv7

2020-04-24 Thread David Marchand
On Thu, Apr 23, 2020 at 4:25 PM David Marchand wrote: > > Caught by OBS on armv7: > > In file included from .../lib/librte_eal/include/rte_string_fns.h:21, > from .../lib/librte_kvargs/rte_kvargs.c:9: > .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', > ';

[dpdk-dev] [PATCH] net/bnxt: disable vector mode if flow mark is used

2020-04-24 Thread Stephen Hemminger
Since vector mode can't be used with flow mark actions. The choice of vector or non-vector mode is done dynamically earlier in the initialization process (config) and the user application has no direct control over the selection. Therefore the best resolution to the conflict is for the driver to d

Re: [dpdk-dev] [PATCH v6] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread David Marchand
On Fri, Apr 24, 2020 at 3:19 PM Li Feng wrote: > > Currently, even though memory is mapped with PROT_NONE, this does not > cause it to be excluded from core dumps. This is counter-productive, > because in a lot of cases, this memory will go unused (e.g. when the > memory subsystem preallocates VA

[dpdk-dev] [PATCH] bus/pci: pcidev access from secondary process

2020-04-24 Thread Vijaya Mohan Guvva
For pci devices presented through igb_uio, pcidev->mem_resource[] is not populated when the device is initialized for secondary process. Initialize pcidev->mem_resource[] with pci-bar mapped addresses. Fixes: c752998b (pci: introduce library and driver) Cc: sta...@dpdk.org Signed-off-by: Vijaya

Re: [dpdk-dev] [PATCH v4] lpm: skip table entries update if rules found

2020-04-24 Thread Thomas Monjalon
21/04/2020 17:44, Medvedkin, Vladimir: > Hi Yangchao, > > Thanks for the patch. > This might be useful for control plane implementations that don't track > inserted routes. > I have just a one nit inlined below. Also, could you do the same for lpm6? > > P.S. Please have a look at rte_fib library

[dpdk-dev] [PATCH v2 2/4] hash: check flags on creation

2020-04-24 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_hash/rte_cuckoo_hash.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_hash/rte_

[dpdk-dev] [PATCH v2 0/4] enforce checking on flag values in API's

2020-04-24 Thread Stephen Hemminger
Since the DPDK api's are lazy about checking for flag values it means the flags can never be extended in future releases without causing ABI breakage. This means we end up doing unnecessary symbol versioning just to work around applications that might pass in naughty bits. This is the DPDK analog

[dpdk-dev] [PATCH v2 1/4] ring: future proof flag settings

2020-04-24 Thread Stephen Hemminger
All API's should check that they support the flag values passed. These checks ensure that the extra bits can safely be used without risk of ABI breakage. Signed-off-by: Stephen Hemminger --- lib/librte_ring/rte_ring.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_rin

[dpdk-dev] [PATCH v2 4/4] cfgfile: check flags value

2020-04-24 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/rte_cfgfile.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_cfgfile/rte_cfg

[dpdk-dev] [PATCH v2 3/4] stack: check flags on creation

2020-04-24 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_stack/rte_stack.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_stack/rte_stack.c

Re: [dpdk-dev] [PATCH] mem: mark pages as not accessed when returning back to memory pool

2020-04-24 Thread David Marchand
On Fri, Apr 24, 2020 at 12:43 PM Li Feng wrote: > > Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA") > has mapped the initialized memory with PROT_NONE, and when it's unmapped, > eal_memalloc.c should remmap the anonymous memory with PROT_NONE too. > > Signed-off-by: Li Fe

Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

2020-04-24 Thread Thomas Monjalon
08/04/2020 15:11, Bruce Richardson: > On Wed, Apr 08, 2020 at 03:07:30PM +0200, Alex Kiselev wrote: > > rte_lpm6: fix incorrect size of tbl8 group > > Fixes: e480688dce6d ("lpm6: add incremental update on delete") > > > > Signed-off-by: Alex Kiselev > > --- > Acked-by: Bruce Richardson Applied,

Re: [dpdk-dev] [PATCH v3] app/testpmd: add parsing for QINQ VLAN headers

2020-04-24 Thread Ferruh Yigit
On 4/23/2020 10:05 AM, Raslan Darawsheh wrote: > When having QINQ VLAN headers in the packet, parse_ethernet > is cabable of parsing only the first vlan. > > add parsing for QINQ VLAN headers in the packet. > > Fixes: 51f694dd40f5 ("app/testpmd: rework checksum forward engine") > Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v2] eal: fix spelling errors

2020-04-24 Thread Thomas Monjalon
10/03/2020 17:35, Stephen Hemminger: > Fix spelling errors in comments (found with codespell). > > Note that "inbetween" is not correct in English and should > either be two words or better yet, the in can be dropped. > https://www.grammarly.com/blog/in-between-or-inbetween/ > > Signed-off-by: St

Re: [dpdk-dev] [PATCH] app/testpmd: support flow aging

2020-04-24 Thread Ferruh Yigit
On 4/24/2020 11:55 AM, Bill Zhou wrote: > Currently, there is no way to check the aging event or to get the current > aged flows in testpmd, this patch include those implements, it's included: > - Registering aging event based on verbose level, when set verbose > 0, > will register this event, ot

Re: [dpdk-dev] [PATCH] lpm6: spelling fixes

2020-04-24 Thread Thomas Monjalon
10/03/2020 17:26, Stephen Hemminger: > Fix spelling errors in comments. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx/Tx stats after clear stats command

2020-04-24 Thread Ferruh Yigit
On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote: > From: Chengwen Feng > > Currently, when running start/clear stats&xstats/stop command many times > based on testpmd application, there are incorrect RX/TX-packets stats as > below: > -- Forward statistics for port 0

Re: [dpdk-dev] [dpdk-stable] [PATCH] mempool: remove inline functions from export list

2020-04-24 Thread Thomas Monjalon
23/04/2020 14:53, Andrew Rybchenko: > On 4/22/20 10:37 AM, Fady Bader wrote: > > The code didn't compile when using exported mempool functions under windows. > > > > compilation error logs: > > rte_mempool_exports.def : error LNK2001: > > unresolved external symbol rte_mempool_cache_flush > > rte_

Re: [dpdk-dev] [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-24 Thread Liu, Yong
> -Original Message- > From: Liu, Yong > Sent: Friday, April 24, 2020 9:41 PM > To: 'Maxime Coquelin' ; Ye, Xiaolong > ; Wang, Zhihong > Cc: dev@dpdk.org; Van Haaren, Harry > Subject: RE: [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path > > > > > -Original Message--

Re: [dpdk-dev] [PATCH v4 02/18] telemetry: move code to metrics for later reuse

2020-04-24 Thread Bruce Richardson
On Fri, Apr 24, 2020 at 08:29:53AM -0700, Stephen Hemminger wrote: > On Fri, 24 Apr 2020 13:41:43 +0100 > Ciara Power wrote: > > > This commit moves some of the telemetry library code to a new file in > > the metrics library. No modifications are made to the moved code, > > except what is needed

Re: [dpdk-dev] [PATCH v4 02/18] telemetry: move code to metrics for later reuse

2020-04-24 Thread Stephen Hemminger
On Fri, 24 Apr 2020 13:41:43 +0100 Ciara Power wrote: > This commit moves some of the telemetry library code to a new file in > the metrics library. No modifications are made to the moved code, > except what is needed to allow it to compile and run. The additional > code in metrics is built only

Re: [dpdk-dev] [PATCH v6] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Burakov, Anatoly
On 24-Apr-20 2:19 PM, Li Feng wrote: Currently, even though memory is mapped with PROT_NONE, this does not cause it to be excluded from core dumps. This is counter-productive, because in a lot of cases, this memory will go unused (e.g. when the memory subsystem preallocates VA space but hasn't ye

Re: [dpdk-dev] [PATCH] cryptodev: add support for user callback functions

2020-04-24 Thread Ananyev, Konstantin
> In an eventdev world, multiple workers (with ordered queue) will be > working on IPsec ESP processing. The ESP header's sequence number is > unique and has to be sequentially incremented in an orderly manner. > This rises a need for incrementing sequence number in crypto stage > especially in e

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread David Marchand
On Fri, Apr 24, 2020 at 4:50 PM Ray Kinsella wrote: > > ah ok, the particular system I made the change on was Ubuntu 18.04.2. > which is libabigail 1.2.0. > > Given we still support v19.11 on Ubuntu 18.04.2. > I think it's worthwhile keeping the suppression until v20.11? 1.2 is fairly old and doe

Re: [dpdk-dev] [PATCH v5 1/1] eal: add internal ABI marking support

2020-04-24 Thread David Marchand
On Thu, Apr 23, 2020 at 5:25 AM Haiyue Wang wrote: > > Introduce __rte_internal tag to mark internal ABI function which is used > by the drivers or other libraries. > > Signed-off-by: Haiyue Wang > --- > buildtools/check-internal-syms.sh | 57 + > devtools/check-sym

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread Ray Kinsella
ah ok, the particular system I made the change on was Ubuntu 18.04.2. which is libabigail 1.2.0. Given we still support v19.11 on Ubuntu 18.04.2. I think it's worthwhile keeping the suppression until v20.11? Ray K On 24/04/2020 15:10, David Marchand wrote: > On Thu, Apr 23, 2020 at 8:48 AM Ray K

Re: [dpdk-dev] [PATCH v1 2/2] ring: use wfe to wait for ring tail update on aarch64

2020-04-24 Thread Honnappa Nagarahalli
Hi Gavin, There are other sync modes added to rte_ring library. Can you please extend this to other rte_pause() calls in the library? Thanks, Honnappa > Subject: [PATCH v1 2/2] ring: use wfe to wait for ring tail update on aarch64 > > Instead of polling for tail to be updated, use wfe

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread David Marchand
On Thu, Apr 23, 2020 at 8:48 AM Ray Kinsella wrote: > > Change references to abi 20.0.1 to use abi v21, add myself as the map > file maintainer to more closely monitor future abi changes. Add > suppressions that were missed on changes to librte_lpm. About the lpm change below, this might be becau

Re: [dpdk-dev] [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path

2020-04-24 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Friday, April 24, 2020 9:36 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Van Haaren, Harry > Subject: Re: [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path > > > > On 4/24/20 3:33 PM, Liu, Y

Re: [dpdk-dev] [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-24 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Friday, April 24, 2020 9:34 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Van Haaren, Harry > Subject: Re: [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path > > > > On 4/24/20 3:12 PM, Liu, Y

Re: [dpdk-dev] [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path

2020-04-24 Thread Maxime Coquelin
On 4/24/20 3:33 PM, Liu, Yong wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, April 24, 2020 8:30 PM >> To: Liu, Yong ; Ye, Xiaolong ; >> Wang, Zhihong >> Cc: dev@dpdk.org; Van Haaren, Harry >> Subject: Re: [PATCH v9 7/9] net/virtio: add vectorized packed

Re: [dpdk-dev] [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-24 Thread Maxime Coquelin
On 4/24/20 3:12 PM, Liu, Yong wrote: >> IIUC, the only difference with the non-vectorized version is the GSO >> support removed here. >> gso_type being in the same cacheline as flags in virtio_net_hdr, I don't >> think checking the performance gain is worth the added maintainance >> effort due t

Re: [dpdk-dev] [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path

2020-04-24 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Friday, April 24, 2020 8:30 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Van Haaren, Harry > Subject: Re: [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path > > > > On 4/24/20 11:24 AM, Marvi

Re: [dpdk-dev] [PATCH v9 9/9] doc: add packed vectorized path

2020-04-24 Thread Maxime Coquelin
On 4/24/20 11:24 AM, Marvin Liu wrote: > Document packed virtqueue vectorized path selection logic in virtio net > PMD. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH v9 8/9] net/virtio: add election for vectorized path

2020-04-24 Thread Maxime Coquelin
On 4/24/20 11:24 AM, Marvin Liu wrote: > Rewrite vectorized path selection logic. Default setting comes from > vectorized devarg, then checks each criteria. > > Packed ring vectorized path need: > AVX512F and required extensions are supported by compiler and host > VERSION_1 and IN_ORDE

Re: [dpdk-dev] [PATCH 3/3] examples/ipsec-secgw/parser.c: Removing the re-implementation of inet_pton

2020-04-24 Thread Ibtisam Tariq
Hi Ananyev, Konstantin, Thank you for your email. I appreciate your feedback. Sorry for the trouble. I patched the two more files with the same modifications so unintentionally I typed it wrong. I'm going to fix it in v2. In the future, I will be carefully reviewing the code and testing the appl

Re: [dpdk-dev] [PATCH v1 2/2] ring: use wfe to wait for ring tail update on aarch64

2020-04-24 Thread Ananyev, Konstantin
> > Instead of polling for tail to be updated, use wfe instruction. > > Signed-off-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Steve Capper > Reviewed-by: Ola Liljedahl > Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_ring/rte_ring_c11_mem.h | 4 ++-- > lib/librte_ring/r

[dpdk-dev] [PATCH v6] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Li Feng
Currently, even though memory is mapped with PROT_NONE, this does not cause it to be excluded from core dumps. This is counter-productive, because in a lot of cases, this memory will go unused (e.g. when the memory subsystem preallocates VA space but hasn't yet mapped physical pages into it). Use

Re: [dpdk-dev] [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-24 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Friday, April 24, 2020 7:52 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Van Haaren, Harry > Subject: Re: [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path > > > > On 4/24/20 11:24 AM, Marvi

Re: [dpdk-dev] [PATCH] devtools: fix tracepoint symbols check

2020-04-24 Thread Thomas Monjalon
24/04/2020 14:43, David Marchand: > On Fri, Apr 24, 2020 at 12:53 PM Thomas Monjalon wrote: > > > > The tracepoint symbols __rte_*_trace_* are defined via a macro, > > adding prefix "__", so they cannot be found by map checker. > > Those symbols defined by RTE_TRACE_POINT and RTE_TRACE_POINT_FP >

Re: [dpdk-dev] [PATCH v5] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Bruce Richardson
On Fri, Apr 24, 2020 at 08:53:11PM +0800, Li Feng wrote: > Currently, even though memory is mapped with PROT_NONE, this does not > cause it to be excluded from core dumps. This is counter-productive, > because in a lot of cases, this memory will go unused (e.g. when the > memory subsystem prealloca

[dpdk-dev] [PATCH v4 18/18] doc: update telemetry documentation

2020-04-24 Thread Ciara Power
The existing documentation for Telemetry is updated, and further documentation is added. Signed-off-by: Ciara Power --- v4: - Removed JSON API from docs as it is now internal. - Updated guide to show use of data functions. --- doc/guides/howto/telemetry.rst| 108 ++--

[dpdk-dev] [PATCH v4 17/18] eal: add eal telemetry callbacks

2020-04-24 Thread Ciara Power
From: Bruce Richardson EAL now registers commands to provide some basic info from EAL. Example: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.05.0-rc0", "pid": 72662, "max_output_len": 16384} --> / {"/": ["/", "/eal/app_params", "/eal/params", "/ethdev/link_status", \

[dpdk-dev] [PATCH v4 16/18] eal: remove rte-option infrastructure

2020-04-24 Thread Ciara Power
As Telemetry no longer uses rte_option, and was the only user of this infrastructure, it can now be removed. Signed-off-by: Ciara Power --- lib/librte_eal/common/eal_common_options.c | 1 - lib/librte_eal/common/eal_private.h| 28 --- lib/librte_eal/common/meson.build | 2

[dpdk-dev] [PATCH v4 15/18] lib: add telemetry as eal dependency

2020-04-24 Thread Ciara Power
This patch moves telemetry further down the build, and adds it as a dependency for EAL. Telemetry V2 is now configured to build by default, and the legacy support is built when the telemetry config flag is set. Telemetry now has EAL flags, shown below: "--telemetry" = Enables telemetry (this is de

[dpdk-dev] [PATCH v4 14/18] telemetry: remove existing telemetry files

2020-04-24 Thread Ciara Power
This patch removes the existing telemetry files, which are now redundant as the new version of telemetry has backward compatibility for their functionality. Signed-off-by: Ciara Power --- lib/librte_metrics/rte_metrics_telemetry.c|9 - lib/librte_telemetry/Makefile |4

[dpdk-dev] [PATCH v4 13/18] telemetry: introduce telemetry backward compatibility

2020-04-24 Thread Ciara Power
The new telemetry will now open a socket using the old telemetry path, to ensure backward compatibility. This is not yet initialised, as it would clash with the existing telemetry, to be removed in a later patch. This means that both old and new telemetry socket interfaces are handled in a common w

[dpdk-dev] [PATCH v4 12/18] examples/l3fwd-power: enable use of new telemetry

2020-04-24 Thread Ciara Power
The l3fwd-power example app now registers a stats command with telemetry, and provides a callback function to handle formatting the power stats. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.05.0-rc0", "pid": 63384, "max_output_len": 16384

[dpdk-dev] [PATCH v4 11/18] rawdev: add callback support for telemetry

2020-04-24 Thread Ciara Power
The rawdev library now registers commands with telemetry, and implements the corresponding callback functions. These allow a list of rawdev devices and xstats for a rawdev port to be queried. An example usage, with ioat rawdev driver instances, is shown below: Connecting to /var/run/dpdk/rte/dpdk

[dpdk-dev] [PATCH v4 10/18] ethdev: add callback support for telemetry

2020-04-24 Thread Ciara Power
From: Bruce Richardson The ethdev library now registers commands with telemetry, and implements the callback functions. These commands allow the list of ethdev ports and the xstats and link status for a port to be queried. An example using ethdev commands is shown below: Connecting to /var/run/

[dpdk-dev] [PATCH v4 09/18] usertools: add new telemetry python script

2020-04-24 Thread Ciara Power
From: Bruce Richardson This patch adds a python script that can be used with the new telemetry socket. It connects as a client to the socket, and allows the user send a command and see the JSON response. The example usage below shows the script connecting to the new telemetry socket, and sending

[dpdk-dev] [PATCH v4 08/18] telemetry: add default callback commands

2020-04-24 Thread Ciara Power
The default commands are now added to provide the list of commands available, help text for a specified command, and also information about DPDK and telemetry. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson --- v4: Added help command to provide help text for a command. --- lib/libr

[dpdk-dev] [PATCH v4 07/18] telemetry: add functions for returning callback data

2020-04-24 Thread Ciara Power
From: Bruce Richardson The functions added in this patch will help applications build up data in reply to a telemetry request. Signed-off-by: Bruce Richardson --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build | 2 +- lib/librte_telemetry

[dpdk-dev] [PATCH v4 06/18] telemetry: introduce new telemetry functionality

2020-04-24 Thread Ciara Power
From: Bruce Richardson This patch introduces a new telemetry connection socket and handling functionality. Like the existing telemetry implementation (which is unaffected by this change) it uses a unix socket, but unlike the existing one it does not have a fixed list of commands - instead librari

[dpdk-dev] [PATCH v4 05/18] telemetry: add utility functions for creating json

2020-04-24 Thread Ciara Power
From: Bruce Richardson The functions added in this patch will make it easier for telemetry to convert data to correct JSON responses to telemetry requests. Tests are also added for these json utility functions. Signed-off-by: Bruce Richardson --- v4: Tests included in patch with utility funct

[dpdk-dev] [PATCH v4 04/18] telemetry: invert dependency on metrics

2020-04-24 Thread Ciara Power
From: Bruce Richardson Rather than having the telemetry library depend on the metrics lib we invert the dependency so that metrics instead depends on telemetry lib, and registers the needed functions with it at init time. This prepares the way for a cleaner telemetry architecture to be applied in

[dpdk-dev] [PATCH v4 03/18] metrics: reduce code taken from telemetry

2020-04-24 Thread Ciara Power
The telemetry code that was moved into the metrics library can be shortened, while still maintaining the same functionality. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson --- lib/librte_metrics/rte_metrics_telemetry.c | 476 lib/librte_metrics/rte_metrics_tele

[dpdk-dev] [PATCH v4 02/18] telemetry: move code to metrics for later reuse

2020-04-24 Thread Ciara Power
This commit moves some of the telemetry library code to a new file in the metrics library. No modifications are made to the moved code, except what is needed to allow it to compile and run. The additional code in metrics is built only when the Jansson library is present. Telemetry functions as nor

[dpdk-dev] [PATCH v4 01/18] build: add arch-specific header path to global includes

2020-04-24 Thread Ciara Power
From: Bruce Richardson The global include path, which is used by anything built before EAL, points to the EAL header files so they utility macros etc. can be used anywhere in DPDK. This path included the OS-specific EAL header files, but not the architecture-specific ones. This patch moves the se

[dpdk-dev] [PATCH v4 00/18] update and simplify telemetry library.

2020-04-24 Thread Ciara Power
v4: - Internal representation now uses generic data format instead of JSON. - Help command added to provide help text for a command. v3: - Removed rte_option as it is no longer used. - General cleanup. v2: - Added JSON API, and unit tests, to simplify creation of valid json response

[dpdk-dev] [PATCH v5] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Li Feng
Currently, even though memory is mapped with PROT_NONE, this does not cause it to be excluded from core dumps. This is counter-productive, because in a lot of cases, this memory will go unused (e.g. when the memory subsystem preallocates VA space but hasn't yet mapped physical pages into it). Use

Re: [dpdk-dev] [PATCH] devtools: fix tracepoint symbols check

2020-04-24 Thread David Marchand
On Fri, Apr 24, 2020 at 12:53 PM Thomas Monjalon wrote: > > The tracepoint symbols __rte_*_trace_* are defined via a macro, > adding prefix "__", so they cannot be found by map checker. > Those symbols defined by RTE_TRACE_POINT and RTE_TRACE_POINT_FP > are checked without the generated prefix. >

[dpdk-dev] [PATCH v4] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Li Feng
Currently, even though memory is mapped with PROT_NONE, this does not cause it to be excluded from core dumps. This is counter-productive, because in a lot of cases, this memory will go unused (e.g. when the memory subsystem preallocates VA space but hasn't yet mapped physical pages into it). Use

Re: [dpdk-dev] [EXT] RE: [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-24 Thread Ananyev, Konstantin
> > > > Hi Lukas, > > > > Apologies for delay with response. > > > > > Do you have any thoughts how both cases could be covered: > > > 1. Inline not applied to inbound IPsec pkts for short duration of time > > > after rte_eth_dev_start() but before sa_init() is executed (which creates > > > SAs).

Re: [dpdk-dev] [PATCH v2] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Li Feng
Thanks, Feng Li Burakov, Anatoly 于2020年4月24日周五 下午7:23写道: > > On 24-Apr-20 11:50 AM, Li Feng wrote: > > Currently, even though memory is mapped with PROT_NONE, this does not > > cause it to be excluded from core dumps. This is counter-productive, > > because in a lot of cases, this memory will go

Re: [dpdk-dev] [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path

2020-04-24 Thread Maxime Coquelin
On 4/24/20 11:24 AM, Marvin Liu wrote: > Optimize packed ring Tx path alike Rx path. Split Tx path into batch and s/alike/like/ ? > single Tx functions. Batch function is further optimized by AVX512 > instructions. > > Signed-off-by: Marvin Liu > > diff --git a/drivers/net/virtio/virtio_eth

Re: [dpdk-dev] [PATCH v2] eal: add madvise to avoid dump memory

2020-04-24 Thread Li Feng
Thanks, Feng Li Burakov, Anatoly 于2020年4月24日周五 下午7:00写道: > > On 24-Apr-20 10:33 AM, Feng Li wrote: > > Bruce Richardson 于2020年4月24日周五 下午5:14写道: > >> > >> On Fri, Apr 24, 2020 at 10:12:10AM +0100, Burakov, Anatoly wrote: > >>> On 23-Apr-20 9:04 PM, David Marchand wrote: > On Thu, Apr 23, 20

Re: [dpdk-dev] [PATCH v9 6/9] net/virtio: reuse packed ring xmit functions

2020-04-24 Thread Maxime Coquelin
On 4/24/20 11:24 AM, Marvin Liu wrote: > Move xmit offload and packed ring xmit enqueue function to header file. > These functions will be reused by packed ring vectorized Tx function. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-24 Thread Maxime Coquelin
On 4/24/20 11:24 AM, Marvin Liu wrote: > Optimize packed ring Rx path with SIMD instructions. Solution of > optimization is pretty like vhost, is that split path into batch and > single functions. Batch function is further optimized by AVX512 > instructions. Also pad desc extra structure to 16 b

Re: [dpdk-dev] [PATCH 3/3] examples/ipsec-secgw/parser.c: Removing the re-implementation of inet_pton

2020-04-24 Thread Ananyev, Konstantin
> inet_pton4 and inet_pton6 was reimplemented. Replacing implementation of > inet_pton4 and inet_pton6 with libc inet_pton function > Bugzilla ID: 365 NACK After that patch ispec-secgw wouldn't even start. Next time before submitting a patch - spend some time to test it first. > Cc: dev@dpdk

Re: [dpdk-dev] [PATCH v2] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Burakov, Anatoly
On 24-Apr-20 12:36 PM, Bruce Richardson wrote: On Fri, Apr 24, 2020 at 12:23:44PM +0100, Burakov, Anatoly wrote: On 24-Apr-20 11:50 AM, Li Feng wrote: Currently, even though memory is mapped with PROT_NONE, this does not cause it to be excluded from core dumps. This is counter-productive, becau

Re: [dpdk-dev] [PATCH v2] eal: use madvise to exclude unmapped memory from being dumped

2020-04-24 Thread Bruce Richardson
On Fri, Apr 24, 2020 at 12:23:44PM +0100, Burakov, Anatoly wrote: > On 24-Apr-20 11:50 AM, Li Feng wrote: > > Currently, even though memory is mapped with PROT_NONE, this does not > > cause it to be excluded from core dumps. This is counter-productive, > > because in a lot of cases, this memory wil

  1   2   >