ah ok, the particular system I made the change on was Ubuntu 18.04.2.
which is libabigail 1.2.0.

Given we still support v19.11 on Ubuntu 18.04.2.
I think it's worthwhile keeping the suppression until v20.11?

Ray K

On 24/04/2020 15:10, David Marchand wrote:
> On Thu, Apr 23, 2020 at 8:48 AM Ray Kinsella <m...@ashroe.eu> wrote:
>>
>> Change references to abi 20.0.1 to use abi v21, add myself as the map
>> file maintainer to more closely monitor future abi changes. Add
>> suppressions that were missed on changes to librte_lpm.
> 
> About the lpm change below, this might be because you are using an old
> version of libabigail.
> I think the change went in:
> $ git describe --contains 215b7eb4
> libabigail-1.4~8
> 
> I use either libabigail 1.7 or the current master (when testing Dodji
> enhancements).
> 
> 
>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
>> index cd86d89ca..20c821cee 100644
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/libabigail.abignore
>> @@ -2,7 +2,6 @@
>>          symbol_version = EXPERIMENTAL
>>  [suppress_variable]
>>          symbol_version = EXPERIMENTAL
>> -
>>  ; Explicit ignore for driver-only ABI
>>  [suppress_type]
>>          name = rte_cryptodev_ops
>> @@ -18,3 +17,15 @@
>>  [suppress_type]
>>          type_kind = struct
>>          name = rte_event_ring
>> +; Explicit ignore ABI 20.0.1
>> +[suppress_function]
>> +        symbol_version = DPDK_20.0.1
>> +[suppress_variable]
>> +        symbol_version = DPDK_20.0.1
>> +; Explicit ignore of const lpm6_lookup change
>> +[suppress_function]
>> +        name = rte_lpm6_delete
>> +        parameter = '1 uint8_t*
>> +[suppress_function]
>> +        name = rte_lpm6_is_rule_present
>> +        parameter = '1 uint8_t*
> 
> 

Reply via email to