[dpdk-dev] [PATCH 3/3] net/ixgbe: fix include of vector header file

2020-04-23 Thread Ruifeng Wang
The include of 'arm_neon.h' causes issues to old gcc and aarch32. Including 'rte_vect.h' instead fixes these issues. Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- drivers/net/ixgbe/ixgbe_rxtx_vec_neo

[dpdk-dev] [PATCH 0/3] aarch32 compilation

2020-04-23 Thread Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these. When building with make, please refer to guide: http://patches.dpdk.org/patch/62820/ When building with meson, requires series: http://patches.dpdk.org/cover/68534/ [1] https://m

[dpdk-dev] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32

2020-04-23 Thread Ruifeng Wang
vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic. Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- lib/librte_eal/arm/include/rte_vect.h | 6 +- 1 file changed, 5

[dpdk-dev] [PATCH 2/3] net/ixgbe: add support for aarch32

2020-04-23 Thread Ruifeng Wang
Expand vector PMD support to aarch32. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h index 20a8b291d..7e09291b2 100644 --

Re: [dpdk-dev] [PATCH v3 04/12] build: remove redundant code

2020-04-23 Thread Phil Yang
> -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Tuesday, March 17, 2020 9:18 AM > To: tho...@monjalon.net; harry.van.haa...@intel.com; > konstantin.anan...@intel.com; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer

Re: [dpdk-dev] [PATCH v3 03/12] eal/build: add libatomic dependency for 32-bit clang

2020-04-23 Thread Phil Yang
> -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Tuesday, March 17, 2020 9:18 AM > To: tho...@monjalon.net; harry.van.haa...@intel.com; > konstantin.anan...@intel.com; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer

Re: [dpdk-dev] [PATCH v2] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-04-23 Thread Phil Yang
> -Original Message- > From: Jerin Jacob > Sent: Friday, April 24, 2020 1:45 AM > To: Phil Yang > Cc: Ananyev, Konstantin ; dpdk-dev > ; tho...@monjalon.net; Bernard Iremonger > ; Vladimir Medvedkin > ; Honnappa Nagarahalli > ; Gavin Hu ; > Ruifeng Wang ; nd > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v2] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-04-23 Thread Phil Yang
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, April 24, 2020 2:11 AM > To: Phil Yang ; dev@dpdk.org > Cc: tho...@monjalon.net; Iremonger, Bernard > ; Medvedkin, Vladimir > ; Honnappa Nagarahalli > ; Gavin Hu ; > Ruifeng Wang ; nd > Subject: RE: [PATCH v2] ipsec: optimiz

[dpdk-dev] [PATCH v3] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-04-23 Thread Phil Yang
For SA outbound packets, rte_atomic64_add_return is used to generate SQN atomically. Use c11 atomics with RELAXED ordering for outbound SQN update instead of rte_atomic ops which enforce unnecessary barriers on aarch64. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu --

[dpdk-dev] [PATCH v4 1/2] virtio: one way barrier for split vring used idx

2020-04-23 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v4 2/2] virtio: one way barrier for split vring avail idx

2020-04-23 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v4 0/2] one way barrier for split vring idx

2020-04-23 Thread Joyce Kong
This patchset replaces the two-way barriers with C11 one-way barriers for split vring idx, when the frontend and backend are implemented in software. By doing PVP benchmarking, the test result of 2c1q showed the throughput increased 20% with the 0.001% of acceptable loss rate on Thunderx2 platform

[dpdk-dev] [PATCH v9 6/6] net/hinic: use common rte bit operation APIs instead

2020-04-23 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/hinic/Makefile| 1 + drivers/net/hinic/base/hinic_compat.h | 33 +-- drivers/net/hinic/hin

[dpdk-dev] [PATCH v9 4/6] net/bnx2x: use common rte bit operation APIs instead

2020-04-23 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/bnx2x/bnx2x.c| 271 +-- drivers/net/bnx2x/bnx2x.h| 10 +- drivers/net/bnx2x/ecore_sp.c

[dpdk-dev] [PATCH v9 3/6] net/axgbe: use common rte bit operation APIs instead

2020-04-23 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/axgbe/axgbe_common.h | 29 + drivers/net/axgbe/axgbe_ethdev.c | 14 +++--- drivers/net/axgb

[dpdk-dev] [PATCH v9 5/6] net/qede: use common rte bit operation APIs instead

2020-04-23 Thread Joyce Kong
Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/qede/base/bcm_osal.c | 22 + drivers/net/qede/base/bcm_osal.h | 14 - drivers/net/qede/ba

[dpdk-dev] [PATCH v9 0/6] implement common bit operation APIs

2020-04-23 Thread Joyce Kong
Bitwise operation APIs are defined and used in a lot of PMDs, which caused a huge code duplication. To reduce duplication, this patch consolidates them into a common API family and use it for all the PMDs(we started with a few selectively). v9: 1. Change '*addr = (*addr) | mask' to '*addr = val

[dpdk-dev] [PATCH v9 1/6] lib/eal: implement the family of common bit operation APIs

2020-04-23 Thread Joyce Kong
Bitwise operation APIs are defined and used in a lot of PMDs, which caused a huge code duplication. To reduce duplication, this patch consolidates them into a common API family. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Acked-by: Morten Brørup --- MAINTAINERS

[dpdk-dev] [PATCH v9 2/6] test/bitops: add bit operation test case

2020-04-23 Thread Joyce Kong
Add test cases for setting bit, clearing bit, testing and setting bit, testing and clearing bit operation. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- MAINTAINERS | 1 + app/test/Makefile | 1 + app/test/autotest_data.py | 6 ++ app/te

[dpdk-dev] [Bug 461] i40evf link status is always down with the Intel XL710 driver

2020-04-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=461 Bug ID: 461 Summary: i40evf link status is always down with the Intel XL710 driver Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRM

Re: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule deletion

2020-04-23 Thread Zhao1, Wei
It will be delete after fix in kernel to re-enable vf list feature. Reviewed-by: Wei Zhao > -Original Message- > From: dev On Behalf Of Qi Zhang > Sent: Thursday, April 23, 2020 12:22 PM > To: Yang, Qiming > Cc: Ye, Xiaolong ; Xing, Beilei > ; > Zhang, Xiao ; dev@dpdk.org; Zhang, Qi Z

[dpdk-dev] [PATCH v9 9/9] doc: add packed vectorized path

2020-04-23 Thread Marvin Liu
Document packed virtqueue vectorized path selection logic in virtio net PMD. Signed-off-by: Marvin Liu diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index d59add23e..dbcf49ae1 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -482,6 +482,13 @@ acc

[dpdk-dev] [PATCH v9 8/9] net/virtio: add election for vectorized path

2020-04-23 Thread Marvin Liu
Rewrite vectorized path selection logic. Default setting comes from vectorized devarg, then checks each criteria. Packed ring vectorized path need: AVX512F and required extensions are supported by compiler and host VERSION_1 and IN_ORDER features are negotiated mergeable feature is not

[dpdk-dev] [PATCH v9 3/9] net/virtio: add vectorized devarg

2020-04-23 Thread Marvin Liu
Previously, virtio split ring vectorized path was enabled by default. This is not suitable for everyone because that path dose not follow virtio spec. Add new devarg for virtio vectorized path selection. By default vectorized path is disabled. Signed-off-by: Marvin Liu diff --git a/doc/guides/ni

[dpdk-dev] [PATCH v9 7/9] net/virtio: add vectorized packed ring Tx path

2020-04-23 Thread Marvin Liu
Optimize packed ring Tx path alike Rx path. Split Tx path into batch and single Tx functions. Batch function is further optimized by AVX512 instructions. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 5c112cac7..b7d52d497 100

[dpdk-dev] [PATCH v9 4/9] net/virtio-user: add vectorized devarg

2020-04-23 Thread Marvin Liu
Add new devarg for virtio user device vectorized path selection. By default vectorized path is disabled. Signed-off-by: Marvin Liu diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 902a1f0cf..d59add23e 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.

[dpdk-dev] [PATCH v9 6/9] net/virtio: reuse packed ring xmit functions

2020-04-23 Thread Marvin Liu
Move xmit offload and packed ring xmit enqueue function to header file. These functions will be reused by packed ring vectorized Tx function. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index c9b6e7844..cf18fe564 100644 --- a/drivers

[dpdk-dev] [PATCH v9 5/9] net/virtio: add vectorized packed ring Rx path

2020-04-23 Thread Marvin Liu
Optimize packed ring Rx path with SIMD instructions. Solution of optimization is pretty like vhost, is that split path into batch and single functions. Batch function is further optimized by AVX512 instructions. Also pad desc extra structure to 16 bytes aligned, thus four elements will be saved in

[dpdk-dev] [PATCH v9 2/9] net/virtio: inorder should depend on feature bit

2020-04-23 Thread Marvin Liu
Ring initialization is different when inorder feature negotiated. This action should dependent on negotiated feature bits. Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 94ba7a3ec..e450477e8 100644 --

[dpdk-dev] [PATCH v9 1/9] net/virtio: add Rx free threshold setting

2020-04-23 Thread Marvin Liu
Introduce free threshold setting in Rx queue, its default value is 32. Limit the threshold size to multiple of four as only vectorized packed Rx function will utilize it. Virtio driver will rearm Rx queue when more than rx_free_thresh descs were dequeued. Signed-off-by: Marvin Liu Reviewed-by: Ma

[dpdk-dev] [PATCH v9 0/9] add packed ring vectorized path

2020-04-23 Thread Marvin Liu
This patch set introduced vectorized path for packed ring. The size of packed ring descriptor is 16Bytes. Four batched descriptors are just placed into one cacheline. AVX512 instructions can well handle this kind of data. Packed ring TX path can fully transformed into vectorized path. Packed ring

Re: [dpdk-dev] [PATCH v2] lib/timer: relax barrier for status update

2020-04-23 Thread Carrillo, Erik G
Hi Honnappa, > -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, April 23, 2020 3:06 PM > To: Phil Yang ; Carrillo, Erik G > ; rsanf...@akamai.com; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Ananyev, > Konstantin ; jer...@marvell.com; > hemant.agra.

Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes

2020-04-23 Thread Ajit Khaparde
On Thu, Apr 23, 2020 at 7:46 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > Please apply. > Applied to dpdk-next-net-brcm. Thanks > > Kalesh AP (1): > net/bnxt: fix to reset VNIC rxq count on VNIC free > > Rahul Gupta (1): > net/bnxt: fix for memleak durin

Re: [dpdk-dev] [PATCH v2] lib/timer: relax barrier for status update

2020-04-23 Thread Honnappa Nagarahalli
Hi Erik, > Subject: [PATCH v2] lib/timer: relax barrier for status update > > Volatile has no ordering semantics. The rte_timer structure defines timer > status as a volatile variable and uses the rte_r/wmb barrier to guarantee > inter-thread visibility. > > This patch optimized the volatile ope

Re: [dpdk-dev] [PATCH v2] eal: add madvise to avoid dump memory

2020-04-23 Thread David Marchand
On Thu, Apr 23, 2020 at 6:34 PM Burakov, Anatoly wrote: > > diff --git a/lib/librte_eal/common/eal_common_memory.c > > b/lib/librte_eal/common/eal_common_memory.c > > index cc7d54e0c..2d9564b28 100644 > > --- a/lib/librte_eal/common/eal_common_memory.c > > +++ b/lib/librte_eal/common/eal_common_m

[dpdk-dev] DPDK techboard minutes for Apr 22nd 2020

2020-04-23 Thread Honnappa Nagarahalli
Meeting notes for the DPDK technical board meeting held on 2020-04-22 Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli (Chair) - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin

[dpdk-dev] [PATCH] doc: refine ethernet and VLAN flow rule items

2020-04-23 Thread Dekel Peled
Specified pattern may be translated in different manner. For example the pattern "eth / ipv4" can be translated to match untagged packets only, since the pattern doesn't specify a vlan item. It can also be translated to match both tagged and untagged packets, for the same reason. This patch updates

Re: [dpdk-dev] [PATCH v2] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-04-23 Thread Ananyev, Konstantin
> > For SA outbound packets, rte_atomic64_add_return is used to generate > SQN atomically. This introduced an unnecessary full barrier by calling > the '__sync' builtin implemented rte_atomic_XX API on aarch64. This > patch optimized it with c11 atomic and eliminated the expensive barrier > for aa

Re: [dpdk-dev] [PATCH v2] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-04-23 Thread Jerin Jacob
On Thu, Apr 23, 2020 at 10:47 PM Phil Yang wrote: > > For SA outbound packets, rte_atomic64_add_return is used to generate > SQN atomically. This introduced an unnecessary full barrier by calling > the '__sync' builtin implemented rte_atomic_XX API on aarch64. This > patch optimized it with c11 at

Re: [dpdk-dev] [PATCH v4 2/2] eal: emulate glibc getentropy for initial random seed

2020-04-23 Thread Dan Gora
On Wed, Apr 22, 2020 at 11:39 PM Stephen Hemminger wrote: > > On Wed, 22 Apr 2020 20:42:54 -0300 > Dan Gora wrote: > > > + fd = open("/dev/urandom", O_RDONLY); > > + if (fd < 0) { > > + errno = ENODEV; > > + return -1; > > + } > > + > > + end = start + leng

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-23 Thread Dan Gora
On Thu, Apr 23, 2020 at 12:59 PM Luca Boccassi wrote: > > > > > > /dev/urandom is basically only a different interface to the same > > > underlying mechanism. > > This is not the whole story though - while the end result when all > works is the same, there are important differences in getting ther

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-23 Thread Dan Gora
On Thu, Apr 23, 2020 at 9:36 AM Mattias Rönnblom wrote: > >> > >> /dev/urandom is basically only a different interface to the same > >> underlying mechanism. > >> > >> Such an alternative would look something like: > >> > >> static int > >> getentropy(void *buffer, size_t length) > >> { > >>

[dpdk-dev] [PATCH v2] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-04-23 Thread Phil Yang
For SA outbound packets, rte_atomic64_add_return is used to generate SQN atomically. This introduced an unnecessary full barrier by calling the '__sync' builtin implemented rte_atomic_XX API on aarch64. This patch optimized it with c11 atomic and eliminated the expensive barrier for aarch64. Signe

[dpdk-dev] [PATCH v2] vhost: optimize broadcast rarp sync with c11 atomic

2020-04-23 Thread Phil Yang
The rarp packet broadcast flag is synchronized with rte_atomic_XX APIs which is a full barrier, DMB, on aarch64. This patch optimized it with c11 atomic one-way barrier. Signed-off-by: Phil Yang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Reviewed-by: Joyce Kong --- v2: split from

Re: [dpdk-dev] [PATCH v2] eal: add madvise to avoid dump memory

2020-04-23 Thread Burakov, Anatoly
On 23-Apr-20 4:43 PM, Li Feng wrote: Avoid dump all mapped memory to a core dump file when crash. Otherwise it will very large and it's hard to analyze with gdb. In my test, it will dump 128GiB memory to a core dump file when integrated to spdk with default configuration. Suggested rewording:

[dpdk-dev] [PATCH v2 6/6] service: relax barriers with C11 atomics

2020-04-23 Thread Phil Yang
The runstate, comp_runstate and app_runstate are used as guard variables in the service core lib. To guarantee the inter-threads visibility of these guard variables, it uses rte_smp_r/wmb. This patch use c11 atomic built-ins to relax these barriers. Signed-off-by: Phil Yang Reviewed-by: Honnappa

[dpdk-dev] [PATCH v2 4/6] service: remove redundant code

2020-04-23 Thread Phil Yang
The service id validation is duplicated, remove the redundant code in the calling functions. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common/rte_service.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) diff --git a/lib/l

[dpdk-dev] [PATCH v2 5/6] service: optimize with c11 atomics

2020-04-23 Thread Phil Yang
The num_mapped_cores is used as a statistics. Use c11 atomics with RELAXED ordering for num_mapped_cores instead of rte_atomic ops which enforce unnessary barriers on aarch64. Replace execute_lock operations to spinlock_try_lock to avoid duplicate code. Signed-off-by: Phil Yang Reviewed-by: Honn

[dpdk-dev] [PATCH v2 3/6] service: remove rte prefix from static functions

2020-04-23 Thread Phil Yang
clean up rte prefix from static functions. remove unused parameter for service_dump_one function. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common/rte_service.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) diff -

[dpdk-dev] [PATCH v2 2/6] service: identify service running on another core correctly

2020-04-23 Thread Phil Yang
From: Honnappa Nagarahalli The logic to identify if the MT unsafe service is running on another core can return -EBUSY spuriously. In such cases, running the service becomes costlier than using atomic operations. Assume that the application passes the right parameters and reduces the number of in

[dpdk-dev] [PATCH v2 1/6] service: fix race condition for MT unsafe service

2020-04-23 Thread Phil Yang
From: Honnappa Nagarahalli The MT unsafe service might get configured to run on another core while the service is running currently. This might result in the MT unsafe service running on multiple cores simultaneously. Use 'execute_lock' always when the service is MT unsafe. Fixes: e9139a32f6e8 (

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Ranjit Menon
On 4/23/2020 3:48 AM, Thomas Monjalon wrote: 23/04/2020 11:06, Dmitry Kozlyuk: On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: 23/04/2020 01:51, Ranjit Menon: On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman Move common functions between Unix and Windows to eal_co

[dpdk-dev] [PATCH v2 0/6] use c11 atomics for service core lib

2020-04-23 Thread Phil Yang
The rte_atomic ops and rte_smp barriers enforce DMB barriers on aarch64. Using c11 atomics with explicit memory ordering instead of the rte_atomic ops and rte_smp barriers for inter-threads synchronization can uplift the performance on aarch64 and no performance loss on x86. This patchset contains

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Lukasz Wojciechowski
W dniu 23.04.2020 o 18:14, Akhil Goyal pisze: > Hi Anoob, >> Hi Akhil, >> >> I have my concerns over unwanted checks in the datapath. Something that >> crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As >> Konstantin had suggested, PMDs (IXGBE here) could define a functio

[dpdk-dev] [PATCH] test/security: enable tests for non-implemented ops

2020-04-23 Thread Lukasz Wojciechowski
After re-enabling checks for non-implemneted ops in non-debug mode in librte_security set_pkt_metadata and get_userdata functions, tests verifying proper work of tests can be enabled also. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 8 1 file changed, 8 deletions(

Re: [dpdk-dev] [PATCH v3 0/4] add new k32v64 hash table

2020-04-23 Thread Ananyev, Konstantin
Hi everyone, > > > > On 2020-04-16 12:18, Medvedkin, Vladimir wrote: > > > Hi Mattias, > > > > > > -Original Message- > > > From: Mattias Rönnblom > > > Sent: Wednesday, April 15, 2020 7:52 PM > > > To: Medvedkin, Vladimir ; dev@dpdk.org > > > Cc: Ananyev, Konstantin ; Wang, Yipeng1 > >

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Akhil Goyal
Hi Anoob, > > Hi Akhil, > > I have my concerns over unwanted checks in the datapath. Something that > crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As > Konstantin had suggested, PMDs (IXGBE here) could define a function which > returns -ENOTSUP and it would have been

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Anoob Joseph
Hi Akhil, I have my concerns over unwanted checks in the datapath. Something that crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As Konstantin had suggested, PMDs (IXGBE here) could define a function which returns -ENOTSUP and it would have been win-win for everyone.

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Akhil Goyal
> Valid checks for optional function pointers inside dev-ops > were disabled by undefined macro. > > Fixes: b6ee98547847 ("security: fix verification of parameters") > Cc: sta...@dpdk.org > > Signed-off-by: Konstantin Ananyev > --- Acked-by: Akhil Goyal Anoob, Do you have any concerns over

[dpdk-dev] [PATCH v2] eal: add madvise to avoid dump memory

2020-04-23 Thread Li Feng
Avoid dump all mapped memory to a core dump file when crash. Otherwise it will very large and it's hard to analyze with gdb. In my test, it will dump 128GiB memory to a core dump file when integrated to spdk with default configuration. Signed-off-by: Li Feng --- lib/librte_eal/common/eal_common

Re: [dpdk-dev] [PATCH] eal: fix build on armv7

2020-04-23 Thread Thomas Monjalon
23/04/2020 16:24, David Marchand: > Caught by OBS on armv7: > > In file included from .../lib/librte_eal/include/rte_string_fns.h:21, > from .../lib/librte_kvargs/rte_kvargs.c:9: > .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', > ';', 'asm' or '__attribu

[dpdk-dev] [PATCH v5] test/ipsec: measure libipsec performance

2020-04-23 Thread Savinay Dharmappa
Add new test-case to measure performance of ipsec data-path functions. Signed-off-by: Savinay Dharmappa --- MAINTAINERS| 2 +- app/test/Makefile | 2 +- app/test/meson.build | 2 + app/test/test_ipsec_perf.c | 614 + 4 file

Re: [dpdk-dev] [PATCH v8 0/9] add packed ring vectorized path

2020-04-23 Thread Wang, Yinan
Tested-by: Wang, Yinan > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: 2020年4月23日 20:31 > To: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong > Cc: Van Haaren, Harry ; dev@dpdk.org; Liu, > Yong > Subject: [dpdk-dev] [PATCH v8 0/9] add packed ring vectorized

Re: [dpdk-dev] [PATCH 2/2] timer: support EAL functions on Windows

2020-04-23 Thread Dmitry Kozlyuk
On 2020-04-23 17:43 GMT+0300 Fady Bader wrote: [snip] > diff --git a/lib/librte_eal/windows/eal_timer.c > b/lib/librte_eal/windows/eal_timer.c > new file mode 100644 > index 0..73eaff948 > --- /dev/null > +++ b/lib/librte_eal/windows/eal_timer.c > @@ -0,0 +1,67 @@ > +/* SPDX-License-Identi

[dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Konstantin Ananyev
Valid checks for optional function pointers inside dev-ops were disabled by undefined macro. Fixes: b6ee98547847 ("security: fix verification of parameters") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.c | 9 ++--- 1 file changed, 6 insertions(

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Ananyev, Konstantin
> > > > Hi Akhil, > > > > > > > > Hi Anoob/Konstantin, > > > > > > > > > > Check that ops->get_userdata is a valid function pointer will be > > > > > compiled > > out. > > > > > So PMDs that don't implement this function will crash in > > > > > rte_security_get_userdata(). > > > > > In our parti

[dpdk-dev] [PATCH 1/2] net/bnxt: fix for memleak during queue restart

2020-04-23 Thread Kalesh A P
From: Rahul Gupta During port 0 rxq 1 start ie queue start, bnxt_free_hwrm_rx_ring() we are clearing the pointers to mbuf array. Due to this we overwrite the queue with fresh mbuf allocations causing previously allocated mbufs to leak. Add a check before allocating mbuf to replenish only empty mb

[dpdk-dev] [PATCH 2/2] net/bnxt: fix to reset VNIC rxq count on VNIC free

2020-04-23 Thread Kalesh A P
From: Kalesh AP bnxt_free_one_vnic and bnxt_setup_one_vnic are called on configuring port vlan stripping. bnxt_setup_one_vnic keeps incrementing the vnic rx_queue_cnt. Fix to reset vnic rx_queue_cnt in bnxt_free_one_vnic. Fixes: cfadfee41ed1 ("net/bnxt: fix VLAN strip") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH 1/2] timer: move from common to Unix directory

2020-04-23 Thread Fady Bader
Eal common timer doesn't compile under Windows. Compilation log: error LNK2019: unresolved external symbol nanosleep referenced in function rte_delay_us_sleep error LNK2019: unresolved external symbol get_tsc_freq referenced in function set_tsc_freq error LNK2019: unresolved external symbol sleep

[dpdk-dev] [PATCH 0/2] bnxt bug fixes

2020-04-23 Thread Kalesh A P
From: Kalesh AP Please apply. Kalesh AP (1): net/bnxt: fix to reset VNIC rxq count on VNIC free Rahul Gupta (1): net/bnxt: fix for memleak during queue restart drivers/net/bnxt/bnxt_ethdev.c | 2 ++ drivers/net/bnxt/bnxt_hwrm.c | 12 drivers/net/bnxt/bnxt_rxr.c| 44 +++

[dpdk-dev] [PATCH 0/2] eal timer split and implementation for Windows

2020-04-23 Thread Fady Bader
This patchset splits OS dependent EAL timer functions and implements them for windows. Depends-on: series-9374 ("Windows basic memory management") Fady Bader (2): timer: move from common to Unix directory timer: support EAL functions on Windows lib/librte_eal/common/eal_common_timer.c | 22

[dpdk-dev] [PATCH 2/2] timer: support EAL functions on Windows

2020-04-23 Thread Fady Bader
Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 67 + lib/librte_eal/windows/include/rte_o

[dpdk-dev] [PATCH] eal: fix build on armv7

2020-04-23 Thread David Marchand
Caught by OBS on armv7: In file included from .../lib/librte_eal/include/rte_string_fns.h:21, from .../lib/librte_kvargs/rte_kvargs.c:9: .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 67 | typedef u

Re: [dpdk-dev] [PATCH v7 00/32] DPDK Trace support

2020-04-23 Thread David Marchand
On Wed, Apr 22, 2020 at 9:04 PM wrote: > This patch set contains > > > # The native implementation of common trace format(CTF)[1] based tracer > # Public API to create the trace points. > # Add tracepoints to eal, ethdev, mempool, eventdev and cryptodev > library for traci

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Akhil Goyal
> > Hi Akhil, > > > > > Hi Anoob/Konstantin, > > > > > > > > Check that ops->get_userdata is a valid function pointer will be > > > > compiled > out. > > > > So PMDs that don't implement this function will crash in > > > > rte_security_get_userdata(). > > > > In our particular case - ixgbe. >

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Ananyev, Konstantin
Hi Akhil, > > Hi Anoob/Konstantin, > > > > > > Check that ops->get_userdata is a valid function pointer will be compiled > > > out. > > > So PMDs that don't implement this function will crash in > > > rte_security_get_userdata(). > > > In our particular case - ixgbe. > > > Same story with rte_s

[dpdk-dev] [PATCH v2] crypto/aesni_mb: fix DOCSIS AES-256

2020-04-23 Thread Pablo de Lara
When adding support for DOCSIS AES-256, when setting the cipher parameters, all key sizes were accepted, but only 128-bit and 256-bit keys are supported. Fixes: 124d04b43743 ("crypto/aesni_mb: support DOCSIS AES-256") Signed-off-by: Pablo de Lara Acked-by: Mairtin o Loingsigh --- v2: - Fixed c

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-23 Thread Andrew Rybchenko
On 4/13/20 5:21 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > The order of mempool initiation affects mempool index in the > rte_mempool_ops_table. For example, when building APPs with: > > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... > > The "bucket" mempool will be regist

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of algo from NIST TDES test files

2020-04-23 Thread Anoob Joseph
> > Few of the NIST TDES test files don't contain TDES string. > Added indicators to identify such files. These indicators are part of only > NIST > TDES test vector files. > > Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing") > > Signed-off-by: Archana Muniganti > Signed-

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-23 Thread Ananyev, Konstantin
Hi Vladimir, Apologies for late review. My comments below. > K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. > This table is hash function agnostic so user must provide > precalculated hash signature for add/delete/lookup operations. > > Signed-off-by: Vladimir Medvedki

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Lukasz Wojciechowski
W dniu 23.04.2020 o 14:55, Akhil Goyal pisze: > Hi Anoob/Konstantin, >>> Check that ops->get_userdata is a valid function pointer will be compiled >>> out. >>> So PMDs that don't implement this function will crash in >>> rte_security_get_userdata(). >>> In our particular case - ixgbe. >>> Same s

[dpdk-dev] DPDK Release Status Meeting 23/04/2020

2020-04-23 Thread Ferruh Yigit
Minutes 23 April 2020 - Agenda: * Release Dates * Subtrees Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.05 dates: * Integration/Merge/RC1 pushed to *Friday 24 April 2020* * Release:

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: add per core packet stats

2020-04-23 Thread Anoob Joseph
Adding per core packet handling stats to analyze traffic distribution when multiple cores are engaged. Since aggregating the packet stats across cores would affect performance, keeping the feature disabled using compile time flags. Signed-off-by: Anoob Joseph --- v2: * Added lookup failure case

[dpdk-dev] [PATCH v2] net/ice/base: fix DCF switch rule

2020-04-23 Thread Qi Zhang
1. ln_en bit should not be turned on, since we only support Rx VEB. 2. lan_en bit need to be turn on for a DCF switch rule, otherwise any Tx packet that hit on a rule will be dropped. Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe") Signed-off-by: Qi Zhang --- v2:

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Akhil Goyal
Hi Anoob/Konstantin, > > > > Check that ops->get_userdata is a valid function pointer will be compiled > > out. > > So PMDs that don't implement this function will crash in > > rte_security_get_userdata(). > > In our particular case - ixgbe. > > Same story with rte_security_set_pkt_metadata() - s

Re: [dpdk-dev] [PATCH] mempool: remove inline functions from export list

2020-04-23 Thread Andrew Rybchenko
On 4/22/20 10:37 AM, Fady Bader wrote: > The code didn't compile when using exported mempool functions under windows. > > compilation error logs: > rte_mempool_exports.def : error LNK2001: > unresolved external symbol rte_mempool_cache_flush > rte_mempool_exports.def : error LNK2001: > unresolved

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-23 Thread Mattias Rönnblom
On 2020-04-22 22:35, Dan Gora wrote: > On Wed, Apr 22, 2020 at 5:14 PM Mattias Rönnblom > wrote: >> On 2020-04-22 19:44, Dan Gora wrote: >>> On Wed, Apr 22, 2020 at 5:28 AM Mattias Rönnblom >>> wrote: On 2020-04-21 21:54, Dan Gora wrote: > The getentropy() function was introduced into gl

[dpdk-dev] [PATCH v1] doc: QAT support for AES-256 DOCSIS

2020-04-23 Thread Mairtin o Loingsigh
Update QAT pmd to support AES-256 DOCSIS Signed-off-by: Mairtin o Loingsigh --- doc/guides/rel_notes/release_20_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 7f2049a0f..5e81c1964 100644 --- a/

Re: [dpdk-dev] [PATCH] eal: add madvise to avoid dump memory

2020-04-23 Thread Burakov, Anatoly
On 23-Apr-20 7:36 AM, Feng Li wrote: Hi, I have tested as follows, the core dump file is ~ 200KB. It should generate one core dump file each crash. #include #include #include #include #include #include int main(int argc, char** argv) { // FIXME(fengli): X uint64_t size = 1<<30; void*

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-23 Thread Luca Boccassi
On Thu, 2020-04-23 at 12:44 +0200, Thomas Monjalon wrote: > 23/04/2020 12:30, Luca Boccassi: > > On Thu, 2020-04-09 at 11:37 +0200, Thomas Monjalon wrote: > > > 09/04/2020 11:19, Bruce Richardson: > > > > On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > > > > > 08/04/2020 18:49, C

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, April 23, 2020 4:25 PM > To: Anoob Joseph ; dev@dpdk.org; Lukasz > Wojciechowski > Cc: akhil.go...@nxp.com; Doherty, Declan > Subject: [EXT] RE: [dpdk-dev] [PATCH] securi

Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree

2020-04-23 Thread Neil Horman
On Wed, Apr 22, 2020 at 02:18:05PM +0200, Thomas Monjalon wrote: > 22/04/2020 14:07, Neil Horman: > > On Wed, Apr 22, 2020 at 12:43:44PM +0100, Ray Kinsella wrote: > > > On 21/04/2020 22:42, Thomas Monjalon wrote: > > > > 21/04/2020 20:56, Neil Horman: > > > >> On Tue, Apr 21, 2020 at 01:46:43PM +0

Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree

2020-04-23 Thread Neil Horman
On Wed, Apr 22, 2020 at 02:16:57PM +0200, Thomas Monjalon wrote: > 22/04/2020 14:01, Neil Horman: > > On Tue, Apr 21, 2020 at 11:42:42PM +0200, Thomas Monjalon wrote: > > > 21/04/2020 20:56, Neil Horman: > > > > On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjalon wrote: > > > > > 21/04/2020 1

Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Ananyev, Konstantin
> > > > > > These are data path ops and so it will be better if we can avoid such > > > checks in > > the datapath. The same is done in ethdev also. > > > > AFAIK, get_userdata is an *optional* dev-ops function that can be used by > > data- > > path. > > So far there was no strict requirement

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Thomas Monjalon
23/04/2020 11:06, Dmitry Kozlyuk: > On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: > > 23/04/2020 01:51, Ranjit Menon: > > > On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: > > > > From: Tal Shnaiderman > > > > > > > > Move common functions between Unix and Windows to eal_config.c. > >

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-23 Thread Thomas Monjalon
23/04/2020 12:30, Luca Boccassi: > On Thu, 2020-04-09 at 11:37 +0200, Thomas Monjalon wrote: > > 09/04/2020 11:19, Bruce Richardson: > > > On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > > > > 08/04/2020 18:49, Ciara Power: > > > > > This patchset extensively reworks the telemetr

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-23 Thread Luca Boccassi
On Thu, 2020-04-09 at 11:37 +0200, Thomas Monjalon wrote: > 09/04/2020 11:19, Bruce Richardson: > > On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > > > 08/04/2020 18:49, Ciara Power: > > > > This patchset extensively reworks the telemetry library adding new > > > > functionality

[dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning

2020-04-23 Thread Ray Kinsella
Clarify the reasons behind the three part version numbering scheme. Documents the fixes made in f26c2b3. Signed-off-by: Ray Kinsella Signed-off-by: Bruce Richardson --- doc/guides/contributing/abi_policy.rst | 3 ++- doc/guides/rel_notes/release_20_05.rst | 12 2 files changed, 14

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-04-23 Thread Luca Boccassi
On Wed, 2020-04-22 at 17:35 -0300, Dan Gora wrote: > On Wed, Apr 22, 2020 at 5:14 PM Mattias Rönnblom > wrote: > > On 2020-04-22 19:44, Dan Gora wrote: > > > On Wed, Apr 22, 2020 at 5:28 AM Mattias Rönnblom > > > wrote: > > > > On 2020-04-21 21:54, Dan Gora wrote: > > > > > The getentropy() funct

Re: [dpdk-dev] [PATCH v8 2/9] net/virtio: enable vectorized path

2020-04-23 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, April 23, 2020 4:50 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: Van Haaren, Harry ; dev@dpdk.org > Subject: Re: [PATCH v8 2/9] net/virtio: enable vectorized path > > > > On 4/23/20 10:46 AM, Liu, Yong wrote

  1   2   >