Hi Akhil,
I have my concerns over unwanted checks in the datapath. Something that crypto
enqueue/dequeue APIs are not doing is being enforced on other APIs. As
Konstantin had suggested, PMDs (IXGBE here) could define a function which
returns -ENOTSUP and it would have been win-win for everyone.
Anyway, I don't have any objections to this.
Thanks,
Anoob
> -----Original Message-----
> From: Akhil Goyal <akhil.go...@nxp.com>
> Sent: Thursday, April 23, 2020 9:22 PM
> To: Konstantin Ananyev <konstantin.anan...@intel.com>; dev@dpdk.org;
> Anoob Joseph <ano...@marvell.com>
> Cc: declan.dohe...@intel.com; sta...@dpdk.org
> Subject: [EXT] RE: [PATCH v2] security: fix crash at accessing non-implemented
> ops
>
> External Email
>
> ----------------------------------------------------------------------
>
> > Valid checks for optional function pointers inside dev-ops were
> > disabled by undefined macro.
> >
> > Fixes: b6ee98547847 ("security: fix verification of parameters")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> > ---
>
> Acked-by: Akhil Goyal <akhil.go...@nxp.com>
>
> Anoob,
>
> Do you have any concerns over this patch?
>
> Regards,
> Akhil
