Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Ori Kam
Hi Guy, > -Original Message- > From: dev On Behalf Of Guy Kaneti > Sent: Tuesday, April 7, 2020 7:37 PM > To: Ori Kam ; Jerin Jacob ; > Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; xiang.w.w...@intel.com; > Pavan Nikhilesh Bhagavatula ; dev@dpdk.org; > Shahaf Shuler ; hemant.agra...

Re: [dpdk-dev] [PATCH v2] net/iavf: enable port reset

2020-04-07 Thread Ye Xiaolong
On 04/01, Lunyuan Cui wrote: >This patch is intended to add iavf_dev_reset ops, enable iavf to support >"port reset all". > >Signed-off-by: Lunyuan Cui >Acked-by: Jingjing Wu >--- > drivers/net/iavf/iavf_ethdev.c | 17 + > 1 file changed, 17 insertions(+) > >diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH v7] net/i40e: enable MAC address as FDIR input set

2020-04-07 Thread Ye Xiaolong
On 04/02, Lunyuan Cui wrote: >Enable source MAC address and destination MAC address as FDIR's >input set for ipv4-other, ipv4-udp and ipv4-tcp. When OVS-DPDK is >working as a pure L2 switch, enable MAC address as FDIR input set >with Mark+RSS action would help the performance speed up. And FVL >FDI

Re: [dpdk-dev] [PATCH v5] net/ice: fix RSS advanced rule invalid issue

2020-04-07 Thread Ye Xiaolong
On 04/07, Junyu Jiang wrote: >This patch moved the RSS initialization from dev start to dev configure >to fix RSS advanced rule invalid after running port stop and port start. > >Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") >Cc: sta...@dpdk.org > >Signed-off-by: Junyu Jiang >--- > drivers/

Re: [dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Xueming(Steven) Li
Thanks for your suggestion, will include them in next version. > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, April 8, 2020 1:12 PM > To: Xueming(Steven) Li > Cc: Anatoly Burakov ; Ferruh Yigit > ; dev@dpdk.org; Asaf Penso > Subject: Re: [dpdk-dev] [PATCH v1 1/2] mall

[dpdk-dev] [PATCH v3 10/11] net/iavf: add RSS hash parsing in AVX path

2020-04-07 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in AVX data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 92 ++- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v3 09/11] net/iavf: support flow mark in SSE path

2020-04-07 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in SSE path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/i

[dpdk-dev] [PATCH v3 11/11] net/iavf: add RSS hash parsing in SSE path

2020-04-07 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in SSE data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 86 ++-- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v3 06/11] net/iavf: add flow director enabled switch value

2020-04-07 Thread Leyi Rong
The commit adds fdir_enabled flag into iavf_rx_queue structure to identify if fdir id is active. Rx data path can be benefit if fdir id parsing is not needed, especially in vector path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_rxtx.h | 29 ++

[dpdk-dev] [PATCH v3 05/11] net/iavf: flexible Rx descriptor support in SSE path

2020-04-07 Thread Leyi Rong
Support flexible Rx descriptor format in SSE path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 4 +- drivers/net/iavf/iavf_rxtx.h | 5 + drivers/net/iavf/iavf_rxtx_vec_sse.c | 414 +++ 3 files changed, 421 insertions(+), 2 d

[dpdk-dev] [PATCH v3 08/11] net/iavf: support flow mark in AVX path

2020-04-07 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in AVX path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 72 +-- 1 file changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf

[dpdk-dev] [PATCH v3 07/11] net/iavf: support flow mark in normal data path

2020-04-07 Thread Leyi Rong
Support Flow Director mark ID parsing in normal path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 3 +++ drivers/net/iavf/iavf_rxtx.c | 37 2 files changed, 40 insertions(+) diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h inde

[dpdk-dev] [PATCH v3 04/11] net/iavf: flexible Rx descriptor support in AVX path

2020-04-07 Thread Leyi Rong
Support flexible Rx descriptor format in AVX path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 24 +- drivers/net/iavf/iavf_rxtx.h | 6 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 550 +- 3 files changed, 570 insertions(+), 1

[dpdk-dev] [PATCH v3 03/11] net/iavf: flexible Rx descriptor support in normal path

2020-04-07 Thread Leyi Rong
Support flexible Rx descriptor format in normal path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h| 2 + drivers/net/iavf/iavf_ethdev.c | 8 + drivers/net/iavf/iavf_rxtx.c | 479 ++--- drivers/net/iavf/iavf_rxtx.h | 8 + drivers/n

[dpdk-dev] [PATCH v3 02/11] net/iavf: return error if opcode is mismatched

2020-04-07 Thread Leyi Rong
Adds error return when the opcode of read message is mismatched which is received from adminQ. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index fa4

[dpdk-dev] [PATCH v3 00/11] framework for advanced iAVF PMD

2020-04-07 Thread Leyi Rong
This patchset enable framework for advanced iAVF, includes flexible descriptor support, FDIR mark id and RSS hash support. --- v3: - Remove patch to query DDP package info as it's specific to DCF. - Specify fdir_ref_cnt as per VF value for enable/disable FDIR ID parse. - Move fdir_enabled flag to

[dpdk-dev] [PATCH v3 01/11] net/iavf: flexible Rx descriptor definitions

2020-04-07 Thread Leyi Rong
Add definitions for flexible Rx descriptor structures and macros. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.h | 200 +++ 1 file changed, 200 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 09b5bd99e..5e30

Re: [dpdk-dev] [PATCH v3 2/7] net/virtio-user: add vectorized packed ring parameter

2020-04-07 Thread Ye Xiaolong
On 04/08, Marvin Liu wrote: >Add new parameter "packed_vec" which can disable vectorized packed ring >datapath explicitly. When "packed_vec" option is on, driver will check >packed ring vectorized datapath prerequisites. If any one of them not >matched, vectorized datapath won't be selected. > >Sig

Re: [dpdk-dev] [PATCH v3 1/7] net/virtio: add Rx free threshold setting

2020-04-07 Thread Ye Xiaolong
On 04/08, Marvin Liu wrote: >Introduce free threshold setting in Rx queue, default value of it is 32. >Limiated threshold size to multiple of four as only vectorized packed Rx s/Limiated/Limit >function will utilize it. Virtio driver will rearm Rx queue when more >than rx_free_thresh descs were d

Re: [dpdk-dev] [PATCH 2/2] ethdev: allow unknown link speed

2020-04-07 Thread Jerin Jacob
On Wed, Apr 8, 2020 at 3:57 AM Thomas Monjalon wrote: > > When querying the link informations, the link status is > a mandatory major information. > Other boolean values are supposed to be accurate: > - duplex mode (half/full) > - negotiation (auto/fixed) > > This API update is mak

Re: [dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

2020-04-07 Thread Asaf Penso
Thank you, Thomas, for taking care of this. PSB. Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, April 8, 2020 1:27 AM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Andrew Rybchenko > > Subject: [dpdk-dev] [PATCH 1/2] ethdev: deduplicate fu

Re: [dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Stephen Hemminger
On Wed, 8 Apr 2020 04:04:53 + Xueming Li wrote: > * Dump contents of all malloc heaps to a file. > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > index f9ede5b..25c4b13 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_ea

Re: [dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Stephen Hemminger
On Wed, 8 Apr 2020 04:04:53 + Xueming Li wrote: > int n_alloc_free = 0; > + int n_alloc = 0; > + int n_free_alloc = 0; > + int n_free = 0; > + size_t alloc_leak = 0; All statistics should be unsigned, size_t or uint64_t to avoid any wraparound issues.

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-07 Thread Honnappa Nagarahalli
> > Introduce relaxed tail sync (RTS) mode for MT ring synchronization. > Aim to reduce stall times in case when ring is used on overcommited cpus > (multiple active threads on the same cpu). > The main difference from original MP/MC algorithm is that tail value is > increased not by every threa

Re: [dpdk-dev] [PATCH v3 2/9] ring: prepare ring to allow new sync schemes

2020-04-07 Thread Honnappa Nagarahalli
> Subject: [PATCH v3 2/9] ring: prepare ring to allow new sync schemes > > Change from *single* to *sync_type* to allow different synchronisation > schemes to be applied. > Mark *single* as deprecated in comments. > Add new functions to allow user to query ring sync types. > Replace direct acces

Re: [dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test

2020-04-07 Thread Honnappa Nagarahalli
> Subject: [PATCH v3 1/9] test/ring: add contention stress test Minor, would 'add stress test for overcommitted use case' sound better? > > Introduce new test-case to measure ring perfomance under contention Minor, 'over committed' seems to the word commonly used from the references you provid

[dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Xueming Li
This patch introduces new feature to track rte_malloc leakage by logging malloc and free. Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_memcfg.h | 26 lib/librte_eal/common/malloc_elem.h | 6 +- lib/librte_eal/common/rte_malloc.c | 259 +++- li

[dpdk-dev] [PATCH v1 0/2] malloc: support malloc and free tracking log

2020-04-07 Thread Xueming Li
DPDK uses second level memory allocation management, this makes regular memory profiler tool not applicant. This patch trys to provide a lightweight malloc and free logging, then show leaked memory entries based on logs. This tool only target to malloc and free tracking, for memzone used by ring a

[dpdk-dev] [PATCH v1 2/2] app/testpmd: support malloc and free tracking log

2020-04-07 Thread Xueming Li
New CLI commands to manipulate malloc tracking log: dump_malloc start : start malloc tracking with number of buffers dump_malloc dump : dump mmalloc tracking log with detail level dump_malloc stop: stop malloc tracking Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c

Re: [dpdk-dev] [EXT] Re: [PATCH 01/13] librte_security: fix verification of parameters

2020-04-07 Thread Lukasz Wojciechowski
Hi, I pushed the 2nd version of patches. I hope I understood all your comments well. Many thanks, Lukasz W dniu 07.04.2020 o 08:20, Anoob Joseph pisze: > Hi Lukasz, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Lukasz Wojciechowski >> Sent: Tuesday, April

Re: [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

2020-04-07 Thread Xiaojun Liu
Hi Xiao, Please check the source file. It not looks align in patch file because the patch add "+" for each new line. Best regards, Xiaojun -Original Message- From: Wang, Xiao W [mailto:xiao.w.w...@intel.com] Sent: Thursday, April 02, 2020 4:42 PM To: Xiaojun Liu; Zhang, Qi Z; Kwan, Nga

[dpdk-dev] [PATCH v2 13/13] app/test: add rte security capability get tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_capability_get function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 522 +++ 1 file changed, 522 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 9da81fa1d..d5b76a127

[dpdk-dev] [PATCH v2 11/13] app/test: add rte security get userdata tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_get_userdata function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 191 +++ 1 file changed, 191 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index a1f0e7879..230b53891 10

[dpdk-dev] [PATCH v2 08/13] app/test: add rte security session stats get tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_stats_get function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 173 +++ 1 file changed, 173 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 9c5e7d0da..c495449

[dpdk-dev] [PATCH v2 12/13] app/test: add rte security capabilities get tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_capabilities_get function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 138 +++ 1 file changed, 138 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 230b53891..9da81fa1

[dpdk-dev] [PATCH v2 10/13] app/test: add rte security set pkt metadata tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_set_pkt_metadata function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 201 +++ 1 file changed, 201 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index b1a907bd9..a1f0e787

[dpdk-dev] [PATCH v2 09/13] app/test: add rte security session destroy tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_destroy function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 166 +++ 1 file changed, 166 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index c495449b0..b1a907bd9

[dpdk-dev] [PATCH v2 07/13] app/test: add rte security session get size tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_get_size function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 132 +++ 1 file changed, 132 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index daaf30b62..9c5e7d0d

[dpdk-dev] [PATCH v2 06/13] app/test: add rte security session update tests

2020-04-07 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_update function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 229 +++ 1 file changed, 229 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 3fc83abae..daaf30b62

[dpdk-dev] [PATCH v2 05/13] app/test: introduce librte security tests

2020-04-07 Thread Lukasz Wojciechowski
This patch introduces set of unit tests of librte_security API functions. Tests are added to dpdk-test application and can be run with "security_autotest" runtime command. This is the first patch in the series of patches as adding all test cases for all API functions in a single patch would make i

[dpdk-dev] [PATCH v2 03/13] security: fix session counter

2020-04-07 Thread Lukasz Wojciechowski
Fix session counter to be decreased in rte_security_session_destroy only when session was successfully destroyed. Formerly session counter was decreased prior session destroying and returning session object to mempool. It remained decreased even if session was not destroyed and mempool object rele

[dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-07 Thread Lukasz Wojciechowski
Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause as it might be already defined. Fixes: 5afc521eac6a ("eal: add test assert macros") Cc: pbhagavat...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Lukasz Wojciechowski --- app/test/test.h | 4 +++- 1 file changed, 3 inser

[dpdk-dev] [PATCH v2 02/13] security: fix return types in documentation

2020-04-07 Thread Lukasz Wojciechowski
Enhance returned values description for rte_security_session_destroy and some other minor description changes. Fixes: c261d1431bd8 ("security: introduce security API and framework") Cc: akhil.go...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Lukasz Wojciechowski --- lib/librte_security/rte_secu

[dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

2020-04-07 Thread Lukasz Wojciechowski
This patch adds verification of the parameters to the ret_security API functions. All required parameters are checked if they are not NULL. Checks verify full chain of pointers, e.g. in case of verification of "instance->ops->session_XXX", they check also "instance" and "instance->ops". Fixes: c2

[dpdk-dev] [PATCH v2 00/13] Fixes and unit tests for librte_security

2020-04-07 Thread Lukasz Wojciechowski
Set of patches fix minor issues like proper verification of input parameters and aligning documentation with code in the matter of return values. Another fixed issue is invalid decrementation of the session counter which might cause inconsistency between counter values and a true number of sessions

[dpdk-dev] [PATCH v2 2/2] test/bitmap: add bitmap create with all bits set case

2020-04-07 Thread Suanming Mou
Add the case to verify bitmap create with all bits set works correctly. Signed-off-by: Suanming Mou --- app/test/test_bitmap.c | 57 +- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c in

[dpdk-dev] [PATCH v2 1/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Suanming Mou
Currently, in the case to use bitmap as resource allocator, after bitmap creation, all the bitmap bits should be set to indicate the bit available. Every time when allocate one bit, search for the set bits and clear it to make it in use. Add a new rte_bitmap_init_with_all_set() function to have a

[dpdk-dev] [PATCH v2 0/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Suanming Mou
Currently, in the case to use bitmap as resource allocator, after bitmap creation, all the bitmap bits should be set to indicate the bit available. Every time when allocate one bit, search for the set bits and clear it to make it in use. Add a new rte_bitmap_init_with_all_set() function to have a

Re: [dpdk-dev] [PATCH 1/4] lib: introduce IF Proxy library

2020-04-07 Thread Varghese, Vipin
Hi Andrzej, Thanks for the reply. Please find explanations for some of the queries snipped > >> +uint64_t rte_ifpx_events_available(void) { > >> + /* All events are supported on Linux. */ > >> + return (1ULL << RTE_IFPX_NUM_EVENTS) - 1; > > Should we give the available from the used count? >

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Suanming Mou
Hi > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, April 8, 2020 1:48 AM > To: Suanming Mou > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/2] bitmap: add create bitmap with all bits set > > Hi Suanming, > > > -Original Message- > > From: Suanming Mou > > Sent

Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd

2020-04-07 Thread wangyunjian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, April 7, 2020 10:56 PM > To: wangyunjian > Cc: dev@dpdk.org; keith.wi...@intel.com; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix clo

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/5] net/tap: fix mbuf and mem leak during queue release

2020-04-07 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, April 7, 2020 8:55 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 2/5] net/tap:

[dpdk-dev] [PATCH v3 7/7] doc: add packed vectorized datapath

2020-04-07 Thread Marvin Liu
Document packed virtqueue vectorized datapath selection logic in virtio net PMD. Add packed virtqueue vectorized datapath features to new ini file. Signed-off-by: Marvin Liu diff --git a/doc/guides/nics/features/virtio-packed_vec.ini b/doc/guides/nics/features/virtio-packed_vec.ini new file mod

[dpdk-dev] [PATCH v3 1/7] net/virtio: add Rx free threshold setting

2020-04-07 Thread Marvin Liu
Introduce free threshold setting in Rx queue, default value of it is 32. Limiated threshold size to multiple of four as only vectorized packed Rx function will utilize it. Virtio driver will rearm Rx queue when more than rx_free_thresh descs were dequeued. Signed-off-by: Marvin Liu diff --git a/

[dpdk-dev] [PATCH v3 5/7] net/virtio: add vectorized packed ring Tx datapath

2020-04-07 Thread Marvin Liu
Optimize packed ring Tx datapath alike Rx datapath. Split Tx datapath into batch and single Tx functions. Batch function further optimized by vector instructions. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 10e39670e..c9aa

[dpdk-dev] [PATCH v3 4/7] net/virtio: reuse packed ring xmit functions

2020-04-07 Thread Marvin Liu
Move xmit offload and packed ring xmit enqueue function to header file. These functions will be reused by packed ring vectorized Tx function. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index ac417232b..b8b4d3c25 100644 --- a/drivers

[dpdk-dev] [PATCH v3 2/7] net/virtio-user: add vectorized packed ring parameter

2020-04-07 Thread Marvin Liu
Add new parameter "packed_vec" which can disable vectorized packed ring datapath explicitly. When "packed_vec" option is on, driver will check packed ring vectorized datapath prerequisites. If any one of them not matched, vectorized datapath won't be selected. Signed-off-by: Marvin Liu diff --gi

[dpdk-dev] [PATCH v3 3/7] net/virtio: add vectorized packed ring Rx function

2020-04-07 Thread Marvin Liu
Optimize packed ring Rx datapath when AVX512 enabled and mergeable buffer/Rx LRO offloading are not required. Solution of optimization is pretty like vhost, is that split datapath into batch and single functions. Batch function is further optimized by vector instructions. Also pad desc extra struct

[dpdk-dev] [PATCH v3 6/7] net/virtio: add election for vectorized datapath

2020-04-07 Thread Marvin Liu
Packed ring vectorized datapath will be selected when criterian matched. 1. AVX512 is enabled in dpdk config and supported by compiler 2. Host cpu has AVX512F flag 3. Ring size is power of two 4. virtio VERSION_1 and IN_ORDER features are negotiated 5. LRO and mergeable are disabled in Rx datapath

[dpdk-dev] [PATCH v3 0/7] add packed ring vectorized datapath

2020-04-07 Thread Marvin Liu
This patch set introduced vectorized datapath for packed ring. The size of packed ring descriptor is 16Bytes. Four batched descriptors are just placed into one cacheline. AVX512 instructions can well handle this kind of data. Packed ring TX datapath can fully transformed into vectorized datapath.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 3/5] net/tap: fix check for mbuf's nb_segs failure

2020-04-07 Thread wangyunjian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, April 8, 2020 12:08 AM > To: Ferruh Yigit > Cc: wangyunjian ; dev@dpdk.org; > keith.wi...@intel.com; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stabl

Re: [dpdk-dev] [PATCH v3 5/5] net/tap: fix netlink socket file descriptor check before close

2020-04-07 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, April 7, 2020 11:36 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/tap: fix netlink soc

Re: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types

2020-04-07 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 8, 2020 1:02 AM > To: Guo, Jia ; Ye, Xiaolong ; > Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei ; Guo, Jia > > Subject: RE: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types

[dpdk-dev] [PATCH v3 3/3] net/mlx4: fix build with -fno-common

2020-04-07 Thread Thomas Monjalon
The variable storages of the same name are merged together if compiled with -fcommon. This is the default. This default behaviour allows to declare a variable in a header file and share the variable in every .o binaries thanks to merge at link-time. In the case of dlopen linking of the glue librar

[dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10)

2020-04-07 Thread Thomas Monjalon
In GCC 10, -fno-common will be the default. There are 2 ways of solving issues: - add -fcommon - stop allocating variables in .h files In this patchset, the variables are declared extern, because it is cleaner anyway. v2: do not initialize global variables and Cc stable v3: fix rebase Thom

[dpdk-dev] [PATCH v3 1/3] common/mlx5: split glue initialization

2020-04-07 Thread Thomas Monjalon
The function mlx5_glue_init was doing three things: - initialize logs - load glue library if in dlopen mode - initialize glue layer They are split in three functions for clarity. The config option RTE_IBVERBS_LINK_DLOPEN is not used anymore outside of make and meson files.

[dpdk-dev] [PATCH v3 2/3] common/mlx5: fix build with -fno-common

2020-04-07 Thread Thomas Monjalon
The variable storages of the same name are merged together if compiled with -fcommon. This is the default. This default behaviour allows to declare a variable in a header file and share the variable in every .o binaries thanks to merge at link-time. In the case of dlopen linking of the glue librar

[dpdk-dev] [PATCH v2 3/3] net/mlx4: fix build with -fno-common

2020-04-07 Thread Thomas Monjalon
The variable storages of the same name are merged together if compiled with -fcommon. This is the default. This default behaviour allows to declare a variable in a header file and share the variable in every .o binaries thanks to merge at link-time. In the case of dlopen linking of the glue librar

[dpdk-dev] [PATCH v2 2/3] common/mlx5: fix build with -fno-common

2020-04-07 Thread Thomas Monjalon
The variable storages of the same name are merged together if compiled with -fcommon. This is the default. This default behaviour allows to declare a variable in a header file and share the variable in every .o binaries thanks to merge at link-time. In the case of dlopen linking of the glue librar

[dpdk-dev] [PATCH v2 1/3] common/mlx5: split glue initialization

2020-04-07 Thread Thomas Monjalon
The function mlx5_glue_init was doing three things: - initialize logs - load glue library if in dlopen mode - initialize glue layer They are split in three functions for clarity. The config option RTE_IBVERBS_LINK_DLOPEN is not used anymore outside of make and meson files.

[dpdk-dev] [PATCH v2 0/3] mlx: fix build with -fno-common (gcc 10)

2020-04-07 Thread Thomas Monjalon
In GCC 10, -fno-common will be the default. There are 2 ways of solving issues: - add -fcommon - stop allocating variables in .h files In this patchset, the variables are declared extern, because it is cleaner anyway. v2: do not initialize global variables and Cc stable Thomas Monjalon (3)

[dpdk-dev] [PATCH] log: fix level picked with globbing on type register

2020-04-07 Thread Thomas Monjalon
When a log type is registered, the level can be picked by matching saved options. The check of fnmatch globbing result was reversed. The same bug was already fixed in a similar function. This one is acting in log type register function. Note: this function rte_log_register_type_and_pick_level() i

[dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

2020-04-07 Thread Thomas Monjalon
There are two function to retrieve link informations. The only small difference is a boolean timeout parameter. Adding a new static function, with an additional parameter, removes the code redundancy. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 52 ++--

[dpdk-dev] [PATCH 0/2] ethdev link speed

2020-04-07 Thread Thomas Monjalon
Following 2 discussions about link speed, here is an API update and a small clean-up. Morten's proposal: http://inbox.dpdk.org/dev/4957996.Zugxlq0yvN@xps/ Recent Ivan's virtio patch assuming the same API update: http://inbox.dpdk.org/dev/20200406085855.25773-6-i.dyu...@samsung.com/ Benoit's propos

[dpdk-dev] [PATCH 2/2] ethdev: allow unknown link speed

2020-04-07 Thread Thomas Monjalon
When querying the link informations, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ET

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-07 Thread Neil Horman
On Tue, Apr 07, 2020 at 01:58:57PM +0200, Thomas Monjalon wrote: > 07/04/2020 13:33, Neil Horman: > > On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: > > > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: > > > > > > > > Since we've moved away from our initial abi_versioning.sh sc

Re: [dpdk-dev] Arm roadmap for 20.05

2020-04-07 Thread Mattias Rönnblom
On 2020-03-24 19:53, Honnappa Nagarahalli wrote: Subject: Re: [dpdk-dev] Arm roadmap for 20.05 On 2020-03-10 17:42, Honnappa Nagarahalli wrote: Hello, Following are the work items planned for 20.05: 1) Use C11 atomic APIs in timer library 2) Use C11 atomic APIs in service cores 3

Re: [dpdk-dev] [PATCH v2 1/4] raw/common: add multi-function interface

2020-04-07 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Friday, April 3, 2020 5:37 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Trahe, Fiona > ; De Lara Guarch, Pablo > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; Coyle, David > ; O'loingsigh, Mairtin > Subjec

Re: [dpdk-dev] [PATCH v2 4/4] app/crypto-perf: add support for multi-function processing

2020-04-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Friday, April 3, 2020 5:37 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Trahe, Fiona > ; De Lara Guarch, Pablo > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; Coyle, David > ; O'loingsigh, Mairtin > Subject: [PATC

Re: [dpdk-dev] [PATCH v2 2/4] raw/aesni_mb: add aesni_mb raw device

2020-04-07 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Friday, April 3, 2020 5:37 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Trahe, Fiona > ; De Lara Guarch, Pablo > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; Coyle, David > ; O'loingsigh, Mairtin > Subjec

Re: [dpdk-dev] [PATCH v3 1/4] ip_frag: ensure minimum v4 fragmentation length

2020-04-07 Thread Aaron Conole
"Ananyev, Konstantin" writes: >> >> "Ananyev, Konstantin" writes: >> >> >> >> >> The IPv4 specification says that each fragment must at least the size of >> >> an IP header plus 8 octets. When attempting to run ipfrag using a >> >> smaller size, the fragment library will return successful com

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-07 Thread Trahe, Fiona
Hi David, Ferruh, > -Original Message- > From: Coyle, David > Sent: Tuesday, April 7, 2020 12:28 PM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: Doherty, Declan ; Trahe, Fiona > ; De Lara > Guarch, Pablo ; Ryan, Brendan > ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; Akhil Goyal > >

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Dumitrescu, Cristian
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Tuesday, March 10, 2020 8:21 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: [PATCH 1/2] bitmap: add create bitmap with all bits set > > Currently, in the case to use bitmap as resource allocator, after > bitmap

Re: [dpdk-dev] [PATCH v4 1/4] lib/rcu: add resource reclamation APIs

2020-04-07 Thread Ananyev, Konstantin
> Add resource reclamation APIs to make it simple for applications > and libraries to integrate rte_rcu library. Few nits, thoughts, please see below. Apart from that - LGTM. Acked-by: Konstantin Ananyev > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ola Liljedhal > Reviewed-by: Ruife

Re: [dpdk-dev] [EXT] RE: [PATCH 1/2] ethdev: add tm cap for private shaper packet mode

2020-04-07 Thread Nithin Dabilpuram
Hi Cristian, Thanks for your comments. I have some queries below. On Tue, Apr 07, 2020 at 04:31:47PM +, Dumitrescu, Cristian wrote: > External Email > > -- > Hi Nithin, > > > -Original Message- > > From: Nithin Dabil

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-04-07 Thread Kevin Traynor
On 13/03/2020 09:22, Gavin Hu wrote: > Hi Bruce, > >> -Original Message- >> From: Bruce Richardson >> Sent: Wednesday, March 11, 2020 8:08 PM >> To: Morten Brørup >> Cc: Gavin Hu ; Ferruh Yigit ; >> dev@dpdk.org; nd ; david.march...@redhat.com; >> tho...@monjalon.net; ktray...@redhat.com

Re: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types

2020-04-07 Thread Iremonger, Bernard
Hi Jeff, > -Original Message- > From: dev On Behalf Of Jeff Guo > Sent: Thursday, March 26, 2020 4:41 PM > To: Ye, Xiaolong ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types

[dpdk-dev] [PATCH v3 4/4] net/mlx5: modify net PMD to use common MR driver

2020-04-07 Thread Vu Pham
Modify mlx5 net pmd driver to use MR management APIs from common driver. Signed-off-by: Vu Pham --- drivers/common/mlx5/Makefile |1 + drivers/common/mlx5/meson.build |1 + drivers/net/mlx5/mlx5.c |4 +- drivers/net/mlx5/mlx5.h | 12 +- drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH v3 1/4] common/mlx5: refactor multi-process IPC handling codes to common driver

2020-04-07 Thread Vu Pham
Refactor common multi-process handling codes from net PMD to common driver. Using tuple mp_id{name, port_id} as standard input parameter for all multi-process IPC APIs instead of using rte_eth_dev. Signed-off-by: Vu Pham --- drivers/common/mlx5/mlx5_common_mp.c| 188 +

[dpdk-dev] [PATCH v3 3/4] common/mlx5: refactor memory management codes

2020-04-07 Thread Vu Pham
Refactor common memory btree and cache management to common driver. Replace some input parameters of MR APIs to more common datastructure like PD, port_id, share_cache,... so that muliptle PMD drivers can use those MR APIs. Signed-off-by: Vu Pham --- drivers/common/mlx5/mlx5_common_mr.c

[dpdk-dev] [PATCH v3 0/4] refactor multi-process IPC and memory management codes to common driver

2020-04-07 Thread Vu Pham
Current mlx5 net PMD and future mlx5(regex,...) PMDs that run and share the same HCAs need to use common memory management driver. Memory management codes embeddedly use multi-process IPC for primary/secondary processes to register and sync on memory registrations MRs. That's the main reason to mo

[dpdk-dev] [PATCH v3 2/4] net/mlx5: modify net PMD to use common multi-process APIs

2020-04-07 Thread Vu Pham
Modify net PMD to use multi-process APIs from common driver. Signed-off-by: Vu Pham --- drivers/common/mlx5/Makefile| 3 +- drivers/common/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.c | 15 ++- drivers/net/mlx5/mlx5.h | 43 +--- drivers/net/mlx5/mlx5_mp.c |

[dpdk-dev] [PATCH v2 3/4] common/mlx5: refactor memory management codes

2020-04-07 Thread Vu Pham
Refactor common memory btree and cache management to common driver. Replace some input parameters of MR APIs to more common datastructure like PD, port_id, share_cache,... so that muliptle PMD drivers can use those MR APIs. Signed-off-by: Vu Pham --- drivers/common/mlx5/mlx5_common_mr.c

[dpdk-dev] [PATCH v2 1/4] common/mlx5: refactor MP IPC handling codes to common driver

2020-04-07 Thread Vu Pham
Refactor common mp handling codes from net pmd to common driver. Using port_id as standard input parameter for all MP IPC APIs instead of using rte_eth_dev. Signed-off-by: Vu Pham --- drivers/common/mlx5/mlx5_common_mp.c| 188 drivers/common/mlx5/mlx5_common_

[dpdk-dev] [PATCH v2 0/4] refactor multi-process IPC and memory management codes to common driver

2020-04-07 Thread Vu Pham
Current mlx5 net PMD and future mlx5(regex,...) PMDs that run and share the same HCAs need to use common memory management driver. Memory management codes embeddedly use multi-process IPC for primary/secondary processes to register and sync on memory registrations MRs. That's the main reason to mo

[dpdk-dev] [PATCH v2 4/4] net/mlx5: modify net pmd to use common MR driver

2020-04-07 Thread Vu Pham
Modify mlx5 net pmd driver to use MR managment APIs from common driver. Signed-off-by: Vu Pham --- drivers/common/mlx5/Makefile |1 + drivers/common/mlx5/meson.build |1 + drivers/net/mlx5/mlx5.c |4 +- drivers/net/mlx5/mlx5.h | 12 +- drivers/net/mlx5/mlx5_m

[dpdk-dev] [PATCH v2 2/4] net/mlx5: modify net pmd to use common multi-process APIs

2020-04-07 Thread Vu Pham
Modify net pmd to use common Multi-Process APIs from common driver. Signed-off-by: Vu Pham --- drivers/common/mlx5/Makefile| 3 +- drivers/common/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.c | 15 ++- drivers/net/mlx5/mlx5.h | 43 +--- drivers/net/mlx5/mlx5_mp.c

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Guy Kaneti
> -Original Message- > From: Ori Kam > Sent: Tuesday, April 07, 2020 7:29 PM > To: Guy Kaneti ; Jerin Jacob ; > Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; > xiang.w.w...@intel.com; Pavan Nikhilesh Bhagavatula > ; dev@dpdk.org; Shahaf Shuler > ; hemant.agra...@nxp.com; Opher Reviv

Re: [dpdk-dev] [PATCH 1/2] ethdev: add tm cap for private shaper packet mode

2020-04-07 Thread Dumitrescu, Cristian
Hi Nithin, > -Original Message- > From: Nithin Dabilpuram > Sent: Monday, March 30, 2020 5:00 PM > To: Dumitrescu, Cristian ; Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko > Cc: dev@dpdk.org; jer...@marvell.com; kka...@marvell.com; Nithin > Dabilpuram > Subject: [PATCH 1/2] eth

[dpdk-dev] [PATCH] build: gcc 10 disable stringop-overflow warnings

2020-04-07 Thread Kevin Traynor
stringop-overflow warns when it sees a possible overflow in a string operation. In the rte_memcpy functions different implementations are used depending on the size. stringop-overflow is raised for the paths in the function where it sees the static size of the src could be overflowed. However, in

  1   2   >