On Tue, Apr 07, 2020 at 01:58:57PM +0200, Thomas Monjalon wrote: > 07/04/2020 13:33, Neil Horman: > > On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: > > > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman <nhor...@tuxdriver.com> wrote: > > > > > > > > Since we've moved away from our initial abi_versioning.sh script, in > > > > > > abi_versioning.sh does not exist (idem with the patch title). > > > I suppose you meant validate-abi.sh. > > > > > Crud, you're right, I was convoluting terms, sorry. Shall I repost with a > > corrected changelog? > > Not only the commit log, look below how you did not care about the basic > usage of the new tool. > > > > > > favor of check_abi.sh, which uses libabigail, remove the old script from > > > > > > check-abi.sh > > > > > > > the tree, and update the docs accordingly > [...] > > > > --- a/doc/guides/contributing/abi_versioning.rst > > > > +++ b/doc/guides/contributing/abi_versioning.rst > > The maintainer of doc/guides/contributing/abi_*.rst > is Ray Kinsella so I add him as Cc. > > [...] > > > > -The syntax of the ``validate-abi.sh`` utility is:: > > > > +The syntax of the ``check-abi.sh`` utility is:: > > > > > > > > - ./devtools/validate-abi.sh <REV1> <REV2> > > > > + ./devtools/check-abi.sh <REV1> <REV2> > > > > > > The new script is not a direct replacement. > > > It won't take git revisions, but build directories where versions of > > > dpdk have been compiled. > > > > > > devtools/test-build.sh and devtools/test-meson-builds.sh illustrate its > > > use. > > > https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n127 > > David, I think Neil did not take time to understand what changed in > ABI tooling. > I really wonder who is the real maintainer of ABI tooling and policy. > Neil, Ray, I was expecting a better involvement in this major > policy enforcement. > > This is where we are: > - Neil asked first for ABI compatibility > - Neil created validate-abi.sh > - Ray asked for a strict policy > - Kevin worked on a new tooling > - David completed the tooling work > - David integrated ABI checks in Travis > > There are many people partly involved. > I think we need one person truly involved in ABI questions, > someone who feels responsible and will take care of details > like the documentation update requested above. > > Please don't rely on David and myself, we are already very busy > with making sure every patches are properly reviewed. > We need good help on the ABI topic in general. > We're all very busy Thomas, theres no need to get bent out of shape. You're right, I thought this was easier than it was, thinking that check-abi.sh was interface compatible, apologies. I'm going through this more carefully, and will repost soon.
FWIW, I don't think I'll be able to fill this role full time. I'm not sure if anyone else is either, i'm afraid. Neil > >
