Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Ori Kam
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, April 7, 2020 8:50 AM > To: Ori Kam > Cc: Thomas Monjalon ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com; Pavan Nikhilesh Bhagavatula > ; dev@dpdk.org; Shahaf Shuler > ; hemant.agra...@nxp.com; Opher Reviv > ; Alex Rosenb

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: support 192/256 AES key sizes

2020-04-06 Thread Anoob Joseph
Adding support for the following, 1. AES-192-GCM 2. AES-256-GCM 3. AES-192-CBC Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- v4: * Reverted to v2 as suggested by Akhil. * Added additional check in print routines to make sure correct key size is printed. * Updated incorrect do

Re: [dpdk-dev] [EXT] Re: [PATCH 01/13] librte_security: fix verification of parameters

2020-04-06 Thread Anoob Joseph
Hi Lukasz, Please see inline. Thanks, Anoob > -Original Message- > From: Lukasz Wojciechowski > Sent: Tuesday, April 7, 2020 12:19 AM > To: Anoob Joseph ; dev@dpdk.org > Cc: Narayana Prasad Raju Athreya ; Lukas Bartosik [C] > > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH 01/13] librte_sec

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-06 Thread Suanming Mou
On 4/3/2020 10:49 PM, Andrzej Ostruszka wrote: Hello Suanming Please find my comments below. However please note that so far I have never used DPDK bitmaps so I might not be the best person to comment - this patch needs some attention so I spent some time on it. Overall I'm fine with the chang

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Jerin Jacob
> > > > If it abstracts it properly adding vdev and PCI is a simple change. > > See > > > > lib/librte_eventdev/rte_eventdev_pmd_vdev.h > > lib/librte_eventdev/rte_eventdev_pmd_pci.h > > > > I think, the common code should take from other matured subsystem instead if > > writing from scratch, > > >

Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type

2020-04-06 Thread Jeff Guo
hi, Ori On 4/5/2020 11:56 PM, Ori Kam wrote: Hi Jeff, -Original Message- From: Jeff Guo Sent: Tuesday, March 31, 2020 11:50 AM To: Ori Kam ; xiaolong...@intel.com; qi.z.zh...@intel.com Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com; simei...@intel.com Subject: Re: [dpdk-

Re: [dpdk-dev] Arm roadmap for 20.05

2020-04-06 Thread Honnappa Nagarahalli
> Subject: RE: [dpdk-dev] Arm roadmap for 20.05 > > > (apologies Morten - I missed your response, consolidating the discussion in > this thread) > > + Intel x86 and IBM POWER maintainers > > > > > > > Subject: Re: [dpdk-dev] Arm roadmap for 20.05 > > > > > > > > On 2020-03-10 17:4

Re: [dpdk-dev] [PATCH v5] net/ice: fix RSS advanced rule invalid issue

2020-04-06 Thread Yang, Qiming
Acked-by: Qiming Yang > -Original Message- > From: Jiang, JunyuX > Sent: 2020年4月7日 9:48 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Jiang, JunyuX ; > sta...@dpdk.org > Subject: [PATCH v5] net/ice: fix RSS advanced rule invalid issue > > This patch moved the RSS initializatio

[dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd

2020-04-06 Thread wangyunjian
From: Yunjian Wang The internals is freed and setted NULL in the rte_eth_dev_release_port() and zero is a valid fd. As a result, a valid fd is incorrectly closed. Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- driver

[dpdk-dev] [PATCH v3 5/5] net/tap: fix netlink socket file descriptor check before close

2020-04-06 Thread wangyunjian
From: Yunjian Wang The "internals->nlsk_fd" is possibly a zero value. Error comparison should check for negative fd. Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file change

[dpdk-dev] [PATCH v3 2/5] net/tap: fix mbuf and mem leak during queue release

2020-04-06 Thread wangyunjian
From: Yunjian Wang For the tap PMD, we should release mbufs and iovecs from the Rx queue when close or remove device. Fixes: 0781f5762cfe ("net/tap: support segmented mbufs") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_tap.c | 12 1 file changed, 1

[dpdk-dev] [PATCH v3 3/5] net/tap: fix check for mbuf's nb_segs failure

2020-04-06 Thread wangyunjian
From: Yunjian Wang Now the rxq->pool is mbuf concatenation, But its nb_segs is 1. When do some sanity checks on the mbuf, it fails. Fixes: 0781f5762cfe ("net/tap: support segmented mbufs") CC: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_tap.c | 27 +

[dpdk-dev] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-06 Thread wangyunjian
From: Yunjian Wang When the tap_write_mbufs() function return with break, mbuf was freed without incrementing num_packets. This may lead applications also free the mbuf. And the pmd_tx_burst() function should returns the number of original packets it actually sent excluding tso mbufs. Fixes: 939

[dpdk-dev] [PATCH v3 0/5] fixes for tap

2020-04-06 Thread wangyunjian
From: Yunjian Wang This series include three fixes patches for tap PMD driver. -- v3: - Add fix close a vaild fd and netlink socket file descriptor check before close v2: - Add null check in tap_rxq_pool_free() Yunjian Wang (5): net/tap: fix mbuf double free when writev fails net/tap: fix

[dpdk-dev] [PATCH 8/8] net/mlx5: reorganize fallback counter management

2020-04-06 Thread Suanming Mou
Currently, the fallback counter is also allocated from the pool, the specify fallback function code becomes a bit duplicate. Reorganize the fallback counter code to make it reuse from the normal counter code. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH 3/8] net/mlx5: change verbs counter allocator to indexed

2020-04-06 Thread Suanming Mou
This is part of the counter optimize which will save the indexed counter id instead of the counter pointer in the rte_flow. Place the verbs counter into the container pool helps the counter to be indexed correctly independent with the raw counter. The counter pointer in rte_flow will be changed t

[dpdk-dev] [PATCH 7/8] net/mlx5: split the counter struct

2020-04-06 Thread Suanming Mou
Currently, the counter struct saves both the members used by batch counters and none batch counters. The members which are only used by none batch counters cost 16 bytes extra memory for batch counters. As normally there will be limited none batch counters, mix the none batch counter and batch coun

[dpdk-dev] [PATCH 4/8] common/mlx5: add batch counter id offset

2020-04-06 Thread Suanming Mou
This commit is a part for the DV counter optimization. The batch counter dcs id starts from 0x80 and none batch counter starts from 0. As currently, the counter is changed to be indexed by pool index and the offset of the counter in the pool counters_raw array. It means now the counter index i

[dpdk-dev] [PATCH 2/8] net/mlx5: optimize counter release query generation

2020-04-06 Thread Suanming Mou
Query generation was introduced to avoid counter to be reallocated before the counter statistics be fully updated. Since the counters be released between query trigger and query handler may miss the packets arrived in the trigger and handler gap period. In this case, user can only allocate the coun

[dpdk-dev] [PATCH 0/8] net/mlx5 counter optimize

2020-04-06 Thread Suanming Mou
In the plan of save the memory consumption for rte_flow, the counter memory consumption will be optimized from two perspective. Change the counter object saving as index instead of pointer in rte_flow. In this case, since currently the counters are allocated from the pool, counter can use the inde

[dpdk-dev] [PATCH 1/8] net/mlx5: fix incorrect counter container usage

2020-04-06 Thread Suanming Mou
As none-batch counter pool allocates only one counter every time, after the new allocated counter pop out, the pool will be empty and moved to the end of the container list in the container. Currently, the new non-batch counter allocation maybe happened with new counter pool allocated, it means th

[dpdk-dev] [PATCH] vhost: fix check peer close

2020-04-06 Thread qikai
In process_slave_message_reply(), there is a possibility that receiving a peer close message instead of a real message response. this patch targeting to handle the peer close scenario and report the correct error message. Signed-off-by: qikai --- lib/librte_vhost/vhost_user.c | 10 +- 1

Re: [dpdk-dev] DTS Config NIC | Test Nic Single Core Perf ISSUE

2020-04-06 Thread Tu, Lijuan
That’s because scapy naming conflict, replace system scapy with trex scapy. Here is an example: # backup system scapy if need. mv /usr/local/lib/python3.6/dist-packages/scapy /usr/local/lib/python3.6/dist-packages/scapy_default # replace scapy cp -fr /home/scm/trex1911_upstream/scripts/e

Re: [dpdk-dev] [EXT] Re: [PATCH v4 03/29] graph: implement node operations

2020-04-06 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Andrzej Ostruszka > Sent: Monday, April 6, 2020 11:27 PM > To: Jerin Jacob Kollanukkaran ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb...@ericsson.com; Pavan Nikhilesh > Bhaga

Re: [dpdk-dev] [PATCH v5] net/ice: fix RSS advanced rule invalid issue

2020-04-06 Thread He, Zhiwei
The patch V5 has test-by Zhiwei -Original Message- From: dev On Behalf Of Junyu Jiang Sent: Tuesday, April 7, 2020 9:48 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Yang, Qiming ; Jiang, JunyuX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v5] net/ice: fix RSS advanced rule invalid issue This p

[dpdk-dev] [PATCH v5] net/ice: fix RSS advanced rule invalid issue

2020-04-06 Thread Junyu Jiang
This patch moved the RSS initialization from dev start to dev configure to fix RSS advanced rule invalid after running port stop and port start. Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 50

Re: [dpdk-dev] [PATCH v2] net/iavf: enable port reset

2020-04-06 Thread Chen, Zhaoyan
Tested-by: Chen, Zhaoyan > -Original Message- > From: dev On Behalf Of Lunyuan Cui > Sent: Wednesday, April 1, 2020 3:12 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Jingjing > ; Cui, LunyuanX > Subject: [dpdk-dev] [PATCH v2] net/iavf: enable port reset > > This patch is intended to

[dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2020-04-06 Thread Qi Zhang
Update a switch rule' action from "to VSI" to "to VSI List" should only happen when the same rule has been programmed with a different fwd destination. This is already handled by below code block: m_entry = ice_find_adv_rule_entry(...) if (m_entry) { ... ice_adv_add_update_vsi_list

Re: [dpdk-dev] [PATCH 0/3] mlx: fix build with -fno-common (gcc 10)

2020-04-06 Thread Thomas Monjalon
17/03/2020 09:34, Matan Azrad: > From: Thomas Monjalon > > In GCC 10, -fno-common will be the default. > > There are 2 ways of solving issues: > > - add -fcommon > > - stop allocating variables in .h files > > > > In this patchset, the variables are declared extern, because it is cleaner > >

[dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition

2020-04-06 Thread Michael Haeuptle
This fix treats a 0 return value from vfio_open_group_fd in vfio_get_group_fd as the intended error condition instead of putting an incorrect 0 file descriptor in the vfio_group table. Sometimes, the creation of device files in sysfs is not instantaneously causing vfio_open_groupfd to return 0. Th

[dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition

2020-04-06 Thread Michael Haeuptle
This fix treats a 0 return value from vfio_open_group_fd in vfio_get_group_fd as the intended error condition instead of putting an incorrect 0 file descriptor in the vfio_group table. Sometimes, the creation of device files in sysfs is not instantaneously causing vfio_open_groupfd to return 0. Th

Re: [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally

2020-04-06 Thread David Marchand
On Fri, Apr 3, 2020 at 4:20 PM wrote: > Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and > meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API > flag globally. This change does not enable the flag globally. > This changes reduces the clutter across

Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition

2020-04-06 Thread David Marchand
On Mon, Apr 6, 2020 at 9:15 PM Haeuptle, Michael wrote: > This is my first submission... how do I get the fixes reference? I recommend reading: https://doc.dpdk.org/guides/contributing/patches.html But let me help you this time. For the missing Fixes: tag, we want to get the sha1 of the commit t

[dpdk-dev] [Bug 444] DPDK fails to receive packets in Azure when using more than 3 transmit queues

2020-04-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=444 Bug ID: 444 Summary: DPDK fails to receive packets in Azure when using more than 3 transmit queues Product: DPDK Version: 19.11 Hardware: All OS: Linux S

[dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-06 Thread Neil Horman
Since we've moved away from our initial abi_versioning.sh script, in favor of check_abi.sh, which uses libabigail, remove the old script from the tree, and update the docs accordingly Signed-off-by: Neil Horman CC: tho...@monjalon.net --- MAINTAINERS| 1 - devto

Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition

2020-04-06 Thread Haeuptle, Michael
Hi Dave, This is my first submission... how do I get the fixes reference? Back porting it to 19.11 would be great. This issue shows up in SPDK 20.01, which uses 19.11. -- Michael -Original Message- From: David Marchand [mailto:david.march...@redhat.com] Sent: Monday, April 6, 2020 7:2

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Ori Kam
Hi Best, Ori > -Original Message- > From: Jerin Jacob > Sent: Monday, April 6, 2020 4:39 PM > To: Thomas Monjalon > Cc: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com; Pavan Nikhilesh Bhagavatula > ; dev@dpdk.org; Shahaf Shuler > ; hemant.agra...@nxp.com; Opher Reviv > ;

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Monday, April 6, 2020 5:00 PM > To: Pavan Nikhilesh Bhagavatula ; Ori Kam > > Cc: Jerin Jacob Kollanukkaran ; xiang.w.w...@intel.com; > dev@dpdk.org; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex > Ros

Re: [dpdk-dev] [EXT] Re: [PATCH 01/13] librte_security: fix verification of parameters

2020-04-06 Thread Lukasz Wojciechowski
Dear Anoob, Thank you for your reply and hints. Now I have patches ready to send as version 2, but I hesitate, because I don't like the idea of placing all checks in #ifdefs for RTE_LIBRTE_SECURITY_DEBUG config option. Let me explain here why: The config flag as a debug one will be disabled b

[dpdk-dev] [PATCH v5] ethdev: fix for compiler warning when vtune profiling is on

2020-04-06 Thread eugeny . parshutin
From: Eugeny Parshutin Add the previous prototype for the 'profile_hook_rx_burst_cb' function to fix the compiler warning when the DPDK is built with 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled: /home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning: no previous prototype for profi

Re: [dpdk-dev] [PATCH v2 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-04-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: O'loingsigh, Mairtin > Sent: Monday, April 6, 2020 4:36 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; O'loingsigh, Mairtin > Subject: [PATCH v2 2/2] test/crypto: Add AES-256 DOCSIS test vectors > > This patch adds test vectors for AES-256 and sets AE

Re: [dpdk-dev] [PATCH v4 04/29] graph: implement node debug routines

2020-04-06 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: > From: Jerin Jacob > > Adding node debug API implementation support to dump > single or all the node objects to the given file. > > Signed-off-by: Jerin Jacob > Signed-off-by: Kiran Kumar K > Signed-off-by: Pavan Nikhilesh > Signed-off-by: Nithin

Re: [dpdk-dev] [PATCH v4 03/29] graph: implement node operations

2020-04-06 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: [...] > diff --git a/lib/librte_graph/node.c b/lib/librte_graph/node.c > index 336cd1c94..d04a0fce0 100644 > --- a/lib/librte_graph/node.c > +++ b/lib/librte_graph/node.c [...] > +static rte_edge_t > +edge_update(struct node *node, struct node *prev, rt

Re: [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support DOCSIS AES-256

2020-04-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: O'loingsigh, Mairtin > Sent: Monday, April 6, 2020 4:36 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; O'loingsigh, Mairtin > Subject: [PATCH v2 1/2] crypto/aesni_mb: support DOCSIS AES-256 > > This patch adds support for DOCSIS AES-256 when using AES

Re: [dpdk-dev] [PATCH v3 12/12] service: relax barriers with C11 atomic operations

2020-04-06 Thread Honnappa Nagarahalli
Just to get us on the same page on 'techniques to communicate data from writer to reader' (apologies if it is too trivial) Let us say that the writer has 512B (key point is - cannot be written atomically) that needs to be communicated to the reader. Since the data cannot be written atomically,

Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case

2020-04-06 Thread Dey, Souvik
Just for reference also attached the changed patch in text format with the changes requested below. Have raised a v3 of the patch too. Now bit ceckpatches and check-git-logs works fine and also updated vlan to VLAN. -- Thanks, Souvik From: Jerin Jacob Sent: Sunday, April 5, 2020 9:06 AM To: De

[dpdk-dev] [PATCH v3] net/bnx2x: handle guest VLAN for SR-IOV case

2020-04-06 Thread Dey, Souvik
From: Souvik Dey In case of bnx2xvf pmd, tx packets can support vland id in 2 ways: 1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the vlanid in mbuf->vlan_tci. 2. the tx packet itself has the vlan id included in the packet. The first case is working as expected but the second case wher

Re: [dpdk-dev] [PATCH] config: update MAX_FRAG to support jumbo packets

2020-04-06 Thread Ananyev, Konstantin
> > RTE_LIBRTE_IP_FRAG_MAX_FRAG flag value increased from 4 to 8. By this > pkt size greater than 6000 is supported in ip-fragmentation and > ip-reassembly. > > Fixes: 9788b93b9d5 ("config: MAX_FRAG updated to support the jumbo > packets") > Cc: sta...@dpdk.org > > Signed-off-by: Apeksha Gupta

[dpdk-dev] Windows DPDK progress

2020-04-06 Thread Thomas Monjalon
The roadmap for DPDK support on Windows is updated on the website: http://core.dpdk.org/roadmap/windows/ The last major step completed was: - MinGW integration for GCC support on Windows We are a bit late for these tasks: - basic memory management - other basic EAL

Re: [dpdk-dev] [EXT] [PATCH] net/bnx2x: add multicast MAC address filtering

2020-04-06 Thread Dey, Souvik
Hi All, Yes I did. I am not getting the below errors. sodey@SODEY-LMA MINGW64 ~/DPDK_Patch/patch $ ../dpdk/devtools/checkpatches.sh v2-0001-net-bnx2x-add-multicast-MAC-address-filtering 1/1 valid patch Also Fixed the Wrong tag issue with check-git-log.sh. Attached the patch in text format too

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-06 Thread Andrzej Ostruszka
On 4/6/20 4:59 PM, Jerin Jacob wrote: > On Mon, Apr 6, 2020 at 6:06 PM Andrzej Ostruszka wrote: [...] >>> +typedef uint32_t rte_graph_off_t; /**< Graph offset type. */ >>> +typedef uint32_t rte_node_t; /**< Node id type. */ >>> +typedef uint16_t rte_edge_t; /**< Edge id type. */ >>> +

Re: [dpdk-dev] [PATCH v2 1/4] raw/common: add multi-function interface

2020-04-06 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Friday, April 3, 2020 5:37 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Trahe, Fiona > ; De Lara Guarch, Pablo > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; Coyle, David > ; O'loingsigh, Mairtin > Subjec

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 4/8] net/netvsc: fix invalid rte_free on dev_close

2020-04-06 Thread Ferruh Yigit
On 3/31/2020 6:14 PM, Stephen Hemminger wrote: > The netvsc PMD was putting the mac address in private data but the > core rte_ethdev doesn't allow that it. It has to be in rte_malloc'd > memory or the a message will be printed on shutdown/close. It doesn't have to be rte_malloc'ed. Setting 'eth_d

Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support

2020-04-06 Thread Ferruh Yigit
On 3/25/2020 8:27 AM, Ori Kam wrote: > > >> -Original Message- >> From: dev On Behalf Of Dekel Peled >> Sent: Wednesday, March 25, 2020 10:13 AM >> To: Ori Kam ; wenzhuo...@intel.com; >> jingjing...@intel.com; bernard.iremon...@intel.com >> Cc: Matan Azrad ; dev@dpdk.org >> Subject: [dpd

[dpdk-dev] [PATCH v2 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-04-06 Thread Mairtin o Loingsigh
This patch adds test vectors for AES-256 and sets AESNI-MB as the target PMD Signed-off-by: Mairtin o Loingsigh --- app/test/test_cryptodev_aes_test_vectors.h | 81 ++ 1 file changed, 81 insertions(+) diff --git a/app/test/test_cryptodev_aes_test_vectors.h b/app/test/test_c

[dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support DOCSIS AES-256

2020-04-06 Thread Mairtin o Loingsigh
This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pm

[dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for split vring used idx

2020-04-06 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v3 2/2] virtio: one way barrier for split vring avail idx

2020-04-06 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v3 0/2] one way barrier for split vring idx

2020-04-06 Thread Joyce Kong
This patch set replaces the two-way barriers with C11 one-way barriers for split vring idx, when the frontend and backend are implemented in software. By doing PVP benchmarking, the test result showed the throughput increased 20% with the 0.001% of acceptable loss rate on Thunderx2 platform.[1] B

Re: [dpdk-dev] [PATCH] putting null checks on ops_name

2020-04-06 Thread Stephen Hemminger
On Mon, 6 Apr 2020 16:30:20 +0500 Muhammad Bilal wrote: > Bugzilla ID: 353 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: hemant.agra...@nxp.com > Signed-off-by: Muhammad Bilal > --- > lib/librte_mbuf/rte_mbuf_pool_ops.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff -

Re: [dpdk-dev] DPDK techboard minutes @25-Mar-2020

2020-04-06 Thread Stephen Hemminger
On Mon, 6 Apr 2020 06:08:23 + Hemant Agrawal wrote: > 2) How to share BPF with Linux >The current DPDK BPF support is not complete and there are missing > bits, which are DPDK specific. Specifically LD_INDIRECT/LD_ABSOLUTE and > classic BPF to DPDK BPF converter are missing. >

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-06 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 6:06 PM Andrzej Ostruszka wrote: > > Hello Jerin Hello Andrzej, > > I've started reviewing this and will go patch-by-patch so some of the > comments might sound silly and/or unnecessary. Thanks for the comments. > > + > > +/** > > + * @file rte_graph.h > > + * > > + *

Re: [dpdk-dev] /validate-abi.sh complains [PATCH v1 3/8] ring: introduce RTS ring mode

2020-04-06 Thread Neil Horman
On Mon, Apr 06, 2020 at 04:02:22PM +0200, Thomas Monjalon wrote: > 01/04/2020 14:52, Neil Horman: > > On Tue, Mar 31, 2020 at 09:24:41PM +0200, Thomas Monjalon wrote: > > > 31/03/2020 21:22, Thomas Monjalon: > > > > 31/03/2020 19:05, Ananyev, Konstantin: > > > > > Hi everyone, > > > > > > > > > >

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-06 Thread Ferruh Yigit
On 4/3/2020 5:36 PM, David Coyle wrote: > PLEASE NOTE: This patchset supercedes the following v1 patches which were > mistakenly added as stand-alone patches (apologies for any confusion this > may cause) > > https://patchwork.dpdk.org/patch/66733/ > https://patchwork.dpdk.org/patch/66735/ > https

Re: [dpdk-dev] [PATCH v3 05/29] graph: implement internal graph operation helpers

2020-04-06 Thread Jerin Jacob
> > +/* Check whether a node has connected path or parent node */ > > +int > > +graph_has_isolated_node(struct graph *graph) > > +{ > > + struct graph_node *graph_node; > > + > > + graph_mark_nodes_as_not_visited(graph); > > + > > + STAILQ_FOREACH(graph_node, &graph->node_list, next) {

Re: [dpdk-dev] /validate-abi.sh complains [PATCH v1 3/8] ring: introduce RTS ring mode

2020-04-06 Thread Thomas Monjalon
01/04/2020 14:52, Neil Horman: > On Tue, Mar 31, 2020 at 09:24:41PM +0200, Thomas Monjalon wrote: > > 31/03/2020 21:22, Thomas Monjalon: > > > 31/03/2020 19:05, Ananyev, Konstantin: > > > > Hi everyone, > > > > > > > > Have a question regarding validate-abi.sh. > > > > > > devtools/validate-abi.s

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Thomas Monjalon
06/04/2020 15:50, Pavan Nikhilesh Bhagavatula: > From: Thomas Monjalon > >> >06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > >> >> >> From: Pavan Nikhilesh Bhagavatula > >> >> >> > >+uint16_t > >> >> >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t > >> >qp_id, > >> >> >> > >+

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Thomas Monjalon >Sent: Monday, April 6, 2020 7:07 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Ori Kam ; Jerin Jacob Kollanukkaran >; xiang.w.w...@intel.com; dev@dpdk.org; >Shahaf Shuler ; hemant.agra...@nxp.com; >Opher Reviv ; Alex Rosenbaum >; Dovrat Zifroni ;

Re: [dpdk-dev] [PATCH v3 05/29] graph: implement internal graph operation helpers

2020-04-06 Thread Wang, Xiao W
Hi, Comment inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb...@er

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 7:00 PM Thomas Monjalon wrote: > > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > From: Pavan Nikhilesh Bhagavatula > > >> >> From: Pavan Nikhilesh Bhagavatula > > >> >> > > >> >> Looks like this implementation is incomplete? > > >> >> I don't see any pmd specific help

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Thomas Monjalon
06/04/2020 15:22, Pavan Nikhilesh Bhagavatula: > >06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > >> >> From: Pavan Nikhilesh Bhagavatula > >> >> > >+uint16_t > >> >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t > >qp_id, > >> >> > >+ struct rte_regex_ops **ops, ui

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-04-06 Thread Kevin Traynor
On 06/04/2020 14:28, Ali Alnubani wrote: > Hi, > >> -Original Message- >> From: Kevin Traynor >> Sent: Friday, March 20, 2020 9:34 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; Ali Alnubani ; >> benjamin.wal...@intel.com; David Christensen ; >> Hemant

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Thomas Monjalon
06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > From: Pavan Nikhilesh Bhagavatula > >> >> From: Pavan Nikhilesh Bhagavatula > >> >> > >> >> Looks like this implementation is incomplete? > >> >> I don't see any pmd specific helper functions for @see > >> >rte_cryptodev_pmd.c, > >> >> rte_eventdev

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-04-06 Thread Ali Alnubani
Hi, > -Original Message- > From: Kevin Traynor > Sent: Friday, March 20, 2020 9:34 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara

Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition

2020-04-06 Thread David Marchand
On Thu, Apr 2, 2020 at 12:11 PM Burakov, Anatoly wrote: > > On 31-Mar-20 5:56 PM, Michael Haeuptle wrote: > > This fix treats a 0 return value from vfio_open_group_fd > > in vfio_get_group_fd as the intended error condition instead > > of putting an incorrect 0 file descriptor in the vfio_group ta

Re: [dpdk-dev] questions about Windows basic memory management patch

2020-04-06 Thread Thomas Monjalon
06/04/2020 14:37, Dmitry Kozlyuk: > > Lastly, in the patch you implemented functions that were common for Linux > > and FreeBSD and in order to use them in Windows (e.g. eal_file_truncate > > that replaced ftruncate) and you got a duplicate code for Linux and > > FreeBSD, how can we solve this d

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Pavan Nikhilesh Bhagavatula
>06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: >> >> From: Pavan Nikhilesh Bhagavatula >> >> > >+uint16_t >> >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t >qp_id, >> >> > >+ struct rte_regex_ops **ops, uint16_t >nb_ops) >> >> > >+{ >> >> > >+ return regex_

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices

2020-04-06 Thread David Marchand
On Mon, Apr 6, 2020 at 11:32 AM Sunil Kumar Kori wrote: > It looks like there is no comment/objection on following patch and it can be > merged. The title does not reflect what this patch is about. I understand this as an optimisation for the pci bus scanning. I agree with Stephen comment. I

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 6:44 PM Thomas Monjalon wrote: > > 06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > > >> From: Pavan Nikhilesh Bhagavatula > > >> > >+uint16_t > > >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > > >> > >+ struct rte_regex_ops **op

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Thomas Monjalon
06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > >> From: Pavan Nikhilesh Bhagavatula > >> > >+uint16_t > >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > >> > >+ struct rte_regex_ops **ops, uint16_t nb_ops) > >> > >+{ > >> > >+ return regex_devices

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Pavan Nikhilesh Bhagavatula
Hi Ori, >Hi Pavan, > >> -Original Message- >> From: dev On Behalf Of Pavan Nikhilesh >Bhagavatula >> Sent: Sunday, April 5, 2020 8:11 PM >> To: Ori Kam ; Jerin Jacob Kollanukkaran >> ; xiang.w.w...@intel.com >> Cc: dev@dpdk.org; Shahaf Shuler ; >> hemant.agra...@nxp.com; Opher Reviv ; >Al

Re: [dpdk-dev] questions about Windows basic memory management patch

2020-04-06 Thread Dmitry Kozlyuk
Hi, > In the "eal/windows: fix rte_page_sizes with Clang on Windows" > (http://patches.dpdk.org/patch/67390/) patch I didn't understand the work > around that you did and what the problem was. Clang on Windows always uses uint32_t as an underlying type for enums. As a consequence, rte_hugepage_

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-06 Thread Andrzej Ostruszka
Hello Jerin I've started reviewing this and will go patch-by-patch so some of the comments might sound silly and/or unnecessary. On 3/31/20 9:29 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Graph architecture abstracts the data processing functions as > "node" and "link" them together

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Pavan Nikhilesh Bhagavatula
>> From: Pavan Nikhilesh Bhagavatula >> > >+uint16_t >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, >> > >+struct rte_regex_ops **ops, uint16_t nb_ops) >> > >+{ >> > >+ return regex_devices[dev_id]- >> > >>enqueue(regex_devices[dev_id], qp_id, >> > >+

[dpdk-dev] [PATCH] net/octeontx2: support for custom L2 header

2020-04-06 Thread psatheesh
From: Satheesh Paul A This patch adds SDP packet parsing support with custom L2 header, adds support to include a field from custom header for flow tag generation. Signed-off-by: Satheesh Paul A --- doc/guides/nics/octeontx2.rst | 2 +- drivers/common/octeontx2/hw/otx2_npc.h

[dpdk-dev] questions about Windows basic memory management patch

2020-04-06 Thread Fady Bader
Hi, I have a few questions regarding your memory management patch. In the "eal/windows: fix rte_page_sizes with Clang on Windows" (http://patches.dpdk.org/patch/67390/) patch I didn't understand the work around that you did and what the problem was. Regarding rte_mp functions I see you implemente

[dpdk-dev] [PATCH] putting null checks on ops_name

2020-04-06 Thread Muhammad Bilal
Bugzilla ID: 353 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: hemant.agra...@nxp.com Signed-off-by: Muhammad Bilal --- lib/librte_mbuf/rte_mbuf_pool_ops.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf/rte_mbuf_pool_ops

Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions

2020-04-06 Thread Thomas Monjalon
05/04/2020 17:04, Ori Kam: > From: Pavan Nikhilesh Bhagavatula > > >+uint16_t > > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > > >+ struct rte_regex_ops **ops, uint16_t nb_ops) > > >+{ > > >+ return regex_devices[dev_id]- > > >>enqueue(regex_devices[dev_id], q

Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support

2020-04-06 Thread Ferruh Yigit
On 4/6/2020 12:05 PM, Dekel Peled wrote: > Hi Ferruh, > > Is this patch ready to be applied in next-net? Hi Dekel, Most probably I can check it today.. > > Regards, > Dekel > >> -Original Message- >> From: Dekel Peled >> Sent: Sunday, March 29, 2020 12:21 PM >> To: wenzhuo...@intel.c

Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support

2020-04-06 Thread Dekel Peled
Hi Ferruh, Is this patch ready to be applied in next-net? Regards, Dekel > -Original Message- > From: Dekel Peled > Sent: Sunday, March 29, 2020 12:21 PM > To: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com > Cc: Matan Azrad ; dev@dpdk.org; Ori Kam > > Subje

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2020-04-06 Thread Ananyev, Konstantin
Hi guys, > On Fri, Oct 4, 2019 at 7:39 PM Daniel Borkmann wrote: > > > > On 10/4/19 12:53 PM, Thomas Monjalon wrote: > > > 04/10/2019 11:54, Steve Capper: > > >> I'd recommend also reaching out the BPF maintainers: > > >> BPF JIT for ARM64 > > >> M: Daniel Borkmann > > >> M: Alexei Starovoi

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-04-06 Thread Burakov, Anatoly
On 13-Mar-20 10:04 AM, David Marchand wrote: On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: This commit releases all service cores from their role, returning them to ROLE_RTE on rte_service_finalize(). This may fix an issue relating to the service cores causing s/may fix/fixes/ a

Re: [dpdk-dev] [PATCH 5/8] net/octeontx: add VLAN filter offload support

2020-04-06 Thread Harman Kalra
On Mon, Mar 16, 2020 at 03:03:41PM +0530, Harman Kalra wrote: > From: Vamsi Attunuru > > Patch adds support for vlan filter offload support. > MBOX messages for vlan filter on/off and vlan filter > entry add/rm are added to configure PCAM entries to > filter out the vlan traffic on a given port.

Re: [dpdk-dev] [PATCH 7/8] net/octeontx: add flow control support

2020-04-06 Thread Harman Kalra
On Mon, Mar 16, 2020 at 03:03:43PM +0530, Harman Kalra wrote: > From: Vamsi Attunuru > > Patch adds ethdev flow control set/get callback ops, > pmd enables modifying flow control attributes like > rx_pause, tx_pause, high & low water mark. > > Signed-off-by: Vamsi Attunuru Acked-by: Harman Kal

Re: [dpdk-dev] [PATCH v3 1/1] net/octeontx: fix meson build for disabled octeontx drivers

2020-04-06 Thread Harman Kalra
On Wed, Mar 04, 2020 at 11:17:04AM +0530, agup...@marvell.com wrote: > From: Amit Gupta > > Add a condition to check if octeontx drivers are disabled. > octeontx drivers are built only if dependent drivers i.e. > ethdev, mempool and common/octeontx are enabled. > > Bugzilla ID: 387 > > Fixes: 7

Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-04-06 Thread Harman Kalra
On Mon, Feb 17, 2020 at 01:10:29PM +0530, agup...@marvell.com wrote: > From: Amit Gupta > > Add a condition to check if octeontx drivers are disabled. > octeontx drivers are built only if dependent drivers i.e. > ethdev, mempool and common/octeontx are enabled. > > BugZilla ID # BUG 387 > > Cha

Re: [dpdk-dev] [PATCH 3/4] event/octeontx: add VLAN filter offload support

2020-04-06 Thread Harman Kalra
On Mon, Mar 16, 2020 at 08:59:12PM +0530, Harman Kalra wrote: > From: Vamsi Attunuru > > Adding rx burst function pointer hooks for vlan filter > offload in event PMD. > > Signed-off-by: Vamsi Attunuru Acked-by: Harman Kalra > --- > drivers/event/octeontx/ssovf_worker.c | 38 +++

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices

2020-04-06 Thread Sunil Kumar Kori
Hello, It looks like there is no comment/objection on following patch and it can be merged. I would request to @David Marchand, please take care of this towards the merging process for 20.05. Regards Sunil Kumar Kori >-Original Message- >From: Sunil Kumar Kori >Sent: Monday, March

Re: [dpdk-dev] [PATCH] [v2 1/1] examples/l2fwd: add cmdline option for forwarding port info

2020-04-06 Thread Andrzej Ostruszka [C]
On 4/5/20 5:52 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Current l2fwd application configures adjacent ports as destination > ports for forwarding the traffic which is a kind of static mapping > that can not be altered by the command line options. > > Patch adds a config option

Re: [dpdk-dev] [EXT] Re: [PATCH v3 11/11] net/octeontx2: add tm capability callbacks

2020-04-06 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 2:45 PM Nithin Dabilpuram wrote: > > > > > > diff --git a/doc/guides/nics/features/octeontx2.ini > > > b/doc/guides/nics/features/octeontx2.ini > > > index 473fe56..fb13517 100644 > > > --- a/doc/guides/nics/features/octeontx2.ini > > > +++ b/doc/guides/nics/features/octeo

  1   2   >