On Fri, Apr 3, 2020 at 4:20 PM <pbhagavat...@marvell.com> wrote:
> Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and
> meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API
> flag globally.
This change does not enable the flag globally.
> This changes reduces the clutter across the project while still maintaining
> the functionality of ALLOW_EXPERIMENTAL_API i.e. warning external
> applications about experimental API usage.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
> Acked-by: Hemant Agrawal <hemant.agra...@nxp.com>
[snip]
> diff --git a/app/meson.build b/app/meson.build
> index 71109cc42..7e9193fc3 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -26,7 +26,6 @@ default_cflags = machine_args
> foreach app:apps
> build = true
> name = app
> - allow_experimental_apis = false
> sources = []
> includes = []
> cflags = default_cflags
> @@ -53,10 +52,7 @@ foreach app:apps
> link_libs = dpdk_static_libraries + dpdk_drivers
> endif
>
> - if allow_experimental_apis
> - cflags += '-DALLOW_EXPERIMENTAL_API'
> - endif
> -
> + cflags += '-DALLOW_EXPERIMENTAL_API'
> executable('dpdk-' + name,
> sources,
> c_args: cflags,
Please apply the same logic in app/ than for drivers/.
This will spare us the special app/test/meson.build thing, which can
be removed too.
[snip]
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 000bbf501..9059f9563 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -62,6 +62,12 @@ New Features
>
> * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit.
>
> +* **Enable ALLOW_EXPERIMENTAL_API flag globally.**
> +
> + Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and
> + meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API
> + flag globally.
> +
Reading this and the sections we have, it does not fit here.
This is not a new feature.
This change only affects DPDK contributors, so let's just drop the
release notes update.
>
> Removed Items
> -------------
[snip]
> diff --git a/lib/meson.build b/lib/meson.build
> index 9c3cc55d5..3bf14fcdf 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -47,7 +47,6 @@ foreach l:libraries
> build = true
> reason = '<unknown reason>' # set if build == false to explain why
> name = l
> - allow_experimental_apis = false
> use_function_versioning = false
> sources = []
> headers = []
> @@ -98,9 +97,7 @@ foreach l:libraries
> static_dep = shared_dep
> else
>
> - if allow_experimental_apis
> - cflags += '-DALLOW_EXPERIMENTAL_API'
> - endif
> + cflags += '-DALLOW_EXPERIMENTAL_API'
> if use_function_versioning
> cflags += '-DRTE_USE_FUNCTION_VERSIONING'
> endif
Ditto, apply same logic than drivers/meson.build
Thanks.
--
David Marchand
