Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-20 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger > Sent: Friday, March 20, 2020 5:55 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; olivier.m...@6wind.com; honnappa.nagaraha...@arm.com; > jer...@marvell.com; d...@linux.vnet.ibm.com > Subject: Re: [RFC] ring: make ring implementation n

Re: [dpdk-dev] Arm roadmap for 20.05

2020-03-20 Thread Honnappa Nagarahalli
> Subject: Re: [dpdk-dev] Arm roadmap for 20.05 > > On 2020-03-10 17:42, Honnappa Nagarahalli wrote: > > Hello, > > Following are the work items planned for 20.05: > > > > 1) Use C11 atomic APIs in timer library > > 2) Use C11 atomic APIs in service cores > > 3) Use C11 atomics in VirtIO spl

[dpdk-dev] 18.11.7 (LTS) patches review and test

2020-03-20 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.7. The planned date for the final release is 14th April. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations

Re: [dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak

2020-03-20 Thread Kevin Traynor
On 20/03/2020 16:23, Maxime Coquelin wrote: > > > On 3/19/20 6:15 PM, Kevin Traynor wrote: >> Hi Itsuro, >> >> On 05/03/2020 02:54, Itsuro Oda wrote: >>> If a vhost device is closed before eth_dev_configure is done >>> to the device, internal resources allocated to the device >>> would not be fre

Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-03-20 Thread Honnappa Nagarahalli
+ Erik as there are similar changes to timer library > > > > Subject: [PATCH v3 00/12] generic rte atomic APIs deprecate proposal > > > > > > DPDK provides generic rte_atomic APIs to do several atomic operations. > > > These APIs are using the deprecated __sync built-ins and enforce > > > full

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-20 Thread Stephen Hemminger
On Fri, 20 Mar 2020 16:41:38 + Konstantin Ananyev wrote: > As was discussed here: > http://mails.dpdk.org/archives/dev/2020-February/158586.html > this RFC aimed to hide ring internals into .c and make all > ring functions non-inlined. In theory that might help to > maintain ABI stability in

[dpdk-dev] [PATCH] net/mlx5: fix gcc 10 enum-conversion warning

2020-03-20 Thread Kevin Traynor
gcc 10.0.1 reports warnings when using mlx5_rte_flow enums with rte_flow type enums. For example: ../drivers/net/mlx5/mlx5_flow.c: In function ‘flow_hairpin_split’: ../drivers/net/mlx5/mlx5_flow.c:3406:19: warning: implicit conversion from ‘enum mlx5_rte_flow_action_type’ to ‘enum rte_flow_action

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-03-20 Thread Ananyev, Konstantin
> > > > > > I tested on an arm64 HW. The former section is without the > > patch(20.02) and later one with this patch. > > I agree with Konstantin that getting more platform tests will be good > > early so that we can focus on the approach > > to avoid back and forth latter. > > > > > > RTE>>ring_

[dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-03-20 Thread Konstantin Ananyev
As was discussed here: http://mails.dpdk.org/archives/dev/2020-February/158586.html this RFC aimed to hide ring internals into .c and make all ring functions non-inlined. In theory that might help to maintain ABI stability in future. This is just a POC to measure the impact of proposed idea, proper

Re: [dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak

2020-03-20 Thread Maxime Coquelin
On 3/19/20 6:15 PM, Kevin Traynor wrote: > Hi Itsuro, > > On 05/03/2020 02:54, Itsuro Oda wrote: >> If a vhost device is closed before eth_dev_configure is done >> to the device, internal resources allocated to the device >> would not be freed. This patch fixes it. >> >> Fixes: 3d01b759d267 ("n

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-03-20 Thread Andrzej Ostruszka
Viacheslav, thanks for the patches. I'll comment here on the whole patch set. This patch set has many similar changes so I'll focus on the first (csumonly) and the comment will apply to all remaining - OK? On 3/19/20 2:50 PM, Viacheslav Ovsiienko wrote: > The execution time of rx/tx burst routin

[dpdk-dev] [PATCH v2] mbuf: optimize memory loads during mbuf freeing

2020-03-20 Thread Alexander Kozyrev
Introduction of pinned external buffers doubled memory loads in the rte_pktmbuf_prefree_seg() function. Analysis of the generated assembly code shows unnecessary load of the pool field of the rte_mbuf structure. Here is the snippet of the assembly for "if (!RTE_MBUF_DIRECT(m))": Before the change t

Re: [dpdk-dev] [PATCH] mbuf: optimize memory loads during mbuf freeing

2020-03-20 Thread Alexander Kozyrev
You are right, Olivier, thanks for your suggestion - it looks even better. I've tested this version and the performance is great - will send a v2 shortly. Regards, Alex > -Original Message- > From: Olivier Matz > Sent: Thursday, March 19, 2020 5:30 > To: Alexander Kozyrev > Cc: dev@dpdk

Re: [dpdk-dev] [RFC PATCH 0/5] Support Intel IPSec MB v0.53 in DPDK 18.11

2020-03-20 Thread De Lara Guarch, Pablo
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Thursday, March 19, 2020 2:32 PM > To: De Lara Guarch, Pablo ; sta...@dpdk.org > Cc: Luca Boccassi ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 0/5] Support Intel IPSec MB v0.53 in DPDK > 18.11 > > +sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH 11/12] lib: add telemetry as eal dependency

2020-03-20 Thread Bruce Richardson
On Fri, Mar 20, 2020 at 05:33:38PM +0530, Jerin Jacob wrote: > On Thu, Mar 19, 2020 at 11:07 PM Ciara Power wrote: > > > > This patch moves telemetry further down the build, and adds it as a > > dependency for EAL. Telemetry is now configured to build by default, and > > has EAL flags, shown below

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: select iova-mode va with no-huge option

2020-03-20 Thread Jerin Jacob
On Fri, Feb 21, 2020 at 4:22 AM David Wilder wrote: > > If --no-huge is set and iova-mode has not been specified force VA mode. > If --no-huge and --iova-mode=PA is requested error out as this is > an impossible configuration. > > Signed-off-by: David Wilder > --- > lib/librte_eal/linux/eal/eal.

Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file

2020-03-20 Thread Jerin Jacob
On Thu, Mar 19, 2020 at 1:41 PM David Marchand wrote: > > On Mon, Mar 16, 2020 at 8:08 PM David Christensen > wrote: > > On 3/16/20 10:49 AM, David Christensen wrote: > > > > > >> The rte_pci.h file includes more header files than are actually needed, > > >> which means that all users of it also

[dpdk-dev] [Bug 395] Build of hinic with GCC 10.0.1 fails on aarch64

2020-03-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=395 Luca Boccassi (luca.bocca...@gmail.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolut

Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-03-20 Thread Jerin Jacob
On Fri, Mar 20, 2020 at 10:31 AM Honnappa Nagarahalli wrote: > > > > > Subject: Re: [PATCH v3 00/12] generic rte atomic APIs deprecate proposal > > > > 18/03/2020 15:01, Van Haaren, Harry: > > > Hi Phil & Honnappa, > > > > > > From: Phil Yang > > > > > > > > DPDK provides generic rte_atomic APIs

Re: [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app

2020-03-20 Thread Jerin Jacob
On Fri, Mar 20, 2020 at 5:21 PM Thomas Monjalon wrote: > > 20/03/2020 07:49, Jerin Jacob: > > On Tue, Mar 17, 2020 at 7:16 PM Wisam Jaddo wrote: > > > > Thanks for this application. Useful stuff. > > > > > > > > Introducing new application for rte_flow performance > > > testing. The application p

Re: [dpdk-dev] [PATCH 11/12] lib: add telemetry as eal dependency

2020-03-20 Thread Jerin Jacob
On Thu, Mar 19, 2020 at 11:07 PM Ciara Power wrote: > > This patch moves telemetry further down the build, and adds it as a > dependency for EAL. Telemetry is now configured to build by default, and > has EAL flags, shown below: > "--telemetry" = Enables telemetry (this is default if no flags give

Re: [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app

2020-03-20 Thread Thomas Monjalon
20/03/2020 07:49, Jerin Jacob: > On Tue, Mar 17, 2020 at 7:16 PM Wisam Jaddo wrote: > > Thanks for this application. Useful stuff. > > > > > Introducing new application for rte_flow performance > > testing. The application provide the ability to test > > insertion rate of specific rte_flow rule,

Re: [dpdk-dev] [PATCH] eal: reorganize directories layout

2020-03-20 Thread Thomas Monjalon
20/03/2020 10:34, Bruce Richardson: > On Fri, Mar 20, 2020 at 01:12:18AM +0100, Thomas Monjalon wrote: > > Some clean-up is done in EAL sub-directories. > > The goal is to make organization easier to understand, > > and to prepare moving some files from common to Unix-only place. > > > > Since the

[dpdk-dev] [PATCH v1] net/axgbe: add RSS reta/hash query and update

2020-03-20 Thread chandu
From: Chandu Babu N add support for RSS ethdev_ops reta_update, reta_query rss_hash_update, rss_hash_conf_get Signed-off-by: Chandu Babu N --- drivers/net/axgbe/axgbe_dev.c| 5 +- drivers/net/axgbe/axgbe_ethdev.c | 146 +++ drivers/net/axgbe/axgbe_ethdev.h |

Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-03-20 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Friday, March 20, 2020 6:45 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; rahul.lakkire...@chelsio.com; Wang, Xiao W > ; xavier.hu...@huawei.com; Xing, Beilei > ; Lu, Wenzhuo ; Yang, Qiming > ; Ananyev, Konstantin > ; Yigit, Ferruh ; > je

Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-03-20 Thread Thomas Monjalon
20/03/2020 06:35, Zhang, Qi Z: > Hi Thomas: > > From: Thomas Monjalon > > > > This series aims to clean-up the big table of ethdev features: > > http://doc.dpdk.org/guides/nics/overview.html#id1 > > > > We could reorganize the information in this table, maybe split it or > > add/remove > > s

Re: [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM clock frequency from register

2020-03-20 Thread Kevin Traynor
On 20/03/2020 07:14, Zhang, Qi Z wrote: > Hi Kevin: > >> -Original Message- >> From: Kevin Traynor >> Sent: Monday, March 9, 2020 11:45 PM >> To: Zhang, Qi Z ; Yang, Qiming >> ; Xing, Beilei >> Cc: Ye, Xiaolong ; dev@dpdk.org; Shelton, Benjamin H >> ; Stillwell Jr, Paul M >> >> Subject:

Re: [dpdk-dev] [PATCH v4] app/testpmd: add fw version in port info

2020-03-20 Thread Ferruh Yigit
On 3/20/2020 6:46 AM, Muhammad Ahmad wrote: > rte_eth_dev_fw_version_get() was not called in test pmd. >  Added rte_eth_dev_fw_version_get() in testpmd under > show port info > > Bugzilla ID: 225 > > Cc: dev@dpdk.org > > Reported-by: Thomas Monjalon > Signed-off-by: Muhammad Ahmad Reviewed-b

Re: [dpdk-dev] OVS-DPDK public meeting

2020-03-20 Thread Kevin Traynor
Next meeting April 1st 1700 UTC Attendees: Eelco, Aaron, Marcelo, Lance, Majd, Malvika, Simon, Somnath, David, Ajit, Ameer, Daniel, Fouad, Gaetan, Harsha, Hemal, Ian, Ilya, Johann, Oz, Roni, Scott, Thomas, Kevin. March 18th Minutes - Recording is here -- https://bluejeans.com/s/6wR3z Agenda: -

Re: [dpdk-dev] [PATCH v2 0/7] Fix LRO issue and support Flow Control

2020-03-20 Thread Ferruh Yigit
On 3/17/2020 3:01 PM, Xiaoyun wang wrote: > This patch fixes LRO and hotupdate firmware problems, > optimize doorbell area initialization without const macro > definition, Optimize log files, support pause flow control > and inner vxlan or non vxlan dport filter type. > > -- > v1->v2: > - Fix LR

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-20 Thread Kevin Traynor
On 20/03/2020 09:53, Muhammad Bilal wrote: > On Fri, Mar 20, 2020 at 2:39 PM Luca Boccassi wrote: >> >> On Fri, 2020-03-20 at 13:02 +0500, Muhammad Bilal wrote: >>> in doc-clean removing the folder which contain >>> the text files and no .rst files, >>> they cause problem When switching branches a

Re: [dpdk-dev] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-20 Thread Muhammad Bilal
On Fri, Mar 20, 2020 at 2:39 PM Luca Boccassi wrote: > > On Fri, 2020-03-20 at 13:02 +0500, Muhammad Bilal wrote: > > in doc-clean removing the folder which contain > > the text files and no .rst files, > > they cause problem When switching branches and compiling > > the documentation for older re

Re: [dpdk-dev] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-20 Thread Luca Boccassi
On Fri, 2020-03-20 at 13:02 +0500, Muhammad Bilal wrote: > in doc-clean removing the folder which contain > the text files and no .rst files, > they cause problem When switching branches and compiling > the documentation for older releases (for example > building a documentation on 18.11 or 17.11,

Re: [dpdk-dev] [PATCH] eal: reorganize directories layout

2020-03-20 Thread Bruce Richardson
On Fri, Mar 20, 2020 at 01:12:18AM +0100, Thomas Monjalon wrote: > Some clean-up is done in EAL sub-directories. > The goal is to make organization easier to understand, > and to prepare moving some files from common to Unix-only place. > > Since the kernel modules are moved to kernel/ directory,

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-20 Thread Ray Kinsella
On 19/03/2020 16:13, Pavan Nikhilesh Bhagavatula wrote: > > >> -Original Message- >> From: Ray Kinsella >> Sent: Thursday, March 19, 2020 9:21 PM >> To: Pavan Nikhilesh Bhagavatula ; Jerin >> Jacob Kollanukkaran ; Nithin Kumar Dabilpuram >> >> Cc: dev@dpdk.org; tho...@monjalon.net; >

Re: [dpdk-dev] [PATCH 1/6] eal: introduce zmm type for AVX 512-bit

2020-03-20 Thread Jerin Jacob
On Tue, Mar 10, 2020 at 8:14 PM Medvedkin, Vladimir wrote: > > Hi Jerin, Hi Vladimir, > > Are we missing __attribute__((aligned(64))) here? > > Agree. While modern compilers align __m512i by default, some old could > failure to align. Please correct me if I'm wrong. Yes. > > +} rte_zmm_t; >

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: support flow director feature

2020-03-20 Thread Anoob Joseph
Hi Praveen, You need to rebase to the latest dpdk-next-crypto code base. This patch is not applying cleanly. There were few patches from Intel removing the existing FDIR and adding some new implementation. Hope this patch takes that also into account. Also, why do we need to call the feature f

[dpdk-dev] [PATCH v1] test: fix ipsec unit test segfault

2020-03-20 Thread Ruifeng Wang
Segfault was observed when running ipsec unit test: + TestCase [10] : test_ipsec_replay_inb_repeat_null_null_wrapper succeeded + TestCase [11] : test_ipsec_replay_inb_inside_burst_null_null_wrapper succeeded + TestCase [12] : test_ipsec_crypto_inb_burst_2sa

[dpdk-dev] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-20 Thread Muhammad Bilal
in doc-clean removing the folder which contain the text files and no .rst files, they cause problem When switching branches and compiling the documentation for older releases (for example building a documentation on 18.11 or 17.11, with a documentation on master branch, built before. Bugzilla ID:

Re: [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM clock frequency from register

2020-03-20 Thread Zhang, Qi Z
Hi Kevin: > -Original Message- > From: Kevin Traynor > Sent: Monday, March 9, 2020 11:45 PM > To: Zhang, Qi Z ; Yang, Qiming > ; Xing, Beilei > Cc: Ye, Xiaolong ; dev@dpdk.org; Shelton, Benjamin H > ; Stillwell Jr, Paul M > > Subject: Re: [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM

[dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support

2020-03-20 Thread Xiaojun Liu
Split dev init to 2 parts. First only register the port in switch management; second init hook will be called after all the pf are registered and switch initialization. It will finish dev init. Also add switch interrupt support. Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset to support mirror op

[dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management

2020-03-20 Thread Xiaojun Liu
Add flow interface to support offload flow into HW. It supports parse vlan and parse mpls, all these data will be transferred to ffu data. Add switch management, includes initialization, port mapping, epl port link, LED controller, interrupt handler. It create 3 threads. One for interrupt handler,

[dpdk-dev] [PATCH v3 3/5] net/fm10k: add ffu and statistics and config file functions

2020-03-20 Thread Xiaojun Liu
Add ffu to support offload flow into HW. It supports forward, mirror, push VLAN, pop VLAN. It also supports flowset for a group flow definition. The config file can configure debug log, port speed, epl port mapping dpdk port, flowset. All these configuration will be used by switch management. Stati

[dpdk-dev] [PATCH v3 0/5] support fm10k switch management

2020-03-20 Thread Xiaojun Liu
V3: * Add I2C to control the inside LED and PHY. * Add SBUS to communicate with spico. * Add registers defination. * Add switch management log API. * Add switch management structures. * Add epl serdes include loading spico, controlling pcsl, dma, dfe, ical. * Add spico code. * Add state machine

[dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

2020-03-20 Thread Xiaojun Liu
Add I2C to control the inside LED and PHY. All the operations of I2C are using fm10k I2C register. Add SBUS to communicate with spico(micro code in serdes) by using fm10k SBUS register. This is like I2C operations. Add registers defination, which include all the registers will be used in the driver

Re: [dpdk-dev] [PATCH v2] [RFC] ethdev: support flow aging

2020-03-20 Thread Jerin Jacob
On Mon, Mar 16, 2020 at 6:22 PM BillZhou wrote: > > One of the reasons to destroy a flow is the fact that no packet matches the > flow for "timeout" time. > For example, when TCP\UDP sessions are suddenly closed. > > Currently, there is no any dpdk mechanism for flow aging and the > applications u