Hi Kevin, > -----Original Message----- > From: Kevin Traynor <ktray...@redhat.com> > Sent: Thursday, March 19, 2020 2:32 PM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; sta...@dpdk.org > Cc: Luca Boccassi <bl...@debian.org>; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 0/5] Support Intel IPSec MB v0.53 in DPDK > 18.11 > > +sta...@dpdk.org > > Hi Pablo, > > Sorry, but I'm not comfortable with these patches for 18.11. > > On 05/03/2020 15:34, Pablo de Lara wrote: > > This patchset adds support to the following crypto PMDs to use Intel > > IPSec MB v0.53, in DPDK v18.11: > > - AESNI MB PMD: had support up to v0.52, extending to v0.53 > > - AESNI GCM PMD: had support up to v0.52, extending to v0.53 > > For the AES ones, it looks like it is removing support for <0.50? I'm also > not clear > if it's changing the default or not. The patches are very intrusive too. My > concern is that it might break backwards compatibility and introduce > regressions. > > > - SNOW3G PMD: linking now to IPSec MB v0.53, instead of libsso > > - ZUC PMD: linking now to IPSec MB v0.53, instead of libsso > > - KASUMI PMD: linking now to IPSec MB v0.53, instead of libsso > > > > Aren't these the ones we discussed offline? If so, Luca and I both commented > that this will break build for existing users and is not a backwards > compatible > change that could be put on stable branches.
No problem, we can park these patches and possibly explore in the future a way to introduce them into 18.11 (probably not, knowing that 18.11 support will be dropped in a few months). Having these patches available publicly is OK for us, even if they don't get merged. Thanks, Pablo
