20/03/2020 10:34, Bruce Richardson: > On Fri, Mar 20, 2020 at 01:12:18AM +0100, Thomas Monjalon wrote: > > Some clean-up is done in EAL sub-directories. > > The goal is to make organization easier to understand, > > and to prepare moving some files from common to Unix-only place. > > > > Since the kernel modules are moved to kernel/ directory, > > there is no need anymore for the sub-directory eal/ in > > linux/, freebsd/ and windows/. > > > > The EAL API (with doxygen documentation) is moved from > > common/include/ to include/, which makes more clear that > > it is the global API for all environments and architectures. > > Note that the arch-specific and os-specific include files are not > > in this global include directory, but include/generic/ should > > cover the doxygen documentation for them. > > > > The arch-specific directories arm, ppc_64 and x86 in common/arch/ > > and in common/include/arch are moved at the same level as the > > os-specific directories, adding an include/ sub-directory. > > It makes more clear that EAL is covering a matrix combining OS and arch. > > Note that ppc_64 is renamed to ppc. > > > > These moves offer the opportunity to simplify the make and meson files. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > > > --- > > > > This change was proposed to the Technical Board in advance: > > http://mails.dpdk.org/archives/dev/2020-January/156732.html > > > > If required, the patch may be split: > > 1/ remove FreeBSD kernel Makefile > > 2/ move arch .c files > > 3/ move arch .h files > > 4/ move common and generic includes > > 5/ move os/eal/ to os/ > > > > I've scanned through this patch and it is quite long. I like the idea of > cleanup, but I do think splitting would make reviewing easier, since it's > hard to track what is moving where all in one go.
OK, I'll prepare a v2, split in 5 patches. Note: v1 is not compiling because I missed some "git add" in the include directory.
