Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

Tested-by: Zhao, Xinfengmailto:xinfengx.z...@intel.com>> > -Original Message- > From: Dybkowski, AdamX intel.com> > Sent: Thursday, February 20, 2020 3:04 PM > To: dev at dpdk.org; Trahe, Fiona > https://mail

Re: [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability

> -Original Message- > From: Ye, Xiaolong > Sent: Friday, March 13, 2020 13:52 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability > > For the subject, since this

Re: [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability

> -Original Message- > From: Ye, Xiaolong > Sent: Friday, March 13, 2020 14:04 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Xing, > Beilei ; Zhao1, Wei > Subject: Re: [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability > > On 03/10, Haiyue Wang wrote

Re: [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability

On 03/10, Haiyue Wang wrote: > >+static int >+ice_dcf_mode_disable(struct ice_dcf_hw *hw) >+{ >+ int err; >+ >+ err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE, >+NULL, 0); >+ if (err) { >+ PMD_DRV_LOG(ERR, "Fail to

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation

Yes. But I'm OK if it's applied to later since it won't take effect anyway with the share code change in 20.02. > -Original Message- > From: Ye, Xiaolong > Sent: Friday, March 13, 2020 13:22 > To: Li, Xiaoyun > Cc: Zhike Wang ; dev@dpdk.org; Xing, Beilei > ; Zhang, Qi Z ; sta...@dpdk.org

Re: [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability

For the subject, since this patch is about acquire + disable, how about net/ice: support DCF capability acquire/disable On 03/10, Haiyue Wang wrote: >Since the DCF (Device Config Function) controls the flow setting of >other VFs by the mailbox with PF, for security, it needs to acquire >the DCF c

Re: [dpdk-dev] [PATCH v2 1/7] net/iavf: stop the PCI probe in DCF mode

On 03/10, Haiyue Wang wrote: >A new DCF PMD will be introduced, which runs on Intel VF hardware, and >it is a pure software design to control the advance functionality (such >as switch, ACL) for rest of the VFs. > >So if the DCF (Device Config Function) mode is specified by the devarg >'cap=dcf', t

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation

Hi, Xiaoyun Thanks for the review, just want to double check, are you suggesting that this fix should just be applied to LTS? Latest code doesn't need it, right? Thanks, Xiaolong On 03/13, Li, Xiaoyun wrote: >Hi > >This issue is already fixed in 20.02 with base code update of the following >c

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation

Hi This issue is already fixed in 20.02 with base code update of the following commit. commit 37b091c75b13d2f26359be9b77adbc33c55a7581 Author: Xiaolong Ye Date: Mon Jan 13 10:39:31 2020 +0800 net/i40e/base: extend PHY access AQ command Currently FW use MDIO I/F number corres

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/l2fwd-keepalive: fix packet drops limited mbufs

Tested-by:xix.zh...@intel.com Best regards, Jiang Mao > -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Louise > Kilheeney > Sent: Wednesday, March 11, 2020 8:05 PM > To: dev@dpdk.org > Cc: Kilheeney, Louise ; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH

[dpdk-dev] [PATCH 4/7] net/ice: add support for MAC VLAN rule

This patch add support for MAC VLAN rule, it enable swicth filter to direct packet base on mac address and vlan id. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/

[dpdk-dev] [PATCH 5/7] net/ice: change default tunnle type

The default tunnle type for swicth filter change to new defination of ICE_SW_TUN_AND_NON_TUN in order that the rule will be apply to more packet type. Cc: sta...@dpdk.org Fixes: 47d460d63233 ("net/ice: rework switch filter") Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 3 ++

[dpdk-dev] [PATCH 6/7] net/ice: add action number check for swicth

The action number can only be one for DCF or PF switch filter, not support large action. Cc: sta...@dpdk.org Fixes: 47d460d63233 ("net/ice: rework switch filter") Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 48 + 1 file changed, 48 insertions(+)

[dpdk-dev] [PATCH 7/7] net/ice: fix input set of VLAN item

The input set for inner type of vlan item should be ICE_INSET_ETHERTYPE, not ICE_INSET_VLAN_OUTER. This mac vlan filter is also part of DCF switch filter. Cc: sta...@dpdk.org Fixes: 47d460d63233 ("net/ice: rework switch filter") Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c |

[dpdk-dev] [PATCH 1/7] net/ice: enable switch flow on DCF

DCF on CVL is a control plane VF which take the responsibility to configure all the PF/global resources, this patch add support DCF on to program forward rule to direct packetS to VFs. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_dcf_ethdev.c| 10 ++-- drivers/net/ice/ice_dcf_parent.c

[dpdk-dev] [PATCH 2/7] net/ice: support for more PPPoE input set

This patch add more support for PPPoE packet, it enable swicth filter to direct PPPoE packet base on session id and PPP protocol type. Signed-off-by: Wei Zhao --- config/common_linux | 1 + drivers/net/ice/ice_generic_flow.c | 13 + drivers/net/ice/ice_generic_flow.h | 9

[dpdk-dev] [PATCH 0/7] add switch filter support for intel DCF

A DCF (Device Config Function) framework has been add for intel device, this patch set add add switch filter support for it, this set also fix bugs which block this feature. This patchset is based on: [1] https://patchwork.dpdk.org/cover/66480/ : add Intel DCF PMD support Depends-on: series-8859

[dpdk-dev] [PATCH 3/7] net/ice: change swicth parser to support flexible mask

DCF need to make configuration of flexible mask, that is to say some iput set mask may be not 0x type all one bit. In order to direct L2/IP multicast packets, the mask for source IP maybe 0xF000, this patch enable switch filter parser for it. Signed-off-by: Wei Zhao --- drivers/net/ice/i

[dpdk-dev] [PATCH 7/7] net/ice: fix input set of VLAN item

The input set for inner type of vlan item should be ICE_INSET_ETHERTYPE, not ICE_INSET_VLAN_OUTER. This mac vlan filter is also part of DCF switch filter. Cc: sta...@dpdk.org Fixes: 47d460d63233 ("net/ice: rework switch filter") Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c |

[dpdk-dev] [PATCH 5/7] net/ice: change default tunnle type

The default tunnle type for swicth filter change to new defination of ICE_SW_TUN_AND_NON_TUN in order that the rule will be apply to more packet type. Cc: sta...@dpdk.org Fixes: 47d460d63233 ("net/ice: rework switch filter") Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 3 ++

[dpdk-dev] [PATCH 6/7] net/ice: add action number check for swicth

The action number can only be one for DCF or PF switch filter, not support large action. Cc: sta...@dpdk.org Fixes: 47d460d63233 ("net/ice: rework switch filter") Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 48 + 1 file changed, 48 insertions(+)

[dpdk-dev] [PATCH 4/7] net/ice: add support for MAC VLAN rule

This patch add support for MAC VLAN rule, it enable swicth filter to direct packet base on mac address and vlan id. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/

[dpdk-dev] [PATCH 1/7] net/ice: enable switch flow on DCF

DCF on CVL is a control plane VF which take the responsibility to configure all the PF/global resources, this patch add support DCF on to program forward rule to direct packetS to VFs. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_dcf_ethdev.c| 10 ++-- drivers/net/ice/ice_dcf_parent.c

[dpdk-dev] [PATCH 3/7] net/ice: change swicth parser to support flexible mask

DCF need to make configuration of flexible mask, that is to say some iput set mask may be not 0x type all one bit. In order to direct L2/IP multicast packets, the mask for source IP maybe 0xF000, this patch enable switch filter parser for it. Signed-off-by: Wei Zhao --- drivers/net/ice/i

[dpdk-dev] [PATCH 2/7] net/ice: support for more PPPoE input set

This patch add more support for PPPoE packet, it enable swicth filter to direct PPPoE packet base on session id and PPP protocol type. Signed-off-by: Wei Zhao --- config/common_linux | 1 + drivers/net/ice/ice_generic_flow.c | 13 + drivers/net/ice/ice_generic_flow.h | 9

[dpdk-dev] [PATCH 0/7] add switch filter support for intel DCF

A DCF (Device Config Function) framework has been add for intel device, this patch set add add switch filter support for it, this set also fix bugs which block this feature. This patchset is based on: [1] https://patchwork.dpdk.org/cover/66480/ : add Intel DCF PMD support Depends-on: series-8859

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

Hi Ori, Sorry for the late response as I am occupied by other works. Two comments below to make the definitions compatible to Hyperscan. Thanks, Xiang On Tue, Mar 10, 2020 at 10:32:33AM +, Ori Kam wrote: > +#define RTE_REGEX_PCRE_RULE_MATCH_ALL_F (1ULL << 13) > +/**< This flag marks that the

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix setting VF MAC address

On 03/11, Guinan Sun wrote: >The reason why PF cannot receive data normally is that >vf performed the clear_rar operation through dev close >without adding a mac address.  >This will cause the association between the index and >rx address set by VMDq to be cancelled,thus affecting >the data recepti

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

27/02/2020 05:25, Dmitry Kozlyuk: > When using __attribute__((format(...)) on functions, GCC on Windows > assumes MS-specific format string by default, even if the underlying > stdio implementation is ANSI-compliant (either MS Unicersal CRT > or MinGW implementation). Wrap attribute into a macro th

Re: [dpdk-dev] [PATCH v3 00/14] bbdev new features

Hi Akhil, Thomas, Checking there is nothing preventing this serie to be applied. Thanks Nic -Original Message- From: Chautru, Nicolas Sent: Wednesday, March 4, 2020 10:55 AM To: tho...@monjalon.net; akhil.go...@nxp.com; dev@dpdk.org Cc: Yigit, Ferruh ; Chautru, Nicolas Subject: [PAT

[dpdk-dev] [PATCH 7/7] examples/vhost: block attempts to use owned ports

If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH 6/7] examples/tep_termination: block attempts to use owned ports

If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/tep_termination/Makefile| 2 ++ examples/tep_

[dpdk-dev] [PATCH 5/7] examples/l3fwd-power: block attempts to use owned ports

If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of l3fwd. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 4 1 file changed, 4 insertio

[dpdk-dev] [PATCH 2/7] examples/l2fwd-cat: block attempts to use owned ports

If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/Makefile| 2 ++ examples/l2fwd-cat/

[dpdk-dev] [PATCH 1/7] ethdev: add function to test port ownership

Applications using a port mask need a method to be able to test for (and reject) ethdev ports that are in use for other purposes. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c

[dpdk-dev] [PATCH 4/7] examples/l3fwd-acl: block attempts to use owned ports

If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l3fwd-acl/Makefile| 3 +++ examples/l3fwd-acl

[dpdk-dev] [PATCH 3/7] examples/l3fwd: block attempts to use owned ports

If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of l3fwd. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l3fwd/Makefile| 3 +++ examples/l3fwd/main.c |

[dpdk-dev] [PATCH 0/7] checking for owned ports in portmask

The failsafe, bonding, and netvsc PMD use eth dev port ownership to control sub devices. These sub devices are hidden in the normal iteration over ports but some applications use a direct port mask. In these cases, user may still (incorrectly) try to directly use the sub devices. This patch set i

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

On 3/12/2020 3:15 PM, Kevin Traynor wrote: > On 12/03/2020 14:31, Ferruh Yigit wrote: >> On 3/12/2020 2:18 PM, Kevin Traynor wrote: >>> On 12/03/2020 13:25, Ferruh Yigit wrote: On 3/11/2020 11:32 AM, Kevin Traynor wrote: > gcc 10.0.1 reports: > > ../drivers/net/avp/avp_ethdev.c: In

Re: [dpdk-dev] 19.11.1 patches review and test

On Thu, 2020-03-12 at 10:16 -0500, Thinh Tran wrote: > Hi - > IBM - DPDK on Power test result for v19.11.1-rc1 > > *Basic PF on Mallanox: No new errors or regressions were seen. > * Single port stability test using l3fwd (16 cpus) and TRex, tested > 64 >and 1500 byte packets at a 0.0% drop rat

[dpdk-dev] [PATCH] pmdinfo: check for pci.ids in /usr/share/misc

From: Luca Boccassi Debian and Ubuntu switched years ago from /usr/share/hwdata to /usr/share/misc, and the former is just a compat symlink now. We are starting to get bug reports to nudge us into changing. So check the new path first, and the old one as a fallback. Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] 19.11.1 patches review and test

Hi - IBM - DPDK on Power test result for v19.11.1-rc1 *Basic PF on Mallanox: No new errors or regressions were seen. * Single port stability test using l3fwd (16 cpus) and TRex, tested 64 and 1500 byte packets at a 0.0% drop rate for 4 hours each. *Performance: no degradation compared to 19.11.

[dpdk-dev] [PATCH 13/13] app/test: add rte_security_capability_get tests

Signed-off-by: Lukasz Wojciechowski Change-Id: I228cba78333b54aee3b50e89709b438e45f374db --- app/test/test_security.c | 522 +++ 1 file changed, 522 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 895e4a03e..d28bab16a 10064

[dpdk-dev] [PATCH 11/13] app/test: add rte_security_get_userdata tests

Signed-off-by: Lukasz Wojciechowski Change-Id: I310b40b7e3749efde96d27fe2b448410a33c51c4 --- app/test/test_security.c | 178 +++ 1 file changed, 178 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index fa9141f89..e8aba2870 10064

[dpdk-dev] [PATCH 12/13] app/test: add rte_security_capabilities_get tests

Signed-off-by: Lukasz Wojciechowski Change-Id: Iaa273d1b4e663a6238ad67bbf0ec6dd40c21d075 --- app/test/test_security.c | 137 +++ 1 file changed, 137 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index e8aba2870..895e4a03e 10064

[dpdk-dev] [PATCH 10/13] app/test: add rte_security_set_pkt_metadata tests

Signed-off-by: Lukasz Wojciechowski Change-Id: Id5b4304e83a12443c62557c2a917125084e14f6b --- app/test/test_security.c | 204 +++ 1 file changed, 204 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index dc11b96ff..fa9141f89 10064

[dpdk-dev] [PATCH 09/13] app/test: add rte_security_session_destroy tests

Signed-off-by: Lukasz Wojciechowski Change-Id: Id1543157b4ce89bd5ec07fc46ff67b65ec3b4a89 --- app/test/test_security.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 647a2dd0a..dc11b96ff 10064

[dpdk-dev] [PATCH 08/13] app/test: add rte_security_session_stats_get tests

Signed-off-by: Lukasz Wojciechowski Change-Id: Ib373d2e01aba2924e2f21ff2d5edfa1643e9eff4 --- app/test/test_security.c | 172 +++ 1 file changed, 172 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index d4b3e9515..647a2dd0a 10064

[dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests

This patch introduces set of unit tests of librte_security API functions. Tests are added to dpdk-test application and can be run with "security_autotest" runtime command. This is the first patch in the series of patches as adding all test cases for all API functions in a single patch would make i

[dpdk-dev] [PATCH 07/13] app/test: add rte_security_session_get_size tests

Signed-off-by: Lukasz Wojciechowski Change-Id: I1d1238d38c0cca5ba9c14c8ba395a16d686ae110 --- app/test/test_security.c | 131 +++ 1 file changed, 131 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index cf13b8080..d4b3e9515 10064

[dpdk-dev] [PATCH 06/13] app/test: add rte_security_session_update tests

Signed-off-by: Lukasz Wojciechowski Change-Id: I3d5df17a33913a94e6ad6806de91c7157184e3b4 --- app/test/test_security.c | 225 +++ 1 file changed, 225 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 885281703..cf13b8080 10064

[dpdk-dev] [PATCH 04/13] app/test: fix macro definition

Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause as it might be already defined. Signed-off-by: Lukasz Wojciechowski Change-Id: I0da5c66d5a7ae369214acfdfd3f872c2fc417d19 --- app/test/test.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test/test.h b/a

[dpdk-dev] [PATCH 02/13] librte_security: fix return types in documentation

Enhance returned values description for rte_security_session_destroy and some other minor description changes. Signed-off-by: Lukasz Wojciechowski Change-Id: Ic18ee9e76507fda1a0921b3a2a914a2434d2 --- lib/librte_security/rte_security.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletion

[dpdk-dev] [PATCH 01/13] librte_security: fix verification of parameters

This patch adds verification of the parameters to the ret_security API functions. All required parameters are checked if they are not NULL. Checks verify full chain of pointers, e.g. in case of verification of "instance->ops->session_XXX", they check also "instance" and "instance->ops". Signed-of

[dpdk-dev] [PATCH 00/13] Fixes and unit tests for librte_security

Set of patches fix minor issues like proper verification of input parameters and aligning documentation with code in the matter of return values. Another fixed issue is invalid decrementation of the session counter which might cause inconsistency between counter values and a true number of sessions

[dpdk-dev] [PATCH 03/13] librte_security: fix session counter

Fix session counter to be decreased in rte_security_session_destroy only when session was successfully destoyed. Formerly session counter was decreased prior session destroying and returning session object to mempool. It remained decreased even if session was not destroyed and mempool object relea

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

On 12/03/2020 14:31, Ferruh Yigit wrote: > On 3/12/2020 2:18 PM, Kevin Traynor wrote: >> On 12/03/2020 13:25, Ferruh Yigit wrote: >>> On 3/11/2020 11:32 AM, Kevin Traynor wrote: gcc 10.0.1 reports: ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: ../driver

Re: [dpdk-dev] [PATCH v2] log: add API to check if a logtype can log in a given level

On 3/12/2020 1:41 PM, David Marchand wrote: > On Tue, Mar 3, 2020 at 7:18 PM Ferruh Yigit wrote: >> >> This is a helper function in case components would like to do more work >> than just logging a message based on log level, like for example >> collecting some stats if the log type is DEBUG etc..

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

On 3/12/2020 2:18 PM, Kevin Traynor wrote: > On 12/03/2020 13:25, Ferruh Yigit wrote: >> On 3/11/2020 11:32 AM, Kevin Traynor wrote: >>> gcc 10.0.1 reports: >>> >>> ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: >>> ../drivers/net/avp/avp_ethdev.c:1791:24: >>> warning: ‘avp

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

On 12/03/2020 13:25, Ferruh Yigit wrote: > On 3/11/2020 11:32 AM, Kevin Traynor wrote: >> gcc 10.0.1 reports: >> >> ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: >> ../drivers/net/avp/avp_ethdev.c:1791:24: >> warning: ‘avp_bufs[count]’ may be used uninitialized in this fun

[dpdk-dev] [PATCH 1/2] common/qat: get version of QAT firmware

This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 89 + d

[dpdk-dev] [PATCH 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 9 -

[dpdk-dev] DPDK Release Status Meeting 12/03/2020

Minutes 12 March 2020 - Agenda: * Release Dates * Subtrees * OvS * Opens Participants: * Debian/Microsoft * Intel * Marvell * Mellanox * Red Hat Release Dates - * v20.05 dates: * Proposal/V1:Wednesday 18 March 2020 * Integration/Merge/RC1:

Re: [dpdk-dev] [PATCH v2] log: add API to check if a logtype can log in a given level

On Tue, Mar 3, 2020 at 7:18 PM Ferruh Yigit wrote: > > This is a helper function in case components would like to do more work > than just logging a message based on log level, like for example > collecting some stats if the log type is DEBUG etc.. > > A few existing relevant usage converted to th

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

On 3/11/2020 11:32 AM, Kevin Traynor wrote: > gcc 10.0.1 reports: > > ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: > ../drivers/net/avp/avp_ethdev.c:1791:24: > warning: ‘avp_bufs[count]’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > 1791 | tx

Re: [dpdk-dev] [EXT] RE: [PATCH v5 00/15] add eventmode to ipsec-secgw

> Hi Akhil, > > This is release note proposal for event mode feature. > > > > diff --git a/doc/guides/rel_notes/release_20_05.rst > b/doc/guides/rel_notes/release_20_05.rst > index 2190eaf..f8deda7 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

Hi All, If there are no more comments, I'm starting to implement the new class. Thanks, Ori > -Original Message- > From: Ori Kam > Sent: Tuesday, March 10, 2020 7:00 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; xiang.w.w...@intel.com > Cc: dev@dpdk.org; Shahaf Shu

[dpdk-dev] Impossible to build external application if user build DPDK with "make config"

Hi all, If the user follows the quick guide (http://core.dpdk.org/doc/quick-start/) DPDK will be compiled in the "build" folder. However, external applications will always fail to build because RTE_SDK_BIN is strictly defined as $RTE_SDK/$RTE_TARGET, and mk/internal/rte.extvars.mk needs to

[dpdk-dev] [PATCH 08/11] net/octeontx2: add tm dynamic topology update cb

Add dynamic parent and shaper update callbacks that can be used to change RR Quantum or PIR/CIR rate dynamically post hierarchy commit. Dynamic parent update callback only supports updating RR quantum of a given child with respect to its parent. There is no support yet to change priority or parent

[dpdk-dev] [PATCH 10/11] net/octeontx2: add tx queue ratelimit callback

From: Krzysztof Kanas Add Tx queue ratelimiting support. This support is mutually exclusive with TM support i.e when TM is configured, tx queue ratelimiting config is no more valid. Signed-off-by: Krzysztof Kanas Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_ethdev.c | 1 +

[dpdk-dev] [PATCH 11/11] net/octeontx2: add tm capability callbacks

From: Krzysztof Kanas Add Traffic Management capability callbacks to provide global, level and node capabilities. This patch also adds documentation on Traffic Management Support. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- doc/guides/nics/features/octeontx2.ini | 1

[dpdk-dev] [PATCH 09/11] net/octeontx2: add tm debug support

Add debug support to TM to dump configured topology and registers. Also enable debug dump when sq flush fails. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_ethdev_debug.c | 274 +

[dpdk-dev] [PATCH 07/11] net/octeontx2: add tm stats and shaper profile cbs

Add TM support for stats read and private shaper profile addition or deletion. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 271 drivers/net/octeontx2/otx2_tm.h | 4 + 2 files changed, 275 insert

[dpdk-dev] [PATCH 05/11] net/octeontx2: add tm node suspend and resume cb

From: Krzysztof Kanas Add TM support to suspend and resume nodes post hierarchy commit. Signed-off-by: Krzysztof Kanas Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_tm.c | 81 + 1 file changed, 81 insertions(+) diff --git a/drivers/ne

[dpdk-dev] [PATCH 03/11] net/octeontx2: add dynamic topology update support

Modify resource allocation and freeing logic to support dynamic topology commit while to traffic is flowing. This patch also modifies SQ flush to timeout based on minimum shaper rate configured. SQ flush is further split to pre/post functions to adhere to HW spec of 96XX C0. Signed-off-by: Nithin

[dpdk-dev] [PATCH 06/11] net/octeontx2: add tm hierarchy commit callback

Add TM hierarchy commit callback to support enabling newly created topology. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 170 1 file changed, 170 insertions(+) diff --git a/drivers/net/octeontx2/

[dpdk-dev] [PATCH 04/11] net/octeontx2: add tm node add and delete cb

Adds support to Traffic Management callbacks "node_add" and "node_delete". These callbacks doesn't support dynamic node addition or deletion post hierarchy commit. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 271 +

[dpdk-dev] [PATCH 02/11] net/octeontx2: restructure tm helper functions

Restructure traffic manager helper function by splitting to multiple sets of register configurations like shaping, scheduling and topology config. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 689 ++--

[dpdk-dev] [PATCH 01/11] net/octeontx2: setup link config based on BP level

Configure NIX_AF_TL3_TL2X_LINKX_CFG using schq at level based on NIX_AF_PSE_CHANNEL_LEVEL[BP_LEVEL]. Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_tm.c | 16 +++- 2 files changed, 16 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 00/11] net/octeontx2: add traffic manager support

Add support to traffic management api in OCTEON TX2 PMD. This support applies to CN96xx of C0 silicon version. This series depends on http://patchwork.dpdk.org/patch/66344/ Depends-on:series-66344 Krzysztof Kanas (3): net/octeontx2: add tm node suspend and resume cb net/octeontx2: add tx que

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature

Hi Praveen, I do have some review comments on the code. Before that, can you give a brief overview of what is being targeted? My understanding is that the primary objective is to use rte_flow (or flow director) to redirect a specific flow(/SA) to a specific queue. Can you confirm? Couple of qu

[dpdk-dev] [PATCH] vhost: return -EAGAIN during unregistering vhost if it is busy.

The vhost_user_read_cb() and rte_vhost_driver_unregister() can be called at the same time by 2 threads, and may lead to deadlock. Eg thread1 calls vhost_user_read_cb()->vhost_user_get_vring_base()->destroy_device(), then thread2 calls rte_vhost_driver_unregister(), and will retry the fdset_try_de

Re: [dpdk-dev] [EXT] RE: [PATCH v5 00/15] add eventmode to ipsec-secgw

Hi Akhil, This is release note proposal for event mode feature. diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst index 2190eaf..f8deda7 100644 --- a/doc/guides/rel_notes/release_20_05.rst +++ b/doc/guides/rel_notes/release_20_05.rst @@ -56,6 +56,14 @

Re: [dpdk-dev] [PATCH] net/mlx5: fix zero value check for set tag action

-Original Message- From: Wisam Monther Sent: Monday, March 9, 2020 3:13 PM To: dev@dpdk.org; Raslan Darawsheh ; Matan Azrad Cc: Slava Ovsiienko ; sta...@dpdk.org Subject: [PATCH] net/mlx5: fix zero value check for set tag action If we allow to have data and mask <0x0> we might hit a

Re: [dpdk-dev] [PATCH] net/i40e: fix X722 judgement when disable adminq operation

Hi, Any one to review it? I saw there is a build error on 0-day robert, but it seems environment issue (apt get failed). Br, Zhike Wang JDCloud, Product Development, IaaS   Mobile／+86 13466719566 E

[dpdk-dev] [PATCH] net/mlx5: fix validate set meta action for zero value

There is no reason to prevent the user from using zero metadata, it indeed means no metadata, but sometimes the user may need to report to datapath that there is no metadata anymore, which is valid case. Fixes: fcc8d2f716fd ("net/mlx5: extend flow metadata support") Cc: viachesl...@mellanox.com Cc

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

On Wed, Mar 11, 2020 at 6:08 PM Aaron Conole wrote: > > David Marchand writes: > > > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > > wrote: > >> > >> This commit releases all service cores from their role, > >> returning them to ROLE_RTE on rte_service_finalize(). > >> > >> This may fix an

Re: [dpdk-dev] [RFC] A REST API based daemon of dpdk-devbind.py

Thanks for your comments. "Better" may be subjective as the tool we are working on and using within out infrastructure provides a RESTful API interface whereas "driverctl" as you said seems more generic. "driverctl" is an external tool and isn't part of DPDK toolset, what we are providing here is

Re: [dpdk-dev] [PATCH] net/iavf: unify Rx ptype table

> -Original Message- > From: Wang, ShougangX > Sent: Friday, March 6, 2020 10:24 AM > To: dev@dpdk.org > Cc: Rong, Leyi ; Wu, Jingjing ; > Wang, ShougangX > Subject: [PATCH] net/iavf: unify Rx ptype table > > From: Wang Shougang > > This patch unified the Rx ptype table. > > Signed-

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

Hello, On Wed, Mar 11, 2020 at 5:21 PM Van Haaren, Harry wrote: > Issue was that service cores can remain running while main thread > has freed service-core memory, later racy return of service lcore > then causes use-after-free. > > This commit fixes it by > A) resetting all service cores to ret

Re: [dpdk-dev] [PATCH v2 2/2] ci: add test suite run without hugepage

> -Original Message- > From: Juraj Linkeš > Sent: Thursday, March 12, 2020 15:13 > To: Ruifeng Wang ; Aaron Conole > > Cc: maicolgabr...@hotmail.com; bruce.richard...@intel.com; dev@dpdk.org; > david.march...@redhat.com; Gavin Hu ; Honnappa > Nagarahalli ; nd ; nd > > Subject: RE: [PAT

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] drivers/crypto: fix build with make 4.3

28/02/2020 14:25, Thomas Monjalon: > In the check for the version of intel-ipsec-mb library, > there is a backslash in front of the #include. > This backslash is for escaping the hash sign parsed as > a number sign in make. > > Since make-4.3, escaping is not required for the number sign. > As a c

[dpdk-dev] [PATCH v2 10/10] service: relax barriers with C11 atomic operations

To guarantee the inter-threads visibility of the shareable domain, it uses a lot of rte_smp_r/wmb in the service library. This patch relaxed these barriers for service by using c11 atomic one-way barrier operations. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu --- l

[dpdk-dev] [PATCH v2 09/10] service: optimize with c11 one-way barrier

The num_mapped_cores and execute_lock are synchronized with rte_atomic_XX APIs which is a full barrier, DMB, on aarch64. This patch optimized it with c11 atomic one-way barrier. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- lib/

[dpdk-dev] [PATCH v2 08/10] service: identify service running on another core correctly

From: Honnappa Nagarahalli The logic to identify if the MT unsafe service is running on another core can return -EBUSY spuriously. In such cases, running the service becomes costlier than using atomic operations. Assume that the application passes the right parameters and reduces the number of in

[dpdk-dev] [PATCH v2 05/10] service: remove rte prefix from static functions

Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses") Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common/rte_service.c | 18 +- 1 file chang

[dpdk-dev] [PATCH v2 06/10] service: remove redundant code

The service id validation is verified in the calling function, remove the redundant code inside the service_update function. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common

[dpdk-dev] [PATCH v2 04/10] ipsec: optimize with c11 atomic for sa outbound sqn update

For SA outbound packets, rte_atomic64_add_return is used to generate SQN atomically. This introduced an unnecessary full barrier by calling the '__sync' builtin implemented rte_atomic_XX API on aarch64. This patch optimized it with c11 atomic and eliminated the expensive barrier for aarch64. Signe

[dpdk-dev] [PATCH v2 07/10] service: avoid race condition for MT unsafe service

From: Honnappa Nagarahalli There has possible that a MT unsafe service might get configured to run on another core while the service is running currently. This might result in the MT unsafe service running on multiple cores simultaneously. Use 'execute_lock' always when the service is MT unsafe.

[dpdk-dev] [PATCH v2 00/10] generic rte atomic APIs deprecate proposal

DPDK provides generic rte_atomic APIs to do several atomic operations. These APIs are using the deprecated __sync built-ins and enforce full memory barriers on aarch64. However, full barriers are not necessary in many use cases. In order to address such use cases, C language offers C11 atomic APIs.

  1   2   >