Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses")
Fixes: 21698354c832 ("service: introduce service cores concept")
Cc: sta...@dpdk.org

Signed-off-by: Phil Yang <phil.y...@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
---
 lib/librte_eal/common/rte_service.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/lib/librte_eal/common/rte_service.c 
b/lib/librte_eal/common/rte_service.c
index 7e537b8..a691f5d 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -333,7 +333,7 @@ rte_service_runstate_get(uint32_t id)
 }
 
 static inline void
-rte_service_runner_do_callback(struct rte_service_spec_impl *s,
+service_runner_do_callback(struct rte_service_spec_impl *s,
                               struct core_state *cs, uint32_t service_idx)
 {
        void *userdata = s->spec.callback_userdata;
@@ -376,10 +376,10 @@ service_run(uint32_t i, struct core_state *cs, uint64_t 
service_mask,
                if (!rte_atomic32_cmpset((uint32_t *)&s->execute_lock, 0, 1))
                        return -EBUSY;
 
-               rte_service_runner_do_callback(s, cs, i);
+               service_runner_do_callback(s, cs, i);
                rte_atomic32_clear(&s->execute_lock);
        } else
-               rte_service_runner_do_callback(s, cs, i);
+               service_runner_do_callback(s, cs, i);
 
        return 0;
 }
@@ -433,7 +433,7 @@ rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t 
serialize_mt_unsafe)
 }
 
 static int32_t
-rte_service_runner_func(void *arg)
+service_runner_func(void *arg)
 {
        RTE_SET_USED(arg);
        uint32_t i;
@@ -703,7 +703,7 @@ rte_service_lcore_start(uint32_t lcore)
         */
        lcore_states[lcore].runstate = RUNSTATE_RUNNING;
 
-       int ret = rte_eal_remote_launch(rte_service_runner_func, 0, lcore);
+       int ret = rte_eal_remote_launch(service_runner_func, 0, lcore);
        /* returns -EBUSY if the core is already launched, 0 on success */
        return ret;
 }
@@ -782,7 +782,7 @@ rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id,
 }
 
 static void
-rte_service_dump_one(FILE *f, struct rte_service_spec_impl *s,
+service_dump_one(FILE *f, struct rte_service_spec_impl *s,
                     uint64_t all_cycles, uint32_t reset)
 {
        /* avoid divide by zero */
@@ -815,7 +815,7 @@ rte_service_attr_reset_all(uint32_t id)
        SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
 
        int reset = 1;
-       rte_service_dump_one(NULL, s, 0, reset);
+       service_dump_one(NULL, s, 0, reset);
        return 0;
 }
 
@@ -873,7 +873,7 @@ rte_service_dump(FILE *f, uint32_t id)
                SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
                fprintf(f, "Service %s Summary\n", s->spec.name);
                uint32_t reset = 0;
-               rte_service_dump_one(f, s, total_cycles, reset);
+               service_dump_one(f, s, total_cycles, reset);
                return 0;
        }
 
@@ -883,7 +883,7 @@ rte_service_dump(FILE *f, uint32_t id)
                if (!service_valid(i))
                        continue;
                uint32_t reset = 0;
-               rte_service_dump_one(f, &rte_services[i], total_cycles, reset);
+               service_dump_one(f, &rte_services[i], total_cycles, reset);
        }
 
        fprintf(f, "Service Cores Summary\n");
-- 
2.7.4

Reply via email to