Hi, Any one to review it? I saw there is a build error on 0-day robert, but it seems environment issue (apt get failed).
Br, Zhike Wang JDCloud, Product Development, IaaS ------------------------------------------------------------------------------------------------ Mobile/+86 13466719566 E- mail/wangzh...@jd.com Address/5F Building A,North-Star Century Center,8 Beichen West Street,Chaoyang District Beijing Https://JDCloud.com ------------------------------------------------------------------------------------------------ -----Original Message----- From: wangzk...@163.com [mailto:wangzk...@163.com] On Behalf Of Zhike Wang Sent: Thursday, January 16, 2020 9:20 AM To: dev@dpdk.org Cc: beilei.x...@intel.com; qi.z.zh...@intel.com; sta...@dpdk.org; 王志克 Subject: [PATCH] net/i40e: fix X722 judgement when disable adminq operation X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722 /I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge whether it is X722 or not. Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16") Signed-off-by: Zhike Wang <wangzh...@jd.com> --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..85ccb76 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1443,7 +1443,7 @@ static inline void i40e_config_automask(struct i40e_pf *pf) return -EIO; } /* Firmware of SFP x722 does not support adminq option */ - if (hw->device_id == I40E_DEV_ID_SFP_X722) + if (hw->mac.type == I40E_MAC_X722) hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE; PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d eetrack %04x", -- 1.8.3.1