Re: [dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le

2020-02-18 Thread Thomas Monjalon
19/02/2020 02:10, David Wilder: > This change follows the example of aarch64 Travis support > by adding support for ppc64le gcc builds. Limitations for > ppc64le are the same as aarch64 as described in commit > 31bb45bcfd. > > Signed-off-by: David Wilder > Reviewed-by: David Christensen > --- >

Re: [dpdk-dev] [PATCH] net/mlx5: fix geneve tunnel flow validation

2020-02-18 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Wednesday, February 19, 2020 8:52 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix geneve tunnel flow validation > > The new Mellanox devices support geneve tunnel statless offloads by native > HW

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-02-18 Thread Ye Xiaolong
On 02/18, Guinan Sun wrote: >When the port starts, the hw register is reset first, >and then the required parameters are set again. >If the parameters to be used are not set after resetting the register, >a read register error will occur. This patch is used to fix the problem. > >Fixes: af75078fece

[dpdk-dev] [PATCH] doc: fix octeontx2 eventdev devargs

2020-02-18 Thread pbhagavatula
From: Pavan Nikhilesh Fix OCTEON TX2 event device devargs examples. Fixes: 55e778ca4648 ("event/octeontx2: add devargs for inflight buffer count") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx2.rst | 18 +- 1 file changed, 9 insertions(+)

[dpdk-dev] [PATCH] net/mlx5: fix geneve tunnel flow validation

2020-02-18 Thread Matan Azrad
The new Mellanox devices support geneve tunnel statless offloads by native HW parsers, FW doesn't need to configure flex parser to support it. The FW capability for geneve flex parser is not set for the above devices, hence the geneve flow validation failed for them. Remove the flex parser valida

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-02-18 Thread Xiaojun Liu
Hi Xiao, I have already finished the fixing. Thank you for your helping so much. I still have some questions. 1. Shall I generate the patch based on old patches ? 2. I used checkpatches.sh+check-git-log.sh+test-build.sh to check the patch, is that enough ? 3. May I send the patch to you

Re: [dpdk-dev] [PATCH v2 00/13] Implement new devargs framework

2020-02-18 Thread Pavan Nikhilesh Bhagavatula
@Thomas Monjalon, Ping?. Some parts of this patch set was scheduled for 19.02. >-Original Message- >From: dev On Behalf Of Thomas Monjalon >Sent: Wednesday, October 3, 2018 6:02 PM >To: Gaetan Rivet >Cc: dev@dpdk.org; Shreyansh Jain ; >Andrew Rybchenko >Subject: Re: [dpdk-dev] [PATCH v2

Re: [dpdk-dev] [PATCH] net/i40e: fix compile warning

2020-02-18 Thread Ye Xiaolong
On 02/19, Shougang Wang wrote: >This patch adds memset array before using. > >Fixes: 622e24aa6712 ("net/i40e: fix multiple interrupt for VF") > >Signed-off-by: Shougang Wang >--- > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/i40e/i40e_ethdev

Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-02-18 Thread Amit Gupta
> -Original Message- > From: David Marchand > Sent: Monday, February 17, 2020 3:24 PM > To: Amit Gupta > Cc: Harman Kalra ; dev ; Bruce > Richardson > Subject: [EXT] Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if > octeontx drivers are disabled > > External Email > > ---

Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-02-18 Thread Amit Gupta
> -Original Message- > From: Bruce Richardson > Sent: Monday, February 17, 2020 4:19 PM > To: Amit Gupta > Cc: Harman Kalra ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if > octeontx drivers are disabled > > External Email > > -

Re: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-18 Thread Tiwei Bie
On Tue, Feb 18, 2020 at 06:22:40PM +0100, Maxime Coquelin wrote: > Ethdev's .dev_configure callback can be called multiple > time during a device life-time, but Vhost makes the > wrong assumption that it is not the case and try to > setup again the device on reconfiguration. > > This patch ensures

Re: [dpdk-dev] [PATCH 1/2] net/vhost: fix Vhost setup error path

2020-02-18 Thread Tiwei Bie
On Tue, Feb 18, 2020 at 06:22:39PM +0100, Maxime Coquelin wrote: > If for some reason vhost_driver_setup() fails, the list > element for the device may be freed without being removed > from the internal list of devices. > > This patch fixes all the error paths, by unregistering the > device from V

[dpdk-dev] [PATCH] net/i40e: fix compile warning

2020-02-18 Thread Shougang Wang
This patch adds memset array before using. Fixes: 622e24aa6712 ("net/i40e: fix multiple interrupt for VF") Signed-off-by: Shougang Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.

[dpdk-dev] [Bug 400] start testpmd with vmxnet3 can't receive and forward packets

2020-02-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=400 Bug ID: 400 Summary: start testpmd with vmxnet3 can't receive and forward packets Product: DPDK Version: 19.05 Hardware: x86 OS: Linux Status: UNCONFIRME

[dpdk-dev] [PATCH v2 1/3] eal/linux: select iova-mode va with no-huge option

2020-02-18 Thread David Wilder
If --no-huge is set and iova-mode has not been specified force VA mode. If --no-huge and --iova-mode=PA is requested error out as this is an impossible configuration. Signed-off-by: David Wilder --- lib/librte_eal/linux/eal/eal.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le

2020-02-18 Thread David Wilder
This change follows the example of aarch64 Travis support by adding support for ppc64le gcc builds. Limitations for ppc64le are the same as aarch64 as described in commit 31bb45bcfd. Signed-off-by: David Wilder Reviewed-by: David Christensen --- .travis.yml | 30 ++

[dpdk-dev] [PATCH v2 2/3] devtools: allow test-null.sh to run on ppc64le

2020-02-18 Thread David Wilder
Memory requirements are larger for ppc64le due to a higher RTE_MAX_LCORE value. Signed-off-by: David Wilder Reviewed-by: David Christensen --- devtools/test-null.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/test-null.sh b/devtools/test-null.sh index 548de8113.

[dpdk-dev] [PATCH v2 0/3] add travis ci support for ppc64le

2020-02-18 Thread David Wilder
This patch series adds Travis gcc compilation jobs for ppc64le. Limitations for ppc64le are similar to arm64 (see commit 31bb45bcfd). 1. Only gcc builds are supported on ppc64le. 2. A container is used, therefor Huge pages are not available. Unit tests are not run, a single test (test-null) us

Re: [dpdk-dev] [PATCH] doc: update af_xdp documentation on MTU limitations

2020-02-18 Thread Ye Xiaolong
Nice doc about MTU of AF_XDP, thanks for the update. On 02/18, Ciara Loftus wrote: >Explain how kernel driver RX buffer sizes affect the maximum >MTU size in practice. > >Signed-off-by: Ciara Loftus >--- > doc/guides/nics/af_xdp.rst | 26 +++--- > 1 file changed, 23 insertions(

[dpdk-dev] [PATCH] ipsec: fix use of uninitialized variable

2020-02-18 Thread Konstantin Ananyev
Defects reported by coverity scan uninit_use_in_call: Using uninitialized element of array clen when calling cpu_crypto_bulk. Coverity issue: 354233, 354234 Fixes: 957394f72658 ("ipsec: support CPU crypto mode") Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/esp_inb.c | 4 +++- lib/lib

Re: [dpdk-dev] [PATCH v3 0/2] improve Travis coverage

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 10:20 PM Thomas Monjalon wrote: > > Remove some useless jobs and add more packages > to build more PMDs in Travis. > > v3: reword commit logs > v2: remove libbpf because not available > > Thomas Monjalon (2): > ci: remove redundant configs disabling kmods > ci: enable m

Re: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-18 Thread Itsuro ODA
Hi Yinan, Maxime, David, Thank you for quick test, fix and review. It looks good to me. The original fix has been queued to stable 19.11.1. It should be rejected or applied this fix too. Thanks. Itsuto Oda On Tue, 18 Feb 2020 18:22:38 +0100 Maxime Coquelin wrote: > This series fixes regressio

Re: [dpdk-dev] Fwd: high latency detected in IP pipeline example

2020-02-18 Thread James Huang
No. I didn't notice the RTT bouncing symptoms. In high throughput scenario, if multiple pipelines runs in a single cpu core, it does increase the latency. Regards, James Huang On Tue, Feb 18, 2020 at 1:50 AM Victor Huertas wrote: > Dear James, > > I have done two different tests with the foll

Re: [dpdk-dev] [PATCH v2] eal/windows: fix out-of-memory check

2020-02-18 Thread Ranjit Menon
On 2/17/2020 3:56 PM, Dmitry Kozlyuk wrote: Check vsnprintf() result to prevent calling malloc() with negative size. Check actual malloc() result and terminate asprintf() with documented error code to prevent the use of NULL pointer. Fixes: e8428a9d8 ("eal/windows: add some basic functions and m

Re: [dpdk-dev] Windows Draft Build

2020-02-18 Thread Ranjit Menon
On 2/16/2020 5:14 PM, Dmitry Kozlyuk wrote: Hi, > "Dpdk.sln" builds OK, will try launching sample apps > a bit later. Netuio driver consistently fails to install on Windows 10 in QEMU with virtio-net (modern interface). Described below is my attempt to install the driver from clean "windpdk-v18

Re: [dpdk-dev] [PATCH v3 6/7] doc: guide for Windows build using MinGW-w64

2020-02-18 Thread William Tu
On Mon, Feb 17, 2020 at 4:03 PM Dmitry Kozlyuk wrote: > > Instructions for different toolchains presented as options on the > corresponging steps of the guide, so that common parts may be reused. > > Signed-off-by: Dmitry Kozlyuk > --- > doc/guides/windows_gsg/build_dpdk.rst | 63 +++

[dpdk-dev] [PATCH v3 1/2] ci: remove redundant configs disabling kmods

2020-02-18 Thread Thomas Monjalon
The kernel modules are not built by default since below commit. The Travis CI matrix can be simplified by removing the redundant option enable_kmods=false, and by removing some jobs which are redundant. Note: there is no benefit in checking kmods in Travis Ubuntu. Anyway different kernel versions

[dpdk-dev] [PATCH v3 2/2] ci: enable more drivers in Travis builds

2020-02-18 Thread Thomas Monjalon
The Travis compilation is missing some dependencies to build all PMDs. More PMDs are enabled in Travis which runs Ubuntu Bionic Beaver (18.04): - ipn3ke (libfdt) - mlx (libibverbs) The next Ubuntu LTS, Focal Fossa (20.04) will allow to support more: - af_xdp (libbpf)

[dpdk-dev] [PATCH v3 0/2] improve Travis coverage

2020-02-18 Thread Thomas Monjalon
Remove some useless jobs and add more packages to build more PMDs in Travis. v3: reword commit logs v2: remove libbpf because not available Thomas Monjalon (2): ci: remove redundant configs disabling kmods ci: enable more drivers in Travis builds .travis.yml | 30 +--

Re: [dpdk-dev] [PATCH v3 0/7] MinGW-w64 support

2020-02-18 Thread William Tu
On Mon, Feb 17, 2020 at 4:02 PM Dmitry Kozlyuk wrote: > > This patch series add support for building DPDK using MinGW-w64. > > MinGW-w64 provides GNU toolchain and independent platform SDK on > Windows. It also supports cross-compilation to Windows from POSIX > systems by providing cross tollchain

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

2020-02-18 Thread Thomas Monjalon
Hi, 09/04/2019 21:06, Vivian Kong: > To build and run DPDK on Linux on IBM Z (s390x), big endian support > is added and s390x vector intrinics are used in the implementation > of DPDK libraries. What is the status of this work? Is it abandoned?

Re: [dpdk-dev] [PATCH v3] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 9:31 PM Aaron Conole wrote: > David Marchand writes: > > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > breakage [1]. > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > > in launchpad [3]. > > > > But for now, buil

Re: [dpdk-dev] [PATCH v3] ci: build and use libabigail 1.6

2020-02-18 Thread Aaron Conole
David Marchand writes: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > can be kept.

[dpdk-dev] [PATCH v3] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
libabigail 1.2 (at least) reports changes in 'const' property as an ABI breakage [1]. This was fixed upstream in libabigail 1.4 [2], and a bug has been opened in launchpad [3]. But for now, build and use the last version 1.6 so that the ABI checks can be kept. 1: https://travis-ci.com/DPDK/dpdk/j

Re: [dpdk-dev] [PATCH v2] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Ferruh Yigit
On 2/18/2020 1:39 PM, Ciara Power wrote: > If a function is added to the eth_dev_ops struct before > tx_descriptor_status function, this will cause ABI breakage. This is due > to static inline functions using this function, and some other functions > above it in the struct, so they cannot change po

Re: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-18 Thread Maxime Coquelin
Sorry, just see I missed the v2 prefix. On 2/18/20 6:22 PM, Maxime Coquelin wrote: > This series fixes regression introduced in v20.02-rc3. > First patch fixes the error path, and second one fix > Vhost device reconfigure issue reported by Yinan. > > v2: > --- > - Fix error path order (David) >

[dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-18 Thread Maxime Coquelin
Ethdev's .dev_configure callback can be called multiple time during a device life-time, but Vhost makes the wrong assumption that it is not the case and try to setup again the device on reconfiguration. This patch ensures the device hasn't been already setup before proceeding. Fixes: 3d01b759d267

[dpdk-dev] [PATCH 1/2] net/vhost: fix Vhost setup error path

2020-02-18 Thread Maxime Coquelin
If for some reason vhost_driver_setup() fails, the list element for the device may be freed without being removed from the internal list of devices. This patch fixes all the error paths, by unregistering the device from Vhost library it has been registered, remove the device from the list, reset d

[dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-18 Thread Maxime Coquelin
This series fixes regression introduced in v20.02-rc3. First patch fixes the error path, and second one fix Vhost device reconfigure issue reported by Yinan. v2: --- - Fix error path order (David) Maxime Coquelin (2): net/vhost: fix Vhost setup error path net/vhost: prevent multiple setup on

Re: [dpdk-dev] [PATCH v2] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 4:46 PM Thomas Monjalon wrote: > > 18/02/2020 15:29, David Marchand: > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > breakage [1]. > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > > in launchpad [3]. > > > > But

Re: [dpdk-dev] [PATCH 1/2] net/vhost: fix Vhost setup error path

2020-02-18 Thread Maxime Coquelin
On 2/18/20 5:15 PM, David Marchand wrote: > On Tue, Feb 18, 2020 at 3:35 PM Maxime Coquelin > wrote: >> >> If for some reason vhost_driver_setup() fails, the list >> element for the device may be freed without being removed >> from the internal list of devices. >> >> This patch fixes all the er

Re: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 3:35 PM Maxime Coquelin wrote: > > Ethdev's .dev_configure callback can be called multiple > time during a device life-time, but Vhost makes the > wrong assumption that it is not the case and try to > setup again the device on reconfiguration. > > This patch ensures the dev

Re: [dpdk-dev] [PATCH 1/2] net/vhost: fix Vhost setup error path

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 3:35 PM Maxime Coquelin wrote: > > If for some reason vhost_driver_setup() fails, the list > element for the device may be freed without being removed > from the internal list of devices. > > This patch fixes all the error paths, by unregistering the > device from Vhost lib

Re: [dpdk-dev] [PATCH v2] ci: build and use libabigail 1.6

2020-02-18 Thread Thomas Monjalon
18/02/2020 15:29, David Marchand: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > ca

Re: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-18 Thread Wang, Yinan
Tested-by: Yinan Wang > -Original Message- > From: Maxime Coquelin > Sent: 2020年2月18日 22:35 > To: dev@dpdk.org; o...@valinux.co.jp; Wang, Yinan ; > Bie, Tiwei ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 2/2] net/vhost: prevent multiple setup on reconfig > > Ethdev's .

Re: [dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-18 Thread Maxime Coquelin
On 2/18/20 3:35 PM, Maxime Coquelin wrote: > Ethdev's .dev_configure callback can be called multiple > time during a device life-time, but Vhost makes the > wrong assumption that it is not the case and try to > setup again the device on reconfiguration. > > This patch ensures the device hasn't

Re: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-18 Thread Maxime Coquelin
On 2/18/20 4:24 PM, Wang, Yinan wrote: > This patch set can fix Vhost device reconfigure issue, thanks! Thanks for the quick test, I'll ask your Tested-by on patch 2. Maxime > >> -Original Message- >> From: Maxime Coquelin >> Sent: 2020年2月18日 22:35 >> To: dev@dpdk.org; o...@valinux.

Re: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-18 Thread Wang, Yinan
This patch set can fix Vhost device reconfigure issue, thanks! > -Original Message- > From: Maxime Coquelin > Sent: 2020年2月18日 22:35 > To: dev@dpdk.org; o...@valinux.co.jp; Wang, Yinan ; > Bie, Tiwei ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 0/2] Fix Vhost PMD setup

Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 3:55 PM Aaron Conole wrote: > > David Marchand writes: > > > On Tue, Feb 18, 2020 at 10:40 AM David Marchand > > wrote: > >> > >> On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole wrote: > >> > > >> > David Marchand writes: > >> > > >> > > libabigail 1.2 (at least) reports c

Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-18 Thread Aaron Conole
David Marchand writes: > On Tue, Feb 18, 2020 at 10:40 AM David Marchand > wrote: >> >> On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole wrote: >> > >> > David Marchand writes: >> > >> > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI >> > > breakage [1]. >> > > This was

Re: [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson

2020-02-18 Thread Bruce Richardson
On Tue, Feb 18, 2020 at 03:26:47PM +0100, Thomas Monjalon wrote: > 18/02/2020 01:02, Dmitry Kozlyuk: > > --- a/config/meson.build > > +++ b/config/meson.build > > +# MS linker requires special treatment. > > +# FIXME: use cc.get_linker_id() with Meson >= 0.54 > > +is_ms_linker = is_windows and (cc.

[dpdk-dev] [PATCH] net/mlx5: fix flow match on GRE key

2020-02-18 Thread Matan Azrad
The RTE_FLOW_ITEM_TYPE_GRE_KEY means that GRE key should be present on the flow and in addition can explicitly match on the GRE key field itself. When no value is set in this item any GRE key should match the flow. The match on GRE key wrongly was not added if the item fields are NULL while at le

[dpdk-dev] [PATCH 1/2] net/vhost: fix Vhost setup error path

2020-02-18 Thread Maxime Coquelin
If for some reason vhost_driver_setup() fails, the list element for the device may be freed without being removed from the internal list of devices. This patch fixes all the error paths, by unregistering the device from Vhost library it has been registered, remove the device from the list, reset d

[dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig

2020-02-18 Thread Maxime Coquelin
Ethdev's .dev_configure callback can be called multiple time during a device life-time, but Vhost makes the wrong assumption that it is not the case and try to setup again the device on reconfiguration. This patch ensures the device hasn't been already setup before proceeding. Fixes: 3d01b759d267

[dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup

2020-02-18 Thread Maxime Coquelin
This series fixes regression introduced in v20.02-rc3. First patch fixes the error path, and second one fix Vhost device reconfigure issue reported by Yinan. Maxime Coquelin (2): net/vhost: fix Vhost setup error path net/vhost: prevent multiple setup on reconfig drivers/net/vhost/rte_eth_vho

[dpdk-dev] [PATCH v2] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
libabigail 1.2 (at least) reports changes in 'const' property as an ABI breakage [1]. This was fixed upstream in libabigail 1.4 [2], and a bug has been opened in launchpad [3]. But for now, build and use the last version 1.6 so that the ABI checks can be kept. 1: https://travis-ci.com/DPDK/dpdk/j

Re: [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson

2020-02-18 Thread Thomas Monjalon
18/02/2020 01:02, Dmitry Kozlyuk: > --- a/config/meson.build > +++ b/config/meson.build > +# MS linker requires special treatment. > +# FIXME: use cc.get_linker_id() with Meson >= 0.54 > +is_ms_linker = is_windows and (cc.get_id() == 'clang') Please could you replace this FIXME with an actual fix

Re: [dpdk-dev] [PATCH] net/mlx5: fix the matching for ICMP fragments

2020-02-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, February 17, 2020 4:11 PM > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Jack Min > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the matching for ICMP fragments > > The hardware ca

Re: [dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Thomas Monjalon
18/02/2020 14:13, Andrew Rybchenko: > On 2/18/20 2:59 PM, Ferruh Yigit wrote: > > On 2/18/2020 10:46 AM, Ciara Power wrote: > >> If a function is added to the eth_dev_ops struct before > >> tx_descriptor_status function, this will cause ABI breakage. This is due > >> to static inline functions usin

[dpdk-dev] [PATCH] doc: update af_xdp documentation on MTU limitations

2020-02-18 Thread Ciara Loftus
Explain how kernel driver RX buffer sizes affect the maximum MTU size in practice. Signed-off-by: Ciara Loftus --- doc/guides/nics/af_xdp.rst | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/af_xdp.rst b/doc/guides/nics/af_xdp.rst in

Re: [dpdk-dev] Proposal to add a new toolchain for dpdk: g++

2020-02-18 Thread Victor Huertas
Thanks Neil for your answer, I think I will try the first option you posted without touching the makefiles from the dpdk-stable and I will tell how it goes. So, as a conclusion, it seems that all the modifications I have done are not necessary in order to build your DPDK application using g++. Reg

[dpdk-dev] [PATCH v2] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Ciara Power
If a function is added to the eth_dev_ops struct before tx_descriptor_status function, this will cause ABI breakage. This is due to static inline functions using this function, and some other functions above it in the struct, so they cannot change position. A comment is added to inform developers o

Re: [dpdk-dev] [PATCH v2] net/mlx5: add BlueField-2 device ID

2020-02-18 Thread Raslan Darawsheh
Removed V1 from next-net-mlx, and applied new version to next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Tuesday, February 18, 2020 3:23 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: add BlueField-

[dpdk-dev] [PATCH v2] net/mlx5: add BlueField-2 device ID

2020-02-18 Thread Raslan Darawsheh
This adds new device id to the list of Mellanox devices that runs mlx5 PMD. - BlueField-2 integrated ConnectX-6 Dx network controller This device is not ready yet, it is in development stage. Signed-off-by: Raslan Darawsheh Reviewed-by: Gavin Hu Acked-by: Matan Azrad --- v2: added missing supp

Re: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 device ID

2020-02-18 Thread Raslan Darawsheh
Sure, will send a V2 now Kindest regards, Raslan Darawsheh > -Original Message- > From: Matan Azrad > Sent: Tuesday, February 18, 2020 3:11 PM > To: Raslan Darawsheh ; Raslan Darawsheh > ; dev@dpdk.org > Cc: Thomas Monjalon > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 de

Re: [dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Andrew Rybchenko
On 2/18/20 2:59 PM, Ferruh Yigit wrote: > On 2/18/2020 10:46 AM, Ciara Power wrote: >> If a function is added to the eth_dev_ops struct before >> tx_descriptor_status function, this will cause ABI breakage. This is due >> to static inline functions using this function, and some other functions >> a

Re: [dpdk-dev] Proposal to add a new toolchain for dpdk: g++

2020-02-18 Thread Neil Horman
On Mon, Feb 17, 2020 at 02:39:58PM +, Bruce Richardson wrote: > On Mon, Feb 17, 2020 at 11:01:21AM +0100, Victor Huertas wrote: > > Hi all, > > > > I am using DPDK development environment to develop an application from > > which I have to access C++ code. > > I managed to modify some internal

Re: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 device ID

2020-02-18 Thread Matan Azrad
Hi This one should be added to the mlx5 vDPA driver too. > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Tuesday, February 18, 2020 2:02 PM > To: Raslan Darawsheh ; dev@dpdk.org > Cc: Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 devi

Re: [dpdk-dev] [PATCH] net/i40e: fix multiple interrupt for VF

2020-02-18 Thread Ferruh Yigit
On 2/17/2020 3:09 AM, Shougang Wang wrote: > Interrupt mapping should be 1:n queue(s).This patch fixes the > logic of interrupt bind by code reconstruction. > > Fixes: 6a6cf5f88b4a ("net/i40e: enable multi-queue Rx interrupt for VF") > > Signed-off-by: Shougang Wang > --- > drivers/net/i40e/i40

[dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue arming

2020-02-18 Thread Matan Azrad
The mlx5 vDPA driver manages QP and CQ in order to forward the HW event to the guest by the callfd file descriptor for each virtq. The driver arms the CQ for the next CQE index that should be completed by the HW in order to create completion event. In the SW completion event handler, the driver a

Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel flow priority

2020-02-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, February 13, 2020 3:03 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix tunnel flow priority > > The PMD manages internally the priority of the flows

Re: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 device ID

2020-02-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, February 13, 2020 6:12 PM > To: dev@dpdk.org > Cc: Thomas Monjalon > Subject: [dpdk-dev] [PATCH] net/mlx5: add BlueField-2 device ID > > This adds new device id to the list of Mellanox devices > that ru

Re: [dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Ferruh Yigit
On 2/18/2020 10:46 AM, Ciara Power wrote: > If a function is added to the eth_dev_ops struct before > tx_descriptor_status function, this will cause ABI breakage. This is due > to static inline functions using this function, and some other functions > above it in the struct, so they cannot change p

[dpdk-dev] [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions

2020-02-18 Thread Shiri Kuzin
ICMPv6 header contains the checksum field, that includes the IP addresses from IP header. The ConnectX-5 hardware does not support ICMPv6 checksum calculation and in case of IP header modification the checksum will contain the wrong value. The patch rejects the header modification actions related

Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
On Tue, Feb 18, 2020 at 10:40 AM David Marchand wrote: > > On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole wrote: > > > > David Marchand writes: > > > > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > > breakage [1]. > > > This was fixed upstream in libabigail 1.4 [2],

[dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Ciara Power
If a function is added to the eth_dev_ops struct before tx_descriptor_status function, this will cause ABI breakage. This is due to static inline functions using this function, and some other functions above it in the struct, so they cannot change position. A comment is added to inform developers o

Re: [dpdk-dev] [PATCH V1] doc: add testbed Intel platforms with Intel NICs

2020-02-18 Thread Ye Xiaolong
s/testbed/tested On 02/18, Chen, Zhaoyan wrote: >From: "Chen,Bo" > >Add tested Intel platforms with Intel NICs to v20.02 release note. > >Signed-off-by: Chen,Bo Should be Bo Chen >--- > doc/guides/rel_notes/release_20_02.rst | 106 + > 1 file changed, 106 insertions(+)

Re: [dpdk-dev] [EXT] RE: [PATCH 2/2] examples/ip_pipeline: fix to use sock id instead of cpuid

2020-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Jun Yang > Sent: Friday, February 14, 2020 3:19 PM > To: Dumitrescu, Cristian ; Hemant Agrawal > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [EXT] RE: [dpdk-dev] [PATCH 2/2] examples/ip_pipeline: fix to > use sock id instead of cpuid > > Hi Cristian,

[dpdk-dev] [PATCH v4] doc: alias to experimental tag for stable apis

2020-02-18 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

Re: [dpdk-dev] [PATCH V1] doc: Update i40e driver/firmware version mapping table

2020-02-18 Thread Ye Xiaolong
On 02/18, Chen, Zhaoyan wrote: >Update driver/firmware version mapping table for >new driver/firmware supported in 20.02 release > >Signed-off-by: Chen, Zhaoyan >--- > doc/guides/nics/i40e.rst | 4 > 1 file changed, 4 insertions(+) > >diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40

Re: [dpdk-dev] [PATCH v3 2/4] net/vhost: delay vhost driver setup

2020-02-18 Thread Maxime Coquelin
Thanks Yinan for reporting the issue. I'm working on a fix, which should be ready today: 1. Don't do vhost setup if device is already in the list 2. Fix the error path in setup function. Maxime On 2/18/20 9:50 AM, Wang, Yinan wrote: > Hi Itsuro/Maxime, > > Below patch (commit id:3d01b759d2679c21

[dpdk-dev] [PATCH v2] examples/fips_validation: fix incorrect string for CT length

2020-02-18 Thread Anoob Joseph
The NIST test vectors use the string 'PTlen' to denote text lengths in case of encrypt & decrypt operations. So the same string need to be used while parsing PT and CT. Fixes: 2adb3b4e7e54 ("examples/fips_validation: fix AES-GCM cipher length parsing") Signed-off-by: Anoob Joseph --- v2: * Fix

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-18 Thread Ray Kinsella
On 18/02/2020 09:49, Ye Xiaolong wrote: > On 02/18, Thomas Monjalon wrote: >> 18/02/2020 10:12, Ray Kinsella: >>> On 18/02/2020 08:26, Mcnamara, John wrote: From: Ray Kinsella > So to be clear. > I see that documentation like this is brittle and has a limited lifespan. > I can

Re: [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list

2020-02-18 Thread Ferruh Yigit
On 2/18/2020 9:28 AM, Ferruh Yigit wrote: > On 2/18/2020 7:40 AM, Akhil Goyal wrote: >> >>> >>> Update feature list to include inline protocol offload. >>> >>> Signed-off-by: Anoob Joseph >>> --- >>> v3 >>> * Added inline protocol in octeontx2_vf.ini >>> >>> v2 >>> * Reworded doc following suggest

Re: [dpdk-dev] [PATCH V1] doc: Update i40e driver/firmware version mapping table

2020-02-18 Thread Kevin Traynor
On 18/02/2020 06:52, Chen, Zhaoyan wrote: > Update driver/firmware version mapping table for > new driver/firmware supported in 20.02 release > > Signed-off-by: Chen, Zhaoyan > --- > doc/guides/nics/i40e.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/nics/i40e.rst b

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-18 Thread Ye Xiaolong
On 02/18, Thomas Monjalon wrote: >18/02/2020 10:12, Ray Kinsella: >> On 18/02/2020 08:26, Mcnamara, John wrote: >> > From: Ray Kinsella >> >> So to be clear. >> >> I see that documentation like this is brittle and has a limited lifespan. >> >> I can almost guarantee the next version of DPDK or Ope

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-18 Thread Thomas Monjalon
18/02/2020 10:42, Bruce Richardson: > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote: > > Hi, > > > > I would like to remind everybody our mistake when defining ABI versions. > > It has been "fixed" in this commit: > > http://git.dpdk.org/dpdk/commit/?id=f26c2b39 > > > > Please l

Re: [dpdk-dev] Fwd: high latency detected in IP pipeline example

2020-02-18 Thread Victor Huertas
Dear James, I have done two different tests with the following configuration: [PIPELINE 0 MASTER core =0] [PIPELINE 1 core=1] --- SWQ1--->[PIPELINE 2 core=1] -SWQ2> [PIPELINE 3 core=1] The first test (sending a single ping to cross all the pipelines to measure RTT) has been done by settin

Re: [dpdk-dev] [PATCH] build: fix soname for experimental libraries

2020-02-18 Thread Thomas Monjalon
18/02/2020 10:40, Bruce Richardson: > On Tue, Feb 18, 2020 at 12:44:02AM +0100, Thomas Monjalon wrote: > > Because of an original mistake in ABI numbering, > > and a temporary workaround for ABI 20, > > for experimental libs, numbering would lead to consider > > ABI 20.1 > ABI 21.0 > > > > Bef

[dpdk-dev] [PATCH] examples/fips_validation: fix incorrect CT length string

2020-02-18 Thread Anoob Joseph
The NIST test vectors use the string 'PTlen' to denote text lengths in case of encrypt & decrypt operations. So the same string need to be used while parsing PT and CT. Fixes: 12f826533ff7 ("examples/fips_validation: fix incorrect string for CT length") Signed-off-by: Anoob Joseph --- examples

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-18 Thread Bruce Richardson
On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote: > Hi, > > I would like to remind everybody our mistake when defining ABI versions. > It has been "fixed" in this commit: > http://git.dpdk.org/dpdk/commit/?id=f26c2b39 > > Please let's think about the consequence for the experimenta

Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-18 Thread David Marchand
On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole wrote: > > David Marchand writes: > > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > breakage [1]. > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > > in launchpad [3]. > > > > But for now, bu

Re: [dpdk-dev] [PATCH] build: fix soname for experimental libraries

2020-02-18 Thread Bruce Richardson
On Tue, Feb 18, 2020 at 12:44:02AM +0100, Thomas Monjalon wrote: > Because of an original mistake in ABI numbering, > and a temporary workaround for ABI 20, > for experimental libs, numbering would lead to consider > ABI 20.1 > ABI 21.0 > > Before this patch: > > DPDK 19.11: ABI version 0.2

Re: [dpdk-dev] [PATCH] net/i40e: fix multiple interrupt for VF

2020-02-18 Thread Ye Xiaolong
On 02/18, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Wang, ShougangX >> Sent: Monday, February 17, 2020 11:10 AM >> To: dev@dpdk.org >> Cc: Yang, Qiming ; Zhang, Qi Z >> ; Wang, ShougangX >> Subject: [PATCH] net/i40e: fix multiple interrupt for VF >> >> Interrupt mapping shoul

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-18 Thread Thomas Monjalon
18/02/2020 10:12, Ray Kinsella: > On 18/02/2020 08:26, Mcnamara, John wrote: > > From: Ray Kinsella > >> So to be clear. > >> I see that documentation like this is brittle and has a limited lifespan. > >> I can almost guarantee the next version of DPDK or OpenWRT will break it. > >> (and how would

Re: [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list

2020-02-18 Thread Ferruh Yigit
On 2/18/2020 7:40 AM, Akhil Goyal wrote: > >> >> Update feature list to include inline protocol offload. >> >> Signed-off-by: Anoob Joseph >> --- >> v3 >> * Added inline protocol in octeontx2_vf.ini >> >> v2 >> * Reworded doc following suggestions from Akhil >> >> doc/guides/nics/features.rst

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-02-18 Thread Konieczny, TomaszX
Patch fixes reported issue. Tested-by: Tomasz Konieczny Regards Tomasz Konieczny - Intel Corporation (UK) Ltd. Co. Reg. #1134945 Pipers Way, Swindon SN3 1RJ >-Original Message- >From: dev On Behalf Of Guinan Sun >Sent:

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-18 Thread Ray Kinsella
On 18/02/2020 08:26, Mcnamara, John wrote: > > >> -Original Message- >> From: Ray Kinsella >> Sent: Monday, February 17, 2020 3:49 PM >> To: Ye, Xiaolong >> Cc: Mcnamara, John ; Kovacevic, Marko >> ; dev@dpdk.org; Richardson, Bruce >> ; Stephen Hemminger >> ; Thomas Monjalon >> Subj

Re: [dpdk-dev] [PATCH] net/mlx5: fix the matching for ICMP fragments

2020-02-18 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Subject: [PATCH] net/mlx5: fix the matching for ICMP fragments > > The hardware can recognize and mark the layer 4 protocol type for TCP, > UDP and IPSec non-fragmented packets. For all the fragmented packets, > L4 type will be considered as Non

Re: [dpdk-dev] [PATCH] net/mlx5: fix the hairpin queue capacity

2020-02-18 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Subject: [PATCH] net/mlx5: fix the hairpin queue capacity > > The hairpin TX/RX queue depth and packet size is fixed in the past. > When the firmware has some fix or improvement, the PMD will not > make full use of it. And also, 32 packets for a

  1   2   >