On Mon, Feb 17, 2020 at 7:48 PM Aaron Conole <acon...@redhat.com> wrote: > > David Marchand <david.march...@redhat.com> writes: > > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > breakage [1]. > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > > in launchpad [3]. > > > > But for now, build and use the last version 1.6 so that the ABI checks > > can be kept. > > > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > > 2: > > https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=215b7eb4fe8b986fe1cc87d9d8e7412998038392 > > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > Does it make sense to base libabigail required ontop of extra packages? > Otherwise some libraries won't get built / checked, no?
The only change I see is the pcap driver being enabled. On the principle, I agree that trying to build all possible libraries/drivers is better when checking the ABI. So I'll keep extra_packages yes. I am currently testing that touching extra_packages (well, testing Thomas patches) results in Travis treating the job as a new one (i.e. with no cache). > > > .ci/linux-build.sh | 22 ++++++++++++++++++++++ > > .travis.yml | 15 ++++++++++----- > > 2 files changed, 32 insertions(+), 5 deletions(-) > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > > index c7c3840fc..0d4bc9a62 100755 > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -38,6 +38,28 @@ if [ "$AARCH64" != "1" ]; then > > fi > > > > if [ "$ABI_CHECKS" = "1" ]; then > > + > > LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git} > > + LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} > > + > > + if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" > > ]; then > > + rm -rf libabigail > > + # if we change libabigail, invalidate existing abi cache > > + rm -rf reference > > + fi > > + > > + if [ ! -d libabigail ]; then > > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REPO > > libabigail/src > > + cd libabigail/src && autoconf -vfi && cd - And I managed to send a "oh yeah, seems better this way"/untested version... Fixed. -- David Marchand