On Tue, Feb 18, 2020 at 4:46 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > 18/02/2020 15:29, David Marchand: > > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > > breakage [1]. > > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > > in launchpad [3]. > > > > But for now, build and use the last version 1.6 so that the ABI checks > > can be kept. > > > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > > 2: > > https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=215b7eb4fe8b > > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > Acked-by: Thomas Monjalon <tho...@monjalon.net> > > I suggest few improvements below: > > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > if [ "$ABI_CHECKS" = "1" ]; then > > What do you think about moving the libabigail install in a function?
No strong opinion, we had everything inline so far. > > We could justify this with a comment about installing the latest version. > > > + > > LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git} > > + LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} > > + > > + if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" > > ]; then > > + rm -rf libabigail > > + # if we change libabigail, invalidate existing abi cache > > + rm -rf reference > > + fi > > + > > + if [ ! -d libabigail ]; then > > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REPO > > libabigail/src > > Why not using the tarball? > http://mirrors.kernel.org/sourceware/libabigail/libabigail-1.6.tar.gz No good reason "now". I was first bitten by a reference to redhat-hardened-ld in some libtool script in the tarball (/me looks in Dodji direction). I then considered switching to different versions of libabigail by just setting the LIBABIGAIL_VERSION env variable from .travis.yml. I ended up with the current latest version which is also what is in Ubuntu latest releases. The tarball is smaller than a git clone, so best to use it. v3 incoming. -- David Marchand