Re: [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding

2020-02-09 Thread Anoob Joseph
> > Like for OCTEON TX, the OCTEON TX2 crypto engines must first be unbound > from their kernel module, then rebound to vfio-pci, before being used in DPDK. > > As this capability is detected at runtime by dpdk-pmdinfo, add the info in the > PMD registering directives. > > Then an external scrip

[dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding

2020-02-09 Thread Thierry Herbelot
Like for OCTEON TX, the OCTEON TX2 crypto engines must first be unbound from their kernel module, then rebound to vfio-pci, before being used in DPDK. As this capability is detected at runtime by dpdk-pmdinfo, add the info in the PMD registering directives. Then an external script can be used for

Re: [dpdk-dev] [PATCH v2] examples/tep_term: fix return value check

2020-02-09 Thread Ye Xiaolong
On 02/10, Xiaoyun Li wrote: >Added return value check for 'rte_eth_dev_info_get()'. > >Coverity issue: 349922 >Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") >Cc: sta...@dpdk.org > >Signed-off-by: Xiaoyun Li >--- > examples/tep_termination/vxlan_setup.c | 4 +++- > 1 file

[dpdk-dev] [PATCH v2] examples/tep_term: fix return value check

2020-02-09 Thread Xiaoyun Li
Added return value check for 'rte_eth_dev_info_get()'. Coverity issue: 349922 Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- examples/tep_termination/vxlan_setup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-

Re: [dpdk-dev] [PATCH] net/ixgbe: fix coverity issue

2020-02-09 Thread Ye Xiaolong
On 02/10, Guinan Sun wrote: >This patch fixes (Logically dead code) coverity issue. > >Coverity issue: 353613 >Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove") > >Signed-off-by: Guinan Sun >--- > drivers/net/ixgbe/ixgbe_pf.c | 3 --- > 1 file changed, 3 deletions(-) > >diff --gi

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR PASSTHRU issue

2020-02-09 Thread Ye Xiaolong
On 02/10, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Cao, Yahui >> Sent: Tuesday, January 21, 2020 10:26 AM >> To: Yang, Qiming ; Lu, Wenzhuo >> >> Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; Cao, >> Yahui ; Ye, Xiaolong ; Xing, >> Beilei >> >> Subject: [PATCH] net/ice:

Re: [dpdk-dev] [PATCH] examples/tep_term: fix return value check

2020-02-09 Thread Ye Xiaolong
On 02/10, Li, Xiaoyun wrote: >Hi > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Monday, February 10, 2020 11:37 >> To: Li, Xiaoyun >> Cc: Kovacevic, Marko ; dev@dpdk.org; >> sta...@dpdk.org >> Subject: Re: [PATCH] examples/tep_term: fix return value check >> >> On 02/10, Xiaoyun L

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR PASSTHRU issue

2020-02-09 Thread Zhang, Qi Z
> -Original Message- > From: Cao, Yahui > Sent: Tuesday, January 21, 2020 10:26 AM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; Cao, > Yahui ; Ye, Xiaolong ; Xing, > Beilei > > Subject: [PATCH] net/ice: fix FDIR PASSTHRU issue > > The origina

Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-09 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon > Sent: Sunday, February 9, 2020 11:17 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx: replace hardcoded value with macro > > Replace checking against 65535 limit, > with a simpler form using RTE_MIN and UI

Re: [dpdk-dev] Windows Draft Build

2020-02-09 Thread Dmitry Kozlyuk
> Did you install the LLVM toolchain for VStudio: > https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain > > You will need to ensure VS is closed before installing it. > It says it supports VS2017, but it will also work with VS2019, if VS2017 is > already installed.

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-09 Thread Anoob Joseph
Hi Akhil, Can you review this patch? Thanks, Anoob > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 4, 2020 8:06 PM > To: Anoob Joseph ; John McNamara > ; Marko Kovacevic > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Akhil Goyal

Re: [dpdk-dev] [PATCH] examples/tep_term: fix return value check

2020-02-09 Thread Li, Xiaoyun
Hi > -Original Message- > From: Ye, Xiaolong > Sent: Monday, February 10, 2020 11:37 > To: Li, Xiaoyun > Cc: Kovacevic, Marko ; dev@dpdk.org; > sta...@dpdk.org > Subject: Re: [PATCH] examples/tep_term: fix return value check > > On 02/10, Xiaoyun Li wrote: > >Added return value check for

Re: [dpdk-dev] Windows Draft Build

2020-02-09 Thread Ranjit Menon
On 2/8/2020 12:45 AM, Dmitry Kozlyuk wrote: Hi, I'm having trouble building "dpdk.sln" from "windpdk-v18.08-clang" branch of "dpdk-draft-windows" repository using Visual Studio 2019 Community Edition. All projects are set up to use some "llvm" toolset. If I install LLVM Build Tools and switch to

[dpdk-dev] [PATCH] net/ixgbe: fix coverity issue

2020-02-09 Thread Guinan Sun
This patch fixes (Logically dead code) coverity issue. Coverity issue: 353613 Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove") Signed-off-by: Guinan Sun --- drivers/net/ixgbe/ixgbe_pf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/driv

Re: [dpdk-dev] [PATCH] examples/tep_term: fix return value check

2020-02-09 Thread Ye Xiaolong
On 02/10, Xiaoyun Li wrote: >Added return value check for 'rte_eth_dev_info_get()'. > >Coverity issue: 349922 >Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") >Cc: sta...@dpdk.org > >Signed-off-by: Xiaoyun Li >--- > examples/tep_termination/vxlan_setup.c | 4 +++- > 1 file

[dpdk-dev] [PATCH] examples/tep_term: fix return value check

2020-02-09 Thread Xiaoyun Li
Added return value check for 'rte_eth_dev_info_get()'. Coverity issue: 349922 Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- examples/tep_termination/vxlan_setup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-

Re: [dpdk-dev] Offloading L4 checksum to crypto device

2020-02-09 Thread Trahe, Fiona
Right now it's just an RFC. If you want to influence it you can take part in that discussion. Or in development of a sample app to do what you propose. > -Original Message- > From: Heng Wang > Sent: Thursday, February 6, 2020 8:03 AM > To: Trahe, Fiona ; Doherty, Declan > > Cc: Filip

[dpdk-dev] [PATCH] net/mlx5: fix the legacy multi packet write session

2020-02-09 Thread Viacheslav Ovsiienko
To provide the better PCIe bandwidth utilization the ConnectX-4LX NIC supports the multi-packet write (MPW) sessions allowing to pack multiple packets into one descriptor (WQE). This is legacy feature and it has some limitations on the packets and data description segments. To provide the best perf

Re: [dpdk-dev] BUG BPF examples broken

2020-02-09 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, February 8, 2020 4:05 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: BUG BPF examples broken > > The BPF examples do not compile on Debian. > > The issue is that ret_mbuf_core.h includes rte_atomic which inc

Re: [dpdk-dev] [PATCH 6/6] doc: guide for Windows build using MinGW-w64

2020-02-09 Thread Dmitry Kozlyuk
> I think the strategy should be to progress on both GCC and Clang > at the same time. Remembered another issue: thread-local storage (TLS) with shared libraries. Windows PE doesn't support TLS via special sections, so compilers use TLS emulation layer. With static libraries, there are no issues d

[dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro

2020-02-09 Thread Thomas Monjalon
Replace checking against 65535 limit, with a simpler form using RTE_MIN and UINT16_MAX macros. Signed-off-by: Thomas Monjalon --- drivers/net/mlx4/mlx4_ethdev.c | 5 ++--- drivers/net/mlx5/mlx5_ethdev.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx4/ml

[dpdk-dev] [PATCH] fix Mellanox copyright and SPDX tag

2020-02-09 Thread Thomas Monjalon
Mellanox owns Tilera and EZchip, so the copyrights can be converted. At the same time, the license header is switched to SPDX tag format, and a typo is fixed in another copyright line. Signed-off-by: Thomas Monjalon --- app/test-pmd/flowgen.c | 34 ++ app/test-pmd

Re: [dpdk-dev] Offloading L4 checksum to crypto device

2020-02-09 Thread Heng Wang
Hi Fiona, Thanks for the info. Do you have a sample application to show how it works? It's better to have an example of chaining udp checksum with encryption/decryption. I am also wondering to which version it will merge? Regards, Heng -Original Message- From: Trahe, Fiona Sent: den

Re: [dpdk-dev] [PATCH] ether: mark ethernet addresses as being 2-byte aligned

2020-02-09 Thread Martins Eglitis
Hi, Thank you for the help. I think it has something to do how the NFF-Go is being built. Will address the question to NFF-Go devs. Thank you, Martins On 2020-02-05 14:45, Bruce Richardson wrote: On Wed, Feb 05, 2020 at 01:21:54AM +0100, Martins Eglitis wrote: Dear Bruce and Kevin, I tried

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-09 Thread Narcisa Ana Maria Vasile
On 2/6/2020 1:26 AM, Thomas Monjalon wrote: > As discussed in community meeting, the goal was to have core parsing > in Windows EAL 20.02. > Given that there is a crash and a doubt on the imported getopt library, > I think it's better to postpone this series to 20.05. The crash is now fixed in the

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 0/9] Windows patchset with additional EAL functionalities

2020-02-09 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed

Re: [dpdk-dev] [EXTERNAL] [PATCH v8 0/9] Windows patchset with additional EAL functionalities

2020-02-09 Thread Narcisa Ana Maria Vasile
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed

Re: [dpdk-dev] [PATCH] net/mlx5: set VLAN tag matcher bit properly

2020-02-09 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Sunday, February 9, 2020 14:26 > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: set VLAN tag matcher bit properly > > Currently MLX5 PMD can't match on untagged packets specifically.

[dpdk-dev] [PATCH] app/testpmd: fix txonly flow generation entropy

2020-02-09 Thread Viacheslav Ovsiienko
The testpmd application in txonly forwarding mode has an option to generate the packet flows by varying the destination IP address. The patch increments the IP for each packet sent, this improves the entropy and RSS distibution on the peer receiving size is getting more uniform. Fixes: 82010ef55e7

[dpdk-dev] [PATCH] net/mlx5: fix xcapsulation validation

2020-02-09 Thread Matan Azrad
The encapsulation and decapsulation actions are divided into 2 types: L2 and L3. In order to configure L3 xcapsulation actions the user should use both RAW_DECAP and RAW_ENCAP and setting the appropriated data sizes in their action configuration structures. The PMD flow validation wrongly didn't d

[dpdk-dev] [PATCH] net/mlx5: set VLAN tag matcher bit properly

2020-02-09 Thread Dekel Peled
Currently MLX5 PMD can't match on untagged packets specifically. Tagged traffic still hits the flows intended for untagged packets. If the flow has ETH, it will catch all matching packets, tagged and untagged. The solution is to use cvlan_tag bit. If mask=1 and value=0 it matches on untagged traffi