Hi Thomas
From: Thomas Monjalon > Sent: Sunday, February 9, 2020 11:17 PM > To: Matan Azrad <ma...@mellanox.com>; Shahaf Shuler > <shah...@mellanox.com>; Slava Ovsiienko <viachesl...@mellanox.com> > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx: replace hardcoded value with macro > > Replace checking against 65535 limit, > with a simpler form using RTE_MIN and UINT16_MAX macros. > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > --- > drivers/net/mlx4/mlx4_ethdev.c | 5 ++--- drivers/net/mlx5/mlx5_ethdev.c > | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/mlx4/mlx4_ethdev.c > b/drivers/net/mlx4/mlx4_ethdev.c index e500ec422c..9ff05c6738 100644 > --- a/drivers/net/mlx4/mlx4_ethdev.c > +++ b/drivers/net/mlx4/mlx4_ethdev.c > @@ -645,9 +645,8 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *info) > */ > max = ((priv->device_attr.max_cq > priv->device_attr.max_qp) ? > priv->device_attr.max_qp : priv->device_attr.max_cq); > - /* If max >= 65535 then max = 0, max_rx_queues is uint16_t. */ > - if (max >= 65535) > - max = 65535; > + /* max_rx_queues is uint16_t. */ > + max = RTE_MIN(max, (unsigned int)UINT16_MAX); > info->max_rx_queues = max; > info->max_tx_queues = max; > info->max_mac_addrs = RTE_DIM(priv->mac); diff --git > a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index > 86923aa7af..d7d3bc73ce 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -619,9 +619,8 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *info) > */ > max = RTE_MIN(priv->sh->device_attr.orig_attr.max_cq, > priv->sh->device_attr.orig_attr.max_qp); > - /* If max >= 65535 then max = 0, max_rx_queues is uint16_t. */ > - if (max >= 65535) > - max = 65535; > + /* max_rx_queues is uint16_t. */ > + max = RTE_MIN(max, (unsigned int)UINT16_MAX); > info->max_rx_queues = max; > info->max_tx_queues = max; > info->max_mac_addrs = MLX5_MAX_UC_MAC_ADDRESSES; No more misusing of *_MAX \ RTE_MIN\RTE_MAX in the mlx PMDs?
