Re: [dpdk-dev] app/test: unit test problem with testing mbuf in forked child process

2020-02-05 Thread Olivier Matz
Hi Slava, On Wed, Jan 29, 2020 at 12:31:35PM +, Slava Ovsiienko wrote: > While working on the unit test for the mbuf with pinned external buffers I > found that: > app/test/test_mbuf.c: > - test_failing_mbuf_sanity_check() > - verify_mbuf_check_panics(buf) > - fork() > - child pro

[dpdk-dev] [PATCH v2 6/7] build: add cross-file for MinGW-w64

2020-02-05 Thread Dmitry Kozlyuk
Add Meson configuration to cross-compile for Windows using MinGW-w64. It may require adjustments in some cases, but at least it provides the foundation. Signed-off-by: Dmitry Kozlyuk --- config/x86/meson_mingw.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 config/x

[dpdk-dev] [PATCH v2 7/7] doc: guide for Windows build using MinGW-w64

2020-02-05 Thread Dmitry Kozlyuk
Instructions for different toolchains presented as options on the corresponging steps of the guide, so that common parts may be reused. Signed-off-by: Dmitry Kozlyuk --- doc/guides/windows_gsg/build_dpdk.rst | 65 +++ 1 file changed, 56 insertions(+), 9 deletions(-) diff

[dpdk-dev] [PATCH v2 5/7] build: MinGW-w64 support for Meson

2020-02-05 Thread Dmitry Kozlyuk
MinGW-w64 linker does not mimic MS linker options, so the build system must differentiate between linkers on Windows. Use GNU linker options with GCC and MS linker options with Clang. MinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI, most notably its formatting and string hand

[dpdk-dev] [PATCH v2 2/7] eal: use portable format attribute

2020-02-05 Thread Dmitry Kozlyuk
Use portable format attribute for logging and panic messages. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/include/rte_common.h | 2 +- lib/librte_eal/common/include/rte_debug.h | 2 +- lib/librte_eal/common/include/rte_devargs.h | 2 +- lib/librte_eal/common/include/rte_log.h

[dpdk-dev] [PATCH v2 3/7] cmdline: use portable format attribute

2020-02-05 Thread Dmitry Kozlyuk
Use portable format attribute for output strings. Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline.h b/lib/librte_cmdline/cmdline.h index 27d2effdf..952a50829 100644 --- a/lib/librte_c

[dpdk-dev] [PATCH v2 4/7] eal/windows: use lowercase filenames for system headers

2020-02-05 Thread Dmitry Kozlyuk
Mixed case in Windows header names causes errors when cross-compiling from Linux with case-sensitive filesystem using MinGW, because MinGW distribution provides all platform SDK headers in lowercase. The change does not affect Windows native builds on case-insensitive filesystems (NTFS default). R

[dpdk-dev] [PATCH v2 1/7] eal: introduce portable format attribute

2020-02-05 Thread Dmitry Kozlyuk
When using __attribute__((format(...)) on functions, GCC on Windows assumes MS-specific format string by default, even if the underlying stdio implementation is ANSI-compliant (either MS Unicersal CRT or MinGW implementation). Wrap attribute into a macro that forces GNU-specific format string when

[dpdk-dev] [PATCH v2 0/7] MinGW-w64 support

2020-02-05 Thread Dmitry Kozlyuk
This patch series add support for building DPDK using MinGW-w64. MinGW-w64 provides GNU toolchain and independent platform SDK on Windows. It also supports cross-compilation to Windows from POSIX systems by providing cross tollchains and libraries [0]. It does NOT emulate a full POSIX environment,

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-05 Thread Dmitry Kozlyuk
> On 2/5/2020 4:39 PM, Pallavi Kadam wrote: > > > > > > On 2/5/2020 11:54 AM, Dmitry Kozlyuk wrote: > >> Crashes at argument parsing, WinDbg log attached. > > This patch works fine with meson=0.49. > > I was able to execute the 'helloworld' app. > > > > When I tried to build with meson=0.52 i

[dpdk-dev] [PATCH v1 1/1] net/octeontx2: fix flow control initial state

2020-02-05 Thread vattunuru
From: Vamsi Attunuru Currently when application requests for RTE_FC_NONE earlier than PMD's internal fc mode update, flow control set routine is returning without updating the flow control state. Patch updates the PMD's internal fc mode details during dev_configure to ensure any flow control set

Re: [dpdk-dev] BUG: eBPF missing BPF_ABS

2020-02-05 Thread Jerin Jacob
On Thu, Feb 6, 2020 at 2:46 AM Ananyev, Konstantin wrote: > > > > > Second question is implementation. > I can see two main options here: > a) if we plan to have our own cBPF->eBPF converter and support only it, > we can add these extra instructions generation into converter itself. > I.E. cBPF->

[dpdk-dev] [PATCH] net/mlx5: fix meter header modify before decap issue

2020-02-05 Thread Suanming Mou
The meter flows are split into three subflows each, the prefix subflow with meter action color the packet, the meter subflow filters out the colored packets, the suffix subflow applies all the remaining actions to the passed packets. The tag header modify action is added to the prefix subflow to ma

Re: [dpdk-dev] [PATCH] eal: fix to set the rte_device ptr's device args before hotplug

2020-02-05 Thread Somnath Kotur
Hello Gaetan, Sorry my bad, i think i captured it for the wrong BDF ... So the overarching goal here is that i want to create/add a representor port for 06:02.01 using 06:02:00 as the backing/parent device on the vswitch. I recaptured the debug with 06:02:00 Breakpoint 1, pci_name_set

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-05 Thread Pallavi Kadam
On 2/5/2020 6:11 PM, Thomas Monjalon wrote: 06/02/2020 02:39, Pallavi Kadam: On 2/5/2020 4:39 PM, Pallavi Kadam wrote: On 2/5/2020 11:54 AM, Dmitry Kozlyuk wrote: Crashes at argument parsing, WinDbg log attached. This patch works fine with meson=0.49. I was able to execute the 'helloworld'

Re: [dpdk-dev] [PATCH v2] vhost: check vhost message header size read

2020-02-05 Thread Tiwei Bie
On Wed, Feb 05, 2020 at 04:05:29PM +0100, Maxime Coquelin wrote: > This patch adds a check to ensure the read size of > the Vhost-user message header is not smaller than > the expected size. > > In case of unexpected read size, report an error > and close file descriptors passed with the message,

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/pdump: fix build with clang

2020-02-05 Thread Thomas Monjalon
26/01/2020 02:04, Stephen Hemminger: > Clang checks indentation and found incorrect indentation in pdump. > > app/pdump/main.c:598:3: error: misleading indentation; statement is not part > of the previous 'if' [-Werror,-Wmisleading-indentation] > > Cc: reshma.pat...@intel.com > Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH] bpf: properly install headers in meson build

2020-02-05 Thread Thomas Monjalon
28/01/2020 14:51, Bruce Richardson: > On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote: > > Previously, when librte_bpf is built with meson+ninja, its > > headers such as bpf_def is not installed to the system. > > This commit fixes this problem. > > > > Fixes: 94972f3 ("bpf: add BPF lo

Re: [dpdk-dev] [PATCH v5] build: allow using wildcards to disable drivers

2020-02-05 Thread Thomas Monjalon
27/01/2020 15:28, Bruce Richardson: > Rather than having to explicitly list each and every driver to disable in a > build, we can use a small python script and the python glob library to > expand out the wildcards. This means that we can configure meson using e.g. > > meson -Ddisable_drivers=c

Re: [dpdk-dev] [PATCH 0/2] remove compiler warnings with icc using meson

2020-02-05 Thread Thomas Monjalon
24/01/2020 16:37, Bruce Richardson: > While icc can compile DPDK successfully using a meson/ninja build, there > are a lot of warnings issued in the process, which means that any use of > werror flag will break the build, and the output just looks messy and > possibly worrying to the user. > > To

Re: [dpdk-dev] [PATCH] mk: ignore missing field initializers warning

2020-02-05 Thread Thomas Monjalon
21/01/2020 16:55, Ferruh Yigit: > On 1/21/2020 2:35 PM, Thomas Monjalon wrote: > > Three warnings are commonly disabled in DPDK with make and meson: > > * address-of-packed-member > > always disabled > > * missing-field-initializers > > disabled with meson > >

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-05 Thread Thomas Monjalon
06/02/2020 02:39, Pallavi Kadam: > On 2/5/2020 4:39 PM, Pallavi Kadam wrote: > > On 2/5/2020 11:54 AM, Dmitry Kozlyuk wrote: > >> Crashes at argument parsing, WinDbg log attached. > > This patch works fine with meson=0.49. > > I was able to execute the 'helloworld' app. > > > > When I tried to buil

[dpdk-dev] [PATCH v3 4/4] net/vhost: remove an unused member

2020-02-05 Thread Itsuro Oda
This patch removes an unused member from pmd_internal. Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c

[dpdk-dev] [PATCH v3 1/4] net/vhost: allocate interface name from heap

2020-02-05 Thread Itsuro Oda
This patch allocates iface_name of pmd_internal from heap in order to be able to refer from secondary processes. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost

[dpdk-dev] [PATCH v3 2/4] net/vhost: delay vhost driver setup

2020-02-05 Thread Itsuro Oda
Vhost driver setup is delayed at eth_dev configuration in order to be able to set it from a secondary process. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c

[dpdk-dev] [PATCH v3 3/4] net/vhost: make secondary probe complete

2020-02-05 Thread Itsuro Oda
This patch adds lacking member setting and makes secondary probe complete. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 5 - 1 file changed, 4 insert

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-05 Thread Pallavi Kadam
On 2/5/2020 4:39 PM, Pallavi Kadam wrote: On 2/5/2020 11:54 AM, Dmitry Kozlyuk wrote: Crashes at argument parsing, WinDbg log attached. This patch works fine with meson=0.49. I was able to execute the 'helloworld' app. When I tried to build with meson=0.52 it failed with the error: [9/25]

[dpdk-dev] [PATCH v3 0/4] make vhost PMD available for secondary processes

2020-02-05 Thread Itsuro Oda
vhost PMD has not been available for secondary processes since DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) (for a long term !) This series of patches intend to make vhost PMD available for secondary processes. Because now setting vhost driver to communicate with a vhost-user master (e

Re: [dpdk-dev] [PATCH v7 5/9] eal: add function to detect process type

2020-02-05 Thread Pallavi Kadam
On 2/5/2020 12:04 PM, Dmitry Kozlyuk wrote: +/* Detect if we are a primary or a secondary process */ +enum rte_proc_type_t +eal_proc_type_detect(void) +{ [...] + OVERLAPPED sOverlapped = { 0 }; + sOverlapped.Offset = sizeof(*rte_config.mem_config); +

Re: [dpdk-dev] [PATCH v6 1/8] cryptodev: introduce cpu crypto support API

2020-02-05 Thread Thomas Monjalon
04/02/2020 14:12, Marcin Smoczynski: > +/** > + * Converts portion of mbuf data into a vector representation. > + * Each segment will be represented as a separate entry in *vec* array. > + * Expects that provided *ofs* + *len* not to exceed mbuf's *pkt_len*. > + * @param mbuf > + * Pointer to the

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-05 Thread Pallavi Kadam
On 2/5/2020 11:54 AM, Dmitry Kozlyuk wrote: Crashes at argument parsing, WinDbg log attached. This patch works fine with meson=0.49. I was able to execute the 'helloworld' app. When I tried to build with meson=0.52 it failed with the error: [9/25] Linking target lib/librte_kvargs-20.0.dll. F

Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support

2020-02-05 Thread Narcisa Ana Maria Vasile
On 2/5/2020 12:59 PM, Dmitry Kozlyuk wrote: Use Meson 0.52, version 0.53 introduced this regression among others: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmesonbuild%2Fmeson%2Fissues%2F6431&data=02%7C01%7CNarcisa.Vasile%40microsoft.com%7C3a156299509a4e20c63108

Re: [dpdk-dev] [PATCH v4 14/15] net/octeontx2: add inline Tx path changes

2020-02-05 Thread Thomas Monjalon
04/02/2020 12:17, Anoob Joseph: > From: Ankur Dwivedi > > Adding pre-processing required for inline IPsec outbound packets. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Anoob Joseph > Signed-off-by: Archana Muniganti > Signed-off-by: Tejasree Kondoj > Signed-off-by: Vamsi Attunuru > --

Re: [dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp

2020-02-05 Thread Thomas Monjalon
05/02/2020 13:24, Akhil Goyal: > > For series, > > Acked-by: Ravi Kumar > > > > > > > >From: Sardar Shamsher Singh > > > > > >sha3 support enabled in AMD-CCP crypto controller > > > > > >Signed-off-by: Sardar Shamsher Singh > > >--- > Change patch title and description as below > cryptodev:

Re: [dpdk-dev] [pull-request] next-net 20.02 rc2

2020-02-05 Thread Thomas Monjalon
05/02/2020 14:33, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net for-main-repo Pulled, thanks

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-02-05 Thread David Marchand
On Fri, Jan 31, 2020 at 11:04 PM Thinh Tran wrote: > > __ppc_get_timebase() is GNU extension and is more efficient The commit title and log are quite short and give little idea on what this is about. I had a look at this glibc helper: /* Read the Time Base Register. */ static __inline__ ui

Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support

2020-02-05 Thread Dmitry Kozlyuk
> I did have to apply your patch "eal/windows: refine public interface" before > applying the "MinGW-w64 support" patch set, to avoid the errors caused by > including "Windows.h" in rte_os.h. So, I guess this patch needs to come first > and then the patchset for mingw can be applied. The cause

Re: [dpdk-dev] BUG: eBPF missing BPF_ABS

2020-02-05 Thread Ananyev, Konstantin
> > As I mentioned in my FOSDEM talk the current DPDK eBPF handling is > not usable for packet filters. I have ported the classic BPF to eBPF code > and the generated code is not usable by DPDK. > > The problem is that DPDK eBPF does not implement all the opcodes. > BPF_ABS is not implemented and

Re: [dpdk-dev] [PATCH] vfio: fix VFIO mapping failures in ppc64le

2020-02-05 Thread David Marchand
On Fri, Jan 17, 2020 at 5:26 AM Takeshi Yoshimura wrote: > > ppc64le failed when using large physical memory. I found problems in my two > commits in the past. Let's hope this is not a "Jamais deux sans trois" ;-). Since this problem is linked to your usage in SPDK, please test against -rc2 and c

Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support

2020-02-05 Thread Dmitry Kozlyuk
> > Use Meson 0.52, version 0.53 introduced this regression among others: > > https://github.com/mesonbuild/meson/issues/6431 > > DPDK CI also has Meson version pinned to 0.52, see > > http://mails.dpdk.org/archives/dev/2020-January/154357.html > > I find it handy to switch Meson versions via pip3.

Re: [dpdk-dev] [PATCH v2] build: remove unused function versioning

2020-02-05 Thread David Marchand
On Thu, Jan 30, 2020 at 5:11 PM David Marchand wrote: > > On Thu, Jan 30, 2020 at 10:25 AM Andrzej Ostruszka > wrote: > > > > Timer, LPM and Distributor libraries no longer use function versioning > > and therefore do not need separate build for static and shared version > > of libraries. > > > >

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-05 Thread Dmitry Kozlyuk
> > > > > +if is_windows > > > > > + # Require platform SDK for Windows 7 and above. > > > > > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') > > > > > > > > > > > > > Please explain. Why Windows 7 is needed? What this define is doing? > > > > > > Yes, Windows 7 an

Re: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups

2020-02-05 Thread David Marchand
On Fri, Nov 15, 2019 at 1:51 PM Pattan, Reshma wrote: > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Friday, November 8, 2019 4:47 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups > > > > These are a c

Re: [dpdk-dev] [PATCH v7 5/9] eal: add function to detect process type

2020-02-05 Thread Dmitry Kozlyuk
> +/* Detect if we are a primary or a secondary process */ > +enum rte_proc_type_t > +eal_proc_type_detect(void) > +{ [...] > + OVERLAPPED sOverlapped = { 0 }; > + sOverlapped.Offset = sizeof(*rte_config.mem_config); > + sOverlapped.OffsetHigh = 0; > + > +

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Wednesday, February 5, 2020 11:52 AM >To: Wang, Yipeng1 ; David Marchand > >Cc: Amit Gupta ; Gobriel, Sameh >; tho...@monjalon.net; dev ; >nd ; Honnappa Nagarahalli ; nd > >Subject: RE: [PATCH v2

Re: [dpdk-dev] [PATCH v7 3/9] eal: add additional function overrides in windows header files

2020-02-05 Thread Dmitry Kozlyuk
> +#include Nit: better use lowercase to support cross-compilation from OS with case-sensitive FS. It's not directly relevant for this patch. > +static inline int > +eal_get_thread_affinity_mask(pthread_t threadID, unsigned long *cpuset) > +{ > + /* Workaround for the lack of a GetThreadAff

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-05 Thread Dmitry Kozlyuk
Crashes at argument parsing, WinDbg log attached. -- Dmitry Kozlyuk Microsoft (R) Windows Debugger Version 10.0.18362.1 AMD64 Copyright (c) Microsoft Corporation. All rights reserved. CommandLine: build\native\clang\examples\dpdk-helloworld.exe -cf --log-level=eal:8 Symbol search path is: srv*

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread Honnappa Nagarahalli
> >> > > > >> > > Add lock-free reader writer concurrency functional tests. > >> > > These tests will provide the same coverage that non lock-free > >> > > APIs have. > >> > > > >> > > Signed-off-by: Honnappa Nagarahalli > >> > > > >> > > --- > >> > > app/test/test_hash_readwrite.c | 58 > >> >

Re: [dpdk-dev] [PATCH v4 1/3] hash: fix meson headers packaging

2020-02-05 Thread Wang, Yipeng1
>-Original Message- >From: David Marchand [mailto:david.march...@redhat.com] >Sent: Sunday, February 2, 2020 1:09 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Richardson, Bruce ; >Laatz, Kevin ; >acon...@redhat.com; nhor...@tuxdriver.com; akhil.go...@nxp.com; >ano...@marvell.com; bl...@

Re: [dpdk-dev] [PATCH v3 1/4] hash: fix meson headers packaging

2020-02-05 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Thursday, January 30, 2020 10:40 AM >To: Wang, Yipeng1 ; David Marchand >; dev@dpdk.org >Cc: tho...@monjalon.net; Richardson, Bruce ; >Laatz, Kevin ; >acon...@redhat.com; nhor...@tuxdriver.com; ak

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread Wang, Yipeng1
>-Original Message- >From: David Marchand [mailto:david.march...@redhat.com] >Sent: Wednesday, February 5, 2020 8:42 AM >To: Honnappa Nagarahalli >Cc: Amit Gupta ; Wang, Yipeng1 ; >Gobriel, Sameh ; >tho...@monjalon.net; dev ; nd >Subject: Re: [PATCH v2 3/5] test/hash: add lock free reade

[dpdk-dev] [Bug 391] The dpdk-devbind.py tool crashes if some NIC property contains a unicode character - Patch proposal

2020-02-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=391 Bug ID: 391 Summary: The dpdk-devbind.py tool crashes if some NIC property contains a unicode character - Patch proposal Product: DPDK Version: 19.11 Hardware: All O

Re: [dpdk-dev] [PATCH] ci: increase unit test timeout

2020-02-05 Thread David Marchand
On Thu, Jan 30, 2020 at 12:03 PM Thomas Monjalon wrote: > > 28/01/2020 21:53, Aaron Conole: > > Ferruh Yigit writes: > > > > > Timeout multiplier was 3, which gives 30 seconds for unit test but still > > > some unit test was timing out time to time and travis reporting false > > > positive failur

Re: [dpdk-dev] [PATCH v2 0/5] test/meson: fix hash readwrite timeout failure

2020-02-05 Thread David Marchand
On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli wrote: > > V2 changes: > - Remove duplicated code in the existing patch > - Add lock-free option to hash read-write functional test cases > - Move existing loack-free test cases to performance tests > - A typo fix in the comments for lock-free ex

[dpdk-dev] [Bug 390] netvsc: There are always too many packets in tx-drop queue in testpmd tx-side

2020-02-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=390 Bug ID: 390 Summary: netvsc: There are always too many packets in tx-drop queue in testpmd tx-side Product: DPDK Version: 18.11 Hardware: x86 OS: Linux S

Re: [dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo

2020-02-05 Thread Thomas Monjalon
05/02/2020 18:14, Bruce Richardson: > On Wed, Feb 05, 2020 at 06:07:23PM +0100, Thomas Monjalon wrote: > > If a driver has no info generated by pmdinfogen, > > and if this driver is compiled as pedantic, > > then an failure would occur: > > drivers/rte_common_mlx5.pmd.c:1: error: > > ISO C

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable

2020-02-05 Thread Liang, Ma
Tested-by: Liang Ma

Re: [dpdk-dev] Offloading L4 checksum to crypto device

2020-02-05 Thread Trahe, Fiona
Hi Heng, This may be of interest for your use-case. https://patches.dpdk.org/patch/65559/ Fiona > -Original Message- > From: dev On Behalf Of Heng Wang > Sent: Monday, December 23, 2019 2:28 PM > To: Doherty, Declan > Cc: Filip Pudak ; dev@dpdk.org > Subject: [dpdk-dev] Offloading L4 che

Re: [dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 06:07:23PM +0100, Thomas Monjalon wrote: > If a driver has no info generated by pmdinfogen, > and if this driver is compiled as pedantic, > then an failure would occur: > drivers/rte_common_mlx5.pmd.c:1: error: > ISO C forbids an empty translation unit [-Werror=p

Re: [dpdk-dev] [RFC 0/6] replace telemetry with process_info

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 04:21:16PM +0100, David Marchand wrote: > Hello Ciara, Bruce, > > On Thu, Dec 5, 2019 at 6:34 PM Ciara Power wrote: > > > > From: Bruce Richardson > > > > This patchset proposes a new library, called "process-info" for now, to > > replace the existing telemetry library in

[dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo

2020-02-05 Thread Thomas Monjalon
If a driver has no info generated by pmdinfogen, and if this driver is compiled as pedantic, then an failure would occur: drivers/rte_common_mlx5.pmd.c:1: error: ISO C forbids an empty translation unit [-Werror=pedantic] Such error is triggered with the new mlx5 common directory. I

[dpdk-dev] [PATCH 3/3] examples/qos_sched: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: be1e533238c0 ("examples/qos_sched: add TC and queue config flexibility") Cc: jasvinder.si...@intel.com Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
Fixes: 3d1b33e44ae2 ("examples/eventdev: move common data into pipeline common") Cc: pbhagavat...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- examples/eventdev_pipeline/main.c| 2 ++ examples/eventdev_pipeline/pipeline_common.h | 4 ++-- 2 files changed, 4 inse

Re: [dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Ferruh Yigit
On 2/5/2020 4:44 PM, Július Milan wrote: > On Wed, Feb 05, 2020 at 04:00:19PM +, Ferruh Yigit wrote: >> On 2/5/2020 3:41 PM, Július Milan wrote: >>> With this patch it is possible to connect 2 DPDK memifs into loopback, >>> i.e. when they have the same id and different roles, as for example: >>

Re: [dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Július Milan
On Wed, Feb 05, 2020 at 04:00:19PM +, Ferruh Yigit wrote: > On 2/5/2020 3:41 PM, Július Milan wrote: >> With this patch it is possible to connect 2 DPDK memifs into loopback, >> i.e. when they have the same id and different roles, as for example: >> "--vdev=net_memif0,role=master,id=0" >> "--

Re: [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 9:48 AM David Marchand wrote: > > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > wrote: > > > > The test case target 'hash_readwrite_autotest' is covered by > > 'hash_readwrite_func_autotest' and 'hash_readwrite_perf_autotest'. > > Hence, it is removed along with its

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 5:22 PM Honnappa Nagarahalli wrote: > > > > > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > > wrote: > > > > > > Add lock-free reader writer concurrency functional tests. > > > These tests will provide the same coverage that non lock-free APIs > > > have. > > > > >

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread Honnappa Nagarahalli
> > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > wrote: > > > > Add lock-free reader writer concurrency functional tests. > > These tests will provide the same coverage that non lock-free APIs > > have. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > app/test/test_hash_readwrit

Re: [dpdk-dev] [EXT] RE: [PATCH v3 13/13] examples/ipsec-secgw: make number of buffers dynamic

2020-02-05 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 05.02.2020 14:42, Ananyev, Konstantin wrote: > External Email > > -- > > Hi Lukasz, > >> Make number of buffers in a pool nb_mbuf_in_pool dependent on number >> of ports, c

Re: [dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Ferruh Yigit
On 2/5/2020 3:41 PM, Július Milan wrote: > With this patch it is possible to connect 2 DPDK memifs into loopback, > i.e. when they have the same id and different roles, as for example: > "--vdev=net_memif0,role=master,id=0" > "--vdev=net_memif1,role=slave,id=0" Overall looks good idea but this c

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Eugenio Perez Martin
Thanks! On Wed, Feb 5, 2020 at 10:48 AM Maxime Coquelin wrote: > > > On 2/4/20 3:47 PM, Eugenio Pérez wrote: > > The current implementation of vhost_net in packed vring tries to fill > > the shadow vector before send any actual changes to the guest. While > > this can be beneficial for the throu

[dpdk-dev] [PATCH v3] doc: alias to experimental tag for stable apis

2020-02-05 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

[dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Július Milan
With this patch it is possible to connect 2 DPDK memifs into loopback, i.e. when they have the same id and different roles, as for example: "--vdev=net_memif0,role=master,id=0" "--vdev=net_memif1,role=slave,id=0" Fixes: 09c7e63a71 ("net/memif: introduce memory interface PMD") Signed-off-by: Júl

[dpdk-dev] [PATCH v2] doc: alias to experimental tag for stable apis

2020-02-05 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-02-05 Thread Thomas Monjalon
05/02/2020 15:41, Trahe, Fiona: > From: Thomas Monjalon > > 15/01/2020 16:53, Akhil Goyal: > > > > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > > > > > > > > > Signed-off-by: Arek Kusztal > > > > > Acked-by: Fiona Trahe > > > > > > > > Acked-by: Anoob Joseph > > > > > >

Re: [dpdk-dev] [RFC 0/6] replace telemetry with process_info

2020-02-05 Thread David Marchand
Hello Ciara, Bruce, On Thu, Dec 5, 2019 at 6:34 PM Ciara Power wrote: > > From: Bruce Richardson > > This patchset proposes a new library, called "process-info" for now, to > replace the existing telemetry library in DPDK. (Name subject to change > if someone can propose a better one). > > The e

[dpdk-dev] [PATCH] doc: alias to experimental tag for stable apis

2020-02-05 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

Re: [dpdk-dev] [PATCH 1/3] examples/vhost_blk: fix building with GCC 10

2020-02-05 Thread Maxime Coquelin
On 2/5/20 2:47 PM, Timothy Redaelli wrote: > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: jin...@i

[dpdk-dev] [PATCH v2] vhost: check vhost message header size read

2020-02-05 Thread Maxime Coquelin
This patch adds a check to ensure the read size of the Vhost-user message header is not smaller than the expected size. In case of unexpected read size, report an error and close file descriptors passed with the message, if any. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH v6 0/8] Introduce CPU crypto mode

2020-02-05 Thread Akhil Goyal
> Originally both SW and HW crypto PMDs use rte_crypot_op based API to > process the crypto workload asynchronously. This way provides uniformity > to both PMD types, but also introduce unnecessary performance penalty to > SW PMDs that have to "simulate" HW async behavior (crypto-ops > enqueue/d

Re: [dpdk-dev] [PATCH v6 6/8] examples/ipsec-secgw: cpu crypto support

2020-02-05 Thread Akhil Goyal
> > Add support for CPU accelerated crypto. 'cpu-crypto' SA type has > been introduced in configuration allowing to use abovementioned > acceleration. > > Legacy mode is not currently supported. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > Acked-by: Fan Zhang > -

Re: [dpdk-dev] [PATCH v6 5/8] ipsec: introduce support for cpu crypto mode

2020-02-05 Thread Akhil Goyal
> > Update library to handle CPU cypto security mode which utilizes > cryptodev's synchronous, CPU accelerated crypto operations. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > Acked-by: Fan Zhang > Tested-by: Konstantin Ananyev > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v6 4/8] test/crypto: add cpu crypto mode to tests

2020-02-05 Thread Akhil Goyal
> > This patch adds ability to run unit tests in cpu crypto mode and > provides test for aesni_gcm's cpu crypto implementation. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > --- > app/test/test_cryptodev.c | 161 +++--- > 1 file chan

Re: [dpdk-dev] [PATCH v6 3/8] security: add cpu crypto action type

2020-02-05 Thread Akhil Goyal
> Introduce CPU crypto action type allowing to differentiate between > regular async 'none security' and synchronous, CPU crypto accelerated > sessions. > > This mode is similar to ACTION_TYPE_NONE but crypto processing is > performed synchronously on a CPU. > > Signed-off-by: Marcin Smoczynski

Re: [dpdk-dev] [PATCH v6 1/8] cryptodev: introduce cpu crypto support API

2020-02-05 Thread Akhil Goyal
> > Add new API allowing to process crypto operations in a synchronous > manner. Operations are performed on a set of SG arrays. > > Cryptodevs which allows CPU crypto operation mode have to > use RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO capability. > > Add a helper method to easily convert mbufs to a SG

Re: [dpdk-dev] [PATCH 0/6] code improvements for OCTEON TX crypto PMDs

2020-02-05 Thread Akhil Goyal
> > Hi Akhil, > > This series is ready for merge, if you don't have any comments. > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-02-05 Thread Trahe, Fiona
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 5, 2020 2:29 PM > To: Anoob Joseph ; Kusztal, ArkadiuszX > ; Trahe, > Fiona ; Akhil Goyal > Cc: dev@dpdk.org; Narayana Prasad Raju Athreya ; > Tejasree Kondoj > ; Jerin Jacob Kollanukkaran ; > bl...@de

[dpdk-dev] Travis warning about job configs

2020-02-05 Thread David Marchand
While monitoring the newly pushed ABI check in Travis, I noticed that Travis has now a feature to validate the configuration we pass. You can notice a new "Build config validation" box in https://travis-ci.com/DPDK/dpdk/builds/147554312/config Not sure those warnings are a real issue, but it coul

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] add ABI checks

2020-02-05 Thread Trahe, Fiona
Hi Anoob, > -Original Message- > From: Anoob Joseph > Sent: Wednesday, February 5, 2020 6:16 AM > To: Neil Horman ; Akhil Goyal ; > Trahe, Fiona > > Cc: Thomas Monjalon ; Yigit, Ferruh > ; Ananyev, > Konstantin ; Trahe, Fiona > ; dev@dpdk.org; > David Marchand ; Kusztal, ArkadiuszX >

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 01:41:24AM +0100, Thomas Monjalon wrote: > 05/02/2020 00:21, Dmitry Kozlyuk: > > > I really like this patch. > > > So both GCC (with MinGW) and native clang are supported? > > > > Thanks. Yes, I tested both toolchains. > > > > > [...] > > > > +# MS linker requires special

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-02-05 Thread Thomas Monjalon
15/01/2020 16:53, Akhil Goyal: > > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > > > > > Signed-off-by: Arek Kusztal > > > Acked-by: Fiona Trahe > > > > Acked-by: Anoob Joseph > > > Acked-by: Akhil Goyal > > Applied to dpdk-next-crypto As discussed in other email thre

Re: [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Dumitrescu, Cristian
> -Original Message- > From: Timothy Redaelli > Sent: Wednesday, February 5, 2020 2:12 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; david.march...@redhat.com; Dumitrescu, Cristian > > Subject: [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10 > > GCC 10 defaults to -fno-commo

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:36 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:18 AM > > To: k...@vger.kernel.org > > Subject: Re: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > > > > Promised example QEMU test case... > > > > commit 3557c63bcb286c71f3f

Re: [dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:29 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:06 AM > > To: k...@vger.kernel.org > > Subject: [RFC PATCH 3/7] vfio/pci: Introduce VF token > > > > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > > f

Re: [dpdk-dev] [PATCH v4 0/3] add ABI checks

2020-02-05 Thread Thomas Monjalon
02/02/2020 22:08, David Marchand: > Here is the current state of the ABI checks. > > libabigail has some issues when mixing dump and so files compiled with > clang [1], so for now, all checks are done on dumps only. > libabigail 1.0-rc3 in Xenial reported issues that disappear with the > version 1

Re: [dpdk-dev] [PATCH] vhost: check vhost message header size read

2020-02-05 Thread Maxime Coquelin
On 1/17/20 8:54 AM, Tiwei Bie wrote: > On Thu, Jan 16, 2020 at 11:44:44AM +0100, Maxime Coquelin wrote: >> This patch adds a check to ensure the read size of >> the Vhost-user message header is not smaller than >> the expected size. >> >> Fixes: 8f972312b8f4 ("vhost: support vhost-user") >> Cc:

[dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Red

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:21 + "Liu, Yi L" wrote: > Hi Alex, > > Silly questions on the background: > > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:06 AM > > Subject: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > > There seems to be an ongoing desire to use userspace,

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Tue, 4 Feb 2020 23:01:09 -0800 Christoph Hellwig wrote: > On Tue, Feb 04, 2020 at 04:05:34PM -0700, Alex Williamson wrote: > > We address this in a few ways in this series. First, we can use a bus > > notifier and the driver_override facility to make sure VFs are bound > > to the vfio-pci dri

Re: [dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-05 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, February 5, 2020 7:06 AM > To: k...@vger.kernel.org > Subject: [RFC PATCH 3/7] vfio/pci: Introduce VF token > > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > fully isolated from the PF. The PF can always cause a denial of > ser

  1   2   >