> -----Original Message-----
> From: Timothy Redaelli <tredae...@redhat.com>
> Sent: Wednesday, February 5, 2020 2:12 PM
> To: sta...@dpdk.org
> Cc: dev@dpdk.org; david.march...@redhat.com; Dumitrescu, Cristian
> <cristian.dumitre...@intel.com>
> Subject: [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10
>
> GCC 10 defaults to -fno-common, this means a linker error will now be
> reported if the same global variable is defined in more than one
> compilation unit.
>
> Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
> Cc: cristian.dumitre...@intel.com
> Cc: sta...@dpdk.org
> Signed-off-by: Timothy Redaelli <tredae...@redhat.com>
> ---
>
> v2:
> app is already declared as extern in main.h. (as reported by David)
>
> ---
> app/test-pipeline/config.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c
> index 28ac9fcc0..33f3f1c82 100644
> --- a/app/test-pipeline/config.c
> +++ b/app/test-pipeline/config.c
> @@ -42,8 +42,6 @@
>
> #include "main.h"
>
> -struct app_params app;
> -
> static const char usage[] = "\n";
>
> void
> --
> 2.24.1
Yes, app is declared in main.h and defined & initialized in init.c, no need to
have it defined the second time in config.c.
Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
