Re: [dpdk-dev] [Bug 383] dpdk virtio_user lack of notifications make vhost_net+napi stops tx buffers

2020-01-14 Thread Liu, Yong
> -Original Message- > From: dev On Behalf Of epere...@redhat.com > Sent: Thursday, January 09, 2020 11:56 PM > To: bugzi...@dpdk.org; dev@dpdk.org; Maxime Coquelin > Cc: Jason Wang ; Michael S. Tsirkin ; > Adrian Moreno Zapata > Subject: Re: [dpdk-dev] [Bug 383] dpdk virtio_user lack

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-14 Thread 方统浩50450
Hi Ferruh, thanks for your message. We developed a ethtool-dpdk which is secondary process based dpdk 17.08 version. Our device support hotplug detach, but hotplug deatch is failed when we use ethtool-dpdk.We found the secondary process will change the shared memory when initializing.Secondary

[dpdk-dev] [PATCH v1] pktgen: fix generating sequences with vlan header

2020-01-14 Thread Ivan Dyukov
If lua file contains following code: pktgen.seqTable(0, "0", seq_table); pktgen.set("all", "seqCnt", 1); pktgen.vlan("all", 15); it will not work because the vlan setting resets sequence flag on the port. To solve the issue vlan should not reset EXCLUSIVE_MODES, it should reset only EXCLUSIVE_PKT_

[dpdk-dev] [PATCH v5] net/virtio-user: fix packed ring server mode

2020-01-14 Thread Xuan Ding
This patch fixes the situation where data path does not work properly when vhost reconnects to virtio in server mode with packed ring. Currently, virtio and vhost share memory of vring. For split ring, vhost can read the status of descriptors directly from the available ring and the used ring duri

Re: [dpdk-dev] [PATCH v4] net/virtio-user: fix packed ring server mode

2020-01-14 Thread Ding, Xuan
Hi Maxime, Replies are inline. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 14, 2020 11:04 PM > To: Ding, Xuan ; Bie, Tiwei ; Wang, > Zhihong ; Liu, Yong ; Ye, > Xiaolong > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v4] net/virtio-user: fix packed

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Honnappa Nagarahalli
> > >> > > >> Aaron Conole writes: > > >> > > >> > Honnappa Nagarahalli writes: > > >> > > > >> >> Hi Aaron, > > >> >> I am not able to understand the error, looks like there is no > > >> >> particular error. Can you please take a look? > > >> > > > >> > Gladly. A number of the systems that wer

Re: [dpdk-dev] [PATCH] vhost: fix deadlock on port deletion

2020-01-14 Thread Tiwei Bie
On Tue, Jan 14, 2020 at 07:53:57PM +0100, Maxime Coquelin wrote: > If the vhost-user application (e.g. OVS) deletes the vhost-user > port while Qemu sends a vhost-user request, a deadlock can > happen if the request handler tries to acquire vhost-user's > global mutex, which is also locked by the v

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Honnappa Nagarahalli
> >> > >> Aaron Conole writes: > >> > >> > Honnappa Nagarahalli writes: > >> > > >> >> Hi Aaron, > >> >> I am not able to understand the error, looks like there is no > >> >> particular error. Can you please take a look? > >> > > >> > Gladly. A number of the systems that were running the build

Re: [dpdk-dev] [PATCH V1] doc: update recommended kernel version for i40e

2020-01-14 Thread Ye Xiaolong
On 01/14, Kevin Traynor wrote: >On 14/01/2020 19:10, Kevin Traynor wrote: >> On 14/01/2020 02:28, Ye Xiaolong wrote: >>> On 01/03, Chen, Zhaoyan wrote: Update supported Intel NIC driver version and firmware version for 19.11 Update supported Intel NIC driver version to 2.8.43 for 19.08 wh

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] net/bnx2x: fix to use required mem barriers in Rx path

2020-01-14 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Tuesday, January 14, 2020 5:49 AM >To: Rasesh Mody ; Gavin Hu >Cc: dpdk-dev ; Jerin Jacob Kollanukkaran >; Ferruh Yigit ; GR-Everest- >DPDK-Dev ; dpdk stable > >Subject: [EXT] Re: [dpdk-dev] [PATCH 1/3] net/bnx2x: fix to use required >mem barriers in Rx path >

Re: [dpdk-dev] [PATCH v5 00/14] net/i40e: ESP support

2020-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 14, 2020 9:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v5 00/14] net/i40e: ESP su

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, January 15, 2020 8:20 AM > To: Iremonger, Bernard ; dev@dpdk.org; Xing, > Beilei ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v5 11/14] net/i40e: display Flow Director pa

Re: [dpdk-dev] [PATCH v5 07/14] net/i40e: support ESP in customised code

2020-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 14, 2020 9:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v5 07/14] net/i40e: suppor

[dpdk-dev] [PATCH v3 2/4] net/ice: unify the bool type value

2020-01-14 Thread Haiyue Wang
Replaces the redefined TRUE and FALSE values with standard ones to match the 'bool' type definition. Signed-off-by: Haiyue Wang Acked-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 22 +++--- drivers/net/ice/ice_rxtx.c | 16 2 files changed, 19 insertions(

[dpdk-dev] [PATCH v3 4/4] net/ice/base: osdep.h clean up

2020-01-14 Thread Haiyue Wang
Remove the unused definitions, rewrite the IO data read/write helpers, and put the common definitions related to RTE defines under the macro __INTEL_NET_BASE_OSDEP__, so it works like OS(RTE) dependency. Signed-off-by: Haiyue Wang --- drivers/net/ice/base/ice_osdep.h | 132 --

[dpdk-dev] [PATCH v3 1/4] net/iavf: unify the bool type value

2020-01-14 Thread Haiyue Wang
Replaces the redefined TRUE and FALSE values with standard ones to match the 'bool' type definition. Signed-off-by: Haiyue Wang Acked-by: Qiming Yang --- drivers/net/iavf/iavf_ethdev.c | 31 --- drivers/net/iavf/iavf_rxtx.c | 34 +-

[dpdk-dev] [PATCH v3 0/4] Intel iavf and ice PMDs clean up

2020-01-14 Thread Haiyue Wang
a. Remove the unused definitions in osdep.h. b. Put the common definitions used by Intel net PMDs under the macro __INTEL_NET_BASE_OSDEP__, which works as an include file, so that it is easily maintained. --- v3: update the commit message. v2: add the osdep.h clean up, which depends on v1 to remo

[dpdk-dev] [PATCH v3 3/4] common/iavf: osdep.h clean up

2020-01-14 Thread Haiyue Wang
Remove the unused definitions, rewrite the IO data read/write helpers, and put the common definitions related to RTE defines under the macro __INTEL_NET_BASE_OSDEP__, so it works like OS(RTE) dependency. Signed-off-by: Haiyue Wang --- drivers/common/iavf/iavf_osdep.h | 107 +-

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Honnappa Nagarahalli
> >> > >> Aaron Conole writes: > >> > >> > Honnappa Nagarahalli writes: > >> > > >> >> Hi Aaron, > >> >> I am not able to understand the error, looks like there is no > >> >> particular error. Can you please take a look? > >> > > >> > Gladly. A number of the systems that were running the build

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 14, 2020 9:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v5 11/14] net/i40e: displa

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 14, 2020 9:55 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v5 12/14] librte_ethdev: a

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-14 Thread Thomas Monjalon
20/12/2019 17:20, Kinsella, Ray: > From: Richardson, Bruce > > From: David Marchand > > > +Checking ABI compatibility > > > +-- > > > + > > > +The first thing is to build reference binaries for the latest > > release > > > +your patches are built on top of. > > > + > > > +

[dpdk-dev] [PATCH v4] mempool: remove memory wastage on non x86

2020-01-14 Thread jerinj
From: Jerin Jacob The existing optimize_object_size() function address the memory object alignment constraint on x86 for better performance. Different (micro) architecture may have different memory alignment constraint for better performance and it not the same as the existing optimize_object_si

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Aaron Conole
Honnappa Nagarahalli writes: > >> >> Aaron Conole writes: >> >> > Honnappa Nagarahalli writes: >> > >> >> Hi Aaron, >> >> I am not able to understand the error, looks like there is no >> >> particular error. Can you please take a look? >> > >> > Gladly. A number of the systems that were run

Re: [dpdk-dev] [PATCH v2] examples/l2fwd-event: fix ethdev RSS setup

2020-01-14 Thread Jerin Jacob
On Tue, Jan 14, 2020 at 11:22 AM wrote: > > From: Pavan Nikhilesh > > Setup RSS configuration based on underlying device capabilities. > > Fixes: 4ff457986f76 ("examples/l2fwd-event: add default poll mode routines") > Cc: sta...@dpdk.org > > Signed-off-by: Satananda Burla > Signed-off-by: Pavan

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-14 Thread Rasesh Mody
Hi Kevin, >From: Kevin Traynor >Sent: Tuesday, January 14, 2020 10:52 AM > >On 14/01/2020 04:51, Jerin Jacob wrote: >> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody >wrote: >>> >>> Skip the device re-initialization for secondary process. >>> >>> Cc: sta...@dpdk.com >> >> Correct Cc: to sta...@dpdk

Re: [dpdk-dev] [PATCH v2] event/dsw: avoid credit leak on oversized enqueue bursts

2020-01-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, January 14, 2020 11:34 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Mattias Rönnblom ; > sta...@dpdk.org > Subject: [EXT] [PATCH v2] event/dsw: avoid credit leak on oversized enqueue > bursts > > If an application

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Honnappa Nagarahalli
> > Aaron Conole writes: > > > Honnappa Nagarahalli writes: > > > >> Hi Aaron, > >> I am not able to understand the error, looks like there is no > >> particular error. Can you please take a look? > > > > Gladly. A number of the systems that were running the build stopped > > their output for

[dpdk-dev] [PATCH v4] crypto/qat: add minimum enq threshold to qat pmd

2020-01-14 Thread Arek Kusztal
This patch adds minimum enqueue threshold to Intel QuickAssist Technology PMD. It is an optimisation, configured by a command line option, which can be used to reduce MMIO write occurrences. Signed-off-by: Fiona Trahe Signed-off-by: Arek Kusztal --- v4: - fixed checkpatch issues doc/guides/cry

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: fix event device config

2020-01-14 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 7:57 PM wrote: > > From: Pavan Nikhilesh > > Always enable implicit release since we don't support explicit release > in datapath. > Master lcore is used only for printing stats so don't allocate event > port for it. > Fix service launch for event device without distribute

Re: [dpdk-dev] [PATCH V1] doc: update recommended kernel version for i40e

2020-01-14 Thread Kevin Traynor
On 14/01/2020 19:10, Kevin Traynor wrote: > On 14/01/2020 02:28, Ye Xiaolong wrote: >> On 01/03, Chen, Zhaoyan wrote: >>> Update supported Intel NIC driver version and firmware version for 19.11 >>> Update supported Intel NIC driver version to 2.8.43 for 19.08 which is >>> widely tested >>> > > T

Re: [dpdk-dev] [PATCH V1] doc: update recommended kernel version for i40e

2020-01-14 Thread Kevin Traynor
On 14/01/2020 02:28, Ye Xiaolong wrote: > On 01/03, Chen, Zhaoyan wrote: >> Update supported Intel NIC driver version and firmware version for 19.11 >> Update supported Intel NIC driver version to 2.8.43 for 19.08 which is >> widely tested >> This should be backported to 19.11 branch. Please add

Re: [dpdk-dev] [PATCH v5 01/14] app/testpmd: parse flow command line for ESP

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > add ITEM_ESP > add ITEM_ESP_SPI > > Signed-off-by: Bernard Iremonger > Acked-by: Ori Kam > --- > app/test-pmd/cmdline_flow.c | 4 +--- > app/test-pmd/config.c | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/app/

[dpdk-dev] [PATCH] vhost: fix deadlock on port deletion

2020-01-14 Thread Maxime Coquelin
If the vhost-user application (e.g. OVS) deletes the vhost-user port while Qemu sends a vhost-user request, a deadlock can happen if the request handler tries to acquire vhost-user's global mutex, which is also locked by the vhost-user port deletion API (rte_vhost_driver_unregister). This patch pr

Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > include rte_config.h in i40e_fdir.c > In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() > and in i40e_fdir_construct_pkt() > > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_fdir.c | 12 ++-- > 1 file changed

Re: [dpdk-dev] [PATCH] net/bnx2x: add support for secondary process

2020-01-14 Thread Kevin Traynor
On 14/01/2020 04:51, Jerin Jacob wrote: > On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody wrote: >> >> Skip the device re-initialization for secondary process. >> >> Cc: sta...@dpdk.com > > Correct Cc: to sta...@dpdk.org > Is it a fix, or secondary process was not intended to be supported previousl

Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > Add macros for the following protocols in the DDP esp-ah profile: > ESP > AH > > Add the following RSS macro for IPsec: > ETH_RSS_IPSEC > > Signed-off-by: Bernard Iremonger +Ori and other ethdev maintainers. Ori, can you please check this patch?

[dpdk-dev] [Bug 385] latency calculation has potential performance issues

2020-01-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=385 Bug ID: 385 Summary: latency calculation has potential performance issues Product: DPDK Version: 19.11 Hardware: All OS: All Status: UNCONFIRMED Severity: minor

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: rename variable

2020-01-14 Thread Ferruh Yigit
On 12/21/2019 1:02 AM, Stephen Hemminger wrote: > All global variables in kernel should be prefixed by the same > to avoid any symbol conflics. Rename dflt_carrier to kni_default_carrier. > > Fixes: 89397a01ce4a ("kni: set default carrier state of interface") > Cc: d...@adax.com > Cc: sta...@dpdk.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/cxgbe: announce Tx multi segs offload

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 9:43 AM, Rahul Lakkireddy wrote: > Multi-segs Tx is already supported by CXGBE PMD. So, add the missing > DEV_TX_OFFLOAD_MULTI_SEGS flag to the list of supported Tx offload > features. > > Fixes: 436125e64174 ("net/cxgbe: update to Rx/Tx offload API") > Cc: sta...@dpdk.org > > Report

Re: [dpdk-dev] [PATCH v2] net/mlx5: optimize Rx hash fields conversion

2020-01-14 Thread Kevin Traynor
On 14/01/2020 09:18, Dekel Peled wrote: > Previous fix added translation of Rx hash fields to PRM format. > > This patch optimizes the fix, to perform value translation only > if value is not zero. > In case value is zero, there is no need to translate it. > > Cc: sta...@dpdk.org > > Signed-off-

[dpdk-dev] [PATCH v2] event/dsw: avoid credit leak on oversized enqueue bursts

2020-01-14 Thread Mattias Rönnblom
If an application issues rte_event_enqueue_new_burst() or rte_event_enqueue_forward_burst() call with a burst of events longer than the configured max enqueue burst size, DSW allocates credits not only for events actually enqueued, but for the complete burst. If this process is repeated, enough cre

Re: [dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5

2020-01-14 Thread Maxime Coquelin
On 1/14/20 6:52 PM, Ferruh Yigit wrote: > Build error: > In function ‘ixgbe_recv_pkts_lro_bulk_alloc’: > ../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24: > error: ‘next_sc_entry’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > next_sc_entry->fbuf = first_seg; >

Re: [dpdk-dev] [PATCH] net/enic: move macro to the correct file

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 12:24 AM, John Daley wrote: > Move a macro from a widely included header file to a header file > used only by the one caller of the macro. > > Signed-off-by: John Daley > Reviewed-by: Hyong Youb Kim Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/enic: consolidate and remove some defines

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 12:24 AM, John Daley wrote: > There were defines which originally allowed sharing of some code with > the enic kernel driver. The code has long since diverged and now the > abstraction just makes the code harder to read. Mostly mechanical > replacement of defines and reformatting. > >

Re: [dpdk-dev] [PATCH] net/enic: use standard RTE defines

2020-01-14 Thread Ferruh Yigit
On 1/14/2020 12:24 AM, John Daley wrote: > Use the memzone namesize, Ethernet address length defines from the RTE > header files instead of locally defined versions. > Use the RTE byte swap functions instead of the x86 specific locally > defined versions. > > Signed-off-by: John Daley > Reviewed-

[dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5

2020-01-14 Thread Ferruh Yigit
Build error: In function ‘ixgbe_recv_pkts_lro_bulk_alloc’: ../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24: error: ‘next_sc_entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized] next_sc_entry->fbuf = first_seg; ^ http://mails.dpdk.org/archives/t

Re: [dpdk-dev] [PATCH v3 3/4] common/qat: add dual thread support

2020-01-14 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, December 11, 2019 2:50 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Doherty, Declan > ; Kusztal, ArkadiuszX > Subject: [PATCH v3 3/4] common/qat: add dual thread support > > From: Fiona Trahe > >

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-14 Thread Andrzej Ostruszka
On 1/14/20 4:16 PM, Morten Brørup wrote: > Andrzej, Hello Morten > Basically you are adding a very small subset of the Linux IP stack> to > interface with DPDK applications via callbacks. Yes, at the moment this is limited - we'd prefer first to solicit some input from community. > The library

Re: [dpdk-dev] [PATCH v3 2/4] common/qat: move max inflights param into qp

2020-01-14 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, December 11, 2019 2:50 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Doherty, Declan > ; Kusztal, ArkadiuszX > Subject: [PATCH v3 2/4] common/qat: move max inflights param into qp > > From: Fiona Tra

Re: [dpdk-dev] [PATCH v3 1/4] common/qat: remove tail write coalescing feature

2020-01-14 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, December 11, 2019 2:50 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Doherty, Declan > ; Kusztal, ArkadiuszX > Subject: [PATCH v3 1/4] common/qat: remove tail write coalescing feature > > From: Fiona

Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-14 Thread Bruce Richardson
On Tue, Jan 14, 2020 at 04:35:09PM +, Luca Boccassi wrote: > On Tue, 2020-01-14 at 16:19 +, Bruce Richardson wrote: > > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > > > < > > > bruce.richard...@intel.com > > > > wr

Re: [dpdk-dev] [EXT] [PATCH] event/dsw: avoid credit leak on oversized enqueue bursts

2020-01-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mattias Rönnblom > Sent: Friday, January 3, 2020 5:02 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Mattias Rönnblom ; > sta...@dpdk.org > Subject: [EXT] [PATCH] event/dsw: avoid credit leak on oversized enqueue > bursts > > If an application issues

Re: [dpdk-dev] [EXT] [PATCH] event/dsw: immediately flush buffers on zero-sized enqueue

2020-01-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, December 17, 2019 4:44 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; niclas.st...@ericsson.com; Mattias Rönnblom > ; sta...@dpdk.org > Subject: [EXT] [PATCH] event/dsw: immediately flush buffers on zero-sized > enqu

[dpdk-dev] [PATCH] fib: fix possible integer overflow

2020-01-14 Thread Vladimir Medvedkin
Coverity issue: 350596 Coverity issue: 350597 Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") Cc: vladimir.medved...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/trie.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletion

Re: [dpdk-dev] [PATCH 1/2] crypto/qat: add chacha poly implementation

2020-01-14 Thread Trahe, Fiona
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, December 6, 2019 6:14 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH 1/2] crypto/qat: add chacha poly implementation > > This patchset adds Chacha20-Poly

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Aaron Conole
Aaron Conole writes: > Honnappa Nagarahalli writes: > >> Hi Aaron, >> I am not able to understand the error, looks like there is no >> particular error. Can you please take a look? > > Gladly. A number of the systems that were running the build stopped > their output for an unknown reason (look

Re: [dpdk-dev] [PATCH 0/2] net/netvsc: fix secondary process issues

2020-01-14 Thread Ferruh Yigit
On 1/13/2020 7:12 PM, Stephen Hemminger wrote: > First patch is a bug fix for crash in info_get in secondary process. > Second one is modification to prevent similar issues in future. > > Stephen Hemminger (2): > net/netvsc: fix crash in secondary process > net/netvsc: eliminate numa specific

Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-14 Thread Luca Boccassi
On Tue, 2020-01-14 at 16:19 +, Bruce Richardson wrote: > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > > < > > bruce.richard...@intel.com > > > wrote: > > > These patches make some improvements to the meson build, > > > p

Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-14 Thread David Marchand
On Tue, Jan 14, 2020 at 5:19 PM Bruce Richardson wrote: > > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > > wrote: > > > > > > These patches make some improvements to the meson build, particularly > > > for documentation. T

Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-14 Thread Bruce Richardson
On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > wrote: > > > > These patches make some improvements to the meson build, particularly > > for documentation. They also remove many, but not all warnings issued > > by meson e.g. war

Re: [dpdk-dev] [PATCH v4 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-14 Thread Bruce Richardson
On Tue, Jan 14, 2020 at 04:59:24PM +0100, David Marchand wrote: > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > wrote: > > > > Add proper support for calling sphinx whenever a file in the doc > > directory changes. This is accomplished by using a wrapper script > > for sphinx, which runs sph

Re: [dpdk-dev] [PATCH v3 2/4] mbuf: create packet pool with external memory buffers

2020-01-14 Thread Olivier Matz
On Tue, Jan 14, 2020 at 09:15:03AM +, Viacheslav Ovsiienko wrote: > The dedicated routine rte_pktmbuf_pool_create_extbuf() is > provided to create mbuf pool with data buffers located in > the pinned external memory. The application provides the > external memory description and routine initiali

Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-14 Thread David Marchand
On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson wrote: > > These patches make some improvements to the meson build, particularly > for documentation. They also remove many, but not all warnings issued by > meson e.g. warnings about newer features unsupported in baseline. > > The biggest change i

Re: [dpdk-dev] [PATCH v4 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-14 Thread David Marchand
On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson wrote: > > Add proper support for calling sphinx whenever a file in the doc > directory changes. This is accomplished by using a wrapper script > for sphinx, which runs sphinx but also emits a gcc-format dependency > file listing all the doc files.

Re: [dpdk-dev] [PATCH v4 5/5] examples/ipsec-secgw: get rid of maximum sp limitation

2020-01-14 Thread Ananyev, Konstantin
> Get rid of maximum SP limitation. > Keep parsed SP's into the sorted by SPI value array. > Use binary search in the sorted SP array to find appropriate SP > for a given SPI. > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Konstantin Ananyev > 2.7.4

Re: [dpdk-dev] [PATCH v4 4/5] examples/ipsec-secgw: get rid of maximum sa limitation

2020-01-14 Thread Ananyev, Konstantin
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, January 14, 2020 2:27 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; akhil.go...@nxp.com > Subject: [PATCH v4 4/5] examples/ipsec-secgw: get rid of maximum sa limitation > > Get rid of maximum SA limitation. > Keep pa

Re: [dpdk-dev] [PATCH v4 2/5] examples/ipsec-secgw: implement inbound SAD

2020-01-14 Thread Ananyev, Konstantin
> > Add initial support for librte_ipsec SAD library > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Konstantin Ananyev > 2.7.4

Re: [dpdk-dev] [PATCH v4 3/5] examples/ipsec-secgw: integrate inbound SAD

2020-01-14 Thread Ananyev, Konstantin
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, January 14, 2020 2:27 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; akhil.go...@nxp.com > Subject: [PATCH v4 3/5] examples/ipsec-secgw: integrate inbound SAD > > Integrate ipsec SAD support into secgw app: > > 1. Us

Re: [dpdk-dev] [PATCH v4 1/5] ipsec: move ipsec sad name length into .h

2020-01-14 Thread Ananyev, Konstantin
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, January 14, 2020 2:27 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; akhil.go...@nxp.com > Subject: [PATCH v4 1/5] ipsec: move ipsec sad name length into .h > > Move IPSEC_SAD_NAMESIZE into public header > and rename

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-14 Thread Stephen Hemminger
On Tue, 14 Jan 2020 09:15:02 + Viacheslav Ovsiienko wrote: > +/** > + * Returns TRUE if given mbuf has an pinned external buffer, or FALSE > + * otherwise. The pinned external buffer is allocated at pool creation > + * time and should not be freed. > + * > + * External buffer is a user-provid

Re: [dpdk-dev] [PATCH] ethdev: fix switching domain allocation

2020-01-14 Thread Ferruh Yigit
On 12/19/2019 12:47 PM, Viacheslav Ovsiienko wrote: > The maximum amount of unique switching domain is supposed > to be equal to RTE_MAX_ETHPORTS. The current implementation > allows to allocate only RTE_MAX_ETHPORTS-1 domains. > > Fixes: ce9250406323 ("ethdev: add switch domain allocator") > Cc:

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores >RTE_MAX_LCORE

2020-01-14 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Tuesday, January 14, 2020 1:59 PM > > On Mon, Dec 2, 2019 at 4:36 PM David Marchand > wrote: > > > > We are currently stuck with no option but recompile a DPDK if the > system > > has more cores than RTE_MAX_LCORE. > >

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-14 Thread Olivier Matz
Hi Viacheslav, Please see some comments below. On Tue, Jan 14, 2020 at 09:15:02AM +, Viacheslav Ovsiienko wrote: > Update detach routine to check the mbuf pool type. > > Signed-off-by: Shahaf Shuler > Signed-off-by: Viacheslav Ovsiienko > --- > lib/librte_mbuf/rte_mbuf.h | 64 > +

Re: [dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-14 Thread Morten Brørup
Andrzej, Basically you are adding a very small subset of the Linux IP stack to interface with DPDK applications via callbacks. The library also seems to support interfacing to the route table, so it is not "interface proxy", but "IP stack proxy". You already mention ARP table as future work. H

Re: [dpdk-dev] FW: || pw64572 lib/eventdev: use custom element size ring for event rings

2020-01-14 Thread Aaron Conole
Honnappa Nagarahalli writes: > Hi Aaron, > I am not able to understand the error, looks like there is no > particular error. Can you please take a look? Gladly. A number of the systems that were running the build stopped their output for an unknown reason (looks like this was a 1-time thing).

Re: [dpdk-dev] [PATCH v4] net/virtio-user: fix packed ring server mode

2020-01-14 Thread Maxime Coquelin
On 12/23/19 8:25 AM, Xuan Ding wrote: > This patch fixes the situation where datapath does not work properly when > vhost reconnects to virtio in server mode with packed ring. > > Currently, virtio and vhost share memory of vring. For split ring, vhost > can read the status of discriptors direc

Re: [dpdk-dev] [PATCH] event/dsw: add by-name xstats retrieval

2020-01-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mattias Rönnblom > Sent: Friday, December 13, 2019 12:14 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran > Cc: niclas.st...@ericsson.com; Mattias Rönnblom > > Subject: [EXT] [PATCH] event/dsw: add by-name xstats retrieval > > Implement rte_event_dev_stats

Re: [dpdk-dev] [PATCH v5] vhost: add config change slave msg support

2020-01-14 Thread Maxime Coquelin
On 12/20/19 9:22 AM, Li Feng wrote: > This msg is used to notify qemu that should get the config of backend. > > For example, vhost-user-blk uses this msg to notify guest os the > capacity of backend has changed. > > The need_reply flag is not mandatory because it will block the sender > threa

Re: [dpdk-dev] [PATCH v3 09/10] net/bnxt: release port upon close

2020-01-14 Thread Somnath Kotur
Ferruh, Will recheck and revert on Thanks Som On Tue, 14 Jan 2020, 18:26 Ferruh Yigit, wrote: > On 1/14/2020 5:14 AM, Ajit Khaparde wrote: > > From: Somnath Kotur > > > > Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources > > for the port can be freed by rte_eth_dev_close().

Re: [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory

2020-01-14 Thread Ferruh Yigit
On 1/13/2020 5:03 AM, Fang TongHao wrote: > Secondary process calls “rte_eth_dev_pci_allocate” > function and enters rte_eth_copy_pci_info function > when initializing.Then it sets the value of struct > "rte_eth_dev_data.dev_flags" to zero and reset it, > but this struct is shared by primary proces

[dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-14 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.6. The planned date for the final release is 31st January. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validation

Re: [dpdk-dev] [PATCH 00/11] misc updates and fixes for hns3 PMD driver

2020-01-14 Thread Ferruh Yigit
On 1/9/2020 3:15 AM, Wei Hu (Xavier) wrote: > This series are updates and bugfixes for hns3 ethernet PMD driver. > > Chengwen Feng (1): > net/hns3: fix triggering reset proceduce in slave process > > Hongbo Zheng (1): > net/hns3: fix segment error when closing the port > > Wei Hu (Xavier) (8

[dpdk-dev] [PATCH v4 3/5] examples/ipsec-secgw: integrate inbound SAD

2020-01-14 Thread Vladimir Medvedkin
Integrate ipsec SAD support into secgw app: 1. Use SAD library for inbound SA lookup 2. Changes in struct sa_ctx: - sa array allocates dynamically depending on number of configured sa - All SA's are kept one by one without using SPI2IDX 3. SP's userdata now contain index of SA in sa_ctx instea

[dpdk-dev] [PATCH v4 4/5] examples/ipsec-secgw: get rid of maximum sa limitation

2020-01-14 Thread Vladimir Medvedkin
Get rid of maximum SA limitation. Keep parsed SA's into the sorted by SPI value array. Use binary search in the sorted SA array to find appropriate SA for a given SPI. Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec.h | 1 - examples/ipsec-secgw/parser.c | 2 ++ examples/ipse

[dpdk-dev] [PATCH v4 5/5] examples/ipsec-secgw: get rid of maximum sp limitation

2020-01-14 Thread Vladimir Medvedkin
Get rid of maximum SP limitation. Keep parsed SP's into the sorted by SPI value array. Use binary search in the sorted SP array to find appropriate SP for a given SPI. Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/parser.c | 2 + examples/ipsec-secgw/parser.h | 6 +++ examples/ips

[dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-14 Thread Vladimir Medvedkin
This series integrates SA database (SAD) capabilities from ipsec library. The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. Also patch series removes hardcoded limitation for maximum number of SA's and SP's. v4: - put tunnel SA's into SAD with SPI_ONLY type for performance reas

[dpdk-dev] [PATCH v4 2/5] examples/ipsec-secgw: implement inbound SAD

2020-01-14 Thread Vladimir Medvedkin
Add initial support for librte_ipsec SAD library Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec.h | 7 examples/ipsec-secgw/sad.c | 90 examples/ipsec-secgw/sad.h | 74 3 files changed,

[dpdk-dev] [PATCH v4 1/5] ipsec: move ipsec sad name length into .h

2020-01-14 Thread Vladimir Medvedkin
Move IPSEC_SAD_NAMESIZE into public header and rename it to RTE_IPSEC_SAD_NAMESIZE Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/ipsec_sad.c | 20 ++-- lib/librte_ipsec/rte_ipsec_sad.h | 2 ++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/libr

[dpdk-dev] [RFC PATCH 3/3] if_proxy: add example, test and documentation

2020-01-14 Thread Andrzej Ostruszka
This commit adds a test, documentation and a small example. The example just creates one proxy port and binds all ports available to it. Then you can play around with changing of network configuration of this proxy port and you should observe notifications from the appropriate callbacks. Below i

[dpdk-dev] [RFC PATCH 2/3] if_proxy: add preliminary Linux implementation

2020-01-14 Thread Andrzej Ostruszka
This commit adds a preliminary Linux implementation of the IF Proxy library. It should allow one to play around with the idea and check its usefulness. Signed-off-by: Andrzej Ostruszka --- config/common_base| 5 + lib/Makefile | 2

[dpdk-dev] [RFC PATCH 1/3] lib: introduce IF proxy library (API)

2020-01-14 Thread Andrzej Ostruszka
This library allows to designate ports visible to the system (such as Tun/Tap or KNI) as port representors serving as proxies for other DPDK ports. When such a proxy is configured this library initially queries network configuration from the system and later monitors its changes. The information

[dpdk-dev] [RFC PATCH 0/3] introduce IF proxy library

2020-01-14 Thread Andrzej Ostruszka
What is this useful for === Usually, when an ethernet port is assigned to DPDK it vanishes from the system and user looses ability to control it via normal configuration utilities (e.g. those from iproute2 package). Moreover by default DPDK application is not aware of the netw

Re: [dpdk-dev] [PATCH v3] net/octeontx2: fix PTP and HIGIG2 coexistence

2020-01-14 Thread Jerin Jacob
On Tue, Jan 14, 2020 at 2:57 PM wrote: > > From: Kiran Kumar K > > octeontx2 PMD does not support both PTP and HIGIG2 together. > added a check to enforce this and updated the Rx offload capabilities when > Higig2 mode enabled > > fixes: 602009ee2dfb (net/octeontx2: support HIGIG2) > > Signed-off

Re: [dpdk-dev] [PATCH v5 0/2] add travis ci support for native aarch64

2020-01-14 Thread David Marchand
On Mon, Jan 13, 2020 at 7:26 AM Ruifeng Wang wrote: > > This patch set is to enable native aarch64 build in Travis CI. > It leverages Travis CI multi arch support. > > As the first step, compilation jobs are added. > Unit test is not added for now due to service limitation. We are > planning to ru

Re: [dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

2020-01-14 Thread Jerin Jacob
On Tue, Jan 14, 2020 at 3:45 PM Jack Min wrote: > > On Tue, 20-01-14, 10:01, Jerin Jacob wrote: > > On Tue, Jan 14, 2020 at 9:15 AM Xiaoyu Min wrote: > > > > > > From: Xueming Li > > > > > > New flow dump CLI to dump MLX5 PMD specific flows into screen. > > > > > > Signed-off-by: Xueming Li > >

[dpdk-dev] [PATCH v5 13/14] doc: release note for ESP

2020-01-14 Thread Bernard Iremonger
Release note for ESP support on the i40e PMD. Release note for ESP support on testpmd. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_2

Re: [dpdk-dev] [PATCH] maintainers: set git tree for test applications

2020-01-14 Thread Andrew Rybchenko
On 1/14/20 1:25 PM, Ferruh Yigit wrote: > On 1/14/2020 10:12 AM, Thomas Monjalon wrote: >> 14/01/2020 10:20, Jerin Jacob: >>> On Tue, Jan 14, 2020 at 2:48 PM David Marchand >>> wrote: Changes on the main test applications should be considered against subtrees where most of the API c

[dpdk-dev] [PATCH v5 14/14] doc: update i40e user guide

2020-01-14 Thread Bernard Iremonger
Update the i40e user guide with ESP information. Signed-off-by: Bernard Iremonger --- doc/guides/nics/i40e.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 38acf59..5cf34d9 100644 --- a/doc/guides/nics/i40e.rst +

[dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet

2020-01-14 Thread Bernard Iremonger
include rte_config.h in i40e_fdir.c In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and in i40e_fdir_construct_pkt() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/i4

  1   2   >