On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > include rte_config.h in i40e_fdir.c > In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() > and in i40e_fdir_construct_pkt() > > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com> > --- > drivers/net/i40e/i40e_fdir.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c > index 5f85703..67bb28c 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -21,6 +21,10 @@ > #include <rte_tcp.h> > #include <rte_sctp.h> > #include <rte_hash_crc.h> > +#include <rte_config.h> > +#ifdef RTE_LIBRTE_I40E_DEBUG_FD > +#include <rte_hexdump.h> > +#endif > > #include "i40e_logs.h" > #include "base/i40e_type.h" > @@ -954,7 +958,9 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > &fdir_input->flow_ext.flexbytes[dst], > size * sizeof(uint16_t)); > } > - > +#ifdef RTE_LIBRTE_I40E_DEBUG_FD > + rte_hexdump(stdout, NULL, raw_pkt, len); > +#endif > return 0; > } > > @@ -1415,7 +1421,9 @@ i40e_flow_fdir_construct_pkt(struct i40e_pf *pf, > &fdir_input->flow_ext.flexbytes[dst], > size * sizeof(uint16_t)); > } > - > +#ifdef RTE_LIBRTE_I40E_DEBUG_FD > + rte_hexdump(stdout, NULL, raw_pkt, len); > +#endif > return 0; > } > >
Hi Bernard, These are not data path functions, right? If so instead of adding new config option, can we add dynamic debugging for it?
