On Tue, Jan 14, 2020 at 04:59:24PM +0100, David Marchand wrote: > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > Add proper support for calling sphinx whenever a file in the doc > > directory changes. This is accomplished by using a wrapper script > > for sphinx, which runs sphinx but also emits a gcc-format dependency > > file listing all the doc files. This is used by ninja so that any > > change to the doc files triggers a rebuild of the docs. > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > Acked-by: Aaron Conole <acon...@redhat.com> > > Acked-by: Luca Boccassi <bl...@debian.org> > > --- > > MAINTAINERS | 1 + > > buildtools/call-sphinx-build.py | 31 +++++++++++++++++++++++++++++++ > > buildtools/meson.build | 6 ++++-- > > doc/guides/meson.build | 22 ++++++++-------------- > > 4 files changed, 44 insertions(+), 16 deletions(-) > > create mode 100755 buildtools/call-sphinx-build.py > > Caught an issue on fc30: > > [2094/2338] Generating html_guides with a custom command. > FAILED: doc/guides/html > /usr/bin/python3 ../../dpdk/buildtools/call-sphinx-build.py > /usr/libexec/python2-sphinx/sphinx-build > /home/dmarchan/dpdk/doc/guides > /home/dmarchan/builds/build-x86-default/doc/guides > sphinx-build 1.8.4 > Traceback (most recent call last): > File "../../dpdk/buildtools/call-sphinx-build.py", line 15, in <module> > ver = run([sphinx, '--version'], stdout=PIPE).stdout.decode().split()[-1] > IndexError: list index out of range > > Double checked, the version went to stderr: > > $ sphinx-build --version >/dev/null > sphinx-build 1.8.4 > $ sphinx-build --version 2>/dev/null > That is strange. Didn't hit any issues on fedora 31 which I am using here. I'll see if I can make it work with both stderr and stdout reporting.
/Bruce
