Re: [dpdk-dev] [PATCH v11 0/3] doc: changes to abi policy introducing major abi versions

2019-11-11 Thread Thomas Monjalon
11/11/2019 12:57, Ray Kinsella: > TL;DR abbreviation: > A major ABI version that all DPDK releases during an agreed period support. > ABI > versioning is managed at a project-level, in place of library-level > management. > ABI changes to add new features are permitted, as long as ABI compatibili

Re: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang ShougangX > Sent: Tuesday, November 12, 2019 8:51 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Wang, ShougangX > Subject: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile > > The removal of FDIR profile sh

Re: [dpdk-dev] [PATCH v3 1/4] net/ice: fix memzone reserve and release in FDIR

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang ShougangX > Sent: Tuesday, November 12, 2019 8:51 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Wang, ShougangX > Subject: [dpdk-dev] [PATCH v3 1/4] net/ice: fix memzone reserve and release > in FDIR > > To avoid memzone

Re: [dpdk-dev] [PATCH v3 3/4] net/ice: fix FDIR counter resource release

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang ShougangX > Sent: Tuesday, November 12, 2019 8:27 AM > To: dev@dpdk.org > Cc: Wang, ShougangX > Subject: [dpdk-dev] [PATCH v3 3/4] net/ice: fix FDIR counter resource release > > All the counter resources should be cleaned up when tear

Re: [dpdk-dev] [PATCH v3 4/4] net/ice: fix wild pointer

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang ShougangX > Sent: Tuesday, November 12, 2019 8:27 AM > To: dev@dpdk.org > Cc: Wang, ShougangX > Subject: [dpdk-dev] [PATCH v3 4/4] net/ice: fix wild pointer > > To avoid wild pointer, pointers should be set to NULL after free them. >

Re: [dpdk-dev] [PATCH v1] examples/vm_power: fix no PCI option for guest cli

2019-11-11 Thread Thomas Monjalon
30/10/2019 02:09, Yao, Lei A: > From: Hunt, David > > > > If there are no ports available to the guest cli application, it will exit > > when > > setting up the default policy because it fails to set the mac address. This > > should not be the case, as this example can be used for many other use

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] examples/power: fix oob frequency oscillations

2019-11-11 Thread Thomas Monjalon
24/07/2019 15:18, David Hunt: > The branch ratio algorithm in the vm_power_manager sample application > can be very sensitive at patricular loads in a workload, causing > oscillations between min and max frequency. For example, if a > workload is at 50%, scaling up may change the ratio > enough tha

Re: [dpdk-dev] [PATCH] eal: added new api to only enqueue a packet in tx buffer

2019-11-11 Thread Andrew Rybchenko
On 11/11/19 8:30 PM, Thomas Monjalon wrote: > 11/11/2019 17:56, Ferruh Yigit: >> On 10/18/2019 5:24 PM, Yigit, Ferruh wrote: >>> On 8/8/2019 1:28 PM, Nilanjan Sarkar wrote: This api is similar like api `rte_eth_tx_buffer` except it does not attempt to flush the buffer in case buffer is fu

[dpdk-dev] [PATCH v3 4/4] net/ice: fix wild pointer

2019-11-11 Thread Wang ShougangX
To avoid wild pointer, pointers should be set to NULL after free them. Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Signed-off

[dpdk-dev] [PATCH v3 3/4] net/ice: fix FDIR counter resource release

2019-11-11 Thread Wang ShougangX
All the counter resources should be cleaned up when teardown. Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filt

[dpdk-dev] [PATCH v3 0/4] net/ice: fix memory release in FDIR

2019-11-11 Thread Wang ShougangX
These patches include FDIR memory resource fixes related to ICE driver. Patch 1: fix memzone reserve and release in FDIR Patch 2: fix removal of FDIR profile Patch 3: fix FDIR counter resource release Patch 4: fix wild pointer --- v3 changes: Changed error log. v2 changes: Merged patches relat

[dpdk-dev] [PATCH v3 1/4] net/ice: fix memzone reserve and release in FDIR

2019-11-11 Thread Wang ShougangX
To avoid memzone reserve failure and memory leak, following resources management should be added. - Check if the FDIR Memzone already exists before reserving. - Free FDIR memzone when teardown and other failure scenarios. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Signed-off-by:

[dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile

2019-11-11 Thread Wang ShougangX
The removal of FDIR profile should start from ICE_FLTR_PTYPE_NONF_IPV4_UDP. Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ic

Re: [dpdk-dev] [PATCH v3] bus/pci: resolve multiple NICs address conflicts

2019-11-11 Thread Gavin Hu (Arm Technology China)
Hi Eric, > -Original Message- > From: dev On Behalf Of Wangyu (Eric) > Sent: Tuesday, November 12, 2019 10:23 AM > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; Linuxarm ; humin (Q) > ; dengxiaofeng ; > Liyuan (Larry) > Subject: [dpdk-dev] [PATCH v3] bus/pci: resolve multiple NICs addres

[dpdk-dev] [PATCH v3] net/ixgbe: fix device hotplug remove

2019-11-11 Thread Di ChenxuX
testpmd will occur infinite loops when device hotplug remove. We can fix the issue by using the pci generic remove function Fixes: f2f4990eff94 ("net/ixgbe: release port upon close") Signed-off-by: Di ChenxuX v4: used generic remove function for ixgbe_vf_representor_uninit. v3: reverted the cod

[dpdk-dev] [PATCH v3 3/4] net/ice: fix FDIR counter resource release

2019-11-11 Thread Wang ShougangX
All the counter resources should be cleaned up when teardown. Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filt

[dpdk-dev] [PATCH v3 0/4] net/ice: fix memory release in FDIR

2019-11-11 Thread Wang ShougangX
These patches include FDIR memory resource fixes related to ICE driver. Patch 1: fix memzone reserve and release in FDIR Patch 2: fix removal of FDIR profile Patch 3: fix FDIR counter resource release Patch 4: fix wild pointer --- v3 changes: Changed error log. v2 changes: Merged patches relat

[dpdk-dev] [PATCH v3 4/4] net/ice: fix wild pointer

2019-11-11 Thread Wang ShougangX
To avoid wild pointer, pointers should be set to NULL after free them. Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Signed-off

[dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile

2019-11-11 Thread Wang ShougangX
The removal of FDIR profile should start from ICE_FLTR_PTYPE_NONF_IPV4_UDP. Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ic

[dpdk-dev] [PATCH v3 1/4] net/ice: fix memzone reserve and release in FDIR

2019-11-11 Thread Wang ShougangX
To avoid memzone reserve failure and memory leak, following resources management should be added. - Check if the FDIR Memzone already exists before reserving. - Free FDIR memzone when teardown and other failure scenarios. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Signed-off-by:

[dpdk-dev] [PATCH v4] net/i40e: fix device hotplug remove

2019-11-11 Thread Di ChenxuX
testpmd will occur infinite loops when device hotplug remove. We can fix the issue by using the pci generic remove function Fixes: ac89d46096d5 ("net/i40e: release port upon close") Signed-off-by: Di ChenxuX v4: used generic remove function for i40e_vf_representor_uninit. v3: reverted the code

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-11 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 12, 2019 2:03 PM > To: Phil Yang (Arm Technology China) > Cc: Bruce Richardson ; dev@dpdk.org; > david.march...@redhat.com; jer...@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; Joyce Kong (A

Re: [dpdk-dev] 答复: 答复: [PATCH v2] bus/pci: resolve multiple NICs address conflicts

2019-11-11 Thread Gavin Hu (Arm Technology China)
Hi Eric, > -Original Message- > From: dev On Behalf Of Wangyu (Eric) > Sent: Monday, November 11, 2019 5:38 PM > To: Burakov, Anatoly ; David Marchand > > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Linuxarm > ; humin (Q) ; Liyuan > (Larry) ; dengxiaofeng > Subject: [dpdk-dev] 答复: 答复: [PA

[dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile

2019-11-11 Thread Wang ShougangX
The removal of FDIR profile should start from ICE_FLTR_PTYPE_NONF_IPV4_UDP. Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ic

[dpdk-dev] [PATCH v3 3/4] net/ice: fix FDIR counter resource release

2019-11-11 Thread Wang ShougangX
All the counter resources should be cleaned up when teardown. Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filt

[dpdk-dev] [PATCH v3 1/4] net/ice: fix memzone reserve and release in FDIR

2019-11-11 Thread Wang ShougangX
To avoid memzone reserve failure and memory leak, following resources management should be added. - Check if the FDIR Memzone already exists before reserving. - Free FDIR memzone when teardown and other failure scenarios. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Signed-off-by:

[dpdk-dev] [PATCH v3 4/4] net/ice: fix wild pointer

2019-11-11 Thread Wang ShougangX
To avoid wild pointer, pointers should be set to NULL after free them. Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Signed-off

[dpdk-dev] [PATCH v3 0/4] net/ice: fix memory release in FDIR

2019-11-11 Thread Wang ShougangX
These patches include FDIR memory resource fixes related to ICE driver. Patch 1: fix memzone reserve and release in FDIR Patch 2: fix removal of FDIR profile Patch 3: fix FDIR counter resource release Patch 4: fix wild pointer --- v3 changes: Changed error log. v2 changes: Merged patches relat

[dpdk-dev] [PATCH v3 0/4] net/ice: fix memory release in FDIR

2019-11-11 Thread Wang ShougangX
These patches include FDIR memory resource fixes related to ICE driver. Patch 1: fix memzone reserve and release in FDIR Patch 2: fix removal of FDIR profile Patch 3: fix FDIR counter resource release Patch 4: fix wild pointer --- v3 changes: Changed error log. v2 changes: Merged patches relat

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-11 Thread Thomas Monjalon
12/11/2019 06:25, Phil Yang (Arm Technology China): > From: Bruce Richardson > > On Mon, Nov 11, 2019 at 06:34:20PM +0800, Phil Yang wrote: > > > The older version (e.g. version 7.4.0 ) of GNU C compiler for the armhf > > > architecture doesn't support the flag '-Wno-address-of-packed-member', > >

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-11 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Bruce Richardson > Sent: Monday, November 11, 2019 6:47 PM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > jer...@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; Joyce Kong

Re: [dpdk-dev] [PATCH v3] net/ice: fix segmentation fault with a wrong package

2019-11-11 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Monday, November 11, 2019 5:06 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org > Subject: Re: [PATCH v3] net/ice: fix segmentation fault with a wrong package > > Hi, simei > > On 11/07, Simei Su wrote:

Re: [dpdk-dev] [PATCH v3 3/3] config: add cortex-a76 configuration

2019-11-11 Thread Jerin Jacob
On Mon, Nov 11, 2019 at 11:12 AM Gavin Hu wrote: > > To make the list complete and consistent, add cortex-a76 configuration. > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob > --- > config/arm/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [dpdk-dev] [PATCH v3 2/3] config: add arm neoverse N1 SDP configuration

2019-11-11 Thread Jerin Jacob
On Mon, Nov 11, 2019 at 11:12 AM Gavin Hu wrote: > > Arm N1 SDP is an infrastructure segment development platform > based on armv8.2-a Neoverse N1 CPU. For more information, refer to: > https://community.arm.com/developer/tools-software/oss-platforms/w/ > docs/440/neoverse-n1-sdp > > Signed-off-by

[dpdk-dev] [PATCH] net/ice/base: correct swtch programming IPV6 header bitmask

2019-11-11 Thread Wei Zhao
Correct an error in the IPV6 header bitmask used for programming switch rules. Also, change other programming switch headers to use big endian fields in order to make setting these easier. Fixes: 04b8ec1ea807 ("net/ice/base: add protocol structures and defines") Signed-off-by: Dan Nowlin Signed-

[dpdk-dev] [PATCH] net/ice/base: correct swtch programming IPV6 header bitmask

2019-11-11 Thread Wei Zhao
Correct an error in the IPV6 header bitmask used for programming switch rules. Also, change other programming switch headers to use big endian fields in order to make setting these easier. Fixes: 04b8ec1ea807 ("net/ice/base: add protocol structures and defines") Signed-off-by: wei zhao Signed-of

Re: [dpdk-dev] [PATCH v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Tuesday, November 12, 2019 10:42 AM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Ye, Xiaolong > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path > > Fix iavf vf_checksum_sw case fail in X71

Re: [dpdk-dev] [PATCH] eventdev: reserve space in main structs for extension

2019-11-11 Thread Thomas Monjalon
08/11/2019 17:56, jer...@marvell.com: > From: Jerin Jacob > > The struct rte_eventdev and rte_eventdev_data are supposed > to be used internally only, but there is a chance that > increasing their size would break ABI for some applications. > In order to allow smooth addition of features without

[dpdk-dev] [PATCH v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path

2019-11-11 Thread Leyi Rong
Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1 of CMD field in Tx descriptor of AVX Tx path according to Spec. Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf") Signed-off-by: Leyi Rong --- v2: - Use IAVF_TX_DESC_CMD_ICRC instead of 0x04. --- drivers/net/iavf/iavf_rxtx_ve

Re: [dpdk-dev] Mbuf memory alignment constraints for (micro)architectures

2019-11-11 Thread Gavin Hu (Arm Technology China)
Hi Jerin, > -Original Message- > From: dev On Behalf Of Gavin Hu (Arm Technology > China) > Sent: Monday, November 11, 2019 10:01 PM > To: jer...@marvell.com; dev@dpdk.org > Cc: Olivier Matz ; Andrew Rybchenko > ; David Christensen ; > bruce.richard...@intel.com; konstantin.anan...@intel.

[dpdk-dev] [PATCH v3] bus/pci: resolve multiple NICs address conflicts

2019-11-11 Thread Wangyu (Eric)
NIC address conflicts on 64K pagesize when using multiple NICs, as system will mmap 64K pagesize for NIC, but dev->mem_resource[i].len is 16K. Signed-off-by: beard-627 Signed-off-by: Wangyu (Eric) Acked-by: Wei Hu Acked-by: Min Hu --- drivers/bus/pci/linux/pci_uio.c | 2 ++ drivers/bus/pci

Re: [dpdk-dev] [PATCH] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Thursday, November 7, 2019 1:22 PM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Ye, Xiaolong > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path > > Fix iavf vf_checksum_sw case fail in X710/XX

Re: [dpdk-dev] [PATCH v3] net/ice: fix link status recovery

2019-11-11 Thread Ye Xiaolong
On 11/11, Qiming Yang wrote: >This patch fixes a kernel driver link status issue by recovering >link status when device stops. > >Fixes: e6161345d8a9 ("net/ice: support link status change") >Cc: sta...@dpdk.org > >Signed-off-by: Qiming Yang >--- > drivers/net/ice/ice_ethdev.c | 28

Re: [dpdk-dev] [PATCH v2] net/ice: fix RSS rule destroy

2019-11-11 Thread Ye Xiaolong
On 11/11, Simei Su wrote: >This patch changes RSS rule destroy interface from ice_rem_vsi_rss_cfg() >to ice_rem_rss_cfg(). To coordinate with input set change, it should >destroy a specific flow rule but not all vsi cfg. > >Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") > >Signed-off-by: Sime

Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow expand

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 5:41 PM, Ori Kam wrote: > > >> -Original Message- >> From: dev On Behalf Of Matan Azrad >> Sent: Monday, November 11, 2019 12:42 PM >> To: dev@dpdk.org >> Cc: Ori Kam ; Jack Min >> Subject: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow >> expand >> >> Ther

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

2019-11-11 Thread Zhang, Xiao
Hi Eelco, Seems you missed this mail. Thanks, Xiao > -Original Message- > From: Zhang, Xiao > Sent: Wednesday, November 6, 2019 12:58 PM > To: Eelco Chaudron ; Xing, Beilei > > Cc: Zhang, Qi Z ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF >

Re: [dpdk-dev] [PATCH v7 0/3] support API to set max LRO packet size

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 5:47 PM, Dekel Peled wrote: > This series implements support and use of API for configuration and > validation of max size for LRO aggregated packet. > > v2: Updated ethdev patch per review comments. > v3: Updated ethdev and testpmd patches per review comments. > v4: Updated ethdev p

Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: use API to set max LRO packet size

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 5:47 PM, Dekel Peled wrote: > This patch implements use of the API for LRO aggregated packet > max size. > It adds command-line and runtime commands to configure this value, > and adds option to show the supported value. > Documentation is updated accordingly. > > Signed-off-by: Deke

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: support API to set max LRO packet size

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 5:47 PM, Dekel Peled wrote: > This patch implements [1], to support API for configuration and > validation of max size for LRO aggregated packet. > API change notice [2] is removed, and release notes for 19.11 > are updated accordingly. > > [1] http://patches.dpdk.org/patch/58217/ >

Re: [dpdk-dev] [PATCH v2] net/ice: fix RSS rule destroy

2019-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, November 11, 2019 3:55 PM > To: Zhang, Qi Z ; Xing, Beilei ; > Ye, Xiaolong > Cc: dev@dpdk.org; Su, Simei > Subject: [PATCH v2] net/ice: fix RSS rule destroy > > This patch changes RSS rule destroy interface from ice_rem_vsi_rss_

Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow expand

2019-11-11 Thread Ori Kam
Checked and acked. Best, Ori > -Original Message- > From: Ferruh Yigit > Sent: Monday, November 11, 2019 7:14 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Ori Kam ; Jack Min > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow > expand > > On 11/11/2019 10:42 AM, M

[dpdk-dev] [PATCH] remove blank lines at end of file

2019-11-11 Thread Stephen Hemminger
Remove trailing blank lines. They serve no purpose and are just editor leftovers. These can cause git to complain about whitespace errors during merges. Signed-off-by: Stephen Hemminger --- Makefile| 1 - app/test/meson.build

[dpdk-dev] [RFC] use Gcc/Clang fallthrough attribute

2019-11-11 Thread Stephen Hemminger
Use an explicit statement fallthrough attibute, rather than relying on having correct fallthrough comments (that match the magic set of regex which depends on the value of compiler flags). This is more robust and safer. Introduces __rte_fallthrough and fixes existing code to use it. Motivated aft

[dpdk-dev] [PATCH v7 3/3] app/testpmd: use API to set max LRO packet size

2019-11-11 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. It adds command-line and runtime commands to configure this value, and adds option to show the supported value. Documentation is updated accordingly. Signed-off-by: Dekel Peled Acked-by: Bernard Iremonger Acked-by: Matan Az

[dpdk-dev] [PATCH v7 2/3] net/mlx5: use API to set max LRO packet size

2019-11-11 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. Rx queue create is updated to use the relevant configuration. Documentation is updated accordingly. Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 2 ++

[dpdk-dev] [PATCH v7 0/3] support API to set max LRO packet size

2019-11-11 Thread Dekel Peled
This series implements support and use of API for configuration and validation of max size for LRO aggregated packet. v2: Updated ethdev patch per review comments. v3: Updated ethdev and testpmd patches per review comments. v4: Updated ethdev patch for QEDE PMD per review comments. v5: Updated eth

[dpdk-dev] [PATCH v7 1/3] ethdev: support API to set max LRO packet size

2019-11-11 Thread Dekel Peled
This patch implements [1], to support API for configuration and validation of max size for LRO aggregated packet. API change notice [2] is removed, and release notes for 19.11 are updated accordingly. [1] http://patches.dpdk.org/patch/58217/ [2] http://patches.dpdk.org/patch/57492/ Signed-off-by:

Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow expand

2019-11-11 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Monday, November 11, 2019 12:42 PM > To: dev@dpdk.org > Cc: Ori Kam ; Jack Min > Subject: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow > expand > > There is a rte_flow API which expands a RSS flow patt

Re: [dpdk-dev] [PATCH] eal: added new api to only enqueue a packet in tx buffer

2019-11-11 Thread Thomas Monjalon
11/11/2019 17:56, Ferruh Yigit: > On 10/18/2019 5:24 PM, Yigit, Ferruh wrote: > > On 8/8/2019 1:28 PM, Nilanjan Sarkar wrote: > >> This api is similar like api `rte_eth_tx_buffer` except it > >> does not attempt to flush the buffer in case buffer is full. > >> The advantage is that, this api does n

Re: [dpdk-dev] [PATCH] ethdev: fix last item detection on RSS flow expand

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 10:42 AM, Matan Azrad wrote: > There is a rte_flow API which expands a RSS flow pattern to multipile > patterns according to the RSS hash types in the RSS action > configuration. > > Aa part of the expansion, detection of the last item of the flow uses > the "next proto" field of the

[dpdk-dev] [dpdk-announce] DPDK Summit NA Starts Tomorrow!

2019-11-11 Thread Jill Lovato
*LAST CALL! * *DPDK Summit North America 2019* is this week, November 12-13. This is your last chance to join the community in Mountain View, CA at the Computer History Museum to connect and learn about the latest use cases, applications, and trends in Data Plane development and acceleration. Che

Re: [dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-11-11 Thread Ferruh Yigit
On 10/31/2019 5:53 PM, Ferruh Yigit wrote: > On 10/8/2019 3:23 PM, Yigit, Ferruh wrote: >> On 7/30/2019 4:59 PM, Thomas Monjalon wrote: >>> Since the concept of representors was introduced, >>> we do not need any specific API for VF ports. >>> Any VF port should be able to be configured through >>>

Re: [dpdk-dev] [PATCH] eal: added new api to only enqueue a packet in tx buffer

2019-11-11 Thread Ferruh Yigit
On 10/18/2019 5:24 PM, Yigit, Ferruh wrote: > On 8/8/2019 1:28 PM, Nilanjan Sarkar wrote: >> This api is similar like api `rte_eth_tx_buffer` except it >> does not attempt to flush the buffer in case buffer is full. >> The advantage is that, this api does not need port id and >> queue id. In case p

Re: [dpdk-dev] [PATCH]net/bonding: add DEFAULTED state in rx_machine in 802.3ad bonding implementation

2019-11-11 Thread Ferruh Yigit
On 10/30/2019 2:12 AM, lidejun wrote: > Hi All: > This patch fixes a issue when DPDK 802.3ad bonding rx_machine enters EXPIRED > state, but the opposite SWITCH lacp ignores distributing and collecting bit, > so the SWITCH still sends packets to DPDK and all these packets are dropped. Hi lidejun,

Re: [dpdk-dev] [PATCH v2] net/dpaa2: fix Rx offload flags on jumbo MTU set

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 4:08 PM, Sachin Saxena wrote: > The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct. > When frame_size is greater than RTE_ETHER_MAX_LEN, the > intention is to add JUMBO flag in rx offload while it was resetting > all other flags other than JUMBO as AND operator was used

Re: [dpdk-dev] [PATCH v2] ethdev: reserve space in main structs for extension

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 10:54 AM, Ferruh Yigit wrote: > On 11/11/2019 7:26 AM, Thomas Monjalon wrote: >> In order to allow smooth addition of features without breaking >> ABI compatibility, some space is reserved in several core structs >> of ethdev API. >> >> The struct rte_eth_dev and rte_eth_dev_data are

[dpdk-dev] [PATCH v2] net/dpaa2: fix Rx offload flags on jumbo MTU set

2019-11-11 Thread Sachin Saxena
The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct. When frame_size is greater than RTE_ETHER_MAX_LEN, the intention is to add JUMBO flag in rx offload while it was resetting all other flags other than JUMBO as AND operator was used instead of OR. Fixes: 0ebce6129bc6 ("net/dpaa2: su

Re: [dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 11, 2019 9:27 PM > To: Sachin Saxena > Cc: dev@dpdk.org; ferruh.yi...@intel.com; sta...@dpdk.org > Subject: Re: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx > offloads flags > > 11/11/2019 16:36, Sa

Re: [dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Thomas Monjalon
11/11/2019 16:36, Sachin Saxena: > The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct. > When frame_size is greater than RTE_ETHER_MAX_LEN, the > intention is to add JUMBO flag in rx offload while it was resetting > all other flags other than JUMBO as AND operator was used instead of

Re: [dpdk-dev] [PATCH v6] net/memif: zero-copy slave

2019-11-11 Thread David Marchand
On Mon, Nov 11, 2019 at 4:21 PM Ferruh Yigit wrote: > > On 11/4/2019 11:03 AM, Jakub Grajciar wrote: > > Zero-copy slave support for memif PMD. > > Slave interface exposes DPDK memory to > > master interface. Only single file segments > > are supported (EAL option --single-file-segments). > > > >

Re: [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used > to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also > `ol_flags:PKT_RX_RSS`. > > Add new packet type set function `rte_e

[dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Sachin Saxena
The JUMBO frame handling in dpaa2_dev_mtu_set api was not correct. When frame_size is greater than RTE_ETHER_MAX_LEN, the intention is to add JUMBO flag in rx offload while it was resetting all other flags other than JUMBO as AND operator was used instead of OR. Fixes: 0ebce6129bc6 ("net/dpaa2: su

Re: [dpdk-dev] [PATCH v6] net/memif: zero-copy slave

2019-11-11 Thread Thomas Monjalon
11/11/2019 16:21, Ferruh Yigit: > On 11/4/2019 11:03 AM, Jakub Grajciar wrote: > > Zero-copy slave support for memif PMD. > > Slave interface exposes DPDK memory to > > master interface. Only single file segments > > are supported (EAL option --single-file-segments). > > > > Signed-off-by: Jakub G

Re: [dpdk-dev] [PATCH v6] net/memif: zero-copy slave

2019-11-11 Thread Ferruh Yigit
On 11/4/2019 11:03 AM, Jakub Grajciar wrote: > Zero-copy slave support for memif PMD. > Slave interface exposes DPDK memory to > master interface. Only single file segments > are supported (EAL option --single-file-segments). > > Signed-off-by: Jakub Grajciar > --- > doc/guides/nics/memif.rst

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-11 Thread Pavan Nikhilesh Bhagavatula
>On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: >> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c >> index 931e4f4fe..6bc85a3d5 100644 >> --- a/drivers/net/mlx4/mlx4.c >> +++ b/drivers/net/mlx4/mlx4.c >> @@ -248,6 +248,8 @@ mlx4_dev_configure(struct rte_eth_dev *dev) >>

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 931e4f4fe..6bc85a3d5 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -248,6 +248,8 @@ mlx4_dev_configure(struct rte_eth_dev *dev) > struc

Re: [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask

2019-11-11 Thread Pavan Nikhilesh Bhagavatula
>On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add command to set supported ptype mask. >> Usage: >> set port ptype_mask >> >> Signed-off-by: Pavan Nikhilesh > ><...> > >> +set port supported ptypes >> +~ >> + >> +set packet t

Re: [dpdk-dev] [PATCH v17 09/10] app/testpmd: disable packet type parsing by default

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Disable packey type parsing on port init, user can enable ptype parsing > by issuing set ptype command. I will update release notes to add one line sentences to document the behavior change while merging, please s

Re: [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add command to set supported ptype mask. > Usage: > set port ptype_mask > > Signed-off-by: Pavan Nikhilesh <...> > +set port supported ptypes > +~ > + > +set packet types classif

[dpdk-dev] [PATCH] net/mlx5: fix the get function of Rx queue type

2019-11-11 Thread Dekel Peled
Function mlx5_rxq_get_type() uses the input queue index, without checking it, as index to the Rx queues array. If this value is too high, it will result in pointer to memory out of Rx queues array bounds. This patch adds check of the input queue index, to verify it is valid. Fixes: 09775c04aace (

[dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx

2019-11-11 Thread Dekel Peled
RSS action validation function checks the queues included in RSS to make sure they are valid. A Queue is considered valid if the pointer to the queue (item at location queue-index of RxQ array) is not a null value. The queue indices are not checked. If a large value is entered as queue index, using

Re: [dpdk-dev] [PATCH v2] net/mlx5: set VF MAC address from host

2019-11-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Monday, November 11, 2019 1:40 PM > To: Slava Ovsiienko > Cc: Thomas Monjalon ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: set VF MAC address from host > > Allow to configure the default MAC address

Re: [dpdk-dev] Mbuf memory alignment constraints for (micro)architectures

2019-11-11 Thread Gavin Hu (Arm Technology China)
Hi Jerin, > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Thursday, October 31, 2019 2:02 AM > To: dev@dpdk.org > Cc: Olivier Matz ; Andrew Rybchenko > ; David Christensen ; > bruce.richard...@intel.com; konstantin.anan...@intel.com; > hemant.agra...@nxp.com; Shahaf Shuler

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

2019-11-11 Thread Eelco Chaudron
On 1 Nov 2019, at 9:12, Eelco Chaudron wrote: + /* +* Even though the device reset is successful disabling promiscuous +* mode might not always succeed, causing enabling it after reset to I think we need to root cause why fail to disable promiscuous mode and try t

Re: [dpdk-dev] [PATCH] ci: remove LTO job

2019-11-11 Thread Bruce Richardson
On Mon, Nov 11, 2019 at 01:27:23PM +0100, David Marchand wrote: > On Mon, Nov 11, 2019 at 12:32 PM Bruce Richardson > wrote: > > > > On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote: > > > 08/11/2019 20:32, David Marchand: > > > > The LTO job using gcc-7 has two issues at the moment

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-11 Thread Matan Azrad
From: Ferruh Yigit > On 11/11/2019 11:33 AM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit > >> On 11/9/2019 6:20 PM, Matan Azrad wrote: > >>> Hi > >>> > >>> From: Ferruh Yigit > On 11/8/2019 11:56 AM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit > >> On 11/8/2019 10

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: add missing SPDX license header

2019-11-11 Thread Pavan Nikhilesh Bhagavatula
>Add same tag as other files in this example. > >Signed-off-by: Stephen Hemminger Acked-by: Pavan Nikhilesh >--- > examples/l2fwd-event/l2fwd_common.c | 4 > examples/l2fwd-event/l2fwd_poll.c | 4 > 2 files changed, 8 insertions(+) > >diff --git a/examples/l2fwd-event/l2fwd_common.c b

[dpdk-dev] [PATCH] net/octeontx2: fix exit paths after cq init

2019-11-11 Thread Anoob Joseph
After otx2_nix_register_cq_irqs() is called and the IRQs are setup, otx2_nix_unregister_cq_irqs() need to be called in the subsequent error exit paths. Fixes: d34db5ccbf30 ("net/octeontx2: fix driver reconfiguration") Signed-off-by: Anoob Joseph --- drivers/net/octeontx2/otx2_ethdev.c | 4 ++--

[dpdk-dev] [PATCH v17 10/10] app/testpmd: add RSS hash offload to port Rx offload cmd

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Update port rx_offload command to include RSS_HASH testpmd> port config 0 rx_offload rss_hash on Signed-off-by: Pavan Nikhilesh --- app/test-pmd/cmdline.c | 4 ++-- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 2 files changed, 3 insert

[dpdk-dev] [PATCH v17 06/10] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/pipeline_worker_generic.c | 3 +++ 1 file changed

[dpdk-dev] [PATCH v17 09/10] app/testpmd: disable packet type parsing by default

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Disable packey type parsing on port init, user can enable ptype parsing by issuing set ptype command. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/cmdline.c | 2 ++ app/test-pmd/testpmd.c | 12 app/test-pmd/testpmd.h | 1 + 3 files changed, 15 insertions

[dpdk-dev] [PATCH v17 07/10] examples/l2fwd: disable ptype parsing

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing as l2fwd doesn't rely on packet types. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd/Makefile| 2 ++ examples/l2fwd/main.c | 5 + examples/l2fwd/meson.build | 2 ++ 3 files changed, 9 insertions(+) diff --git a/examples/l2fwd/

[dpdk-dev] [PATCH v17 05/10] examples/eventdev_pipeline: split port init sequence

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Split port initialization sequence based on event device capabilities. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 128 - .../pipeline_worker_generic.c | 129 ++ .../eventdev_pipeline/p

[dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh Reviewed-by: Andrew Rybchenko Reviewed-by: Hemant Agrawal Acked-by: Jerin Jacob Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 +- d

[dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Add command to set supported ptype mask. Usage: set port ptype_mask Signed-off-by: Pavan Nikhilesh --- app/test-pmd/cmdline.c | 84 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 91 insertions(+)

[dpdk-dev] [PATCH v17 03/10] ethdev: add validation to offloads set by PMD

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Some PMDs cannot work when certain offloads are enable/disabled, as a workaround PMDs auto enable/disable offloads internally and expose it through dev->data->dev_conf.rxmode.offloads. After device specific dev_configure is called compare the requested offloads to the offlo

[dpdk-dev] [PATCH v17 02/10] ethdev: add mbuf RSS update as an offload

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v17 01/10] ethdev: add set ptype function

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_ptypes` function that will allow the application to inform the PMD about reduced range of packet types to handle. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_pt

[dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags

2019-11-11 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also `ol_flags:PKT_RX_RSS`. Add new packet type set function `rte_eth_dev_set_ptypes`, allows application to inform PMDs about the packe

Re: [dpdk-dev] [PATCH] net/mlx5: fix compiling without definition

2019-11-11 Thread Ferruh Yigit
On 11/11/2019 7:00 AM, Slava Ovsiienko wrote: >> -Original Message- >> From: Bing Zhao >> Sent: Sunday, November 10, 2019 18:37 >> To: Slava Ovsiienko ; Raslan Darawsheh >> >> Cc: Ori Kam ; dev@dpdk.org >> Subject: [PATCH] net/mlx5: fix compiling without definition >> >> When compiling th

  1   2   >