[dpdk-dev] [PATCH v2] net/mlx5: adjust inline setting for large Tx queue sizes

2019-09-30 Thread Viacheslav Ovsiienko
The hardware may have limitations on maximal amount of supported Tx descriptors building blocks (WQEBB). Application requires the Tx queue must accept the specified amount of packets. If inline data feature is engaged the packet may require more WQEBBs and overall amount of blocks may exceed the ha

[dpdk-dev] [PATCH v5 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 113 - .../p

[dpdk-dev] [PATCH v5 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/cxgbe/cxgbe.h| 3 ++- drivers/net/dpaa/dpaa_ethdev.c | 3 ++- drivers/net/dpaa2/

[dpdk-dev] [PATCH v5 7/7] examples: disable Rx packet type parsing

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing in examples that don't use `rte_mbuf::packet_type` by setting ptype_mask as 0 in `rte_eth_dev_set_supported_ptypes` Signed-off-by: Pavan Nikhilesh --- examples/bbdev_app/main.c | 1 + examples/bond/main.c

[dpdk-dev] [PATCH v7 8/8] test/crypto: add tests for Nitrox PMD

2019-09-30 Thread Nagadheeraj Rottela
Add aes chain test cases for Nitrox in-pace and out-of-place operations. Signed-off-by: Nagadheeraj Rottela --- app/test/test_cryptodev.c | 52 ++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_aes_test_vectors.h | 48 +

[dpdk-dev] [PATCH v5 3/7] ethdev: add flow action type update as an offload

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

[dpdk-dev] [PATCH v5 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++- drivers/net/i40e/i40e_ethdev.c | 3 ++- dri

[dpdk-dev] [PATCH v5 2/7] ethdev: add mbuf RSS update as an offload

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v5 0/7] ethdev: add new Rx offload flags

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

[dpdk-dev] [PATCH v7 7/8] crypto/nitrox: add cipher auth crypto chain processing

2019-09-30 Thread Nagadheeraj Rottela
Add cipher auth crypto chain processing functionality in symmetric request manager. Update the release notes. Signed-off-by: Nagadheeraj Rottela --- doc/guides/cryptodevs/features/nitrox.ini | 40 +++ doc/guides/cryptodevs/nitrox.rst | 21 ++ doc/guides/rel_notes/release_19_11.rst

[dpdk-dev] [PATCH v5 1/7] ethdev: add set ptype function

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] [PATCH v7 6/8] crypto/nitrox: add burst enqueue and dequeue operations

2019-09-30 Thread Nagadheeraj Rottela
Add burst enqueue and dequeue operations along with interface for symmetric request manager. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_qp.h | 56 ++ drivers/crypto/nitrox/nitrox_sym.c| 121 - drivers/crypto/nitrox/nitrox_sym_

[dpdk-dev] [PATCH v7 0/8] add Nitrox crypto device support

2019-09-30 Thread Nagadheeraj Rottela
Add the Nitrox PMD to support Nitrox crypto device. --- v7: * Removed rte_wmb() and rte_rmb() usage in all places. * Added rte_smp_wmb() before pending count update in enqueue operation and rte_smp_rmb() before reading softreq from pending queue. * Added rte_io_wmb() before the ring doorbell to

[dpdk-dev] [PATCH v7 2/8] crypto/nitrox: create Nitrox symmetric cryptodev

2019-09-30 Thread Nagadheeraj Rottela
Add Nitrox symmetric cryptodev with following operations, - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/Makefile| 1 + drivers/crypto/nitrox/meson.build | 1 + drivers/crypto/nitrox/nitrox_device.c

[dpdk-dev] [PATCH v7 4/8] crypto/nitrox: add hardware queue management functionality

2019-09-30 Thread Nagadheeraj Rottela
Add hardware queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_csr.h | 12 +++ drivers/crypto/nitrox/nitrox_hal.c | 151 + drivers/crypto/nitrox/nitrox_hal.h | 12

[dpdk-dev] [PATCH v7 5/8] crypto/nitrox: add session management operations

2019-09-30 Thread Nagadheeraj Rottela
Add all the session management operations. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/Makefile | 1 + drivers/crypto/nitrox/meson.build | 1 + drivers/crypto/nitrox/nitrox_sym.c | 334 +++- drivers/crypto/nitro

[dpdk-dev] [PATCH v7 3/8] crypto/nitrox: add software queue management functionality

2019-09-30 Thread Nagadheeraj Rottela
Add software queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/Makefile| 2 + drivers/crypto/nitrox/meson.build | 2 + drivers/crypto/nitrox/nitrox_qp.c | 74 +++

[dpdk-dev] [PATCH v7 1/8] crypto/nitrox: add Nitrox PMD library

2019-09-30 Thread Nagadheeraj Rottela
Add bare minimum Nitrox PMD library which handles pci probe, remove and hardware initialization. Add logs, documentation and update maintainers file. Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 7 ++ config/common_base

[dpdk-dev] [PATCH v4 7/7] examples: disable Rx packet type parsing

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Disable packet type parsing in examples that don't use `rte_mbuf::packet_type` by setting ptype_mask as 0 in `rte_eth_dev_set_supported_ptypes` Signed-off-by: Pavan Nikhilesh --- examples/bbdev_app/main.c | 1 + examples/bond/main.c

[dpdk-dev] [PATCH v4 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result into the mbuf. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 113 - .../p

[dpdk-dev] [PATCH v4 5/7] drivers/net: update Rx flow flag and mark capabilities

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action flag and mark. Signed-off-by: Pavan Nikhilesh --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/enic/enic_res.c | 3 ++- drivers/net/i40e/i40e_ethdev.c | 3 ++- dri

[dpdk-dev] [PATCH v4 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash delivery. Signed-off-by: Pavan Nikhilesh --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/cxgbe/cxgbe.h| 3 ++- drivers/net/dpaa/dpaa_ethdev.c | 3 ++- drivers/net/dpaa2/

[dpdk-dev] [PATCH v4 3/7] ethdev: add flow action type update as an offload

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and `RTE_FLOW_ACTION_FLAG` are enabled. PMDs notify the validity of `rte_mbuf::ha

[dpdk-dev] [PATCH v4 1/7] ethdev: add set ptype function

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t want any ptype information it can call `rte_eth_dev_set_s

[dpdk-dev] [PATCH v4 2/7] ethdev: add mbuf RSS update as an offload

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. Signed-off-by: Pavan Ni

[dpdk-dev] [PATCH v4 0/7] ethdev: add new Rx offload flags

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. Add new packet type set functi

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: support event crypto adapter

2019-09-30 Thread Akhil Goyal
> > > > > > meson cross-build is failing with this patch. Please fix it in v2 and > > > If it makes sense then add this new feature in release notes. > > > > V2 sent with the required changes. > > Looks like there are still errors, please check > > http://mails.dpdk.org/archives/test-report/2019

[dpdk-dev] [PATCH v3 3/3] doc/rcu: add RCU integration design details

2019-09-30 Thread Honnappa Nagarahalli
From: Ruifeng Wang Add a section to describe a design to integrate QSBR RCU library with other libraries in DPDK. Signed-off-by: Honnappa Nagarahalli --- doc/guides/prog_guide/rcu_lib.rst | 59 +++ 1 file changed, 59 insertions(+) diff --git a/doc/guides/prog_guide

[dpdk-dev] [PATCH v3 0/3] Add RCU reclamation APIs

2019-09-30 Thread Honnappa Nagarahalli
This is not a new patch. This patch set is separated from the LPM changes as the size of the changes in RCU library has grown due to comments from community. These APIs will help reduce the changes in LPM and hash libraries that are getting integrated with RCU library. This adds 4 new APIs to RCU

[dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-09-30 Thread Honnappa Nagarahalli
Add resource reclamation APIs to make it simple for applications and libraries to integrate rte_rcu library. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedhal Reviewed-by: Ruifeng Wang --- app/test/test_rcu_qsbr.c | 291 - lib/librte_rcu/meson

[dpdk-dev] [PATCH v3 1/3] lib/ring: add peek API

2019-09-30 Thread Honnappa Nagarahalli
From: Ruifeng Wang The peek API allows fetching the next available object in the ring without dequeuing it. This helps in scenarios where dequeuing of objects depend on their value. Signed-off-by: Dharmik Thakkar Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin

Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-30 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Nipun Gupta >Sent: Monday, September 30, 2019 11:21 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob >Cc: Jerin Jacob Kollanukkaran ; >bruce.richard...@intel.com; Akhil Goyal ; >Marko Kovacevic ; Ori Kam >; Radu Nicolau ; >Tomasz Kantecki ;

Re: [dpdk-dev] [PATCH v2 3/9] eal: add windows compatible header files

2019-09-30 Thread Jerin Jacob
On Mon, Sep 30, 2019 at 11:19 PM Pallavi Kadam wrote: > > Hi Jerin, > > On 9/27/2019 12:58 AM, Jerin Jacob wrote: > > On Fri, Sep 27, 2019 at 2:24 AM Pallavi Kadam wrote: > > Adding dlfcn.h on Windows to support common code. > > Adding eal_filesystem.h to support functions and > path defines for

[dpdk-dev] [PATCH v2] test/lpm: reset total time

2019-09-30 Thread Honnappa Nagarahalli
total_time needs to be reset to measure the cycles for delete API. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- v2 - Corrected checkpatch issue app/test/test_lpm_perf.c | 4 ++-- 1 file changed, 2 insertions

[dpdk-dev] [PATCH] test/lpm: reset total time

2019-09-30 Thread Honnappa Nagarahalli
total_time needs to be reset to measure the cycles for delete API. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Change-Id: I446e4724a9fe2f8ac2cb8f5cc167998d9fc33df8 Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 4 ++-- 1 file c

Re: [dpdk-dev] [PATCH v3 7/7] examples: disable Rx packet type parsing

2019-09-30 Thread Pavan Nikhilesh Bhagavatula
>*app_params, >> } >> >> rte_eth_promiscuous_enable(port_id); >> +rte_eth_dev_set_supported_ptypes(port_id, >RTE_PTYPE_UNKNOWN); > >This is strange, since the function signature is defined (in 1/7) as: > > int rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t >ptype_mask,

Re: [dpdk-dev] [PATCH] eal: move rte_cpu definitions to os specific files

2019-09-30 Thread Jerin Jacob
On Mon, Sep 30, 2019 at 11:04 PM Pallavi Kadam wrote: > > Moving RTE_CPU* definitions from the common code to the > Linux, FreeBSD rte_os.h file to avoid #ifdef clutter. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Antara Ganesh Kolar > Reviewed-by: Ranjit Menon Nit: [master][dpdk.org] $

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: support event crypto adapter

2019-09-30 Thread Jerin Jacob
On Tue, Oct 1, 2019 at 1:43 AM Akhil Goyal wrote: > > Hi Jerin, Hi Akhil, > > > > > On Fri, Sep 6, 2019 at 6:57 PM Akhil Goyal wrote: > > > > > > dpaa_sec hw queues can be attached to a hw dpaa event > > > device and the application can configure the event > > > crypto adapter to access the dpa

Re: [dpdk-dev] [PATCH v2 5/9] eal: add additional function overrides in windows header files

2019-09-30 Thread Pallavi Kadam
Hi Jerin, On 9/27/2019 1:06 AM, Jerin Jacob wrote: On Fri, Sep 27, 2019 at 2:25 AM Pallavi Kadam wrote: Adding additional function definitions for pthread, cpuset implementation, asprintf implementation, in order to support common code. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Gane

Re: [dpdk-dev] [PATCH v2 0/7] Add PDCP test cases

2019-09-30 Thread Akhil Goyal
> > This patch add test vectors and a test framework for PDCP > cplane and uplane protocol processing based on various > sequence number sizes(5/7/12/15/18). > > These test cases and test vectors are validated over NXP DPAA_SEC > and DPAA2_SEC platforms. > > This patchset is a split to the pat

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix null pointer dereferences

2019-09-30 Thread Akhil Goyal
> > One issue caught by Coverity 343408 > *deref_parm: Directly dereferencing parameter val->val. > > In writeback_tdes_hex_str(), tmp_val is initialised to null. > tmp_val.val is updated only if keys are found. > If keys are not found,it doesn't fails but continues > to invoke writeback_hex_s

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: support event crypto adapter

2019-09-30 Thread Akhil Goyal
Hi Jerin, > > On Fri, Sep 6, 2019 at 6:57 PM Akhil Goyal wrote: > > > > dpaa_sec hw queues can be attached to a hw dpaa event > > device and the application can configure the event > > crypto adapter to access the dpaa_sec packets using > > hardware events. > > This patch defines APIs which can

Re: [dpdk-dev] [PATCH v3 00/24] crypto/dpaaX_sec: Support Wireless algos

2019-09-30 Thread Akhil Goyal
> > PDCP protocol offload using rte_security are supported in > dpaa2_sec and dpaa_sec drivers. > > Wireless algos(SNOW/ZUC) without protocol offload are also > supported as per crypto APIs. > > changes in v3: > - fix meson build > - fix checkpatch warnings > - include dependent patches(last 4

[dpdk-dev] [PATCH v2 7/7] test/crypto: support wireless algos for dpaa2-sec

2019-09-30 Thread Akhil Goyal
SNOW and ZUC plain crypto operations for cipher only and auth only are now supported in dpaa2_sec. Signed-off-by: Akhil Goyal Acked-by: Nipun Gupta --- app/test/test_cryptodev.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/app/test/test_cryptodev.

[dpdk-dev] [PATCH v2 3/7] test/crypto: add PDCP uplane encap cases

2019-09-30 Thread Akhil Goyal
PDCP User/Data plane can support 5/7/12/15/18 bit sequence number. This patch add test cases and test vectors for all supported algos for cipher only. (NULL, AES, SNOW, ZUC ciphers) The test cases are added in DPAA_SEC and DPAA2_SEC test suite as a reference. Signed-off-by: Akhil Goyal Signed-of

[dpdk-dev] [PATCH v2 0/7] Add PDCP test cases

2019-09-30 Thread Akhil Goyal
This patch add test vectors and a test framework for PDCP cplane and uplane protocol processing based on various sequence number sizes(5/7/12/15/18). These test cases and test vectors are validated over NXP DPAA_SEC and DPAA2_SEC platforms. This patchset is a split to the patch [1] which was sent

[dpdk-dev] [PATCH v2 6/7] test/crypto: add PDCP cases for scatter gather bufs

2019-09-30 Thread Akhil Goyal
Test cases for PDCP with scattered input and output buffers are added for both inplace and out of place scenarios. 1. input SG - output non SG 2. input and output both SG and inplace buffers 3. input and output both SG with different segment sizes 4. input SG and output non-SG Signed-off-by: Akhil

[dpdk-dev] [PATCH v2 5/7] test/crypto: add PDCP uplane decap cases

2019-09-30 Thread Akhil Goyal
This patch add test cases for user plane PDCP 5/7/12/15/18 bit SN test cases for decapsulation of cipher only and 12/18 bit for cipher + integrity for all algo combinations. Test vectors are reused from the encap cases by swapping the input and output data. The case are added to DPAA_SEC and DPAA

[dpdk-dev] [PATCH v2 1/7] test/crypto: add PDCP cplane encap cases

2019-09-30 Thread Akhil Goyal
PDCP control plane can support 5 bit and 12 bit sequence number. This patch add test cases and test vectors for all supported algo combinations of cipher+integrity (NULL+NULL, NULL+AES, NULL+SNOW, NULL+ZUC, AES+NULL, AES+SNOW, AES+AES, AES+ZUC, SNOW+NULL, SNOW+AES, SNOW+SNOW, SNOW+ZUC, ZUC+NU

[dpdk-dev] [PATCH v2 2/7] test/crypto: add PDCP cplane decap cases

2019-09-30 Thread Akhil Goyal
This patch add test cases for control plane PDCP 5 and 12 bit SN test cases for decapsulation of cipher+integrity for all algo combinations Test vectors are reused from the encap cases by swapping the input and output data. The case are added to DPAA_SEC and DPAA2_SEC testsuite. Signed-off-by: A

[dpdk-dev] [PATCH v2 1/2] crypto/dpaa_sec: support event crypto adapter

2019-09-30 Thread Akhil Goyal
dpaa_sec hw queues can be attached to a hw dpaa event device and the application can configure the event crypto adapter to access the dpaa_sec packets using hardware events. This patch defines APIs which can be used by the dpaa event device to attach/detach dpaa_sec queues. Signed-off-by: Akhil Go

[dpdk-dev] [PATCH v2 2/2] event/dpaa: support event crypto adapter

2019-09-30 Thread Akhil Goyal
event dpaa device support both ethernet as well as crypto queues to be attached to it. eth_rx_adapter provide infrastructure to attach ethernet queues and crypto_adapter provide support for crypto queues. This patch add support for dpaa_eventdev to attach dpaa_sec queues. Signed-off-by: Akhil Goy

[dpdk-dev] [PATCH v2 0/2] dpaa_sec: support event crypto adapter

2019-09-30 Thread Akhil Goyal
changes in v2: fix meson build Akhil Goyal (2): crypto/dpaa_sec: support event crypto adapter event/dpaa: support event crypto adapter drivers/bus/dpaa/base/qbman/qman.c| 9 +- drivers/bus/dpaa/include/fsl_qman.h | 2 +- drivers/crypto/dpaa_sec/Makefile

[dpdk-dev] [PATCH v3 6/6] pdump: use new pktmbuf copy function

2019-09-30 Thread Stephen Hemminger
The rte_pktmbuf_copy handles varying size mbuf pools correctly. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 69 +--- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c i

[dpdk-dev] [PATCH v3 5/6] mbuf: add pktmbuf copy test

2019-09-30 Thread Stephen Hemminger
New test for rte_pktmbuf_copy based of the clone tests. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index aafad0cf6206..49c3a5f7893c 100644

[dpdk-dev] [PATCH v3 4/6] mbuf: add a pktmbuf copy routine

2019-09-30 Thread Stephen Hemminger
This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine

[dpdk-dev] [PATCH v3 1/6] mbuf: don't generate invalid mbuf in clone test

2019-09-30 Thread Stephen Hemminger
The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 3 +++ 1 file

[dpdk-dev] [PATCH v3 3/6] mbuf: deinline rte_pktmbuf_clone

2019-09-30 Thread Stephen Hemminger
Cloning mbufs requires allocations and iteration and therefore should not be an inline. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 39 lib/librte_mbuf/rte_mbuf.h | 38 ++- lib/librte_mbuf/rte_mbuf_ver

[dpdk-dev] [PATCH v3 0/6] mbuf copy/cloning enhancements

2019-09-30 Thread Stephen Hemminger
This patch set is all about improving the mbuf related cloning and copying. They are motivated by seeing issues with mbuf copying in rte_pdump and realized this a wider and more general problem. The pdump copy could not handle different size pools and did not handle meta data, etc. They cause no f

[dpdk-dev] [PATCH v3 2/6] mbuf: delinline rte_pktmbuf_linearize

2019-09-30 Thread Stephen Hemminger
This copy part of this function is too big to be put inline. The places it is used are only in special exception paths where a highly fragmented mbuf arrives at a device that can't handle it. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 37 +

Re: [dpdk-dev] [PATCH v1] eal: add manual probing option

2019-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2019 14:51:03 +0200 Gaetan Rivet wrote: > Add a new EAL option enabling manual probing in the EAL. > This command line option will configure the EAL so that buses > will not trigger their probe step on their own. > > Applications are then expected to hotplug devices as they see fi

[dpdk-dev] [PATCH] net/virtio: get all pending Rx packets in altivec vectorized paths

2019-09-30 Thread David Christensen
The loop to read packets does not take all packets as the number of available packets (nb_used) is decremented in the loop. Take all available packets provides a performance improvement of 3%. Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Cc: thibaut.col...@6wind.com Cc: maxime

[dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec vectorized functions

2019-09-30 Thread David Christensen
With vectorized functions, only the rx stats for number of packets is incremented. Update also the other statistics. Performance impact is about 2% Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Cc: thibaut.col...@6wind.com Cc: maxime.coque...@redhat.com Cc: tiwei@intel.com

[dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec vectorized functions

2019-09-30 Thread David Christensen
With vectorized functions, only the rx stats for number of packets is incremented. Update also the other statistics. Performance impact is about 2% Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Cc: thibaut.col...@6wind.com Cc: maxime.coque...@redhat.com Cc: tiwei@intel.com

Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-30 Thread Nipun Gupta
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Monday, September 30, 2019 1:39 PM > To: Nipun Gupta ; Jerin Jacob > Cc: Jerin Jacob Kollanukkaran ; > bruce.richard...@intel.com; Akhil Goyal ; Marko > Kovacevic ; Ori Kam ; > Radu Nicolau ; Tomasz Kantecki > ; Sunil Kuma

Re: [dpdk-dev] [PATCH v1] eal: add manual probing option

2019-09-30 Thread Aaron Conole
Gaetan Rivet writes: > Add a new EAL option enabling manual probing in the EAL. > This command line option will configure the EAL so that buses > will not trigger their probe step on their own. > > Applications are then expected to hotplug devices as they see fit. > > Devices declared on the comm

Re: [dpdk-dev] [PATCH v2 3/9] eal: add windows compatible header files

2019-09-30 Thread Pallavi Kadam
Hi Jerin, On 9/27/2019 12:58 AM, Jerin Jacob wrote: On Fri, Sep 27, 2019 at 2:24 AM Pallavi Kadam wrote: Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support functions and path defines for files and directories on Windows. Adding getopt.h to support parsing op

Re: [dpdk-dev] [PATCH v3 7/7] examples: disable Rx packet type parsing

2019-09-30 Thread Aaron Conole
writes: > From: Pavan Nikhilesh > > Disable packet type parsing in examples that don't use > `rte_mbuf::packet_type` by setting ptype_mask as 0 in > `rte_eth_dev_set_supported_ptypes` > > Signed-off-by: Pavan Nikhilesh > --- > examples/bbdev_app/main.c | 1 + > examples/bond/m

[dpdk-dev] [PATCH] eal: move rte_cpu definitions to os specific files

2019-09-30 Thread Pallavi Kadam
Moving RTE_CPU* definitions from the common code to the Linux, FreeBSD rte_os.h file to avoid #ifdef clutter. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon --- lib/librte_eal/common/include/rte_lcore.h | 44 - lib/librte_eal/fre

Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs

2019-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2019 16:42:04 + Ciara Loftus wrote: > +/* drivers supported for the queue_irq option */ > +enum supported_drivers { > + I40E_DRIVER, > + IXGBE_DRIVER, > + MLX5_DRIVER, > + NUM_DRIVERS > +}; Anything device specific like this raises a red flag to me. This regex

[dpdk-dev] [PATCH v2] app/test-eventdev: add options to set mbuf and pkt size

2019-09-30 Thread pbhagavatula
From: Pavan Nikhilesh Add options to set mbuf size and max packet size which allow the user to enable jumbo frames and Rx/Tx scatter gather. Arrange `struct evt_options` based on ascending order of data type to make it more readable. Packet mbuf size can be modified by using `--mbuf_sz=N`. Max p

[dpdk-dev] [PATCH v2 1/3] net/af_xdp: fix Tx halt when no recv packets

2019-09-30 Thread Ciara Loftus
From: Xiaolong Ye The kernel only consumes Tx packets if we have some Rx traffic on specified queue or we have called send(). So we need to issue a send() even when the allocation fails so that kernel will start to consume packets again. Commit 45bba02c95b0 ("net/af_xdp: support need wakeup feat

[dpdk-dev] [PATCH v2 3/3] net/af_xdp: enable support for unaligned umem chunks

2019-09-30 Thread Ciara Loftus
This patch enables the unaligned chunks feature for AF_XDP which allows chunks to be placed at arbitrary places in the umem, as opposed to them being required to be aligned to 2k. This allows for DPDK application mempools to be mapped directly into the umem and in turn enable zero copy transfer bet

[dpdk-dev] [PATCH v2 2/3] net/af_xdp: support pinning of IRQs

2019-09-30 Thread Ciara Loftus
Network devices using the AF_XDP PMD will trigger interrupts on reception of packets. The new PMD argument 'queue_irq' allows the user to specify a core on which to pin interrupts for a given queue. Multiple queue_irq arguments can be specified. For example: --vdev=net_af_xdp1,iface=eth0,queue_c

[dpdk-dev] [PATCH v2 0/3] AF_XDP tx halt fix, IRQ pinning and unaligned chunks

2019-09-30 Thread Ciara Loftus
This series contains 3 patches for the AF_XDP PMD. Previous: http://mails.dpdk.org/archives/dev/2019-September/143910.html Patch 1: fix Tx halt when no recv packets (Xiaolong Ye) Patch 2: support pinning of IRQs v1 -> v2: * Change enum format to match coding style * Change some variables to cons

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Ferruh Yigit
On 8/27/2019 9:21 AM, Ferruh Yigit wrote: > On 7/16/2019 4:40 PM, Stephen Hemminger wrote: >> The generic RTE_LOGTYPE_PMD is a historical relic and should >> not be used. Every driver should register the logtypes >> for itself. >> >> Signed-off-by: Stephen Hemminger > > <...> > >> +#ifdef RTE_LI

Re: [dpdk-dev] [PATCH v2 09/11] port: replace license text with SPDX tag

2019-09-30 Thread Yigit, Ferruh
On 7/29/2019 12:15 PM, Ferruh Yigit wrote: > On 7/26/2019 5:43 PM, Xiaolong Ye wrote: >> Signed-off-by: Xiaolong Ye >> Acked-by: Bruce Richardson > > Hi Ethan, > > Can you please check this patch, this is switching license representation (not > license itself) to SPDX tags, as a copyright owner

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Ferruh Yigit
On 9/30/2019 4:50 PM, Stephen Hemminger wrote: > On Mon, 30 Sep 2019 23:28:38 +0800 > Ye Xiaolong wrote: > >> On 08/27, Ferruh Yigit wrote: >>> On 7/16/2019 4:40 PM, Stephen Hemminger wrote: The generic RTE_LOGTYPE_PMD is a historical relic and should not be used. Every driver should

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2019 23:28:38 +0800 Ye Xiaolong wrote: > On 08/27, Ferruh Yigit wrote: > >On 7/16/2019 4:40 PM, Stephen Hemminger wrote: > >> The generic RTE_LOGTYPE_PMD is a historical relic and should > >> not be used. Every driver should register the logtypes > >> for itself. > >> > >> Signe

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: add NSH key field to flow API

2019-09-30 Thread Yigit, Ferruh
On 7/25/2019 10:03 AM, kirankum...@marvell.com wrote: > From: Kiran Kumar K > > Add new rte_flow_item_nsh in order to match the network service header > based on RFC 8300. > > Signed-off-by: Kiran Kumar K Hi Adrien, Ori, Any concern/objection on the patchset [1], if not will be merged in next

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Ye Xiaolong
On 08/27, Ferruh Yigit wrote: >On 7/16/2019 4:40 PM, Stephen Hemminger wrote: >> The generic RTE_LOGTYPE_PMD is a historical relic and should >> not be used. Every driver should register the logtypes >> for itself. >> >> Signed-off-by: Stephen Hemminger > ><...> > >> +#ifdef RTE_LIBRTE_E1000_DEBU

[dpdk-dev] [PATCH v2 6/6] pdump: use new pktmbuf copy function

2019-09-30 Thread Stephen Hemminger
The rte_pktmbuf_copy handles varying size mbuf pools correctly. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 69 +--- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c i

[dpdk-dev] [PATCH v2 3/6] mbuf: deinline rte_pktmbuf_clone

2019-09-30 Thread Stephen Hemminger
Cloning mbufs requires allocations and iteration and therefore should not be an inline. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 39 lib/librte_mbuf/rte_mbuf.h | 38 ++- lib/librte_mbuf/rte_mbuf_ver

[dpdk-dev] [PATCH v2 5/6] mbuf: add pktmbuf copy test

2019-09-30 Thread Stephen Hemminger
New test for rte_pktmbuf_copy based of the clone tests. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index aafad0cf6206..49c3a5f7893c 100644

[dpdk-dev] [PATCH v2 4/6] mbuf: add a pktmbuf copy routine

2019-09-30 Thread Stephen Hemminger
This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine

[dpdk-dev] [PATCH v2 2/6] mbuf: delinline rte_pktmbuf_linearize

2019-09-30 Thread Stephen Hemminger
This function is too big to be put inline. The places it is used are only in special exception paths where a highly fragmented mbuf arrives at a device that can't handle it. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 40 lib/librte_mb

[dpdk-dev] [PATCH v2 1/6] mbuf: don't generate invalid mbuf in clone test

2019-09-30 Thread Stephen Hemminger
The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 3 +++ 1 file

[dpdk-dev] [PATCH v2 0/6] mbuf copy related enhancements

2019-09-30 Thread Stephen Hemminger
This patch set is all about improving the mbuf related cloning and copying. They are motivated by seeing issues with mbuf copying in rte_pdump and realized this a wider and more general problem. The pdump copy could not handle different size pools and did not handle meta data, etc. They cause no f

Re: [dpdk-dev] [PATCH v3 18/19] net/hinic: optimize RX performance

2019-09-30 Thread Ferruh Yigit
On 9/30/2019 3:00 PM, Xiaoyun wang wrote: > This patch optimizes receive packets performance > on arm platform. > > Signed-off-by: Xiaoyun wang <...> > @@ -28,6 +28,7 @@ struct hinic_rq_ctrl { > u32 ctrl_fmt; > }; > > +#if defined(__X86_64_SSE__) > struct hinic_rq_cqe { > u3

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-09-30 Thread Ferruh Yigit
On 9/30/2019 3:00 PM, Xiaoyun wang wrote: > This patch set adds advanced features for Huawei hinic pmd, > such as VLAN filter and VLAN offload, SR-IOV, FW version get, > set link down and up, Flow director for LACP, VRRP, BGP and so on. > > -- > v2: > - Fix RSS bugs for vxlan packets inner type

[dpdk-dev] [PATCH v3 24/24] crypto/dpaa2_sec: improve debug logging

2019-09-30 Thread Akhil Goyal
From: Hemant Agrawal unnecessary debug logs in data path are removed and hardware debug logs are compiled off. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) dif

[dpdk-dev] [PATCH v3 23/24] crypto/dpaa_sec: change per cryptodev pool to per qp

2019-09-30 Thread Akhil Goyal
In cases where single cryptodev is used by multiple cores using multiple queues, there will be contention for mempool resources and may eventually get exhuasted. Basically, mempool should be defined per core. Now since qp is used per core, mempools are defined in qp setup. Signed-off-by: Akhil Goy

[dpdk-dev] [PATCH v3 18/24] crypto/dpaa2_sec/hw: support kasumi

2019-09-30 Thread Akhil Goyal
From: Vakul Garg Add Kasumi processing for non PDCP proto offload cases. Also add support for pre-computed IV in Kasumi-f9 Signed-off-by: Vakul Garg Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/hw/desc/algo.h | 64 +++-- 1 file changed,

[dpdk-dev] [PATCH v3 21/24] crypto/dpaa2_sec: allocate context as per num segs

2019-09-30 Thread Akhil Goyal
From: Hemant Agrawal DPAA2_SEC hardware can support any number of SG entries. This patch allocate as many SG entries as are required. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 28 + 1 file changed, 17 inserti

[dpdk-dev] [PATCH v3 20/24] crypto/dpaa2_sec: support zuc ciphering/integrity

2019-09-30 Thread Akhil Goyal
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Signed-off-by: Vakul Garg Acked-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 25 +++- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 45 + 2 files changed, 68 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v3 22/24] crypto/dpaa_sec: dynamic contxt buffer for SG cases

2019-09-30 Thread Akhil Goyal
From: Hemant Agrawal This patch allocate/clean the SEC context dynamically based on the number of SG entries in the buffer. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 43 ++ drivers/crypto/dpaa_sec/dpaa_sec.h | 8 +

[dpdk-dev] [PATCH v3 19/24] crypto/dpaa2_sec/hw: support ZUCE and ZUCA

2019-09-30 Thread Akhil Goyal
From: Vakul Garg This patch add support for ZUC Encryption and ZUC Authentication. Before passing to CAAM, the 16-byte ZUCA IV is converted to 8-byte format which consists of 38-bits of count||bearer|direction. Signed-off-by: Vakul Garg Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal ---

[dpdk-dev] [PATCH v3 17/24] crypto/dpaa2_sec: support snow3g cipher/integrity

2019-09-30 Thread Akhil Goyal
From: Hemant Agrawal Adding basic framework to use snow3g f8 and f9 based ciphering or integrity with direct crypto apis. This patch does not support any combo usages yet. Signed-off-by: Hemant Agrawal Signed-off-by: Vakul Garg Acked-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dps

[dpdk-dev] [PATCH v3 11/24] crypto/dpaa2_sec/hw: support 18-bit PDCP enc-auth cases

2019-09-30 Thread Akhil Goyal
From: Vakul Garg This patch support following algo combinations(ENC-AUTH). - AES-SNOW - SNOW-AES - AES-ZUC - ZUC-AES - SNOW-ZUC - ZUC-SNOW Signed-off-by: Vakul Garg Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/hw/desc/pdcp.h | 211 1 file changed, 140 inser

[dpdk-dev] [PATCH v3 10/24] crypto/dpaa2_sec: disable 'write-safe' for PDCP

2019-09-30 Thread Akhil Goyal
From: Vakul Garg PDCP descriptors in some cases internally use commands which overwrite memory with extra '0s' if write-safe is kept enabled. This breaks correct functional behavior of PDCP apis and they in many cases give incorrect crypto output. There we disable 'write-safe' bit in FLC for PDCP

  1   2   3   >