[dpdk-dev] [PATCH v7] net/i40e: i40e get link status update from ipn3ke

2019-07-10 Thread Andy Pei
Add switch_mode argument for i40e PF to specify the specific FPGA that i40e PF is connected to. i40e PF get link status update via the connected FPGA. Add bool switch_ethdev_support_flag to struct i40e_pf to specify if there are switch_mode argues in cmd. Add switch_ethdev to struct i40e_pf to trac

Re: [dpdk-dev] [PATCH v6 1/2] net/i40e: i40e get link status update from ipn3ke

2019-07-10 Thread Pei, Andy
HI QI -Original Message- From: Zhang, Qi Z Sent: Thursday, July 11, 2019 12:37 PM To: Pei, Andy ; dev@dpdk.org Cc: Wu, Jingjing ; Xing, Beilei ; Yigit, Ferruh ; Xu, Rosen ; Ye, Xiaolong ; Zhang, Roy Fan ; sta...@dpdk.org Subject: RE: [PATCH v6 1/2] net/i40e: i40e get link status update

Re: [dpdk-dev] [PATCH v6 1/2] net/i40e: i40e get link status update from ipn3ke

2019-07-10 Thread Pei, Andy
Hi, Qi Reply inline. -Original Message- From: Zhang, Qi Z Sent: Thursday, July 11, 2019 12:37 PM To: Pei, Andy ; dev@dpdk.org Cc: Wu, Jingjing ; Xing, Beilei ; Yigit, Ferruh ; Xu, Rosen ; Ye, Xiaolong ; Zhang, Roy Fan ; sta...@dpdk.org Subject: RE: [PATCH v6 1/2] net/i40e: i40e get li

[dpdk-dev] [PATCH v2 1/1] app/test: fix --socket-mem option in eal flag autotest

2019-07-10 Thread vattunuru
From: Vamsi Attunuru eal flag autotest fails when multiple mem size flags are passed to --socket-mem option irrespective of RTE_MAX_NUMA_NODES. Patch fixes --socket-mem option by setting enough numbers of numa node mem flags based on RTE_MAX_NUMA_NODES config. Fixes: 45f1b6e8680a ("app: add new

Re: [dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-10 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, July 10, 2019 3:29 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 2/2] net/ice: add safe mode support devarg > > > > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 10,

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: remove unused devargs

2019-07-10 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, July 10, 2019 3:28 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3 1/2] net/ice: remove unused devargs > > > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, J

Re: [dpdk-dev] [PATCH v6 1/2] net/i40e: i40e get link status update from ipn3ke

2019-07-10 Thread Zhang, Qi Z
> -Original Message- > From: Pei, Andy > Sent: Wednesday, July 10, 2019 5:41 PM > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Qi Z ; Wu, > Jingjing ; Xing, Beilei ; Yigit, > Ferruh ; Xu, Rosen ; Ye, > Xiaolong ; Zhang, Roy Fan > ; sta...@dpdk.org > Subject: [PATCH v6 1/2] net/i40e: i40e ge

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-10 Thread Jason Wang
On 2019/7/10 下午3:30, Liu, Yong wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Wednesday, July 10, 2019 12:28 PM To: Liu, Yong ; Bie, Tiwei ; maxime.coque...@redhat.com; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enq

Re: [dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight

2019-07-10 Thread Tiwei Bie
On Thu, Jul 11, 2019 at 10:23:11AM +0800, Yu, Jin wrote: > > -Original Message- > > From: Bie, Tiwei > > Sent: Wednesday, July 10, 2019 3:26 PM > > To: Yu, Jin > > Cc: dev@dpdk.org; Liu, Changpeng ; > > maxime.coque...@redhat.com; Wang, Zhihong > > Subject: Re: [PATCH v2 2/2] vhost: Add v

Re: [dpdk-dev] [PATCH v2 1/2] vhost: support inflight share memory protocol feature

2019-07-10 Thread Tiwei Bie
On Thu, Jul 11, 2019 at 10:39:46AM +0800, Yu, Jin wrote: > > On Thu, Jul 11, 2019 at 10:09:26AM +0800, Yu, Jin wrote: > > [...] > > > > > +int __rte_experimental > > > > > +rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx, > > > > > + uint16_t idx); > > > > [...] > > > > >

[dpdk-dev] [PATCH] octeontx2: do not put escape sequences in log

2019-07-10 Thread Stephen Hemminger
Putting color escape sequences in the log look pretty for the developer but fails in real world DPDK usage. A real application will put DPDK log to syslog, and syslog does not handle escape sequences. Fixes: dd543124cd93 ("common/octeontx2: add runtime log infra") Signed-off-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value

2019-07-10 Thread Yang, Qiming
Hi, Thomas Thanks for the comments. Will change it. Qiming -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Wednesday, July 10, 2019 3:30 PM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value Hi,

Re: [dpdk-dev] [PATCH v2 1/2] vhost: support inflight share memory protocol feature

2019-07-10 Thread Yu, Jin
> On Thu, Jul 11, 2019 at 10:09:26AM +0800, Yu, Jin wrote: > [...] > > > > +int __rte_experimental > > > > +rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx, > > > > + uint16_t idx); > > > [...] > > > > +int __rte_experimental > > > > +rte_vhost_clr_inflight_desc_split(in

[dpdk-dev] [PATCH] vfio: fix build errors on old Linux

2019-07-10 Thread Takeshi Yoshimura
The commit db90b4969e2e ("vfio: retry creating sPAPR DMA window") introduced a build breakage on old Linux. Linux <4.2 does not define ddw in struct vfio_iommu_spapr_tce_info. Without ddw, we cannot change window size and so should give up the creation. I just exculuded the retrying code if ddw is

Re: [dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight

2019-07-10 Thread Yu, Jin
> -Original Message- > From: Bie, Tiwei > Sent: Wednesday, July 10, 2019 3:26 PM > To: Yu, Jin > Cc: dev@dpdk.org; Liu, Changpeng ; > maxime.coque...@redhat.com; Wang, Zhihong > Subject: Re: [PATCH v2 2/2] vhost: Add vhost-user-blk example which > support inflight > > On Wed, Jul 10, 2

Re: [dpdk-dev] [PATCH v2 1/2] vhost: support inflight share memory protocol feature

2019-07-10 Thread Tiwei Bie
On Thu, Jul 11, 2019 at 10:09:26AM +0800, Yu, Jin wrote: [...] > > > +int __rte_experimental > > > +rte_vhost_set_inflight_desc_split(int vid, uint16_t vring_idx, > > > + uint16_t idx); > > [...] > > > +int __rte_experimental > > > +rte_vhost_clr_inflight_desc_split(int vid, uint16_t vring_

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread Takeshi T Yoshimura
-"Burakov, Anatoly" wrote: - >To: Thomas Monjalon >From: "Burakov, Anatoly" >Date: 07/10/2019 09:01AM >Cc: Takeshi Yoshimura , dev@dpdk.org, David >Christensen >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR >DMA window > >On 10-Jul-19 1:39 PM, Thomas Monjalon wr

Re: [dpdk-dev] [PATCH v2 1/2] vhost: support inflight share memory protocol feature

2019-07-10 Thread Yu, Jin
Hi Tiwei, thanks. > -Original Message- > From: Bie, Tiwei > Sent: Wednesday, July 10, 2019 3:18 PM > To: Yu, Jin > Cc: dev@dpdk.org; Liu, Changpeng ; > maxime.coque...@redhat.com; Wang, Zhihong ; > LinLi ; XunNi ; YuZhang > > Subject: Re: [PATCH v2 1/2] vhost: support inflight share memo

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-10 Thread Yongseok Koh
On Tue, Jul 09, 2019 at 10:38:06AM +0200, Adrien Mazarguil wrote: > On Fri, Jul 05, 2019 at 06:05:50PM +, Yongseok Koh wrote: > > > On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil > > > wrote: > > > > > > On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: > > >> A tag is a transient

[dpdk-dev] [v5] net/e1000: fix i219 hang on reset/close

2019-07-10 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. This state can be detected by configure status by bit 8 in register. If the bit is set and there are pending descriptors in one of the rings, we must flush them before reset or close. Signed-off-by: Xiao

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread David Christensen
@Thomas Do we still support these older distros? If the kernel is not maintained, we don't support it. For most distros, Linux < 3.16 is not maintained. This is on kernel 3.13 (Ubuntu 14.04 LTS which according to Canonical's published schedule [1] has stopped receiving even maintenance updates

Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa

2019-07-10 Thread yoursunny
Hi Ferruh I have no objection of merging the current commit. I do have some ideas on how to support indirect mbufs. Please review at https://bugs.dpdk.org/show_bug.cgi?id=183#c4 Yours, Junxiao On Wed, Jul 10, 2019 at 5:23 PM Ferruh Yigit wrote: > > your use case is about indirect mbufs, I can s

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-10 Thread Stephen Hemminger
On Wed, 10 Jul 2019 16:31:59 -0400 Aaron Conole wrote: > Stephen Hemminger writes: > > > On Wed, 10 Jul 2019 15:13:02 -0400 > > Aaron Conole wrote: > > > >> Stephen Hemminger writes: > >> > >> > On Wed, 10 Jul 2019 14:33:42 -0400 > >> > Aaron Conole wrote: > >> > > >> >> rte_ether_u

Re: [dpdk-dev] [PATCH v9] app/pdump: exit with primary process

2019-07-10 Thread Thomas Monjalon
10/07/2019 16:04, Suanming Mou: > On 6/24/2019 6:30 AM, Thomas Monjalon wrote: > > 20/06/2019 15:32, Pattan, Reshma: > >> From: Suanming.Mou [mailto:mousuanm...@huawei.com] > >>> Signed-off-by: Suanming Mou > >>> Reviewed-by: Anatoly Burakov > >>> Reviewed-by: Vipin Varghese > >>> Reviewed-by: R

Re: [dpdk-dev] [PATCH v4] app/pdump: enforcing pdump to use SW mempool

2019-07-10 Thread Thomas Monjalon
10/07/2019 11:22, Harman Kalra: > A secondary process cannot access HW mempool already > initiazed by primary, and neither it can setup its own > HW mempool due to its own restrictions. > > Since dpdk-pdump creates mempool for managing its local > mbufs, SW mempool is capable enough to solve this

Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"

2019-07-10 Thread Thomas Monjalon
09/07/2019 16:39, Stephen Hemminger: > On Fri, 7 Jun 2019 16:08:41 -0700 > Stephen Hemminger wrote: > > > From: Stephen Hemminger > > > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. > > That commit breaks support for netvsc PMD with MLX SRIOV > > on both Hyper-V and Azure. >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library

2019-07-10 Thread Thomas Monjalon
10/07/2019 12:52, Harman Kalra: > Once the library usage is over, it must be deinitialized which > will free the shared memory reserved during initialization. > > Observed an issue while running 'metrics_autotest' continuously > without quiting. For the first run 'metrics_autotest' passes > all te

Re: [dpdk-dev] [PATCH v1] examples/l3fwd-power: fix telemetry coverity issue

2019-07-10 Thread Thomas Monjalon
10/07/2019 17:26, David Hunt: > 6 issues caught by Coverity 343465 > * Possible divide by zero on 3 lines > * Convert to float then back to int, losing precision on 3 lines > > This patch modifies the code so that it only assigns calculated > values if the divisor is > 0, otherwise sets metrics to

Re: [dpdk-dev] [PATCH v6] power: add fifo per core for JSON interface

2019-07-10 Thread Thomas Monjalon
09/07/2019 17:21, David Hunt: > From: Marcin Hajkowski > > This patch implements a separate FIFO for each cpu core to improve the > previous functionality where anyone with access to the FIFO could affect > any core on the system. By using appropriate permissions, fifo interfaces > can be configu

Re: [dpdk-dev] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-10 Thread Thomas Monjalon
09/07/2019 13:09, Bernard Iremonger: > This patch fixes the out-of-bounds coverity issue by removing the > offending line of code at line 107 in rte_flow_classify_parse.c > which is never executed. > > Coverity issue: 343454 > > Fixes: be41ac2a330f ("flow_classify: introduce flow classify library

[dpdk-dev] [PATCH 0/2] Fixes on IOVA mode selection

2019-07-10 Thread David Marchand
Following the issues reported by Jerin and the discussion that emerged from it, here are fixes to restore and document the behavior of the EAL and the pci bus driver. I pondered all the arguments and tried to have the less changes possible. I can't find a need for a flag to just announce support o

[dpdk-dev] [PATCH 1/2] Revert "bus/pci: add Mellanox kernel driver type"

2019-07-10 Thread David Marchand
This reverts commit 0cb86518db57d35e0abc14d6703fad561a0310e2. The pci bus now reports DC when faced with a device bound to an unknown driver and, in such a case, the IOVA mode is selected against physical address availability. As a consequence, there is no reason for this special case for Mellano

[dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers

2019-07-10 Thread David Marchand
The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which was intended to mean "driver only supports VA" but had been understood as "driver supports both PA and VA" by most net drivers and used to let dpdk processes to run as non root (which do not have access to physical addresses on r

Re: [dpdk-dev] [PATCH] fbarray: fix fbarray destruction

2019-07-10 Thread Thomas Monjalon
09/07/2019 16:00, Anatoly Burakov: > Currently, when fbarray is destroyed, the fbarray structure is not > zeroed out, which leads to stale data being there and confusing > secondary process init in legacy mem mode. Fix it by always > memsetting the fbarray to zero when destroying it. > > Fixes: 5b

Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa

2019-07-10 Thread Ferruh Yigit
On 7/10/2019 9:40 PM, yoursunny wrote: > Hi Ferruh > > I've uploaded my test case to Bug 183. > You can determine whether it is a bug that should be covered by this > patch, or it should be handled separately. Thanks for clarification, your use case is about indirect mbufs, I can see why it is no

Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition

2019-07-10 Thread Thomas Monjalon
10/07/2019 14:33, David Marchand: > Populating the eventfd in rte_intr_enable in each request to vfio > triggers a reconfiguration of the interrupt handler on the kernel side. > The problem is that rte_intr_enable is often used to re-enable masked > interrupts from drivers interrupt handlers. > >

Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa

2019-07-10 Thread yoursunny
Hi Ferruh I've uploaded my test case to Bug 183. You can determine whether it is a bug that should be covered by this patch, or it should be handled separately. Yours, Junxiao On Wed, Jul 10, 2019 at 4:11 PM Ferruh Yigit wrote: > > On 7/2/2019 9:07 PM, Junxiao Shi wrote: > > I am battling a rel

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-10 Thread Aaron Conole
Stephen Hemminger writes: > On Wed, 10 Jul 2019 15:13:02 -0400 > Aaron Conole wrote: > >> Stephen Hemminger writes: >> >> > On Wed, 10 Jul 2019 14:33:42 -0400 >> > Aaron Conole wrote: >> > >> >> rte_ether_unformation_addr is very lax in what it accepts now, including >> >> ethernet addresse

Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa

2019-07-10 Thread Ferruh Yigit
On 7/2/2019 9:07 PM, Junxiao Shi wrote: > I am battling a related problem as reported on > https://bugs.dpdk.org/show_bug.cgi?id=183 and this patch seems > relevant, so I applied this patch on 196a46fab6eeb3ce2039e3bcaca80f8ba43ffc8d > > However, this patch does not work for me: > with CONFIG_RTE_

Re: [dpdk-dev] [PATCH v3] kni: fix possible kernel crash with va2pa

2019-07-10 Thread Ferruh Yigit
On 6/25/2019 4:04 PM, Yangchao Zhou wrote: > va2pa depends on the physical address and virtual address offset of > current mbuf. It may get the wrong physical address of next mbuf which > allocated in another hugepage segment. > > In rte_mempool_populate_default(), trying to allocate whole block o

[dpdk-dev] Time to kill RTE_LOGTYPE_PMD?

2019-07-10 Thread Stephen Hemminger
The old "Poll Mode Driver" PMD log type should not be used in current DPDK but lots of drivers still are. The PMD log level should purged. Could the driver writers please fix it (or I will do it for them). drivers/bus/dpaa/rte_dpaa_logs.h drivers/bus/fslmc/fslmc_logs.h drivers/common/cpt/cpt_pmd_

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-10 Thread Stephen Hemminger
On Wed, 10 Jul 2019 15:13:02 -0400 Aaron Conole wrote: > Stephen Hemminger writes: > > > On Wed, 10 Jul 2019 14:33:42 -0400 > > Aaron Conole wrote: > > > >> rte_ether_unformation_addr is very lax in what it accepts now, including > >> ethernet addresses formatted ambiguously as "x:xx:x:xx:x:

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-10 Thread Aaron Conole
Stephen Hemminger writes: > On Wed, 10 Jul 2019 14:33:42 -0400 > Aaron Conole wrote: > >> rte_ether_unformation_addr is very lax in what it accepts now, including >> ethernet addresses formatted ambiguously as "x:xx:x:xx:x:xx". However, >> previously this behavior was enforced via the my_ether_

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-10 Thread Stephen Hemminger
On Wed, 10 Jul 2019 14:33:42 -0400 Aaron Conole wrote: > rte_ether_unformation_addr is very lax in what it accepts now, including > ethernet addresses formatted ambiguously as "x:xx:x:xx:x:xx". However, > previously this behavior was enforced via the my_ether_aton which would > fail ambiguously

[dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-10 Thread Aaron Conole
rte_ether_unformation_addr is very lax in what it accepts now, including ethernet addresses formatted ambiguously as "x:xx:x:xx:x:xx". However, previously this behavior was enforced via the my_ether_aton which would fail ambiguously formatted values. Reported-by: Michael Santana Fixes: 596d31092

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-10 Thread Wiles, Keith
> On Jul 10, 2019, at 12:49 PM, Stephen Hemminger > wrote: > > On Wed, 10 Jul 2019 11:29:07 +0200 > Olivier Matz wrote: > >> /** >> * Indicate that the metadata field in the mbuf is in use. >> @@ -738,6 +741,8 @@ struct rte_mbuf { >> */ >> struct rte_mbuf_ext_shared_info *shinfo

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-10 Thread Stephen Hemminger
On Wed, 10 Jul 2019 11:29:07 +0200 Olivier Matz wrote: > /** > * Indicate that the metadata field in the mbuf is in use. > @@ -738,6 +741,8 @@ struct rte_mbuf { >*/ > struct rte_mbuf_ext_shared_info *shinfo; > > + uint64_t dynfield1; /**< Reserved for dynamic fields. */ > +

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-10 Thread Wang, Haiyue
Hi, Sounds cool, just have some questions inline. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Wednesday, July 10, 2019 17:29 > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags > > Many features requir

[dpdk-dev] [PATCH] net/bnxt: create ring group array only when needed

2019-07-10 Thread Lance Richardson
Fix an overrun of the ring group array with BCM5750X-based adapters by ensuring that the ring group array is not allocated or accessed for adapters that do not support ring groups. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Kh

[dpdk-dev] [PATCH] common/octeontx2: add CNF95xx SoC support

2019-07-10 Thread Nithin Dabilpuram
Update platform support of CNF95xx in documentation and also, update the HW cap based on PCI subsystem id and revision id. This patch also changes HW capability handling to be based on PCI Revision ID. PCI Revision ID contains a unique identifier to identify chip, major and minor revisions. Signed

Re: [dpdk-dev] [PATCH] doc: fix PDF build in octeontx2 guide

2019-07-10 Thread Thomas Monjalon
> > The unicode characters to draw the debugfs tree may fail with some Latex > > distributions. > > These characters are replaced with some ASCII equivalents. > > > > Fixes: 14ad4f018453 ("doc: add Marvell OCTEON TX2 platform guide") > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Jerin Ja

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Yongseok Koh
> On Jul 10, 2019, at 5:26 AM, Thomas Monjalon wrote: > > 10/07/2019 14:01, Bruce Richardson: >> On Wed, Jul 10, 2019 at 12:07:43PM +0200, Olivier Matz wrote: >>> On Wed, Jul 10, 2019 at 10:55:34AM +0100, Bruce Richardson wrote: On Wed, Jul 10, 2019 at 11:31:56AM +0200, Olivier Matz wrote:

Re: [dpdk-dev] [PATCH v2] net/af_packet: add string error for system errors

2019-07-10 Thread Stephen Hemminger
On Wed, 10 Jul 2019 16:46:30 +0200 wrote: > > +#define PMD_LOG_ERRNO(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, af_packet_logtype, \ > + "%s(): " fmt ":%s\n", __func__, ##args, rte_strerror(errno)) > + > static uint16_t > eth_af_packet_rx(void *queue, struct rte_mbu

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread Burakov, Anatoly
On 10-Jul-19 1:39 PM, Thomas Monjalon wrote: 10/07/2019 14:35, Burakov, Anatoly: On 10-Jul-19 1:17 PM, Thomas Monjalon wrote: 10/07/2019 12:32, Burakov, Anatoly: On 07-Jun-19 3:28 AM, Takeshi Yoshimura wrote: sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. However, Linu

Re: [dpdk-dev] [PATCH] doc: fix PDF build in octeontx2 guide

2019-07-10 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, July 10, 2019 3:32 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > ; John McNamara ; > Marko Kovacevic > Cc: dev@dpdk.org > Subject: [PATCH] doc: fix PDF build in octeontx2 guide > >

[dpdk-dev] [PATCH v1] examples/l3fwd-power: fix telemetry coverity issue

2019-07-10 Thread David Hunt
6 issues caught by Coverity 343465 * Possible divide by zero on 3 lines * Convert to float then back to int, losing precision on 3 lines This patch modifies the code so that it only assigns calculated values if the divisor is > 0, otherwise sets metrics to zero. Also removes the un-needed round()

Re: [dpdk-dev] [PATCH v4] net/memif: zero-copy slave

2019-07-10 Thread Ferruh Yigit
On 7/9/2019 9:22 AM, Jakub Grajciar wrote: > Zero-copy slave support for memif PMD. > Slave interface exposes DPDK memory to > master interface. Only single file segments > are supported (EAL option --single-file-segments). > > Signed-off-by: Jakub Grajciar <...> > +Zero-copy slave > +~

Re: [dpdk-dev] [PATCH] crypto/qat: fix seg-fault

2019-07-10 Thread Nowak, DamianX
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 10, 2019 11:53 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Nowak, > DamianX ; Ananyev, Konstantin > > Subject: [PATCH] crypto/qat: fix seg-fault > > Fix for seg-faults occurring: > 1) in buffer re-alignment

[dpdk-dev] [PATCH v4] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Xiaoyu Min
Enabled IP-in-IP tunnel type support on DV/DR flow engine. This includes the following combination: - IPv4 over IPv4 - IPv4 over IPv6 - IPv6 over IPv4 - IPv6 over IPv6 MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sure fw using FLEX Paser profile 0. mlxconfig -d -y set

[dpdk-dev] [PATCH v2] net/af_packet: add string error for system errors

2019-07-10 Thread kkanas
From: Krzysztof Kanas Print system error to make easier diagnosis of errors with af_packet. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 53 ++- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_a

[dpdk-dev] [Bug 316] livelock causes librte_distributor unit test to hang

2019-07-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=316 Bug ID: 316 Summary: livelock causes librte_distributor unit test to hang Product: DPDK Version: 19.08 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Jack Min
On Wed, 19-07-10, 22:35, Slava Ovsiienko wrote: > Regarding point 2) - it is OK, there is common flags update in the item > validation loop. > So, after update point 1) - you can add my Acked-by to the patch, thanks. Great! thank you~ I'll update it soon. > > WBR, > Slava > > > -Original Me

Re: [dpdk-dev] [PATCH v9] app/pdump: exit with primary process

2019-07-10 Thread Suanming Mou
On 6/24/2019 6:30 AM, Thomas Monjalon wrote: > 20/06/2019 15:32, Pattan, Reshma: >> From: Suanming.Mou [mailto:mousuanm...@huawei.com] >>> Signed-off-by: Suanming Mou >>> Reviewed-by: Anatoly Burakov >>> Reviewed-by: Vipin Varghese >>> Reviewed-by: Reshma Pattan >>> Reviewed-by: Thomas Monjalon

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Slava Ovsiienko
Regarding point 2) - it is OK, there is common flags update in the item validation loop. So, after update point 1) - you can add my Acked-by to the patch, thanks. WBR, Slava > -Original Message- > From: dev On Behalf Of Slava Ovsiienko > Sent: Wednesday, July 10, 2019 17:20 > To: Jack M

[dpdk-dev] [PATCH] net/bnxt: fix logic error when freeing RSS context

2019-07-10 Thread Lance Richardson
The conditional used to determine whether freeing RSS contexts for thor vs. non-thor controller was reversed. Fix this, also reset number of active RSS contexts to zero after release in the thor case. Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers") Signed-off-by: Lance Rich

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Slava Ovsiienko
Hi, Xiaoyu There is a couple of small points to note: 1) It would be good to have the testpmd flow create command sample with new tunnels in commit log. 2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ? It looks like a bug, should the second parameter be "&item_flags" ? (if so

[dpdk-dev] [PATCH] examples/ip_fragmentation: fix fail to send un-fragmented packets

2019-07-10 Thread Konstantin Ananyev
With latest changes l3fwd_simple_forward() blindly set (PKT_TX_IPV4 | PKT_TX_IP_CKSUM) ol_flags for all IPv4 packets. Though for un-fragmented packets we also do have to set l3_len to make HW IP cksum offload to work properly. That causes HWi/PMD to drop or generate invalid packets. Though for un-f

[dpdk-dev] [PATCH v2] app/testpmd: add device related cmds

2019-07-10 Thread Nithin Dabilpuram
With the latest published interface of rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), rte_eth_dev_close() would cleanup all the data structures of port's eth dev leaving the device common resource intact if RTE_ETH_DEV_CLOSE_REMOVE is set in dev flags. So a new command "detach device" (~

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread Thomas Monjalon
10/07/2019 14:35, Burakov, Anatoly: > On 10-Jul-19 1:17 PM, Thomas Monjalon wrote: > > 10/07/2019 12:32, Burakov, Anatoly: > >> On 07-Jun-19 3:28 AM, Takeshi Yoshimura wrote: > >>> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. > >>> However, Linux 4.17 or before returns inc

[dpdk-dev] devtools: fix symbol change file matching

2019-07-10 Thread Bing Zhao
The previous regex miss a situation that a new file is added after the map file. It will starts with '/dev/null' instead of 'a /', so all the content in the patch file after 'map' will be considered in the symbol map file. Also, a second regex matching is used for map and other files, the '^map' in

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread Burakov, Anatoly
On 10-Jul-19 1:17 PM, Thomas Monjalon wrote: 10/07/2019 12:32, Burakov, Anatoly: On 07-Jun-19 3:28 AM, Takeshi Yoshimura wrote: sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. However, Linux 4.17 or before returns incorrect page_shift for Power9. I added the code for retr

[dpdk-dev] [PATCH] vfio: fix interrupts race condition

2019-07-10 Thread David Marchand
Populating the eventfd in rte_intr_enable in each request to vfio triggers a reconfiguration of the interrupt handler on the kernel side. The problem is that rte_intr_enable is often used to re-enable masked interrupts from drivers interrupt handlers. This reconfiguration leaves a window during wh

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Thomas Monjalon
10/07/2019 14:01, Bruce Richardson: > On Wed, Jul 10, 2019 at 12:07:43PM +0200, Olivier Matz wrote: > > On Wed, Jul 10, 2019 at 10:55:34AM +0100, Bruce Richardson wrote: > > > On Wed, Jul 10, 2019 at 11:31:56AM +0200, Olivier Matz wrote: > > > > On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Ko

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread Thomas Monjalon
10/07/2019 12:32, Burakov, Anatoly: > On 07-Jun-19 3:28 AM, Takeshi Yoshimura wrote: > > sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. > > However, Linux 4.17 or before returns incorrect page_shift for Power9. > > I added the code for retrying creation of sPAPR DMA window.

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Bruce Richardson
On Wed, Jul 10, 2019 at 12:07:43PM +0200, Olivier Matz wrote: > On Wed, Jul 10, 2019 at 10:55:34AM +0100, Bruce Richardson wrote: > > On Wed, Jul 10, 2019 at 11:31:56AM +0200, Olivier Matz wrote: > > > Hi Yongseok, > > > > > > On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote: > > > > C

[dpdk-dev] [PATCH v7 2/2] examples/ipsec-secgw/test: fix inline test scripts

2019-07-10 Thread Bernard Iremonger
Remove workaround in tun_aesgcm_defs.sh and trs_aesgcm_defs.sh to get around the bug where the first inbound packet is dropped for inline crypto. Fixes: 929784452094 ("examples/ipsec-secgw: add scripts for functional test") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Konstanti

[dpdk-dev] [PATCH v7 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-07-10 Thread Bernard Iremonger
Inline crypto installs a flow rule in the NIC. This flow rule must be installed before the first inbound packet is received. The create_session() function installs the flow rule, create_session() has been refactored into create_inline_session() and create_lookaside_session(). The create_inline_ses

[dpdk-dev] [PATCH v7 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-07-10 Thread Bernard Iremonger
This patchset fixes the issue of the first inbound packet being dropped for inline crypto. Changes in v7: -- Rebased to DPDK 19.08-rc1 Changes in v6: -- Rebased to latest master. Minor changes to the following functions in ipsec.c: create_lookaside_session() create_inline_

[dpdk-dev] [Bug 315] Virtio crypto does not work . Tried with vhost crypto as backend and dpdk test application (cryptodev_virtio_autotest )

2019-07-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=315 Bug ID: 315 Summary: Virtio crypto does not work . Tried with vhost crypto as backend and dpdk test application (cryptodev_virtio_autotest ) Product: DPDK Version: 19.05

Re: [dpdk-dev] devtools: fix symbol change file matching

2019-07-10 Thread Neil Horman
On Wed, Jul 10, 2019 at 05:57:14PM +0800, Bing Zhao wrote: > The previous regex miss a situation that a new file is added after > the map file. It will starts with '/dev/null' instead of 'a /', so > all the content in the patch file after 'map' will be considered in > the symbol map file. Also, a s

[dpdk-dev] [PATCH v3 2/2] test/metrics: fix metrics autotest failure

2019-07-10 Thread Harman Kalra
Issue is observed while running 'metrics_autotest' continuously without quiting. During first execution all test cases pass but second run onwards first test case fails as library is already initialized. To resolve, introduced a new API to deinitialise the library after all test cases are executed

[dpdk-dev] [PATCH v3 1/2] metrics: new API to deinitialise metrics library

2019-07-10 Thread Harman Kalra
Once the library usage is over, it must be deinitialized which will free the shared memory reserved during initialization. Observed an issue while running 'metrics_autotest' continuously without quiting. For the first run 'metrics_autotest' passes all test cases but second run onwards first test c

[dpdk-dev] [PATCH v3 3/3] app/testpmd: add GRE key for raw encap/decap

2019-07-10 Thread Xiaoyu Min
GRE key (rte_flow_item_type_gre_key) is also needed in raw encapsulation/decapsulation. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index f48b202e58..43ae42146f 1006

[dpdk-dev] [PATCH v3 1/3] app/testpmd: support raw encap/decap actions

2019-07-10 Thread Xiaoyu Min
This patch intend to support action_raw_encap/decap [1] in a generic and convenient way. Two new commands - set raw_encap, set raw_decap are introduced just like the other commands for encap/decap, i.e. set vxlan. These two commands have corresponding global buffers which can be used by PMD as th

[dpdk-dev] [PATCH v3 0/3] app/testpmd: support raw encap/decap actions

2019-07-10 Thread Xiaoyu Min
This series is based on RFC [1], which enable the testpmd to support the raw_encap/raw_decap actions in a generic and convenient way. Some rte_flow_item's fields are also opened in testpmd cmdline i.e. MPLS's TC & S in order to make sure the encapsulated tunnel header has the correct data. [1] ht

[dpdk-dev] [PATCH v3 2/3] app/testpmd: support MPLS's TC and S bits

2019-07-10 Thread Xiaoyu Min
Open the MPLS's TC and S bits of rte_flow_item_mpls in command line. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 46f3da07eb..f48b202e58 100644 -

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-10 Thread Burakov, Anatoly
On 07-Jun-19 3:28 AM, Takeshi Yoshimura wrote: sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. However, Linux 4.17 or before returns incorrect page_shift for Power9. I added the code for retrying creation of sPAPR DMA window. Signed-off-by: Takeshi Yoshimura --- lib/lib

[dpdk-dev] [PATCH v3] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Xiaoyu Min
Enabled IP-in-IP tunnel type support on DV/DR flow engine. This includes the following combination: - IPv4 over IPv4 - IPv4 over IPv6 - IPv6 over IPv4 - IPv6 over IPv6 MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sure fw using FLEX Paser profile 0. mlxconfig -d -y set

Re: [dpdk-dev] [PATCH] crypto/qat: fix seg-fault

2019-07-10 Thread Ananyev, Konstantin
> > Fix for seg-faults occurring: > 1) in buffer re-alignment in-place sgl case > 2) case where data end is exactly at end of an sgl segment. > Also renamed variable and increased comments for clearer code. > > Fixes: 40002f6c2a24 ("crypto/qat: extend support for digest-encrypted > auth-ciphe

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Olivier Matz
On Wed, Jul 10, 2019 at 10:55:34AM +0100, Bruce Richardson wrote: > On Wed, Jul 10, 2019 at 11:31:56AM +0200, Olivier Matz wrote: > > Hi Yongseok, > > > > On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote: > > > Currently, metadata can be set on egress path via mbuf tx_meatadata field >

[dpdk-dev] [PATCH] doc: fix PDF build in octeontx2 guide

2019-07-10 Thread Thomas Monjalon
The unicode characters to draw the debugfs tree may fail with some Latex distributions. These characters are replaced with some ASCII equivalents. Fixes: 14ad4f018453 ("doc: add Marvell OCTEON TX2 platform guide") Signed-off-by: Thomas Monjalon --- doc/guides/platform/octeontx2.rst | 96 +++

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Bruce Richardson
On Wed, Jul 10, 2019 at 11:31:56AM +0200, Olivier Matz wrote: > Hi Yongseok, > > On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote: > > Currently, metadata can be set on egress path via mbuf tx_meatadata field > > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_RX_META matches metadata

[dpdk-dev] [PATCH] crypto/qat: fix seg-fault

2019-07-10 Thread Fiona Trahe
Fix for seg-faults occurring: 1) in buffer re-alignment in-place sgl case 2) case where data end is exactly at end of an sgl segment. Also renamed variable and increased comments for clearer code. Fixes: 40002f6c2a24 ("crypto/qat: extend support for digest-encrypted auth-cipher") Signed-off-by:

Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-10 Thread Jerin Jacob Kollanukkaran
Not sure if it is problem from my email client or David email settings, I am getting the David email ONLY as HTML. And outlook creating format issues when change to plain text on reply. It looks like it is due to "Content-Type: multipart/alternative". Please find inline reply. From: David March

[dpdk-dev] [PATCH v6 2/2] doc: add switch mode devargs

2019-07-10 Thread Andy Pei
add document for switch_mode devargs. Signed-off-by: Andy Pei --- doc/guides/nics/i40e.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index a97484c..8d88f0d 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.

[dpdk-dev] [PATCH v6 1/2] net/i40e: i40e get link status update from ipn3ke

2019-07-10 Thread Andy Pei
Add switch_mode argument for i40e PF to specify the specific FPGA that i40e PF is connected to. i40e PF get link status update via the connected FPGA. Add bool switch_ethdev_support_flag to struct i40e_pf to specify if there are switch_mode argues in cmd. Add switch_ethdev to struct i40e_pf to trac

Re: [dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-10 Thread Ray Kinsella
Acked-by: Ray Kinsella On 10/07/2019 05:16, Qi Zhang wrote: > Safe mode support is not necessary by default. > Driver be initialized without OS package silently may confuse users > since most advanced feature are disabled. > Add devarg for safe mode enabling only for when user intend to do this.

Re: [dpdk-dev] [PATCH] doc: update release notes for OCTEON TX2 support

2019-07-10 Thread Thomas Monjalon
09/07/2019 15:35, jer...@marvell.com: > From: Jerin Jacob > > Update release notes for various OCTEON TX2 drivers supported for 19.08. > > Signed-off-by: Jerin Jacob Applied with changes to make drivers list simpler, thanks.

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Olivier Matz
Hi Yongseok, On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote: > Currently, metadata can be set on egress path via mbuf tx_meatadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_RX_META matches metadata. > > This patch extends the usability. > > 1) RTE_FLOW_ACTION_TYPE_SE

[dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-10 Thread Olivier Matz
Many features require to store data inside the mbuf. As the room in mbuf structure is limited, it is not possible to have a field for each feature. Also, changing fields in the mbuf structure can break the API or ABI. This commit addresses these issues, by enabling the dynamic registration of fiel

  1   2   >