On 6/24/2019 6:30 AM, Thomas Monjalon wrote: > 20/06/2019 15:32, Pattan, Reshma: >> From: Suanming.Mou [mailto:mousuanm...@huawei.com] >>> Signed-off-by: Suanming Mou <mousuanm...@huawei.com> >>> Reviewed-by: Anatoly Burakov <anatoly.bura...@intel.com> >>> Reviewed-by: Vipin Varghese <vipin.vargh...@intel.com> >>> Reviewed-by: Reshma Pattan <reshma.pat...@intel.com> >>> Reviewed-by: Thomas Monjalon <tho...@monjalon.net> >>> --- >>> V9: >>> * reword the comments and update the git log. >>> * move release note to release_19_08.rst. >>> * remove dot in name. >>> >> Acked-by line is missing, so re acking. Keep my ack if you have to send next >> version. >> Acked-by: Reshma Pattan <reshma.pat...@intel.com> > That's not correct to add Reviewed-by lines if it was not explicitly > found in a previous reply. > Suanming, I think you need to remove some lines above. > > > > Hi Thomas,
Thanks for the guidelines. Yes, the tags should be as below since just Anatoly gave the Reviewed-by tag and Reshma gave the Acked-by tag in the previous mail. Reviewed-by: Anatoly Burakov <anatoly.bura...@intel.com> Acked-by: Reshma Pattan reshma.pat...@intel.com Sorry for the mistake and the late response. (I wish my thunderbird would correctly handle the In-Reply-To header by direct click the mailto link.) BR SuanmingMou