10/04/2019 23:45, Pradeep Satyanarayana:
>
> > > The IBM Power team is not idle in this area. There's ongoing work to
> > > enable DTS on Power systems.
> >
> > Good to read there is some work in the pipe.
> > I can remember the first emails (in 2015) talking about some automated
> > tests for co
Hi Yongseok,
>-Original Message-
>From: Yongseok Koh
>Sent: Wednesday, April 10, 2019 11:08 PM
>To: Pavan Nikhilesh Bhagavatula
>Cc: Thomas Monjalon ; dev ; Jerin
>Jacob Kollanukkaran ; jerinjac...@gmail.com
>Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support
>machi
From: Eduard Serra
This patch introduces:
- VMxnet3 v4 negotiation and,
- entirely guest-driven UDP RSS support.
VMxnet3 v3 already has UDP RSS support, however it
depends on hypervisor provisioning on the VM through
ESX specific flags, which are not transparent or known
to the guest later on.
Hi Paul,
Thank you for your feedback.
> -Original Message-
> From: Paul E. McKenney
> Sent: Wednesday, April 10, 2019 1:15 PM
> To: Honnappa Nagarahalli
> Cc: konstantin.anan...@intel.com; step...@networkplumber.org;
> marko.kovace...@intel.com; dev@dpdk.org; Gavin Hu (Arm Techno
On 04/10, David Marchand wrote:
>On Wed, Apr 10, 2019 at 12:58 PM Xiaolong Ye wrote:
>
>> Since tx callback only picks mbufs that can be copied to the xdp desc, it
>> should call xsk_ring_prod__submit with valid count other than nb_pkts.
>>
>> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD
> -Original Message-
> From: Li Qiang [mailto:liq...@163.com]
> Sent: Wednesday, April 10, 2019 21:43
> To: Xu, Rosen ; Zhang, Tianfei
>
> Cc: dev@dpdk.org; liq...@gmail.com; Li Qiang
> Subject: [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
>
> In rte_fpga_do_pr() fu
David Hunt :
> A for loop to MAX_VFS had a break as the last line, so the w++
> would never get called, breaking out of the loop after the
> first iteration. Remove the break so that the loop can execute
> properly.
>
> Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
> Coveri
On Wed, 10 Apr 2019 22:00:18 +0100
Bruce Richardson wrote:
> On Wed, Apr 10, 2019 at 03:16:16PM -0500, David Christensen wrote:
> > The function eth_dev_pci_specific_init is missing a typecast to
> > (struct rte_pci_device *) for the input argument bus_device.
> >
> > Cc: sta...@dpdk.org
> >
>
Stephen Hemminger :
> Minor spelling errors found with aspell.
>
> Signed-off-by: Stephen Hemminger
> --
>
Acked-by: Rami Rosen
>
> When using libpcap libraries the error "multiple definition of
> 'bpf_validate'" is observed. Rename the DPDK version to rte_bpf_validate
> to be more consistenet with other DPDK defined functions.
As I already ask Vivian, before we proceed any further with that patch
could you provide som
The function eth_dev_pci_specific_init is missing a typecast to
(struct rte_pci_device *) for the input argument bus_device.
This causes build issues in the GNU C++ compiler.
[CXX] g++ -o utils/pcap_handle.o -c utils/pcap_handle.cc -g3·
-ggdb3 -mcpu=native -mtune=native -isystem·
/home/rchir
Added documentation for Windows support on 19.05 release.
Signed-off-by: Pallavi Kadam
Reviewed-by: Anand Rawat
---
doc/guides/rel_notes/release_19_05.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_notes/release_19_05.rs
> > This patch implements the changes proposed in the deprecation
> > note[1]. Replace multiple color definitions in various places such as
> > rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
> > in rte_meter.h.
> >
> > This is simple search and replace exercise without any imple
10/04/2019 22:58, David Christensen:
> > This is a duplicate of this patch:
> >
> > https://patches.dpdk.org/patch/52505/
> >
> > You are from 2 different Linux teams at IBM,
> > you hit the same issue at the same time,
> > you both miss to give an explanation,
> > funny.
>
> We both work for in
The IBM Power team is not idle in this area. There's ongoing work to
enable DTS on Power systems.
Good to read there is some work in the pipe.
I can remember the first emails (in 2015) talking about some automated
tests for compilation and unit tests on IBM Power.
We are still seeing some compi
On Wed, Apr 10, 2019 at 03:16:16PM -0500, David Christensen wrote:
> The function eth_dev_pci_specific_init is missing a typecast to
> (struct rte_pci_device *) for the input argument bus_device.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Christensen
> Tested-by: Radhika Chirra
> ---
> l
This is a duplicate of this patch:
https://patches.dpdk.org/patch/52505/
You are from 2 different Linux teams at IBM,
you hit the same issue at the same time,
you both miss to give an explanation,
funny.
We both work for infrastructure teams who are supporting a project team
that is developin
Older versions of GCC, such as on Redhat/CentOS 7, don't support
-march=nehalem, but need -march=corei7 instead.
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
devtools/test-meson-builds.sh | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/devtools/test-meson-bui
The use of "==" is non-standard extension from bash, so use "="
for comparisons instead.
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
devtools/test-meson-builds.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-mes
In order to ensure good test coverage, we sometimes need to run builds
on distros with older compilers, such as gcc 4.8 on RHEL/Centos 7. This
patchset does a small amount of clean-up to test-meson-builds.sh script
to allow it to be used for such gcc builds.
Bruce Richardson (3):
devtools/test-m
if either gcc or clang are missing, skip doing those builds.
This allows a setup to only do, e.g. gcc tests.
CC: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
devtools/test-meson-builds.sh | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/devtools/test-meson-bu
Sorry what I meant to say is that we have no control over what Power team
will do in terms on CI. And yes I will definitely reach out to them to see
what their plans are.
Regards,
Vivian Kong
Linux on IBM Z Open Source Ecosystem
IBM Canada Toronto Lab
Thomas Monjalon wrote on 2019/04/10 03:46:
10/04/2019 22:31, David Christensen:
> >>> Second question: How is it tested? Do you have any CI?
> >>
> >> We ran the tests by "make tests". We don't have CI set up at the moment
> >> but this is definitely something we are looking into adding.
> >>
> > Please help with IBM Power CI at the same t
Second question: How is it tested? Do you have any CI?
We ran the tests by "make tests". We don't have CI set up at the moment
but this is definitely something we are looking into adding.
Please help with IBM Power CI at the same time.
I would like to see some progress on this front
before in
10/04/2019 22:16, David Christensen:
> The function eth_dev_pci_specific_init is missing a typecast to
> (struct rte_pci_device *) for the input argument bus_device.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Christensen
> Tested-by: Radhika Chirra
This is a duplicate of this patch:
htt
The function eth_dev_pci_specific_init is missing a typecast to
(struct rte_pci_device *) for the input argument bus_device.
Cc: sta...@dpdk.org
Signed-off-by: David Christensen
Tested-by: Radhika Chirra
---
lib/librte_ethdev/rte_ethdev_pci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
> > From: Jerin Jacob
> >
> > Use CRC32 instruction only when it is available to avoid
> > the build issue like below.
> >
> > {standard input}:16: Error:
> > selected processor does not support `crc32cx w3,w3,x0'
> >
> > Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
> > C
10/04/2019 21:15, Vivian Kong:
> Thomas Monjalon wrote on 2019/04/10 01:43:34 PM:
> > Please help with IBM Power CI at the same time.
> > I would like to see some progress on this front
> > before integrating a new IBM CPU.
>
> For Power CI, not sure how we can help as it is done by another team
For client_server_mp, the total number of buffers for the mbuf mempool
should be correctly calculated. Otherwise, having more clients will stop
traffic.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Yongseok Koh
---
v2:
* split up the calculation
examples/mul
When using libpcap libraries the error "multiple definition of
'bpf_validate'" is observed. Rename the DPDK version to rte_bpf_validate
to be more consistenet with other DPDK defined functions.
Cc: sta...@dpdk.org
Signed-off-by: David Christensen
Tested-by: Radhika Chirra
---
lib/librte_bpf/b
Thanks for the links! I'll go through them.
For Power CI, not sure how we can help as it is done by another team. If
s390x is added, we plan on mainta
> On Apr 10, 2019, at 10:50 AM, Ferruh Yigit wrote:
>
> On 4/10/2019 12:13 AM, Yongseok Koh wrote:
>> UAR (User Access Region) register does not need to be remapped for primary
>> process but it should be remapped only for secondary process. UAR register
>> table is in the process private struc
UAR (User Access Region) register does not need to be remapped for primary
process but it should be remapped only for secondary process. UAR register
table is in the process private structure in rte_eth_devices[],
(struct mlx4_proc_priv *)rte_eth_devices[port_id].process_private
The actual
Queue index is redundantly stored for both Rx and Tx structures.
E.g. txq_ctrl->idx and txq->stats.idx. Both are consolidated to single
storage - rxq->idx and txq->idx.
Also, rxq and txq are moved to the beginning of its control structure
(rxq_ctrl and txq_ctrl) for cacheline alignment.
Signed-of
UAR (User Access Region) register does not need to be remapped for primary
process but it should be remapped only for secondary process. UAR register
table is in the process private structure in rte_eth_devices[],
(struct mlx5_proc_priv *)rte_eth_devices[port_id].process_private
The actual
mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively.
Signed-off-by: Yongseok Koh
Acked-by: Shahaf Shuler
---
drivers/net/mlx5/mlx5.h| 1 -
drivers/net/mlx5/mlx5_flow.c | 5 +++--
drivers/net/mlx5/mlx5_flow_dv.c| 4 +++-
drivers/net/mlx5/mlx5_flow_verbs.
This patchset lifts the requirement of reserving huge virtual address space
and remapping device UAR register on to it in order to use the same address
between primary and secondary process.
v5:
* fix 32-bit build issue
* remove MLX[4|5]_UAR_SIZE and MLX[4|5]_UAR_OFFSET
v4:
* add mlx4_proc_priv_[
Signed-off-by: Stephen Hemminger
---
drivers/net/qede/qede_filter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
index 5e6571ca647d..7aeef700dad4 100644
--- a/drivers/net/qede/qede_filter.c
+++ b/drivers/net/qede/qede_filter.c
Signed-off-by: Stephen Hemminger
---
drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c | 1 -
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c
b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev
Signed-off-by: Stephen Hemminger
---
drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map
b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index 60b81b2989c3..e86007384ab6 100644
--- a/drivers/bus/fslmc/rte_bus_fs
Bad style and git complains about blank line at EOF
Signed-off-by: Stephen Hemminger
---
drivers/net/atlantic/atl_ethdev.c | 1 -
drivers/net/atlantic/atl_rxtx.c | 1 -
drivers/net/atlantic/hw_atl/hw_atl_b0.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/net/atlantic
Signed-off-by: Stephen Hemminger
---
lib/librte_vhost/iotlb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c
index c6354fef7e65..fcf9e9861afd 100644
--- a/lib/librte_vhost/iotlb.c
+++ b/lib/librte_vhost/iotlb.c
@@ -361,4 +361,3 @@ vhost_user
Ran script that looks for extra whitespace (what git and checkpatch
complain about). Found several trival cases of extra line at
end of file.
Stephen Hemminger (5):
vhost: eliminate blank line at EOF
net/atlantic: remove extra blank line at EOF
bus/fslmc: remove blank line at EOF
raw/ifpga
On 4/10/2019 7:59 AM, Shahaf Shuler wrote:
> Monday, April 8, 2019 3:43 PM, Ori Kam:
>> Subject: [PATCH] net/mlx5: fix cross compilation on aarch64
>>
>> In case of cross compilation on aarch64 we must add include for stdlib in
>> order to use the free function.
>>
>> Fixes: cbb66daa3c85 ("net/mlx
On 4/10/2019 7:58 AM, Shahaf Shuler wrote:
> Monday, April 8, 2019 9:23 PM, Yongseok Koh:
>> Subject: [dpdk-dev] [PATCH] net/mlx4: fix Tx doorbell register unmap
>>
>> If rdma-core library doesn't support remapping UAR registers, the register
>> shouldn't be unmapped on device stop.
>>
>> Fixes: 02
On 4/10/2019 12:13 AM, Yongseok Koh wrote:
> UAR (User Access Region) register does not need to be remapped for primary
> process but it should be remapped only for secondary process. UAR register
> table is in the process private structure in rte_eth_devices[],
> (struct mlx5_proc_priv *)rte
On 4/10/2019 7:58 AM, Shahaf Shuler wrote:
> Wednesday, April 10, 2019 2:13 AM, Yongseok Koh:
>> Subject: [PATCH v4 0/4] net/mlx: remove device register remap
>>
>> This patchset lifts the requirement of reserving huge virtual address space
>> and remapping device UAR register on to it in order to
Minor spelling errors found with aspell.
Signed-off-by: Stephen Hemminger
---
doc/guides/testpmd_app_ug/run_app.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/testpmd_app_ug/run_app.rst
b/doc/guides/testpmd_app_ug/run_app.rst
index b717b8c7b742..278fc24a4
10/04/2019 19:09, Vivian Kong:
> Hi Thomas,
>
> Thanks for your comments. Please see my answers to your questions below.
>
> > First question: What is the use case of DPDK on s390x?
>
> IBM would like to use DPDK in our new IBM cloud offering on Z.
>
>
>
> > Second question: How is it tested
The l3fwd example should use the IPv4 addresses defined in RFC5735 and
the IPv6 addresses defined in RFC5180 for the L3 forwarding example
Longest Prefix Match table.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd/l3fwd_lpm.c | 34 ++
1 file changed, 18 inser
The IP addresses should be formatted using standard routines
rather than outputing in raw hex.
Signed-off-by: Stephen Hemminger
Acked-by: Bernard Iremonger
---
examples/l3fwd/l3fwd_lpm.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/examples/l3fwd/l3fwd_lp
This patch changes what testpmd uses as IP addresses when
run in transmit only mode. The old code was using
192.168.0.1 -> 192.168.0.2
but these addresses are reserved for private Internet by RFC 1918.
The new code uses 192.18.0.1 and 192.18.0.2 which are on the
subnet reserved for performance tes
These patches get rid of the custom addresses used in testpmd
and l3fwd, and instead uses values that are reserved for testing
in the relevant RFC 2544.
This version fixes some formatting and long lines.
Stephen Hemminger (3):
app/testpmd: add ability to set Tx IP and UDP parameters
examples/
> On Apr 10, 2019, at 9:13 AM, jerinjac...@gmail.com wrote:
>
> From: Pavan Nikhilesh
>
> Currently, RTE_* flags are set based on the implementer ID but there might
> be some micro arch specific differences from the same vendor
> eg. CACHE_LINESIZE. Add support to set micro arch specific flags
Jerin Jacob Kollanukkaran writes:
> On Wed, 2019-04-10 at 11:52 -0400, Aaron Conole wrote:
>> Jerin Jacob Kollanukkaran writes:
>>
>> > On Mon, 2019-04-08 at 14:24 -0400, Aaron Conole wrote:
>> > > ---
>> > >
>> > > ---
>> > > Com
Don't refer to lcore_config directly.
Signed-off-by: Stephen Hemminger
Reviewed-by: David Marchand
---
app/test/test_cryptodev.c | 2 +-
app/test/test_hash_readwrite_lf.c | 14 +++---
app/test/test_ring_perf.c | 22 --
app/test/test_stack_perf.c
Referring to lcore_config directly is no longer recommended.
Signed-off-by: Stephen Hemminger
---
examples/bond/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/examples/bond/main.c b/examples/bond/main.c
index ef86194fff4a..b047ab23f01d 100644
--- a/examples/bond/
The lcore_config structure will be hidden in future release.
Signed-off-by: Stephen Hemminger
Reviewed-by: David Marchand
---
drivers/bus/dpaa/dpaa_bus.c | 6 --
drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/dr
The fields of the internal EAL core configuration are currently
laid bare as part of the API. This is not good practice and limits
fixing issues with layout and sizes.
Make new accessor functions for the fields used by current drivers
and examples. Mark return code functions as experimental
since
Purely cosmetic change, use unsigned int instead of unsigned alone.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/common/include/rte_lcore.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_lcore.h
b/lib/librte_eal/common/i
This set of patches makes the lcore_config structure less visible
as part of the ABI. This version does not break the ABI (yet)
follow on patch moves lcore_config into eal_private.h
The changes in v2 is to:
- new patch to use unsigned int in lcore.h first
- incorporate feedback from David
- do
Hmm...we weren't able to compile without the cast. I'll take a closer
look. Thanks.
Regards,
Vivian Kong
Linux on IBM Z Open Source Ecosystem
IBM Canada Toronto Lab
Thomas Monjalon wrote on 2019/04/09 04:14:08 PM:
> From: Thomas Monjalon
> To: vivk...@ca.ibm.com
> Cc: dev@dpdk.org
> Date: 2
Hi Thomas,
Thanks for your comments. Please see my answers to your questions below.
> First question: What is the use case of DPDK on s390x?
IBM would like to use DPDK in our new IBM cloud offering on Z.
> Second question: How is it tested? Do you have any CI?
We ran the tests by "make test
On 04/03/2019 16:58, Ferruh Yigit wrote:
> On 3/2/2019 10:42 AM, Hyong Youb Kim wrote:
>> Inner packet matching is currently buggy in many cases.
>>
>> 1. Mishandling null spec ("match any").
>> The copy_item functions do nothing if spec is null. This is incorrect,
>> as all patterns should be appe
Hi Thomas,
I haven't figured out how to send out patches via Notes so I sent them via
Gmail server. I set up "git send-email" to send as my IBM email but Gmail
changed that when the patches get sent out. I have to see if there are
another server I can use to send patches.
Right I don't expect
I'll look into adding that. Thanks.
Regards,
Vivian Kong
Linux on IBM Z Open Source Ecosystem
IBM Canada Toronto Lab
Luca Boccassi wrote on 2019/04/09 03:38:45 PM:
> From: Luca Boccassi
> To: vivk...@ca.ibm.com, dev@dpdk.org
> Date: 2019/04/09 03:38 PM
> Subject: Re: [dpdk-dev] [RFC 01/12] m
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Thursday, April 4, 2019 11:56 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal,
> ArkadiuszX
>
> Subject: [PATCH] doc/crypto: add supported asymmetric crypto algorithms to qat
>
> This patch adds missing a
Hi Fiona,
> > Subject: RE: [PATCH] crypto/qat: fix segmentation fault in QAT PMD
> >
> > Hi Bernard,
> >
> > >
> > > While running the IPsec unit test program the following segmentation
> > > fault is occurring:
> > >
> > > Thread 1 "test" received signal SIGSEGV, Segmentation fault.
> > > 0x0
> Subject: Re: [PATCH v4 2/3] test/rcu_qsbr: add API and functional tests
>
> On Wed, 10 Apr 2019 06:20:05 -0500
> Honnappa Nagarahalli wrote:
>
> > From: Dharmik Thakkar
> >
> > Add API positive/negative test cases, functional tests and performance
> > tests.
> >
> > Signed-off-by: Malvika Gup
From: Jerin Jacob
Optimized configuration for Marvell octeontx2 SoC.
Updated meson build to support Marvell octeontx2 SoC.
Added meson cross build target for octeontx2.
Signed-off-by: Jerin Jacob
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Gavin Hu
---
config/arm/arm64_octeontx2_linux_gcc
From: Jerin Jacob
Optimized configuration for Marvell thunderx2 SoC.
Updated meson build to support Marvell thunderx2 SoC.
Added meson cross compile target.
Product details are here:
https://www.marvell.com/server-processors/thunderx2-arm-processors/
Signed-off-by: Jerin Jacob
Signed-off-by:
From: Pavan Nikhilesh
Currently, RTE_* flags are set based on the implementer ID but there might
be some micro arch specific differences from the same vendor
eg. CACHE_LINESIZE. Add support to set micro arch specific flags.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Jerin Jacob
---
config/
From: Jerin Jacob
Introduce rte_cc_has_argument() Makefile helper to
check a given argument is support by the compiler.
Example Usage:
include $(RTE_SDK)/mk/rte.helper.mk
MACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeontx2)
This would allow adding -mcpu=octeontx2 in MACHINE_CFLAGS
if
On Wed, 2019-04-10 at 11:52 -0400, Aaron Conole wrote:
> Jerin Jacob Kollanukkaran writes:
>
> > On Mon, 2019-04-08 at 14:24 -0400, Aaron Conole wrote:
> > > ---
> > >
> > > ---
> > > Compiler complains of argument type mismatch, li
Jerin Jacob Kollanukkaran writes:
> On Mon, 2019-04-08 at 14:24 -0400, Aaron Conole wrote:
>> ---
>> ---
>> Compiler complains of argument type mismatch, like:
>
> Can you share more details on how to reproduce this issue?
It will b
On Wed, 10 Apr 2019 06:20:05 -0500
Honnappa Nagarahalli wrote:
> From: Dharmik Thakkar
>
> Add API positive/negative test cases, functional tests and
> performance tests.
>
> Signed-off-by: Malvika Gupta
> Signed-off-by: Dharmik Thakkar
> Signed-off-by: Honnappa Nagarahalli
> Reviewed-by: G
No need to add additional vlan tag size for max packet size, since
for i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already
includes the vlan header size.
Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup")
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: sta...@dpdk.org
On Wed, Apr 10, 2019 at 02:44:05AM +, Chenbo Xia wrote:
Fix unchecked return value for fcntl.
Coverity issue: 277210
Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
Cc: sta...@dpdk.org
Signed-off-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost_user.c | 5 -
1 file c
> -Original Message-
> From: Lu, Wenzhuo
> Sent: Wednesday, April 10, 2019 3:29 PM
> To: Zhang, Qi Z ; Xing, Beilei
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Yigit, Ferruh ; Zhang, Qi Z ;
> sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling
>
> Hi Q
> -Original Message-
> From: Lu, Wenzhuo
> Sent: Wednesday, April 10, 2019 3:26 PM
> To: Zhang, Qi Z ; Yang, Qiming
> Cc: dev@dpdk.org; Yigit, Ferruh
> Subject: RE: [PATCH] net/ice: fix max frame size
>
> Hi,
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Wednesday,
> -Original Message-
> From: Richardson, Bruce
> Sent: Wednesday, April 10, 2019 2:45 PM
> To: Ananyev, Konstantin ; acon...@redhat.com
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: [PATCH 2/2] bpf: remove use of weak functions
>
> Weak functions don't work well with static librarie
> -Original Message-
> From: Richardson, Bruce
> Sent: Wednesday, April 10, 2019 2:45 PM
> To: Ananyev, Konstantin ; acon...@redhat.com
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: [PATCH 1/2] acl: remove use of weak functions
>
> Weak functions don't work well with static librarie
Use strlcpy instead of strcpy to fix string overflow.
Coverity issue: 337671
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: david.h...@intel.com
CC: sta...@dpdk.org
Signed-off-by: Reshma Pattan
---
examples/vm_power_manager/channel_monitor.c | 3 ++-
1 file changed, 2 insert
If that is the case, then probably a reference to MAINTAINERS should be
mentioned in the documentation
because there are a lot more other stuff(beyond PMDs) in DPDK where people can
contribute and for that people need to
look into MAINTAINERS anyway.
Hi Akhil,
Thanks for your response. It seems
Hi Akhil,
Thanks for your response. It seems to me though that the MAINTAINER file is
not really part of the documentation,
it is more of a reference type of file. Not sure that new DPDK developers
will know to look in it for this type of information.
I will send V2 of the patch and add event and
On Mon, 2019-04-08 at 14:24 -0400, Aaron Conole wrote:
> ---
> ---
> Compiler complains of argument type mismatch, like:
Can you share more details on how to reproduce this issue?
We already have
CFLAGS_acl_run_neon.o += -flax-vector
Hi Fiona,
>[Fiona] Good idea to add this patch. However despite the name crypto is
actual broader so maybe
>"If you add a new crypto or compression PMD "
Thanks for this feedback, I will fix it in V2 of the patch.
Regards,
Rami Rosen
On Wed, Apr 10, 2019 at 10:07:33AM -0400, Aaron Conole wrote:
> Bruce Richardson writes:
>
> > Weak functions don't work well with static libraries and require the use of
> > "whole-archive" flag to ensure that the correct function is used when
> > linking. Since the weak function is only used a
>-Original Message-
>From: Yongseok Koh
>Sent: Wednesday, April 10, 2019 7:45 AM
>To: jerinjac...@gmail.com; Pavan Nikhilesh Bhagavatula
>
>Cc: Thomas Monjalon ; dev ; Jerin
>Jacob Kollanukkaran
>Subject: [EXT] Re: [dpdk-dev] [PATCH v7 2/4] meson: add infra to support
>machine specific
Hi Fiona,
> > > Subject: [PATCH] crypto/qat: fix second seg fault in QAT PMD
> > >
> > > While running the IPsec unit tests the following segmentation fault
> > > is
> > > occurring:
> > >
> > > Thread 1 "test" received signal SIGSEGV, Segmentation fault.
> > > 0x00bf3b50 in qat_sym_proc
On 4/10/2019 11:55 AM, Burakov, Anatoly wrote:
> On 10-Apr-19 8:52 AM, Ferruh Yigit wrote:
>> On 4/9/2019 3:40 PM, Hunt, David wrote:
>>>
>>> On 9/4/2019 12:18 PM, Burakov, Anatoly wrote:
On 09-Apr-19 10:22 AM, David Hunt wrote:
> A previous change removed the limit of 64 cores by
> mo
On 4/10/2019 12:12 PM, Gagandeep Singh wrote:
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Monday, April 8, 2019 6:47 PM
>> To: Gagandeep Singh ; dev@dpdk.org
>> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing mode
>>
>> WARNING: This email was created outsi
Bruce Richardson writes:
> On Wed, Apr 10, 2019 at 09:54:02AM -0400, Aaron Conole wrote:
>> Bruce Richardson writes:
>>
>> > Weak functions don't work well with static libraries and require the
>> > use of "whole-archive" flag to ensure that the correct function is used
>> > when linking. Since
Bruce Richardson writes:
> Weak functions don't work well with static libraries and require the use of
> "whole-archive" flag to ensure that the correct function is used when
> linking. Since the weak function is only used as a placeholder within this
> library alone, we can replace it with a no
Hi Phil,
On 8/4/2019 4:02 AM, Phil Yang wrote:
'__sync' built-in functions are deprecated, should use the '__atomic'
built-in instead. the sync built-in functions are full barriers, while
atomic built-in functions offer less restrictive one-way barriers,
which help performance.
Here is the exam
On Wed, Apr 10, 2019 at 09:54:02AM -0400, Aaron Conole wrote:
> Bruce Richardson writes:
>
> > Weak functions don't work well with static libraries and require the
> > use of "whole-archive" flag to ensure that the correct function is used
> > when linking. Since the weak functions are only used
Hello David,
I can merge these fixes and run our system using patched DPDK version. Then
report back any problems / improvements I observe. I can also walk through
source code changes and check for anything questionable.
Unfortunately I lack deep enough understanding of DPDK source code to test
t
In rte_fpga_do_pr() function, if 'stat' return error the
'file_fd' is never closed thus leading a fd leak. This patch
avoids this.
Spotted by Coverity: CID 27441
Signed-off-by: Li Qiang
---
Changes since v1: fill ret before goto close_fd per Rosen's review
drivers/raw/ifpga_rawdev/ifpga_rawdev
On Skylake platform, with native build, KNI kernel module crashes
because of the corrupted values passed to kernel module.
The corruption occurs because the userspace kni library works
unexpectedly. Compiler [1] is using AVX512 instructions and generated
binary is wrong [2].
It turned around gcc
The '-mno-avx512f' compiler flag is not passed to the compiler,
detection of the binutils and setting flags works fine, but the flag
itself not used by compiler.
Removing the interim 'march_opt' variable and using directly
'machine_args' and setting '-mno-avx512f' to 'machine_args'
Fixes: 566b4d7
1 - 100 of 200 matches
Mail list logo
