[dpdk-dev] [PATCH] net/enic: fix raw item length check

Currently, the raw item is always preceeded by a UDP header, and both land in the L4 pattern buffer. So consider the UDP header size when checking if the raw spec fits in the L4 buffer. Coverity issue: 336796 Coverity issue: 336850 Fixes: 477959e6eeb0 ("net/enic: enable limited support for raw flo

Re: [dpdk-dev] [PATCH v7 2/2] doc: add guide for debug and troubleshoot

snipped > > > > Would like me to send a v8 or can the v7 be accepted with quotes removed > while merge? > > No Vipin, you need to add quotes everywhere in the doc for the code symbols. > > Thanks, shared v8

[dpdk-dev] [PATCH v8 0/2] guide to debug and troubleshoot.

The patch series adds a how-to guide for debugging and troubleshooting tips. Motivation == DPDK proc-info tool is been enhanced to accommodate the debug information for the port, traffic manager crypto, ring and mempool contents. With these additional information, it becomes easy to analy

[dpdk-dev] [PATCH v8 2/2] doc: add guide for debug and troubleshoot

Add user guide on debugging and troubleshooting for common issues and bottleneck found in the sample application model. Signed-off-by: Vipin Varghese Acked-by: Marko Kovacevic Acked-by: John McNamara --- doc/guides/howto/debug_troubleshoot_guide.rst | 464 ++ doc/guides/howto/i

[dpdk-dev] [PATCH v8 1/2] doc: add svg for debug and troubleshoot guide

Add svg images for debug and troubleshoot guide. Signed-off-by: Vipin Varghese Acked-by: Marko Kovacevic Acked-by: John McNamara --- doc/guides/howto/img/dtg_consumer_ring.svg| 24 doc/guides/howto/img/dtg_crypto.svg | 21 .../howto/img/dtg_distributor_worker.svg

[dpdk-dev] [PATCH] crypto/caam_jr: fix memory leak and illegal memory access

Opendir() returns allocated storage which must be freed at the end of function or in case any return on error. so freeing the allocation using closedir in an error case. Coverity issue: 323507 Coverity issue: 325880 Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specific operations") Cc: g.si...@nx

Re: [dpdk-dev] [PATCH v3 2/5] examples/vhost_scsi: fix missing NULL-check for parameter

On Mon, Apr 08, 2019 at 10:46:37AM +0100, Bruce Richardson wrote: > Coverity points out that there is a check in the main thread loop for the > ctrlr->bdev being NULL, but by that stage the pointer has already been > dereferenced. Therefore, for safety, before we enter the loop do an > initial chec

[dpdk-dev] DPDK Windows Community call - 04 April 2019

Attendees: Thomas (tho...@monjalon.net) Eilon (eil...@mellanox.com) Raslan (rasl...@mellanox.com) Harini (harini.ramakrish...@microsoft.com) Bruce (bruce.richard...@intel.com) Cathal (cathal.oh...@intel.com) Anand (anand.ra...@intel.com) Pallavi (pallavi.ka...@intel.com) Ranjit (ranjit.me...@intel

Re: [dpdk-dev] [PATCH 0/3] librte_acl: fixes related to testing with the meson build

Aaron Conole writes: > This series fixes the following conditions in the RTE_ACL library: > > 1. Fix outstanding compilation issues on ARM with the NEON optimized code > These consisted mostly of compiler type-cast warnings. Additionally, > some > of the vector code didn't initializ

Re: [dpdk-dev] [PATCH v8 3/3] test/ticketlock: add ticket lock test case

On Mon, Mar 25, 2019 at 12:12 PM Joyce Kong wrote: > diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py > index 5f87bb9..db25274 100644 > --- a/app/test/autotest_data.py > +++ b/app/test/autotest_data.py > @@ -171,6 +171,12 @@ > "Report": None, > }, > { > +

Re: [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1

On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > Build error seen with Linux kernel 5.1 and > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > Build error: > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > error: initialization of ... from incompatible pointer type ...

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix coherency of ESP sequence number

On Mon, Apr 08, 2019 at 10:41:29AM +, Ananyev, Konstantin wrote: > > Hi Yongseok, > > > Outbound ESP sequence number should be incremented atomically and refeenced > > indirectly. Otherwise, concurrent access by multiple threads will break > > coherency. > > I think MT mode per SA is not sup

[dpdk-dev] [PATCH v1 5/5] eal: make lcore_config private

The internal structure of lcore_config should not be part of visible API/ABI. Make it private to EAL. Rearrange and resize the fields in the structure so it takes less memory (and cache footprint). THIS BREAKS ABI OF PREVIOUS RELEASES. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common

[dpdk-dev] [PATCH v1 4/5] app/test: use lcore accessor functions

Use the new accessor functions. Don't refer to lcore_config directly. Signed-off-by: Stephen Hemminger --- app/test/test_cryptodev.c | 2 +- app/test/test_hash_readwrite_lf.c | 14 +++--- app/test/test_ring_perf.c | 22 -- app/test/test_stack_perf.c

[dpdk-dev] [PATCH v1 1/5] eal: add accessor functions for lcore_config

The fields of the internal EAL core configuration are currently laid bare as part of the API. This is not good practice and limits fixing issues with layout and sizes. Make new accessor functions for the fields used by current drivers and examples. Mark the state and return code functions as exper

[dpdk-dev] [PATCH v1 0/5] make lcore_config internal

This set of patches makes the lcore_config structure internal to EAL and not part of the ABI. It supersedes earlier RFC. The first 4 would go into current release, and the last would go into later release to make it fully internal. The same should be done for rte_config, but that is more difficul

[dpdk-dev] [PATCH v1 3/5] examples/bond: use lcore accessor

Use the accessor function to look at lcore state. Signed-off-by: Stephen Hemminger --- examples/bond/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/bond/main.c b/examples/bond/main.c index ef86194fff4a..48e6755ea294 100644 --- a/examples/bond/main.c +++ b

[dpdk-dev] [PATCH 3/3] acl: adjust the tests

This makes the tests pass, and also ensures that on platforms where the testing is supported, we can properly test the implementation specific code. One edge case is when we run on x86_64 systems that don't support AVX2, but where the compiler can generate such instructions. That could be an enha

[dpdk-dev] [PATCH v1 2/5] bus: use lcore accessor functions

Fix the bus logic in fslmc and dpaa drivers to use the new accessor functions. Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c | 6 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/bus/d

[dpdk-dev] [PATCH 1/3] acl: fix arm argument types

Compiler complains of argument type mismatch, like: ../lib/librte_acl/acl_run_neon.h: In function ‘transition4’: ../lib/librte_acl/acl_run_neon.h:115:2: note: use -flax-vector-conversions to permit conversions between vectors with differing element types or numbers of subparts

[dpdk-dev] [PATCH 2/3] acl: update the build for multi-arch

For the introduction of the meson build, the build file for the ACL library architecture specific files was not ported. This means the compiler didn't know about the optimized versions when building the RTE_ACL library for each architecture. Now hook up the different architecures by checking the

[dpdk-dev] [PATCH 0/3] librte_acl: fixes related to testing with the meson build

This series fixes the following conditions in the RTE_ACL library: 1. Fix outstanding compilation issues on ARM with the NEON optimized code These consisted mostly of compiler type-cast warnings. Additionally, some of the vector code didn't initialize memory properly. 2. Properly i

[dpdk-dev] [PATCH] net/mlx4: fix Tx doorbell register unmap

If rdma-core library doesn't support remapping UAR registers, the register shouldn't be unmapped on device stop. Fixes: 0203d33a1059 ("net/mlx4: support secondary process") Signed-off-by: Yongseok Koh --- drivers/net/mlx4/mlx4.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH] net/sfc: set min and max MTU

On 4/8/2019 3:04 PM, Andrew Rybchenko wrote: > Advertise minimum and maximum MTU value in device information. > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] kni: implement header_ops parse method

Hi Ferruh, Can we proceed with this patch? Igor On Thu, Jan 24, 2019 at 9:05 PM Igor Ryzhov wrote: > Hi Ferruh, > > Ok, no problem. Generally, it is needed for all applications using > packet(7) interface, running over KNI interfaces. > More specifically, one example of such application is FRR

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: close sockfd before return if errors

On 4/8/2019 12:02 PM, Alejandro Lucero wrote: > Not closing the socket implies a resource leak. > > Coverity issue: 336865 > Fixes: 29a62d1476b6 ("net/nfp: add CPP bridge as service") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] crypto/qat: fix second seg fault in QAT PMD

Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Monday, April 8, 2019 5:44 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin ; akhil.go...@nxp.com > Cc: Trahe, Fiona > Subject: RE: [PATCH] crypto/qat: fix second seg fault in QAT PMD > > Hi Bernard, > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix resource leak

On 4/8/2019 11:49 AM, Alejandro Lucero wrote: > Coverity issue: 32806 > Fixes: ef28aa96e53b ("net/nfp: support multiprocess") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] crypto/qat: fix second seg fault in QAT PMD

Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Monday, April 8, 2019 1:26 PM > To: dev@dpdk.org; Trahe, Fiona ; Ananyev, Konstantin > ; akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH] crypto/qat: fix second seg fault in QAT PMD > > While running the I

[dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

If the af_packet transmit is sending a VLAN packet, and the transmit path to the kernel os full, then it would mismanage the outgoing mbuf. The original mbuf would end up being freed twice, once by AF_PACKET PMD and once by caller. Reported-by: Chas Williams <3ch...@gmail.com> Signed-off-by: Steph

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix memory leak

On 4/8/2019 11:19 AM, Alejandro Lucero wrote: > If errors, release the allocated structure. > > Coverity issue: 277222 > Fixes: c7e9729da6b5 ("net/nfp: support CPP") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] devtools: add git log checks for TPID, LACP and RETA

Add case check to TPID, LACP and RETA abbreviations. Signed-off-by: Ferruh Yigit --- devtools/check-git-log.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 09bc2d8f3..ac7da6898 100755 --- a/devtools/check-git-log.sh +++ b/devt

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: check returned value

On 4/8/2019 11:38 AM, Alejandro Lucero wrote: > If the call fails just returns 0. > > Coverity issue: 277225 > Fixes: c7e9729da6b5 ("net/nfp: support CPP") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks. (squashed with other return value check

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: check value returned

On 4/8/2019 10:59 AM, Alejandro Lucero wrote: > Call to CPP read can fail. > > Coverity issue: 277209 > Fixes: c7e9729da6b5 ("net/nfp: support CPP") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks. (squashed with other return value check patche

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: check value returned

On 4/8/2019 11:10 AM, Alejandro Lucero wrote: > If the call to _nfp6000_cppat_mu_locality fails, the function needs > to return with an error. > > Coverity issue: 277215 > Fixes: c7e9729da6b5 ("net/nfp: support CPP") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next

Re: [dpdk-dev] [PATCH] crypto/qat: fix segmentation fault in QAT PMD

Hi Bernard, Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, April 8, 2019 1:10 PM > To: Iremonger, Bernard ; dev@dpdk.org; Trahe, > Fiona > ; akhil.go...@nxp.com > Subject: RE: [PATCH] crypto/qat: fix segmentation fault in QAT PMD > > Hi Bernard, > > > > > W

[dpdk-dev] [PATCH v2] power: fix coverity issue

Fix the resource leaking issue Coverity issue: 337668 Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/librte_power/power

[dpdk-dev] [PATCH] compress/qat: fixed data-plane return from QAT PMD

Fixes: 62ada2182a46 ("compress/qat: add dynamic sgl allocation") Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 2fadb02..dd0fe1b 1

[dpdk-dev] [PATCH] doc/compress: clarify error handling on data-plane

Fixed some typos and clarified which errors should be returned when and why on the enqueue and dequeue APIs. Fixes: a584d3bea902 ("doc: add compressdev library guide") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- doc/guides/prog_guide/compressdev.rst | 44 +

[dpdk-dev] [PATCH] net/af_packet: fix vlan_insert corruption

If the af_packet transmit is sending a VLAN packet, and the transmit path to the kernel os full, then it would mismanage the outgoing mbuf. The original mbuf would end up being freed twice, once by AF_PACKET PMD and once by caller. Reported-by: Chas Williams <3ch...@gmail.com> Signed-off-by: Steph

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 3:38 PM, David Marchand wrote: On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 08-Apr-19 2:58 PM, David Marchand wrote: > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > mailto:anatoly.bura...@intel.com>

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 3:38 PM, David Marchand wrote: On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 08-Apr-19 2:58 PM, David Marchand wrote: > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > mailto:anatoly.bura...@intel.com>

Re: [dpdk-dev] [PATCH] power: fix coverity issue

Hi Liang, On 8/4/2019 4:21 PM, Liang Ma wrote: Coverity issue: 337668 Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_power/power_psta

[dpdk-dev] [PATCH] power: fix coverity issue

Coverity issue: 337668 Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufre

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On Mon, 8 Apr 2019 16:38:55 +0200 David Marchand wrote: > On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly > wrote: > > > On 08-Apr-19 2:58 PM, David Marchand wrote: > > > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > > > mailto:anatoly.bura...@intel.com>> wrote: > > > > > > As a concr

Re: [dpdk-dev] Function name collision on bpf_validate

Hi Vivian, > > > > Hi, > > Has anyone run into this issue with bpf_validate? We have an application > that links to both DPDK and libpcap and both define bpf_validate. Didn't hit such issue so far. Could you provide some basic way to reproduce it? Thanks Konstantin > I > couldn't find o

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix potential integer overflow

On 4/8/2019 10:39 AM, Alejandro Lucero wrote: > Coverity issue: 277204 > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On Mon, Apr 8, 2019 at 4:03 PM Burakov, Anatoly wrote: > On 08-Apr-19 2:58 PM, David Marchand wrote: > > On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > As a concrete proposal, my number one dream would be to see > > multiprocess > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix file descriptor handle

On 4/8/2019 10:20 AM, Alejandro Lucero wrote: > Although it is rather unlikely getting 0 as the descriptor handle, better > to contemplate that possibility. > > Coverity issue: 195018 > Fixes: 896c265ef954 ("net/nfp: use new CPP interface") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucer

[dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1

Build error seen with Linux kernel 5.1 and when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. Build error: .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: error: initialization of ... from incompatible pointer type ... [-Werror=incompatible-pointer-types] .ndo_fdb_add = igb_ndo_fdb_ad

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

Hi Andrew, *Dekel* (I swear I'm not doing it on purpose, hopefully I won't make that stupid mistake again :) On Mon, Apr 08, 2019 at 04:53:54PM +0300, Andrew Rybchenko wrote: > On 4/8/19 4:36 PM, Dekel Peled wrote: > > Regarding Andrew's suggestion: "Shouldn't these action be > > RTE_FLOW_ACTION_

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: fix mempool free on exit

> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Sunday, April 7, 2019 6:02 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; rasl...@mellanox.com; tho...@monjalon.net; Yigit, > Ferruh ; sta...@dpdk.org > Subject: [PATCH v4 1/3]

Re: [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug

Hi Jia > -Original Message- > From: Guo, Jia > Sent: Friday, December 14, 2018 7:46 AM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; shah...@mellanox.com; tho...@monjalon.net; > ma...@mellanox.com > Cc: Yigit, Ferruh ; Ananyev, Konstantin > ; dev@dpdk.org; Guo, Jia > ; step...@networkplumber.

[dpdk-dev] [PATCH] net/sfc: set min and max MTU

Advertise minimum and maximum MTU value in device information. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 6c33601e7..ff192314d 100644 --- a/drivers/net/

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 2:58 PM, David Marchand wrote: On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: As a concrete proposal, my number one dream would be to see multiprocess gone. I also recall desire for "DPDK to be more lightweight", and i main

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On Mon, Apr 8, 2019 at 3:39 PM Burakov, Anatoly wrote: > As a concrete proposal, my number one dream would be to see multiprocess > gone. I also recall desire for "DPDK to be more lightweight", and i > maintain that DPDK *cannot* be lightweight if we are to support > multiprocess - we can have on

[dpdk-dev] [PATCH v3] usertools: replace unsafe input function

LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel.com Signed-off-by: Andrius Sirvys Acked-by:

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

On 4/8/19 4:36 PM, Dekel Peled wrote: Regarding Andrew's suggestion: "Shouldn't these action be RTE_FLOW_ACTION_TYPE_MOD_TCP_{ACK,SEQ} with singed 32-bit integer parameter (negative to decrement, positive to increment)?" I will leave the actions as is, the action names indicate the operation th

[dpdk-dev] Function name collision on bpf_validate

Hi, Has anyone run into this issue with bpf_validate? We have an application that links to both DPDK and libpcap and both define bpf_validate. I couldn't find other complaints on this so I'm wondering what would be the best way to handle this? Thanks and I appreciate for your input. Regards

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ena: fix assigning Rx csum support to Tx flag

On 4/8/2019 11:27 AM, Michal Krawczyk wrote: > The boolean value was assigned to Tx flag twice, so it could cause bug > whenever Rx checksum will not be supported and Tx will be. > > It was detected by the coverity scan, with CID 336831. > > Fixes: 117ba4a60488 ("net/ena: get device info statical

Re: [dpdk-dev] Secondary process crash in rte_eal_init

On 08-Apr-19 2:07 PM, Mohamed Mahmoud (mmahmoud) wrote: Hi Anatoly: For the secondary process all we are setting is the –proc-type set to secondary, maybe point me to your test that might give me some clues, also How I can generate detailed crash log ? When I checked the init code there are

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: fix mempool free on exit

> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Thursday, April 4, 2019 6:15 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; rasl...@mellanox.com; tho...@monjalon.net; Yigit, > Ferruh ; sta...@dpdk.org > Subject: [PATCH v2 1/3

[dpdk-dev] [PATCH v2] usertools: replace unsafe input function

LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel.com Signed-off-by: Andrius Sirvys Acked-by:

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08-Apr-19 2:00 PM, Ray Kinsella wrote: On 08/04/2019 11:15, Burakov, Anatoly wrote: On 08-Apr-19 10:04 AM, Ray Kinsella wrote: On 07/04/2019 10:48, Thomas Monjalon wrote: 04/04/2019 16:07, Burakov, Anatoly: On 04-Apr-19 1:52 PM, Ray Kinsella wrote: On 04/04/2019 11:54, Bruce Richardson

Re: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection

> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Saturday, April 6, 2019 2:30 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; Gavin Hu ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] lib/librte

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Thursday, April 4, 2019 4:26 PM > To: Ori Kam > Cc: Dekel Peled ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; Yongseok Koh > ; Shahaf Shuler ; > dev@dpdk.org > Subject: Re: [PATCH v2 1/3] e

Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large packets

> -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 5, 2019 4:54 PM > To: Dumitrescu, Cristian > Cc: alanrobertson...@gmail.com; dev@dpdk.org; Alan Robertson > ; Alan Robertson ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large > pac

Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 8, 2019 9:53 AM > To: Alan Dewar > Cc: Yigit, Ferruh ; Dumitrescu, Cristian > ; Kantecki, Tomasz > ; Stephen Hemminger > ; dev@dpdk.org; Alan Dewar > > Subject: Re: [dpdk-dev] [PATCH v7] sch

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

On 4/8/2019 12:22 PM, Gagandeep Singh wrote: > Support added for physical addressing mode and > change driver flags to don't care. > > Signed-off-by: Gagandeep Singh Hi Gagandeep, Since the patchset has been sent after RC1, I assume it is for 19.08. Can you please mark patch title as 19.08 to n

Re: [dpdk-dev] [PATCH v4 3/3] examples/l3fwd: format the IP addresses for printing

Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 3/3] examples/l3fwd: format the IP addresses for > printing > > The

Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses

Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > addresses > > The l3fw

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

On 08/04/2019 11:15, Burakov, Anatoly wrote: > On 08-Apr-19 10:04 AM, Ray Kinsella wrote: >> On 07/04/2019 10:48, Thomas Monjalon wrote: >>> 04/04/2019 16:07, Burakov, Anatoly: On 04-Apr-19 1:52 PM, Ray Kinsella wrote: > On 04/04/2019 11:54, Bruce Richardson wrote: >> On Thu, Apr 04

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add ability to set Tx IP and UDP parameters

Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, April 2, 2019 9:39 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add ability to set Tx IP and > UDP parameters > >

Re: [dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR generator

On 2019-04-08 14:30, Mattias Rönnblom wrote: +static void +__rte_srand_lfsr113(uint32_t seed, struct rte_rand_state *state) +{ + uint32_t lcg32_seed = seed; + state->z1 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 2U); + state->z2 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 8U); +

[dpdk-dev] [PATCH] net/mlx5: fix cross compilation on aarch64

In case of cross compilation on aarch64 we must add include for stdlib in order to use the free function. Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule") Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_glue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/n

[dpdk-dev] [RFC 2/3] Add 32-bit version of rte_rand

Signed-off-by: Mattias Rönnblom --- lib/librte_eal/common/include/rte_random.h | 15 +++ lib/librte_eal/common/rte_random.c | 10 ++ lib/librte_eal/rte_eal_version.map | 1 + 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common

[dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR generator

This commit replaces rte_rand()'s use of lrand48() with a DPDK-native combined Linear Feedback Shift Register (LFSR) (also known as Tausworthe) pseudo-number generator, with four sequences. This generator is faster and produces better quality random numbers than libc's lrand48() implementation. Th

Re: [dpdk-dev] [PATCH] crypto/qat: fix segmentation fault in QAT PMD

Hi Konstantin, > Subject: RE: [PATCH] crypto/qat: fix segmentation fault in QAT PMD > > Hi Bernard, > > > > > While running the IPsec unit test program the following segmentation > > fault is occurring: > > > > Thread 1 "test" received signal SIGSEGV, Segmentation fault. > > 0x00beaece

[dpdk-dev] [RFC 3/3] Introduce random generator functions with upper bound

Add two functions rte_rand32_max() and rte_rand_max(), which generate uniformly distributed pseudo-random number less than a user-specified upper bound. The commonly used pattern rte_rand() % SOME_VALUE, in addition to being slow, also creates biased results if SOME_VALUE is not a power of 2. This

Re: [dpdk-dev] [EXT] Re: [PATCH] app/testpmd: fix ether header size calculation

>-Original Message- >From: Bruce Richardson >Sent: Monday, April 8, 2019 5:28 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; tho...@monjalon.net; >dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size >calculation > >External Email

[dpdk-dev] [PATCH] crypto/qat: fix second seg fault in QAT PMD

While running the IPsec unit tests the following segmentation fault is occurring: Thread 1 "test" received signal SIGSEGV, Segmentation fault. 0x00bf3b50 in qat_sym_process_response ( op=0x5355280 , resp=0x100455100 "") at /root/dpdk/drivers/crypto/qat/qat_sym.h:161 161 if (sess->bpi_c

Re: [dpdk-dev] [PATCH v7 3/4] config: add thunderx2 machine config

On Mon, Apr 08, 2019 at 02:05:00PM +0200, Thomas Monjalon wrote: > 08/04/2019 12:32, Thomas Monjalon: > > 06/04/2019 16:27, jerinjac...@gmail.com: > > > --- /dev/null > > > +++ b/config/arm/arm64_thunderx2_linux_gcc > > > @@ -0,0 +1,16 @@ > > > +[binaries] > > > +c = 'aarch64-linux-gnu-gcc' > > > +

Re: [dpdk-dev] [PATCH] crypto/qat: fix segmentation fault in QAT PMD

Hi Bernard, > > While running the IPsec unit test program the following > segmentation fault is occurring: > > Thread 1 "test" received signal SIGSEGV, Segmentation fault. > 0x00beaece in qat_sym_build_request(in_op=0x0, > out_msg=0x100450580 "", op_cookie=0x101c6fd80, qat_dev_gen=QAT_GE

Re: [dpdk-dev] [PATCH v7 3/4] config: add thunderx2 machine config

08/04/2019 12:32, Thomas Monjalon: > 06/04/2019 16:27, jerinjac...@gmail.com: > > --- /dev/null > > +++ b/config/arm/arm64_thunderx2_linux_gcc > > @@ -0,0 +1,16 @@ > > +[binaries] > > +c = 'aarch64-linux-gnu-gcc' > > +cpp = 'aarch64-linux-gnu-cpp' > > +ar = 'aarch64-linux-gnu-gcc-ar' > > +strip = '

Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation

On Mon, Apr 08, 2019 at 10:13:04AM +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Fix ether header size calculation in Tx only mode. > > Coverity issue: 337684 > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") > > Signed-off-by: Pavan Nikhile

[dpdk-dev] [Bug 242] repeat to calling 'rte_pktmbuf_free' function, make the mempool exist the same 'rte_mbuf' obj;

https://bugs.dpdk.org/show_bug.cgi?id=242 Bug ID: 242 Summary: repeat to calling 'rte_pktmbuf_free' function, make the mempool exist the same 'rte_mbuf' obj; Product: DPDK Version: 18.11 Hardware: All OS: Al

Re: [dpdk-dev] [PATCH 05/13] net/enetc: add statistics APIs

On Mon, Apr 8, 2019 at 1:23 PM Gagandeep Singh wrote: > +static > +int enetc_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_stats *stats) > +{ > + struct enetc_eth_hw *hw = > + ENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct enetc_hw

[dpdk-dev] [PATCH 12/13] net/enetc: enable Rx checksum offload validation

Checksum Validation on Rx is supported. Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 15 +- drivers/net/enetc/enetc_rxtx.c | 107 - 4 f

[dpdk-dev] [PATCH 13/13] net/enetc: fix crash at high speed traffic

On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 +++

[dpdk-dev] [PATCH 11/13] net/enetc: enable CRC offload feature

CRC offload keep feature supported Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 1 + drivers/net/enetc/enetc.h | 1 + drivers/net/enetc/enetc_ethdev.c | 20 ++

[dpdk-dev] [PATCH 10/13] net/enetc: enable Rx-Tx queue start/stop feature

Rx and Tx queue start-stop and deferred queue start features enabled. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/enetc_ethdev.c | 185 ++--- 3 files changed, 134 in

[dpdk-dev] [PATCH 07/13] net/enetc: remove forward declarations

Remove unneeded forward declarations and re-order the code. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 237 ++- 1 file changed, 107 insertions(+), 130 deletions(-) diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/en

[dpdk-dev] [PATCH 06/13] net/enetc: replace register read/write macros with functions

Replacing read-write macros with already available read-write functions. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc.h| 7 + drivers/net/enetc/enetc_ethdev.c | 61 2 files changed, 31 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH 08/13] net/enetc: enable promiscuous and allmulticast feature

Promiscuous and allmulticast enable/disable APIs added. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 3 +- drivers/net/enetc/enetc_ethdev.c | 90 ---

[dpdk-dev] [PATCH 05/13] net/enetc: add statistics APIs

Add basic statistics APIs enetc_stats_get and enetc_stats_reset. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 27 +- drivers/net/enetc/enetc_ethdev.c | 46 ++

[dpdk-dev] [PATCH 09/13] net/enetc: add MTU update and jumbo frames support

Enable the jumbo frames and mtu update feature. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 6 ++- drivers/net/enetc/enetc.h | 5 +++ drivers/net/enetc/enetc_ethdev.c |

[dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

Support added for physical addressing mode and change driver flags to don't care. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 22 -- drivers/net/enetc/enetc_rxtx.c | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 03/13] net/enetc: use correct buffer allocation API

rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 2 +- 1 file changed, 1 inse

[dpdk-dev] [PATCH 02/13] net/enetc: fix SMMU unhandled context fault

First configure ring with BDs properly then enable the ring. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enetc/en

[dpdk-dev] [PATCH 04/13] net/enetc: set interface mode for SXGMII

Support for SXGMII port has been enabled. It will depends on boot loader information passed through IERB. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 13 - drivers/net/enetc/enetc_ethdev.c | 11 +++ 2 files changed, 23 insertions(+), 1 deletion(-)

  1   2   >