>-----Original Message-----
>From: Bruce Richardson <[email protected]>
>Sent: Monday, April 8, 2019 5:28 PM
>To: Pavan Nikhilesh Bhagavatula <[email protected]>
>Cc: Jerin Jacob Kollanukkaran <[email protected]>; [email protected];
>[email protected]
>Subject: [EXT] Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size
>calculation
>
>External Email
>
>----------------------------------------------------------------------
>On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote:
>> From: Pavan Nikhilesh <[email protected]>
>>
>> Fix ether header size calculation in Tx only mode.
>>
>> Coverity issue: 337684
>> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate
>> function")
>>
>> Signed-off-by: Pavan Nikhilesh <[email protected]>
>> ---
>> app/test-pmd/txonly.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
>> 66e63788a..a9c27be3e 100644
>> --- a/app/test-pmd/txonly.c
>> +++ b/app/test-pmd/txonly.c
>> @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct
>rte_mempool *mbp,
>> /*
>> * Copy headers in first packet segment(s).
>> */
>> - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0);
>> + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0);
>
>Would a simpler fix not be to change "sizeof(eth_hdr)" to "sizeof(*eth_hdr)"?
>It
>would keep the logical connection between the destination and destination size,
>and make future refactoring easier.
>
Ack, will send v2.
>/Bruce
