Re: [dpdk-dev] [PATCH] net/ice: fix segment fault

2019-01-31 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, January 30, 2019 4:24 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice: fix segment fault > > Fix segment fault when detach a device due to some redundant function call > in i

[dpdk-dev] [PATCH 2/2,v2] build: fix option ordering

2019-01-31 Thread Chas Williams
Sort the options alphabetically and make a note of the preferred order at the top of the file. Signed-off-by: Chas Williams <3ch...@gmail.com> --- meson_options.txt | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index 49957

[dpdk-dev] [PATCH 1/2 v2] build: add option to override max ethports

2019-01-31 Thread Chas Williams
Allow users and packagers to override the default RTE_MAX_ETHPORTS. This adds a new meson option, max_ethports which defaults to the current value. Signed-off-by: Chas Williams <3ch...@gmail.com> Acked-by: Bruce Richardson --- config/meson.build | 1 + config/rte_config.h | 1 - meson_options.t

Re: [dpdk-dev] [PATCH v2] net/bonding: fix create bonded device test failure

2019-01-31 Thread Chas Williams
On 1/28/19 2:28 AM, Hari Kumar Vemula wrote: Create bonded device test is failing due to improper initialisation in bonded device configuration. which leads to crash while setting up queues. The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of bonded device which fails.

Re: [dpdk-dev] [PATCH] build: add option to override max ethports

2019-01-31 Thread Chas Williams
On 1/31/19 4:32 AM, Bruce Richardson wrote: On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote: Allow users and packagers to override the default RTE_MAX_ETHPORTS. This adds a new meson option, max_ethports which defaults to the current value. Signed-off-by: Chas Williams <3ch...@

Re: [dpdk-dev] [PATCH v2 2/2] ci: Introduce travis builds for github repositories

2019-01-31 Thread Aaron Conole
Bruce Richardson writes: > On Thu, Jan 31, 2019 at 11:43:19AM -0500, Aaron Conole wrote: >> Bruce Richardson writes: >> > >> > >> > This looks very similar to the "config/arm/arm64_armv8_linuxapp_gcc" file. >> > I suggest that file be used instead of adding a new one. >> >> Agreed, we can dro

Re: [dpdk-dev] [PATCH v2 2/2] ci: Introduce travis builds for github repositories

2019-01-31 Thread Bruce Richardson
On Thu, Jan 31, 2019 at 11:43:19AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > > > This looks very similar to the "config/arm/arm64_armv8_linuxapp_gcc" file. > > I suggest that file be used instead of adding a new one. > > Agreed, we can drop this. I completely missed the confi

Re: [dpdk-dev] [PATCH] eal/atomic: reimplement rte atomic APIs with atomic builtins

2019-01-31 Thread Honnappa Nagarahalli
Hi Phil, The rte atomic APIs are not designed for adding memory model details. The memory model to use comes from the API usage (and not from the definition). For ex: rte_atomic32_add can have RELAXED memory ordering in a statistics increment kind of use case, but may be RELEASE if the

Re: [dpdk-dev] [PATCH] doc: document libnuma requirement for NUMA systems

2019-01-31 Thread Kevin Traynor
On 01/31/2019 05:05 PM, Anatoly Burakov wrote: > Since 18.05, libnuma is pretty much required on Linux when using > non-legacy mode, because without it, we cannot know where our > hugepages are located [1]. > > In legacy mode, libnuma is not required because we can still sort > pages by sockets, a

Re: [dpdk-dev] [EXT] Default cacheline size for ARM

2019-01-31 Thread Honnappa Nagarahalli
+ Phil and Hemant > > > > > Yes, we need to be inline with any other package. My > > > > > understanding is that the image will be same for v8,v9,v10 (any > > > > > input from distro engineers will help here). So, my question is, > > > > > should the config file/name used by distros contain anyt

Re: [dpdk-dev] DPDK's GSoC participation

2019-01-31 Thread Thomas Monjalon
31/01/2019 18:07, Karuna Grewal: > Hi everyone, > > I saw the previous thread about DPDK's GSoC ideas. As someone having > experience using the same while investigating various userspace network > stack implementations, I want to know if there are any beginner friendly > tasks on bugzilla for me t

Re: [dpdk-dev] Compiler for Windows

2019-01-31 Thread Wiles, Keith
OK just seems like an unnecessary step to me. Sent from my iPhone > On Jan 31, 2019, at 11:36 AM, Thomas Monjalon wrote: > > 31/01/2019 18:12, Wiles, Keith: >> Sorry I have to top post. I had surgery on my shoulder so I’m doing this >> from my phone. >> >> Why does the windows Eal directory

Re: [dpdk-dev] [PATCH v2] doc: update release notes for 19.02

2019-01-31 Thread Thomas Monjalon
31/01/2019 18:39, John McNamara: > Fix grammar, spelling and formatting of DPDK 19.02 release notes. > > Signed-off-by: John McNamara > --- > doc/guides/rel_notes/release_19_02.rst | 80 > +++--- > 1 file changed, 35 insertions(+), 45 deletions(-) > > v2: Minor typo

Re: [dpdk-dev] [PATCH v4 1/3] doc: clean ABI/API policy guide

2019-01-31 Thread Kevin Traynor
On 01/24/2019 06:10 PM, Ferruh Yigit wrote: > The original document written from the point of ABI versioning but later > additions make document confusing, convert document into a ABI/API > policy documentation and organize the document in subsections: > - ABI/API Deprecation > - Experimental APIs

[dpdk-dev] [PATCH v2] doc: update release notes for 19.02

2019-01-31 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 19.02 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_19_02.rst | 80 +++--- 1 file changed, 35 insertions(+), 45 deletions(-) v2: Minor typo. diff --git a/doc/guides/rel_notes/release_19_02.r

Re: [dpdk-dev] [PATCH 0/3] more doc about isolated mode and bifurcated model

2019-01-31 Thread Thomas Monjalon
31/01/2019 07:58, Shahaf Shuler: > Wednesday, January 30, 2019 1:20 PM, Thomas Monjalon: > > Subject: [dpdk-dev] [PATCH 0/3] more doc about isolated mode and > > bifurcated model > > > > The flow isolated mode lacks some advertisement in the docs, especially in > > association with flow bifurcatio

Re: [dpdk-dev] Compiler for Windows

2019-01-31 Thread Thomas Monjalon
31/01/2019 18:12, Wiles, Keith: > Sorry I have to top post. I had surgery on my shoulder so I’m doing this from > my phone. > > Why does the windows Eal directory have to be a stub? It is just a first step to validate the compilation of existing code in Windows environment without the new Wind

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Wiles, Keith
I agree using register for todays compilers is unnecessary and can actually be wrong in some cases. The compilers can pick the correct registers better then we can normally and restricting the compiler makes no sense. Sent from my iPhone > On Jan 31, 2019, at 3:11 AM, Bruce Richardson > wrot

Re: [dpdk-dev] [PATCH 1/3] doc: add mlx5 note for Bluefield build configuration

2019-01-31 Thread Thomas Monjalon
31/01/2019 07:59, Shahaf Shuler: > Wednesday, January 30, 2019 9:53 AM, Yongseok Koh: > > Subject: [dpdk-dev] [PATCH 1/3] doc: add mlx5 note for Bluefield build > > configuration > > > > Fixes: d14e4e976f65 ("config: add Mellanox BlueField armv8 SoC") > > Cc: sta...@dpdk.org > > > > Signed-off-by

Re: [dpdk-dev] maintainers: resign from maintainership of link bonding

2019-01-31 Thread Thomas Monjalon
28/01/2019 13:57, Declan Doherty: > I've been unable to dedicate enough time to actively help in the > maintainership of the link bonding PMD, and as Chas is now actively > maintaining this PMD, I'm removing my name against it in the > MAINTAINERS file. > > Signed-off-by: Declan Doherty Applied

Re: [dpdk-dev] [PATCH v4 2/3] doc: make RTE_NEXT_ABI optional

2019-01-31 Thread Thomas Monjalon
24/01/2019 19:10, Ferruh Yigit: > Initial process requires oncoming changes described in deprecation > notice should be implemented in a RTE_NEXT_ABI gated way. > > This has been discussed in technical board, and since this can cause a > multiple #ifdef blocks in multiple locations of the code, ca

Re: [dpdk-dev] [PATCH v4 3/3] doc: add deprecation marker usage

2019-01-31 Thread Thomas Monjalon
24/01/2019 19:10, Ferruh Yigit: > Define '__rte_deprecated' usage process. > > Suggests keeping old API with '__rte_deprecated' marker including > next LTS, they will be removed just after the LTS release. > > Signed-off-by: Ferruh Yigit > Acked-by: Luca Boccassi > Acked-by: Neil Horman [...]

[dpdk-dev] DPDK's GSoC participation

2019-01-31 Thread Karuna Grewal
Hi everyone, I saw the previous thread about DPDK's GSoC ideas. As someone having experience using the same while investigating various userspace network stack implementations, I want to know if there are any beginner friendly tasks on bugzilla for me to start contributing to this project. Any poi

Re: [dpdk-dev] Compiler for Windows

2019-01-31 Thread Wiles, Keith
Sorry I have to top post. I had surgery on my shoulder so I’m doing this from my phone. Why does the windows Eal directory have to be a stub? Normally the port must use a separate directory for different architecture. In this case it is the windows architecture which should have all of the ch

[dpdk-dev] [PATCH] doc: document libnuma requirement for NUMA systems

2019-01-31 Thread Anatoly Burakov
Since 18.05, libnuma is pretty much required on Linux when using non-legacy mode, because without it, we cannot know where our hugepages are located [1]. In legacy mode, libnuma is not required because we can still sort pages by sockets, as we use pagemap lookup method to figure out socket ID's fo

Re: [dpdk-dev] [PATCH v2 2/2] ci: Introduce travis builds for github repositories

2019-01-31 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Jan 30, 2019 at 05:16:02PM -0500, Michael Santana wrote: >> GitHub is a service used by developers to store repositories. GitHub >> provides service integrations that allow 3rd party services to access >> developer repositories and perform actions. One of thes

[dpdk-dev] DPDK Release Status Meeting 31/01/2018

2019-01-31 Thread Ferruh Yigit
Minutes 31 January 2018 --- Agenda: * Release Dates * 19.02 RC4 status * 19.02 release * Subtrees * OvS Participants: * Intel * Mellanox * NXP * RedHat Release Dates - * v19.02 dates: * RC4 released on Monday, January 28 * Release: Friday, February 1, 2019

Re: [dpdk-dev] [v3] net/virtio: set offload flag for jumbo frames

2019-01-31 Thread Jens Freimann
On Thu, Jan 31, 2019 at 02:01:53PM +0300, Ilya Maximets wrote: On 31.01.2019 12:17, Jens Freimann wrote: Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. There are two cases t

[dpdk-dev] [PATCH v1] doc: update release notes for 19.02

2019-01-31 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 19.02 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_19_02.rst | 80 +++--- 1 file changed, 35 insertions(+), 45 deletions(-) diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/

Re: [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support on E-Switch

2019-01-31 Thread Slava Ovsiienko
Hi, Kevin It is rather refactoring, not new feature, tunnel inner items support is partially present in 18.11. Yes, this patchset is too big to be simple fix, and updates not so much to be new feature. It is very early patch (after 18.11 release), just mailed later, rebase on the top was done

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Kevin Traynor
On 01/31/2019 03:55 PM, Burakov, Anatoly wrote: > On 31-Jan-19 3:04 PM, Thomas Monjalon wrote: >> 31/01/2019 15:15, Kevin Traynor: >>> On 01/31/2019 02:10 PM, Burakov, Anatoly wrote: On 31-Jan-19 11:21 AM, Kevin Traynor wrote: > On 01/10/2019 01:38 PM, Anatoly Burakov wrote: >> Current

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Burakov, Anatoly
On 31-Jan-19 3:04 PM, Thomas Monjalon wrote: 31/01/2019 15:15, Kevin Traynor: On 01/31/2019 02:10 PM, Burakov, Anatoly wrote: On 31-Jan-19 11:21 AM, Kevin Traynor wrote: On 01/10/2019 01:38 PM, Anatoly Burakov wrote: Currently, we use strdup in a few places to store command-line parameter val

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Thomas Monjalon
31/01/2019 15:15, Kevin Traynor: > On 01/31/2019 02:10 PM, Burakov, Anatoly wrote: > > On 31-Jan-19 11:21 AM, Kevin Traynor wrote: > >> On 01/10/2019 01:38 PM, Anatoly Burakov wrote: > >>> Currently, we use strdup in a few places to store command-line > >>> parameter values for certain internal con

Re: [dpdk-dev] [PATCH 0/5] net/mlx5: add inner tunnel items support on E-Switch

2019-01-31 Thread Kevin Traynor
On 12/27/2018 03:34 PM, Viacheslav Ovsiienko wrote: > The generic Flow rule for tunnels looks like: > > flow create \ > \ > \ > > > Current design supports only L2 addresses as inner pattern > items. This patchset adds support for

Re: [dpdk-dev] [PATCH v4] doc: add meson ut info in prog guide

2019-01-31 Thread Bruce Richardson
On Fri, Jan 25, 2019 at 06:20:51AM +, Hari Kumar Vemula wrote: > Add a programmer's guide section for meson ut > > Signed-off-by: Hari Kumar Vemula > --- > v4: Typos corrected > v3: Modified > v2: Removed enhancement details > --- Some sections I think need rewording to be written more from

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Kevin Traynor
On 01/31/2019 02:10 PM, Burakov, Anatoly wrote: > On 31-Jan-19 11:21 AM, Kevin Traynor wrote: >> On 01/10/2019 01:38 PM, Anatoly Burakov wrote: >>> Currently, we use strdup in a few places to store command-line >>> parameter values for certain internal config values. There are >>> several issues wi

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Burakov, Anatoly
On 31-Jan-19 11:21 AM, Kevin Traynor wrote: On 01/10/2019 01:38 PM, Anatoly Burakov wrote: Currently, we use strdup in a few places to store command-line parameter values for certain internal config values. There are several issues with that. First of all, they're never freed, so memory ends up

[dpdk-dev] [dpdk-announce] New DPDK hosted project: dpdk-burst-replay

2019-01-31 Thread jonathan.ri...@fraudbuster.mobi
Hello all, A new project has come into the DPDK community, a tiny tool named "dpdk-burst-replay" whitch tend to be a "tcpreplay" like based on DPDK (so, with high performance concerns). ATM, only few features are available: - it can replay a pcap multiple times in a row. - it can replay a pcap o

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-31 Thread Kevin Traynor
On 01/10/2019 01:38 PM, Anatoly Burakov wrote: > Currently, we use strdup in a few places to store command-line > parameter values for certain internal config values. There are > several issues with that. > > First of all, they're never freed, so memory ends up leaking > either after EAL exit, or

Re: [dpdk-dev] [v3] net/virtio: set offload flag for jumbo frames

2019-01-31 Thread Ilya Maximets
On 31.01.2019 12:17, Jens Freimann wrote: > Port configuration fails because offload flags don't match the expected > value when max-pkt-len is set to a value that should enable receive port > offloading but doesn't. > > There are two cases to consider: > > 1. VIRTIO_NET_F_MTU is set. Then we nee

[dpdk-dev] [PATCH] build: add meson support for cortex a55 and a76 platforms

2019-01-31 Thread Phil Yang
Enable native/cross compiling for Cortex-A55 and Cortex-A76 on meson. Signed-off-by: Phil Yang Reviewed-by: Ola Liljedahl Reviewed-by: Gavin Hu --- config/arm/arm64_armv8_linuxapp_gcc | 2 ++ config/arm/meson.build | 2 ++ 2 files changed, 4 insertions(+) diff --git a/config/arm/

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-01-31 Thread Akhil Goyal
On 1/17/2019 3:09 PM, Anoob Joseph wrote: > Add new field ff_enable in rte_cryptodev_config. This enables > applications to control the features enabled on the crypto device. > > Proposed new layout: > > /** Crypto device configuration structure */ > struct rte_cryptodev_config { > int socke

Re: [dpdk-dev] [dpdk-announce] release candidate 19.02-rc4

2019-01-31 Thread Raslan Darawsheh
Hi Thomas, We are ok with this release and we don't have any blocking issues. Kindest regards, Raslan Darawsheh > -Original Message- > From: announce On Behalf Of Thomas > Monjalon > Sent: Monday, January 28, 2019 4:10 AM > To: annou...@dpdk.org > Subject: [dpdk-announce] release cand

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Tom Barbette
On 2019-01-31 10:11, Bruce Richardson wrote: What header is that? From what I see the patchset only makes changes to .c files rather than any .h files, so not sure it would help in your case. Yes you're right. There are other occurrences of register indeed. I got the warning from rte_common.h:

Re: [dpdk-dev] [PATCH] build: add option to override max ethports

2019-01-31 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote: > Allow users and packagers to override the default RTE_MAX_ETHPORTS. > This adds a new meson option, max_ethports which defaults to the > current value. > > Signed-off-by: Chas Williams <3ch...@gmail.com> Agree with the idea. Just on

Re: [dpdk-dev] [PATCH v3] net/virtio: set offload flag for jumbo frames

2019-01-31 Thread Maxime Coquelin
On 1/31/19 10:17 AM, Jens Freimann wrote: Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. There are two cases to consider: 1. VIRTIO_NET_F_MTU is set. Then we need to chec

Re: [dpdk-dev] [PATCH v2 2/2] ci: Introduce travis builds for github repositories

2019-01-31 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 05:16:02PM -0500, Michael Santana wrote: > GitHub is a service used by developers to store repositories. GitHub > provides service integrations that allow 3rd party services to access > developer repositories and perform actions. One of these services is > Travis-CI, a sim

[dpdk-dev] [PATCH v3] net/virtio: set offload flag for jumbo frames

2019-01-31 Thread Jens Freimann
Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. There are two cases to consider: 1. VIRTIO_NET_F_MTU is set. Then we need to check if the requested max-pkt-len fits into the

Re: [dpdk-dev] [PATCH v2 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h

2019-01-31 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 05:16:01PM -0500, Michael Santana wrote: > From: Aaron Conole > > The vhost_scsi example code is set to build, even if the requisite header > file virtio_scsi.h isn't available. This happens on some Ubuntu systems > when some versions of the libc-dev package aren't availa

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Bruce Richardson
On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote: > Hi all, > > Has there been any change regarding this? I'm still at DPDK 18.11. Maybe > automatically add -Wno-register when C++17 is enabled? Or have a some > register macro which gets undefined if C++17 is enabled? > > The "warning:

Re: [dpdk-dev] [PATCH v2] net/virtio: set offload flag for jumbo frames

2019-01-31 Thread Maxime Coquelin
On 1/30/19 10:22 PM, Jens Freimann wrote: Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. There are two cases to consider: 1. VIRTIO_NET_F_MTU is set. Then we need to chec

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-31 Thread Ye Xiaolong
Hi, Ferruh On 01/29, Ferruh Yigit wrote: [snip] > >Hi Xiaolong, > >Your analysis looks correct, thanks for history provided, it seems renaming >"state" to "status" was not correct [1]. > >The intention of the 'pci_check_and_mask_intx()' is mask the interrupt if it is >from this device, so your sug

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Tom Barbette
Hi all, Has there been any change regarding this? I'm still at DPDK 18.11. Maybe automatically add -Wno-register when C++17 is enabled? Or have a some register macro which gets undefined if C++17 is enabled? The "warning: ISO C++1z does not allow ‘register’ storage class specifier" is annoyi