Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Ye Xiaolong
Hi, Stephen On 01/15, Stephen Hemminger wrote: >On Wed, 16 Jan 2019 08:34:52 +0800 >Xiaolong Ye wrote: > >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 4

Re: [dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-15 Thread Andrew Rybchenko
On 1/16/19 1:32 AM, Gage Eads wrote: This commit adds support for non-blocking (linked list based) stack mempool handler. The stack uses a 128-bit compare-and-swap instruction, and thus is limited to x86_64. The 128-bit CAS atomically updates the stack top pointer and a modification counter, whic

Re: [dpdk-dev] [PATCH v2] app/testpmd: add tos and ttl field to vxlan encapsulation

2019-01-15 Thread Ori Kam
Hi, Just a small nit. Best, Ori > -Original Message- > From: Iremonger, Bernard > Sent: Monday, January 14, 2019 12:08 PM > To: Shahaf Shuler ; Slava Ovsiienko > ; sha...@mellanox.com; Yigit, Ferruh > ; Lu, Wenzhuo ; Wu, Jingjing > ; Ori Kam ; Adrien Mazarguil > > Cc: dev@dpdk.org > S

Re: [dpdk-dev] [PATCH] examples/kni: fix crash while handling userspace request

2019-01-15 Thread Phil Yang (Arm Technology China)
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 16, 2019 1:28 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; he.qia...@zte.com.cn; Igor Ryzhov > ; Phil Yang (Arm Technology China) > ; Dan Gora > Subject: [PATCH] examples/kni: fix crash while handling userspa

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix Rx packet padding

2019-01-15 Thread Shahaf Shuler
Tuesday, January 15, 2019 7:39 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix Rx packet padding > > Rx packet padding is supposed to be set by an environment variable - > MLX5_PMD_ENABLE_PADDING, but it has been missing for some time by > mistake. > Rather than using such a vari

[dpdk-dev] [PATCH v2 3/3] net/ixgbe: update API version

2019-01-15 Thread Wei Zhao
There is need to update to latest API version in order for negotiation between pf and vf, then new API message can be supported. Fixes: 88fccb7a05c6 ("ixgbevf: fix jumbo frame") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_pf.c | 1 + 2 files c

[dpdk-dev] [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF

2019-01-15 Thread Wei Zhao
There is need to enable two ops of promiscuous_enable and promiscuous_disable on VF. Fixes: af75078fece3 ("first public release") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev

[dpdk-dev] [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host

2019-01-15 Thread Wei Zhao
There is need to PF host promiscuous mode enable. For ixgbe, in order to support VF vlan promiscuous or unicast promiscuous, we need to set PF host register PFVML2FLT of bit UPE and VPE. It also align to ixgbe kernel code version 5.5.3. Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mo

[dpdk-dev] [PATCH v2 0/3] net/ixgbe: promiscuous mode enable on VF

2019-01-15 Thread Wei Zhao
There is need to enable promiscuous mode enable on VF, pf host should also enable to support that. v2: --fix typo in commit log. Zhao Wei (3): net/ixgbe: promiscuous mode enable on VF net/ixgbe: enable promiscuous mode on PF host net/ixgbe: update API version drivers/net/ixgbe/ixgbe_ethde

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Ye Xiaolong
On 01/15, Stephen Hemminger wrote: >On Wed, 16 Jan 2019 08:34:52 +0800 >Xiaolong Ye wrote: > >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 4 >> 1 fi

[dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF

2019-01-15 Thread Wei Zhao
There is need to enable promiscuous mode enable on VF, pf host should also enable to support that. Zhao Wei (3): net/ixgbe: promiscuous mode enable on VF net/ixgbe: enable promiscous mode on PF host net/ixgbe: update API version drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++ drivers/ne

[dpdk-dev] [PATCH 1/3] net/ixgbe: promiscuous mode enable on VF

2019-01-15 Thread Wei Zhao
There is need to enable two ops of promiscuous_enable and promiscuous_disable on VF. Fixes: af75078fece3 ("first public release") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev

[dpdk-dev] [PATCH 3/3] net/ixgbe: update API version

2019-01-15 Thread Wei Zhao
There is need to update to latest API version in order for negotiation between pf and vf, then new API message can be supported. Fixes: 88fccb7a05c6 ("ixgbevf: fix jumbo frame") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_pf.c | 1 + 2 files c

[dpdk-dev] [PATCH 2/3] net/ixgbe: enable promiscous mode on PF host

2019-01-15 Thread Wei Zhao
There is need to PF host promiscous mode enable. For ixgbe, in order to support VF vlan promiscuous or unicast promiscuous, we need to set PF host register PFVML2FLT of bit UPE and VPE. It also align to ixgbe kernel code version 5.5.3. Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mod

Re: [dpdk-dev] [PATCH 0/7] net/ice: update share code

2019-01-15 Thread Lu, Wenzhuo
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, January 15, 2019 8:57 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: Stillwell Jr, Paul M ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Zhang, Qi Z > Subject: [PATCH 0/7] net/ice: update share code > > For ice family NICs,

Re: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

2019-01-15 Thread Varghese, Vipin
Thanks Gage for clarifying and correcting. Appreciate the same. > -Original Message- > From: Eads, Gage > Sent: Monday, January 14, 2019 9:17 PM > To: Varghese, Vipin ; Andrew Rybchenko > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Richardson, Bruce ; > Ananyev, Konstantin > Subject: RE:

[dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide

2019-01-15 Thread Jiayu Hu
This patch adds GRO limitations in the programmer guide. Fixes: 2c900d09055e ("doc: add GRO guide") Cc: sta...@dpdk.org Signed-off-by: Jiayu Hu --- changes in v6: - add VLAN limitation changes in v5: - remove fix commit 9e0b9d2ec0f4 changes in v4: - update MBUF->l2_len/... requirement changes in

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

2019-01-15 Thread Honnappa Nagarahalli
> > >> On Wed, 2019-01-09 at 10:22 +, Yongseok Koh wrote: > > >>> On Jan 9, 2019, at 2:09 AM, Jerin Jacob Kollanukkaran wrote: > > I think, I way forward is to add > > config/arm/arm64_a72_linuxapp_gcc for meson. This config can > > be used for all SoC with A7

Re: [dpdk-dev] [EXT] Default cacheline size for ARM

2019-01-15 Thread Honnappa Nagarahalli
> > > > > > Hi, > > > > > > > > > > > > The cacheline size (RTE_CACHE_LINE_SIZE) for ARM CPUs is set > > > > > > to be 128B by default. Mellanox's BlueField is an ARM CPU > > > > > > having > > > > > > Cortex-A72 > > > > > > and its CL size is 64B. > > > > Just wondering how many devices are out th

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Stephen Hemminger
On Wed, 16 Jan 2019 08:34:52 +0800 Xiaolong Ye wrote: > The comment for igbuio_pci_irqhandler is out of date as the code evolves, > remove it to avoid misleading. > > Signed-off-by: Xiaolong Ye > --- > kernel/linux/igb_uio/igb_uio.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/

[dpdk-dev] [PATCH v3] gro: add missing invalid TCP header length check

2019-01-15 Thread Jiayu Hu
When the TCP header length of input packets is invalid (i.e., less than 20 bytes or greater than 60 bytes), check_seq_option() will access illegal memory area when compare TCP Options, which may cause a segmentation fault. This patch adds missing invalid TCP header length check to avoid illegal me

[dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-15 Thread Xiaolong Ye
The comment for igbuio_pci_irqhandler is out of date as the code evolves, remove it to avoid misleading. Signed-off-by: Xiaolong Ye --- kernel/linux/igb_uio/igb_uio.c | 4 1 file changed, 4 deletions(-) diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c index 3cf3

Re: [dpdk-dev] [PATCH] doc: announce ring ABI and API changes

2019-01-15 Thread Stephen Hemminger
On Tue, 15 Jan 2019 17:59:34 -0600 Gage Eads wrote: > In order to support the non-blocking ring[1], one ABI change and one API > change are required in librte_ring. This commit updates the deprecation > notice to pave the way for their inclusion in 19.05. > > [1] http://mails.dpdk.org/archives/d

Re: [dpdk-dev] [PATCH v2 0/5] Add non-blocking ring

2019-01-15 Thread Stephen Hemminger
On Tue, 15 Jan 2019 17:52:22 -0600 Gage Eads wrote: > For some users, the rte ring's "non-preemptive" constraint is not acceptable; > for example, if the application uses a mixture of pinned high-priority threads > and multiplexed low-priority threads that share a mempool. > > This patchset intr

[dpdk-dev] [PATCH] doc: announce ring ABI and API changes

2019-01-15 Thread Gage Eads
In order to support the non-blocking ring[1], one ABI change and one API change are required in librte_ring. This commit updates the deprecation notice to pave the way for their inclusion in 19.05. [1] http://mails.dpdk.org/archives/dev/2019-January/123475.html Signed-off-by: Gage Eads --- doc/

Re: [dpdk-dev] [PATCH] igb_uio: remove out-of-date comment

2019-01-15 Thread Ye Xiaolong
On 01/15, Burakov, Anatoly wrote: >On 15-Jan-19 3:46 PM, Xiaolong Ye wrote: >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 5 - >> 1 file changed, 5 d

[dpdk-dev] [PATCH v2 5/5] mempool/ring: add non-blocking ring handlers

2019-01-15 Thread Gage Eads
These handlers allow an application to create a mempool based on the non-blocking ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env

[dpdk-dev] [PATCH v2 0/5] Add non-blocking ring

2019-01-15 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking ring, on top of which a mempool can run. C

[dpdk-dev] [PATCH v2 1/5] ring: change head and tail to pointer-width size

2019-01-15 Thread Gage Eads
For 64-bit architectures, doubling the head and tail index widths greatly increases the time it takes for them to wrap-around (with current CPU speeds, it won't happen within the author's lifetime). This is important in avoiding the ABA problem -- in which a thread mistakes reading the same tail in

[dpdk-dev] [PATCH v2 2/5] ring: add a non-blocking implementation

2019-01-15 Thread Gage Eads
This commit adds support for non-blocking circular ring enqueue and dequeue functions. The ring uses a 128-bit compare-and-swap instruction, and thus is limited to x86_64. The algorithm is based on the original rte ring (derived from FreeBSD's bufring.h) and inspired by Michael and Scott's non-blo

[dpdk-dev] [PATCH v2 4/5] test_ring_perf: add non-blocking ring perf test

2019-01-15 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/test/test/test_rin

[dpdk-dev] [PATCH v2 3/5] test_ring: add non-blocking ring autotest

2019-01-15 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring.c | 57 --- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/

Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field

2019-01-15 Thread Stephen Hemminger
On Thu, 20 Dec 2018 12:16:09 + Reshma Pattan wrote: > void > -rte_sched_port_pkt_write(struct rte_mbuf *pkt, > - uint32_t subport, uint32_t pipe, uint32_t > traffic_class, > +rte_sched_port_pkt_write(struct rte_sched_port *port, > + struct rte_mbuf

Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field

2019-01-15 Thread Stephen Hemminger
On Thu, 20 Dec 2018 12:16:09 + Reshma Pattan wrote: > This patch implements the changes proposed in the deprecation > notes [1][2]. > > librte_mbuf changes: > The mbuf->hash.sched field is updated to support generic > definition in line with the ethdev traffic manager and meter APIs. > The n

[dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-15 Thread Gage Eads
This commit adds support for non-blocking (linked list based) stack mempool handler. The stack uses a 128-bit compare-and-swap instruction, and thus is limited to x86_64. The 128-bit CAS atomically updates the stack top pointer and a modification counter, which protects against the ABA problem. In

[dpdk-dev] [PATCH v2 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-15 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. Signed-off-by: Gage Eads --- .../common/include/arch/x86/rte_atomic_64.h| 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_eal/common/include/arch/x86/rte_ato

[dpdk-dev] [PATCH v2 0/2] Add non-blocking stack mempool handler

2019-01-15 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking stack mempool handler. Note that the non-b

Re: [dpdk-dev] [RFC v2 1/2] rcu: add RCU library supporting QSBR mechanism

2019-01-15 Thread Honnappa Nagarahalli
> Hi Honnappa, > > > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock less > > data structures. > > > > Signed-off-by: Honn

Re: [dpdk-dev] [PATCH] use config flags for target OS checks

2019-01-15 Thread Ferruh Yigit
On 12/5/2016 5:50 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > Clean up the code to always use the flags RTE_EXEC_ENV_*APP > set up in the DPDK configuration instead of the native ones. > > Signed-off-by: Thomas Monjalon Hi Thomas, This one is similar, there is not comment on the

Re: [dpdk-dev] [PATCH] use generated flags for SSE and AVX checks

2019-01-15 Thread Ferruh Yigit
On 12/5/2016 3:59 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > 2016-12-05 16:34, Thomas Monjalon: >> Clean up the code to always use the flags RTE_MACHINE_CPUFLAG_* >> generated by the DPDK makefile rte.cpuflags.mk. > > This patch does not work because RTE_MACHINE_CPUFLAG_* are gene

Re: [dpdk-dev] [dpdk-techboard] A new bus for mediated devices

2019-01-15 Thread Alejandro Lucero
Hi Steve, On Tue, Jan 15, 2019 at 2:19 PM Liang, Cunming wrote: > Hi Alejandro, > > > > Good to know we have common interest in DPDK native mdev support. > > > > We’re working on something which mdev based PMD driver is part of. It was > going to collect others’ interest & feedback on DPDK summi

Re: [dpdk-dev] [PATCH v5 1/4] eal: fix clang compilation error on x86

2019-01-15 Thread Honnappa Nagarahalli
> > From: Gavin Hu > > When CONFIG_RTE_FORCE_INTRINSICS is enabled for x86, the clang > compilation error was: > include/generic/rte_atomic.h:215:9: error: > implicit declaration of function '__atomic_exchange_2' > is invalid in C99 > include/generic/rte_a

[dpdk-dev] [PATCH 1/2] net/mlx5: fix Rx packet padding

2019-01-15 Thread Yongseok Koh
Rx packet padding is supposed to be set by an environment variable - MLX5_PMD_ENABLE_PADDING, but it has been missing for some time by mistake. Rather than using such a variable, a PMD parameter (rxq_pkt_pad_en) is added instead. Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx que

[dpdk-dev] [PATCH 2/2] net/mlx5: fix deprecated library API for Rx packet padding

2019-01-15 Thread Yongseok Koh
In rdma-core library IBV_WQ_FLAG_RX_END_PADDING is renamed to IBV_WQ_FLAGS_PCI_WRITE_END_PADDING. Way to query the capability is also changed. Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Reviewed-by: Erez Ferber --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/meson.build | 2 +

Re: [dpdk-dev] [PATCH] net/bonding: fix create bonded device test failure

2019-01-15 Thread Pattan, Reshma
> -Original Message- > From: Vemula, Hari KumarX > Sent: Monday, January 7, 2019 1:01 PM > > > Signed-off-by: Hari Kumar Vemula > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > - memcpy(&dev_info->rx_desc_lim,

Re: [dpdk-dev] [PATCH v1] net/i40e: support request any number of queues

2019-01-15 Thread Kevin Traynor
On 01/15/2019 02:57 PM, Zhirun Yan wrote: > Before this patch, VF must request a specific queues(1/2/4/8/16) with > DPDK PF. This patch align the number of requested queues to next power > of 2. So VF can request any number queues from 1 to 16. > > Signed-off-by: Zhirun Yan > --- > drivers/net/i

[dpdk-dev] [PATCH] examples/kni: fix crash while handling userspace request

2019-01-15 Thread Ferruh Yigit
When KNI interface receives RTE_KNI_REQ_CFG_NETWORK_IF request, it stap/start the physical device which as a result of stop() can free all the mbufs in its queue. Meanwhile sample application continues to read from KNI interface queues and push into device queues. This simultaneous access may cause

Re: [dpdk-dev] [PATCH] igb_uio: remove out-of-date comment

2019-01-15 Thread Burakov, Anatoly
On 15-Jan-19 3:46 PM, Xiaolong Ye wrote: The comment for igbuio_pci_irqhandler is out of date as the code evolves, remove it to avoid misleading. Signed-off-by: Xiaolong Ye --- kernel/linux/igb_uio/igb_uio.c | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/linux/igb_uio/igb_uio

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-15 Thread Eads, Gage
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, January 11, 2019 1:55 PM > To: Eads, Gage > Cc: Burakov, Anatoly ; dev@dpdk.org; > olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > > Subject

[dpdk-dev] [PATCH] igb_uio: remove out-of-date comment

2019-01-15 Thread Xiaolong Ye
The comment for igbuio_pci_irqhandler is out of date as the code evolves, remove it to avoid misleading. Signed-off-by: Xiaolong Ye --- kernel/linux/igb_uio/igb_uio.c | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c index 3cf

[dpdk-dev] [PATCH] doc/gsg: update recommended NIC bios settings

2019-01-15 Thread David Hunt
Update recommended BIOS settings for performance to be more appropriate for a wider variety of applications, and allow users to select the most appropriate settings for their use case, e.g. some users may wish to have Turbo Boost enabled. Signed-off-by: David Hunt --- doc/guides/linux_gsg/nic_pe

Re: [dpdk-dev] [PATCH v4] pdump: fix vdev cleanup

2019-01-15 Thread Ferruh Yigit
On 1/15/2019 1:45 PM, Reshma Pattan wrote: > Virtual devices added in pdump application > using rte_eal_hotplug_add should be removed explicitly > while exiting the pdump application, otherwise the > subsequent run of the pdump application will fail with the reason > that virtual devices with the s

[dpdk-dev] [PATCH 2/2] doc/power: update release note for intel-pstate

2019-01-15 Thread David Hunt
Add release note update for 19.02 for intel_pstate support to Power Management library Signed-off-by: David Hunt --- doc/guides/rel_notes/release_19_02.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst

[dpdk-dev] [PATCH 1/2] doc/power: library can now use intel-pstate

2019-01-15 Thread David Hunt
With the addition of the patchset to allow auto-detection and use of the intel_pstate kernel driver instead of the acpi-cpufreq kernel driver, we need to reflect this in the documentation. Now, instead of telling the user to disable intel_pstate in all cases, it is now an optional step, should the

[dpdk-dev] [PATCH v4] pdump: fix vdev cleanup

2019-01-15 Thread Reshma Pattan
Virtual devices added in pdump application using rte_eal_hotplug_add should be removed explicitly while exiting the pdump application, otherwise the subsequent run of the pdump application will fail with the reason that virtual devices with the same name already exists in primary. Fixes: 6362f362a

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-15 Thread Hu, Jiayu
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, January 15, 2019 6:12 PM > To: Wang, Yinan ; Hu, Jiayu ; > dev@dpdk.org > Cc: tho...@monjalon.net; Hu, Jiayu ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks > >

[dpdk-dev] [PATCH] doc/power: fix references in power management

2019-01-15 Thread David Hunt
In the References section in the Power Management overview, both links pointed to the same l3fwd-power app. Fix the links so that one points to l3fwd-power, and the other points to the vm_power_manager sample app. Signed-off-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 6 -- 1 fi

[dpdk-dev] [RFC] net/ice: enable package download and RSS

2019-01-15 Thread Qi Zhang
This is RFC for customer early eveluation. It depends on below patch set http://patchwork.dpdk.org/project/dpdk/list/?series=3189 package download mechanism is hard coded as: A file named "ice_os_default.pkg" at current directory will be downloaded by driver during init stage. Also RSS is enable

[dpdk-dev] [PATCH v2 3/3] test/rwlock: amortize the cost of getting time

2019-01-15 Thread Joyce Kong
Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong --- test/test/test_rwlock.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/test/test/test_rwlock.c b/test/test/test_rwlock.c index 250ea5a..d42ac35 100644 --- a/tes

[dpdk-dev] [PATCH v2 1/3] rwlock: reimplement with __atomic builtins

2019-01-15 Thread Joyce Kong
From: Gavin Hu The __sync builtin based implementation generates full memory barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins to generate one way barriers. Here is the assembly code of __sync_compare_and_swap builtin. __sync_bool_compare_and_swap(dst, exp, src); 0x0090

[dpdk-dev] [PATCH v2 0/3] reimplement rwlock and add relevant perf test case

2019-01-15 Thread Joyce Kong
v2: Rebase and modify the rwlock test case to address the comments in v1. v1: reimplement rwlock with __atomic builtins, and add a rwlock perf test on all available cores to benchmark the improvement. We tested the patches on three arm64 platforms. ThundeX2 gained 20%

[dpdk-dev] [PATCH v2 2/3] test/rwlock: add perf test case

2019-01-15 Thread Joyce Kong
Add performance test on all available cores to benchmark the scaling up performance of rw_lock. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Suggested-by: Gavin Hu Signed-off-by: Joyce Kong Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Gavin Hu

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2019-01-15 Thread Hu, Xuekun
Thanks, I'm just using CentOS7.5 3.10! I will try a newer kernel. Stay tuned. -Original Message- From: Burakov, Anatoly Sent: Tuesday, January 15, 2019 7:22 PM To: Hu, Xuekun ; Ravi Kerur Cc: dev@dpdk.org; Ananyev, Konstantin ; Lu, Wenzhuo Subject: Re: [dpdk-dev] IXGBE, IOMMU DMAR DR

[dpdk-dev] [PATCH 7/7] net/ice/base: free flow profile entries

2019-01-15 Thread Qi Zhang
Free flow profile entries when free hw tables. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_flex_pipe.c | 38 1 file changed, 38 insertions(+) diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/ba

[dpdk-dev] [PATCH 6/7] net/ice/base: add flow module

2019-01-15 Thread Qi Zhang
Add the module that implemented flow abstraction that base on flexible pipeline. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/Makefile |1 + drivers/net/ice/base/ice_common.h |1 + drivers/net/ice/base/ice_flow.c | 2080 ++

[dpdk-dev] [PATCH 2/7] net/ice/base: add API to support resource allocate

2019-01-15 Thread Qi Zhang
Added API ice_alloc_hw_res and ice_free_hw_res. Added resource type macro. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_adminq_cmd.h | 27 + drivers/net/ice/base/ice_common.c | 71 +++ drivers/net/ice/bas

[dpdk-dev] [PATCH 4/7] net/ice/base: add some help macros

2019-01-15 Thread Qi Zhang
Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_common.h | 10 ++ drivers/net/ice/base/ice_osdep.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/net/ice/base/ice_common.h b/drivers/net/ice/base/ice_common.h index 45d93eb64..675

[dpdk-dev] [PATCH 3/7] net/ice/base: add package download related data structure

2019-01-15 Thread Qi Zhang
Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_adminq_cmd.h | 58 +++ drivers/net/ice/base/ice_type.h | 1 - 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/dri

[dpdk-dev] [PATCH 1/7] net/ice/base: code clean

2019-01-15 Thread Qi Zhang
Remove some unnecessary code. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_common.c | 14 -- drivers/net/ice/base/ice_common.h | 17 - drivers/net/ice/base/ice_controlq.c | 2 +- 3 files changed, 1 insertion(+), 32 dele

[dpdk-dev] [PATCH 0/7] net/ice: update share code

2019-01-15 Thread Qi Zhang
For ice family NICs, package processing pipe line can be configured in a package file should be downloaded into device by driver during init. The patch set add necessary share code APIs to support package download. Also some code clean is included. Though package download will not be enabled in 19

Re: [dpdk-dev] [PATCH] test/ipsec: fix test suite setup function

2019-01-15 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 15, 2019 12:34 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: RE: [PATCH] test/ipsec: fix test suite setup function > > Hi Konstantin > > > > > > Subject: [PATCH] test/ipsec: fi

Re: [dpdk-dev] [PATCH] test/ipsec: fix test suite setup function

2019-01-15 Thread Iremonger, Bernard
Hi Konstantin > > Subject: [PATCH] test/ipsec: fix test suite setup function > > > > Check for valid crypto_null devices before continuing. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Signed-off-by: Bernard Iremonger > > --- > > test/test/test_ipsec.c | 17 +++

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-15 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, January 15, 2019 6:12 PM > To: Wang, Yinan ; Hu, Jiayu ; > dev@dpdk.org > Cc: tho...@monjalon.net; Hu, Jiayu ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks > > Hi, > > > -

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2019-01-15 Thread Burakov, Anatoly
On 14-Jan-19 6:12 AM, Shahaf Shuler wrote: Hi Anatoly, Any last inputs on this one? Would like to prepare a patch for 19.05 and it would much effect the design. Hi Shahaf, Unfortunately, i've been preoccupied with other stuff lately. I will have another look at this issue over the week and

Re: [dpdk-dev] [PATCH] test/ipsec: fix test suite setup function

2019-01-15 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 15, 2019 11:20 AM > To: dev@dpdk.org; Ananyev, Konstantin > Cc: Iremonger, Bernard > Subject: [PATCH] test/ipsec: fix test suite setup function > > Check for valid crypto_null devices before continuing. > > Fixe

Re: [dpdk-dev] [RFC v2 1/2] rcu: add RCU library supporting QSBR mechanism

2019-01-15 Thread Ananyev, Konstantin
Hi Honnappa, > Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data > structures. > > Signed-off-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-15 Thread Ilya Maximets
On 14.01.2019 19:46, Richardson, Bruce wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya Maximets >> Sent: Monday, January 14, 2019 4:15 PM >> To: dev@dpdk.org; Thomas Monjalon >> Cc: Pavan Nikhilesh ; Ilya Maximets >> ; sta...@dpdk.org >> Subj

[dpdk-dev] [PATCH] eal: fix clang build with intrinsics forced

2019-01-15 Thread Ilya Maximets
This fixes x86_64-native-linuxapp-clang build with CONFIG_RTE_FORCE_INTRINSICS=y: include/generic/rte_atomic.h:218:9: error: implicit declaration of function '__atomic_exchange_2' is invalid in C99 [-Werror,-Wimplicit-function-declaration] include/generic/rte_atomic.h:501:

[dpdk-dev] [Bug 189] RTE Timer Adapter Use After Free

2019-01-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=189 Bug ID: 189 Summary: RTE Timer Adapter Use After Free Product: DPDK Version: 19.02 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Nor

Re: [dpdk-dev] [PATCH v2] vhost: add external message handling callbacks to the public API

2019-01-15 Thread Tiwei Bie
On Mon, Jan 14, 2019 at 05:28:29AM +0100, Darek Stojaczyk wrote: > External message callbacks are used e.g. by vhost crypto > to parse crypto-specific vhost-user messages. > > We are now publishing the API to register those callbacks, > so that other backends outside of DPDK can use them as well.

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2019-01-15 Thread Burakov, Anatoly
On 15-Jan-19 7:07 AM, Hu, Xuekun wrote: Hi, Ravi Did you resolve this issue that VF used in guest with vIOMMU enabled? I googled, but still can't get the answer that it is driver or qemu vt-d emulation issue. Currently I met the same issue again that host reported DMAR error: [59939.130110] D

[dpdk-dev] [PATCH] test/ipsec: fix test suite setup function

2019-01-15 Thread Bernard Iremonger
Check for valid crypto_null devices before continuing. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Signed-off-by: Bernard Iremonger --- test/test/test_ipsec.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/test/test/test_ipsec.c b/test/te

Re: [dpdk-dev] [PATCH v1] net/i40e: support request any number of queues

2019-01-15 Thread Zhang, Qi Z
> -Original Message- > From: Yan, Zhirun > Sent: Tuesday, January 15, 2019 10:57 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yan, Zhirun > Subject: [PATCH v1] net/i40e: support request any number of queues > > Before this patch, VF must request a specific queues(1/2/4/8/16) with DPDK PF.

[dpdk-dev] [PATCH v3] ip_pipeline: add QinQ PPPoE encapsulation action

2019-01-15 Thread Marjanovic,Nemanja
Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v2:Fix changes from check patch v3:Changed to use internally defined ETHER_TYPE_PPPOE_SESSION macro --- examples/ip_pipeline/cli.c | 46 ++- lib/librte_pipeline/rte_tab

Re: [dpdk-dev] [PATCH v2] net/i40e: fix FPK VF overwrite PF RSS LUT

2019-01-15 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Tuesday, January 15, 2019 10:24 AM > To: dev@dpdk.org > Cc: Hall, Ryan E ; Zhang, Qi Z ; > Wu, Yanglong ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix FPK VF overwrite PF RSS LUT > Change title to "fix VF overwrite PF RSS LUT for

Re: [dpdk-dev] [PATCH] config: remove NFP PMD from 32-bits builds

2019-01-15 Thread Bruce Richardson
On Mon, Jan 14, 2019 at 08:04:00PM +0100, Thomas Monjalon wrote: > 14/01/2019 19:12, Alejandro Lucero: > > Signed-off-by: Alejandro Lucero > > --- > > config/defconfig_i686-native-linuxapp-gcc| 5 + > > config/defconfig_i686-native-linuxapp-icc| 5 + > > config/defconfig_x86_x32-n

[dpdk-dev] [PATCH] examples/vhost_crypto: fix session private mempool

2019-01-15 Thread Fan Zhang
This patch fixes the incorrect session private mempool passing to cryptodev. Fixes: ac5e42daca19 ("vhost/crypto: use separate session mempools") Signed-off-by: Fan Zhang --- examples/vhost_crypto/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/vhost_crypt

[dpdk-dev] [PATCH] examples/fips_validation: fix session private mempool

2019-01-15 Thread Fan Zhang
This patch fixes the incorrect session private mempool passing to cryptodev. Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") Signed-off-by: Fan Zhang --- examples/fips_validation/fips_dev_self_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ex

[dpdk-dev] [PATCH v5 4/4] spinlock: reimplement with atomic one-way barrier builtins

2019-01-15 Thread gavin hu
From: Gavin Hu The __sync builtin based implementation generates full memory barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins to generate one way barriers. Here is the assembly code of __sync_compare_and_swap builtin. __sync_bool_compare_and_swap(dst, exp, src); 0x0090

[dpdk-dev] [PATCH v5 3/4] test/spinlock: amortize the cost of getting time

2019-01-15 Thread gavin hu
From: Gavin Hu Instead of getting timestamps per iteration, amortize its overhead can help getting more precise benchmarking results. Signed-off-by: Gavin Hu Reviewed-by: Joyce Kong --- test/test/test_spinlock.c | 29 - 1 file changed, 16 insertions(+), 13 deletion

[dpdk-dev] [PATCH v5 1/4] eal: fix clang compilation error on x86

2019-01-15 Thread gavin hu
From: Gavin Hu When CONFIG_RTE_FORCE_INTRINSICS is enabled for x86, the clang compilation error was: include/generic/rte_atomic.h:215:9: error: implicit declaration of function '__atomic_exchange_2' is invalid in C99 include/generic/rte_atomic.h:494

[dpdk-dev] [PATCH v5 2/4] test/spinlock: remove 1us delay for correct benchmarking

2019-01-15 Thread gavin hu
From: Gavin Hu The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. A typical pair of lock and unlock operations costs tens or hundreds of nano seconds, in comparison to this, delaying 1 us outside of the

[dpdk-dev] [PATCH v5 0/4] spinlock optimization and test case enhancements

2019-01-15 Thread gavin hu
V5: Remove ChangeId(sorry for that) V4: 1. Drop one patch for the test case to get time precisely as the overhead of getting time is amortized already in another patch. 2. Drop the ticket lock patch from this series as there are no dependency between them, the ticket lock patch was submitted

Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup

2019-01-15 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, January 15, 2019 10:11 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup > > 15/01/2019 11:09, Pattan, Reshm

Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering feature support

2019-01-15 Thread Ilya Maximets
On 15.01.2019 11:55, Shahaf Shuler wrote: > Tuesday, January 15, 2019 10:29 AM, Ilya Maximets: >> Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory >> ordering feature support >> >> On 15.01.2019 9:33, Shahaf Shuler wrote: >>> Thursday, January 10, 2019 10:37 PM, Shahaf Shuler: >>>

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-15 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: Wang, Yinan > Sent: Tuesday, January 15, 2019 5:05 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; tho...@monjalon.net; > Hu, Jiayu ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks > > Tested-by:

Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup

2019-01-15 Thread Thomas Monjalon
15/01/2019 11:09, Pattan, Reshma: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 11/01/2019 18:51, Reshma Pattan: > > > Virtual devices added in pdump application using rte_eal_hotplug_add > > > should be removed explicitly while existing the pdump application, > > > otherwise the > > >

Re: [dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

2019-01-15 Thread Thomas Monjalon
15/01/2019 11:07, Hunt, David: > > On 14/1/2019 10:35 PM, Thomas Monjalon wrote: > > 28/12/2018 12:32, Liang Ma: > >> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > >> Coverity issue: 328528 > >> > >> Also add the missing functionality of enable/disable turbo > > If you are chan

Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup

2019-01-15 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, January 15, 2019 12:59 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup > > 11/01/2019 18:51, Reshma Pattan

Re: [dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

2019-01-15 Thread Hunt, David
On 14/1/2019 10:35 PM, Thomas Monjalon wrote: 28/12/2018 12:32, Liang Ma: Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Coverity issue: 328528 Also add the missing functionality of enable/disable turbo If you are changing two things, you probably need to split in two patche

  1   2   >